449349e901
When a section is open in the Files app a "show" event is triggered. File list objects handle that event by reloading themselves, but only if the file list was shown at least once. However, the file list objects of plugins are created when the "show" event is triggered for the first time for their section; as the file list objects register their handler for the "show" event when they are created they never handle the first triggered "show" event, as the handler is set while that event is being already handled. Therefore, from the point of view of the handler, the second time that a "show" event was triggered it was seen as if the file list was shown for the first time, and thus it was not reloaded. Now the "shown" property is explicitly set for those file lists that are created while handling a "show" event, which causes them to be reloaded as expected when opening their section again. Note that it is not possible to just reload the file list whenever it is shown; the file list is reloaded also when the directory changes, and this can happen when the web page is initially loaded and the URL is parsed. In that case, if file lists were reloaded when shown for the first time then it could be reloaded twice, one with the default parameters due to the "show" event and another one with the proper parameters once the URL was parsed, and the files that appeard in the list would depend on which response from the server was received the last. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
121 lines
3.4 KiB
JavaScript
121 lines
3.4 KiB
JavaScript
/*
|
|
* Copyright (c) 2014 Vincent Petry <pvince81@owncloud.com>
|
|
*
|
|
* This file is licensed under the Affero General Public License version 3
|
|
* or later.
|
|
*
|
|
* See the COPYING-README file.
|
|
*
|
|
*/
|
|
|
|
(function (OCA) {
|
|
/**
|
|
* @namespace OCA.Files.RecentPlugin
|
|
*
|
|
* Registers the recent file list from the files app sidebar.
|
|
*/
|
|
OCA.Files.RecentPlugin = {
|
|
name: 'Recent',
|
|
|
|
/**
|
|
* @type OCA.Files.RecentFileList
|
|
*/
|
|
recentFileList: null,
|
|
|
|
attach: function () {
|
|
var self = this;
|
|
$('#app-content-recent').on('show.plugin-recent', function (e) {
|
|
self.showFileList($(e.target));
|
|
});
|
|
$('#app-content-recent').on('hide.plugin-recent', function () {
|
|
self.hideFileList();
|
|
});
|
|
},
|
|
|
|
detach: function () {
|
|
if (this.recentFileList) {
|
|
this.recentFileList.destroy();
|
|
OCA.Files.fileActions.off('setDefault.plugin-recent', this._onActionsUpdated);
|
|
OCA.Files.fileActions.off('registerAction.plugin-recent', this._onActionsUpdated);
|
|
$('#app-content-recent').off('.plugin-recent');
|
|
this.recentFileList = null;
|
|
}
|
|
},
|
|
|
|
showFileList: function ($el) {
|
|
if (!this.recentFileList) {
|
|
this.recentFileList = this._createRecentFileList($el);
|
|
}
|
|
return this.recentFileList;
|
|
},
|
|
|
|
hideFileList: function () {
|
|
if (this.recentFileList) {
|
|
this.recentFileList.$fileList.empty();
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Creates the recent file list.
|
|
*
|
|
* @param $el container for the file list
|
|
* @return {OCA.Files.RecentFileList} file list
|
|
*/
|
|
_createRecentFileList: function ($el) {
|
|
var fileActions = this._createFileActions();
|
|
// register recent list for sidebar section
|
|
return new OCA.Files.RecentFileList(
|
|
$el, {
|
|
fileActions: fileActions,
|
|
// The file list is created when a "show" event is handled,
|
|
// so it should be marked as "shown" like it would have been
|
|
// done if handling the event with the file list already
|
|
// created.
|
|
shown: true
|
|
}
|
|
);
|
|
},
|
|
|
|
_createFileActions: function () {
|
|
// inherit file actions from the files app
|
|
var fileActions = new OCA.Files.FileActions();
|
|
// note: not merging the legacy actions because legacy apps are not
|
|
// compatible with the sharing overview and need to be adapted first
|
|
fileActions.registerDefaultActions();
|
|
fileActions.merge(OCA.Files.fileActions);
|
|
|
|
if (!this._globalActionsInitialized) {
|
|
// in case actions are registered later
|
|
this._onActionsUpdated = _.bind(this._onActionsUpdated, this);
|
|
OCA.Files.fileActions.on('setDefault.plugin-recent', this._onActionsUpdated);
|
|
OCA.Files.fileActions.on('registerAction.plugin-recent', this._onActionsUpdated);
|
|
this._globalActionsInitialized = true;
|
|
}
|
|
|
|
// when the user clicks on a folder, redirect to the corresponding
|
|
// folder in the files app instead of opening it directly
|
|
fileActions.register('dir', 'Open', OC.PERMISSION_READ, '', function (filename, context) {
|
|
OCA.Files.App.setActiveView('files', {silent: true});
|
|
var path = OC.joinPaths(context.$file.attr('data-path'), filename);
|
|
OCA.Files.App.fileList.changeDirectory(path, true, true);
|
|
});
|
|
fileActions.setDefault('dir', 'Open');
|
|
return fileActions;
|
|
},
|
|
|
|
_onActionsUpdated: function (ev) {
|
|
if (ev.action) {
|
|
this.recentFileList.fileActions.registerAction(ev.action);
|
|
} else if (ev.defaultAction) {
|
|
this.recentFileList.fileActions.setDefault(
|
|
ev.defaultAction.mime,
|
|
ev.defaultAction.name
|
|
);
|
|
}
|
|
}
|
|
};
|
|
|
|
})(OCA);
|
|
|
|
OC.Plugins.register('OCA.Files.App', OCA.Files.RecentPlugin);
|
|
|