044d5a8d01
The public "IGroupManager" service returned by the dependency injection system is automatically initialized with an "OC\Group\Database" backend. However, no backend is automatically set in private "GroupManager" instances. Therefore, a private "GroupManager" instance does not work as expected when initialized through the dependency injection system. Due to that this commit reverts a previous change in which the public "IGroupManager" was replaced by a private "GroupManager" instance. That change was needed when strict types were set, as "getSubAdmin()" is not part of "IGroupManager" API, so the type had to be changed to "GroupManager". Until a better solution is found strict types are disabled again to be able to inject "IGroupManager" and also use "getSubAdmin()". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
286 lines
7.7 KiB
PHP
286 lines
7.7 KiB
PHP
<?php
|
|
// FIXME: disabled for now to be able to inject IGroupManager and also use
|
|
// getSubAdmin()
|
|
//declare(strict_types=1);
|
|
/**
|
|
*
|
|
*
|
|
* @author Joas Schilling <coding@schilljs.com>
|
|
* @author Lukas Reschke <lukas@statuscode.ch>
|
|
* @author Matthew Setter <matthew@matthewsetter.com>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
|
*
|
|
* @license GNU AGPL version 3 or any later version
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as
|
|
* published by the Free Software Foundation, either version 3 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
namespace OC\Settings\Controller;
|
|
|
|
use OC\HintException;
|
|
use OC\User\Session;
|
|
use OCP\App\IAppManager;
|
|
use OCP\AppFramework\Controller;
|
|
use OCP\AppFramework\Http\JSONResponse;
|
|
use OCP\IGroupManager;
|
|
use OCP\IL10N;
|
|
use OCP\IRequest;
|
|
use OCP\IUser;
|
|
use OCP\IUserManager;
|
|
use OCP\IUserSession;
|
|
|
|
class ChangePasswordController extends Controller {
|
|
|
|
/** @var string */
|
|
private $userId;
|
|
|
|
/** @var IUserManager */
|
|
private $userManager;
|
|
|
|
/** @var IL10N */
|
|
private $l;
|
|
|
|
/** @var IGroupManager */
|
|
private $groupManager;
|
|
|
|
/** @var Session */
|
|
private $userSession;
|
|
|
|
/** @var IAppManager */
|
|
private $appManager;
|
|
|
|
public function __construct(string $appName,
|
|
IRequest $request,
|
|
string $userId,
|
|
IUserManager $userManager,
|
|
IUserSession $userSession,
|
|
IGroupManager $groupManager,
|
|
IAppManager $appManager,
|
|
IL10N $l) {
|
|
parent::__construct($appName, $request);
|
|
|
|
$this->userId = $userId;
|
|
$this->userManager = $userManager;
|
|
$this->userSession = $userSession;
|
|
$this->groupManager = $groupManager;
|
|
$this->appManager = $appManager;
|
|
$this->l = $l;
|
|
}
|
|
|
|
/**
|
|
* @NoAdminRequired
|
|
* @NoSubadminRequired
|
|
* @BruteForceProtection(action=changePersonalPassword)
|
|
*
|
|
* @param string $oldpassword
|
|
* @param string $newpassword
|
|
*
|
|
* @return JSONResponse
|
|
*/
|
|
public function changePersonalPassword(string $oldpassword = '', string $newpassword = null): JSONResponse {
|
|
/** @var IUser $user */
|
|
$user = $this->userManager->checkPassword($this->userId, $oldpassword);
|
|
if ($user === false) {
|
|
$response = new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Wrong password'),
|
|
],
|
|
]);
|
|
$response->throttle();
|
|
return $response;
|
|
}
|
|
|
|
try {
|
|
if ($newpassword === null || $user->setPassword($newpassword) === false) {
|
|
return new JSONResponse([
|
|
'status' => 'error'
|
|
]);
|
|
}
|
|
// password policy app throws exception
|
|
} catch(HintException $e) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $e->getHint(),
|
|
],
|
|
]);
|
|
}
|
|
|
|
$this->userSession->updateSessionTokenPassword($newpassword);
|
|
|
|
return new JSONResponse([
|
|
'status' => 'success',
|
|
'data' => [
|
|
'message' => $this->l->t('Saved'),
|
|
],
|
|
]);
|
|
}
|
|
|
|
/**
|
|
* @NoAdminRequired
|
|
* @PasswordConfirmationRequired
|
|
*
|
|
* @param string $username
|
|
* @param string $password
|
|
* @param string $recoveryPassword
|
|
*
|
|
* @return JSONResponse
|
|
*/
|
|
public function changeUserPassword(string $username = null, string $password = null, string $recoveryPassword = null): JSONResponse {
|
|
if ($username === null) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('No user supplied'),
|
|
],
|
|
]);
|
|
}
|
|
|
|
if ($password === null) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Unable to change password'),
|
|
],
|
|
]);
|
|
}
|
|
|
|
$currentUser = $this->userSession->getUser();
|
|
$targetUser = $this->userManager->get($username);
|
|
if ($currentUser === null || $targetUser === null ||
|
|
!($this->groupManager->isAdmin($this->userId) ||
|
|
$this->groupManager->getSubAdmin()->isUserAccessible($currentUser, $targetUser))
|
|
) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Authentication error'),
|
|
],
|
|
]);
|
|
}
|
|
|
|
if ($this->appManager->isEnabledForUser('encryption')) {
|
|
//handle the recovery case
|
|
$crypt = new \OCA\Encryption\Crypto\Crypt(
|
|
\OC::$server->getLogger(),
|
|
\OC::$server->getUserSession(),
|
|
\OC::$server->getConfig(),
|
|
\OC::$server->getL10N('encryption'));
|
|
$keyStorage = \OC::$server->getEncryptionKeyStorage();
|
|
$util = new \OCA\Encryption\Util(
|
|
new \OC\Files\View(),
|
|
$crypt,
|
|
\OC::$server->getLogger(),
|
|
\OC::$server->getUserSession(),
|
|
\OC::$server->getConfig(),
|
|
\OC::$server->getUserManager());
|
|
$keyManager = new \OCA\Encryption\KeyManager(
|
|
$keyStorage,
|
|
$crypt,
|
|
\OC::$server->getConfig(),
|
|
\OC::$server->getUserSession(),
|
|
new \OCA\Encryption\Session(\OC::$server->getSession()),
|
|
\OC::$server->getLogger(),
|
|
$util);
|
|
$recovery = new \OCA\Encryption\Recovery(
|
|
\OC::$server->getUserSession(),
|
|
$crypt,
|
|
\OC::$server->getSecureRandom(),
|
|
$keyManager,
|
|
\OC::$server->getConfig(),
|
|
$keyStorage,
|
|
\OC::$server->getEncryptionFilesHelper(),
|
|
new \OC\Files\View());
|
|
$recoveryAdminEnabled = $recovery->isRecoveryKeyEnabled();
|
|
|
|
$validRecoveryPassword = false;
|
|
$recoveryEnabledForUser = false;
|
|
if ($recoveryAdminEnabled) {
|
|
$validRecoveryPassword = $keyManager->checkRecoveryPassword($recoveryPassword);
|
|
$recoveryEnabledForUser = $recovery->isRecoveryEnabledForUser($username);
|
|
}
|
|
|
|
if ($recoveryEnabledForUser && $recoveryPassword === '') {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Please provide an admin recovery password; otherwise, all user data will be lost.'),
|
|
]
|
|
]);
|
|
} elseif ($recoveryEnabledForUser && ! $validRecoveryPassword) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Wrong admin recovery password. Please check the password and try again.'),
|
|
]
|
|
]);
|
|
} else { // now we know that everything is fine regarding the recovery password, let's try to change the password
|
|
try {
|
|
$result = $targetUser->setPassword($password, $recoveryPassword);
|
|
// password policy app throws exception
|
|
} catch(HintException $e) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $e->getHint(),
|
|
],
|
|
]);
|
|
}
|
|
if (!$result && $recoveryEnabledForUser) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Backend doesn\'t support password change, but the user\'s encryption key was updated.'),
|
|
]
|
|
]);
|
|
} elseif (!$result && !$recoveryEnabledForUser) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Unable to change password'),
|
|
]
|
|
]);
|
|
}
|
|
}
|
|
} else {
|
|
try {
|
|
if ($targetUser->setPassword($password) === false) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $this->l->t('Unable to change password'),
|
|
],
|
|
]);
|
|
}
|
|
// password policy app throws exception
|
|
} catch(HintException $e) {
|
|
return new JSONResponse([
|
|
'status' => 'error',
|
|
'data' => [
|
|
'message' => $e->getHint(),
|
|
],
|
|
]);
|
|
}
|
|
}
|
|
|
|
return new JSONResponse([
|
|
'status' => 'success',
|
|
'data' => [
|
|
'username' => $username,
|
|
],
|
|
]);
|
|
}
|
|
}
|