5e9ca79788
There is no need to calculate a human readable date on the server side. We supply the mtime and a client can easily convert that himself if needed. This is already done most of the time since the date is often not in the exact right format. There is also no need to attach icon info. We have that available in javascript. And else the client should get the right icon based on the mimetype for its platform. * Updated tests
233 lines
6.6 KiB
PHP
233 lines
6.6 KiB
PHP
<?php
|
|
/**
|
|
* @author Björn Schießle <schiessle@owncloud.com>
|
|
* @author Christopher Schäpers <kondou@ts.unde.re>
|
|
* @author Joas Schilling <nickvergessen@owncloud.com>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Robin Appelman <icewind@owncloud.com>
|
|
* @author tbartenstein <tbartenstein@users.noreply.github.com>
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
* @author Vincent Petry <pvince81@owncloud.com>
|
|
*
|
|
* @copyright Copyright (c) 2015, ownCloud, Inc.
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
|
|
class Test_OC_Files_App_Rename extends \Test\TestCase {
|
|
private static $user;
|
|
|
|
/**
|
|
* @var PHPUnit_Framework_MockObject_MockObject
|
|
*/
|
|
private $viewMock;
|
|
|
|
/**
|
|
* @var \OCA\Files\App
|
|
*/
|
|
private $files;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
|
|
// mock OC_L10n
|
|
if (!self::$user) {
|
|
self::$user = uniqid();
|
|
}
|
|
\OC_User::createUser(self::$user, 'password');
|
|
$this->loginAsUser(self::$user);
|
|
|
|
$l10nMock = $this->getMock('\OC_L10N', array('t'), array(), '', false);
|
|
$l10nMock->expects($this->any())
|
|
->method('t')
|
|
->will($this->returnArgument(0));
|
|
$viewMock = $this->getMock('\OC\Files\View', array('rename', 'normalizePath', 'getFileInfo', 'file_exists'), array(), '', false);
|
|
$viewMock->expects($this->any())
|
|
->method('normalizePath')
|
|
->will($this->returnArgument(0));
|
|
$viewMock->expects($this->any())
|
|
->method('rename')
|
|
->will($this->returnValue(true));
|
|
$this->viewMock = $viewMock;
|
|
$this->files = new \OCA\Files\App($viewMock, $l10nMock);
|
|
}
|
|
|
|
protected function tearDown() {
|
|
$result = \OC_User::deleteUser(self::$user);
|
|
$this->assertTrue($result);
|
|
|
|
$this->logout();
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* test rename of file/folder
|
|
*/
|
|
function testRenameFolder() {
|
|
$dir = '/';
|
|
$oldname = 'oldname';
|
|
$newname = 'newname';
|
|
|
|
$this->viewMock->expects($this->any())
|
|
->method('file_exists')
|
|
->with($this->anything())
|
|
->will($this->returnValueMap(array(
|
|
array('/', true),
|
|
array('/oldname', true)
|
|
)));
|
|
|
|
|
|
$this->viewMock->expects($this->any())
|
|
->method('getFileInfo')
|
|
->will($this->returnValue(new \OC\Files\FileInfo(
|
|
'/new_name',
|
|
new \OC\Files\Storage\Local(array('datadir' => '/')),
|
|
'/',
|
|
array(
|
|
'fileid' => 123,
|
|
'type' => 'dir',
|
|
'mimetype' => 'httpd/unix-directory',
|
|
'mtime' => 0,
|
|
'permissions' => 31,
|
|
'size' => 18,
|
|
'etag' => 'abcdef',
|
|
'directory' => '/',
|
|
'name' => 'new_name',
|
|
), null)));
|
|
|
|
$result = $this->files->rename($dir, $oldname, $newname);
|
|
|
|
$this->assertTrue($result['success']);
|
|
$this->assertEquals(123, $result['data']['id']);
|
|
$this->assertEquals('new_name', $result['data']['name']);
|
|
$this->assertEquals(18, $result['data']['size']);
|
|
$this->assertEquals('httpd/unix-directory', $result['data']['mimetype']);
|
|
$this->assertEquals('abcdef', $result['data']['etag']);
|
|
$this->assertFalse(isset($result['data']['tags']));
|
|
$this->assertEquals('/', $result['data']['path']);
|
|
}
|
|
|
|
/**
|
|
* test rename of file with tag
|
|
*/
|
|
function testRenameFileWithTag() {
|
|
$taggerMock = $this->getMock('\OCP\ITags');
|
|
$taggerMock->expects($this->any())
|
|
->method('getTagsForObjects')
|
|
->with(array(123))
|
|
->will($this->returnValue(array(123 => array('tag1', 'tag2'))));
|
|
$tagManagerMock = $this->getMock('\OCP\ITagManager');
|
|
$tagManagerMock->expects($this->any())
|
|
->method('load')
|
|
->with('files')
|
|
->will($this->returnValue($taggerMock));
|
|
$oldTagManager = \OC::$server->query('TagManager');
|
|
\OC::$server->registerService('TagManager', function ($c) use ($tagManagerMock) {
|
|
return $tagManagerMock;
|
|
});
|
|
|
|
$dir = '/';
|
|
$oldname = 'oldname.txt';
|
|
$newname = 'newname.txt';
|
|
|
|
$this->viewMock->expects($this->any())
|
|
->method('file_exists')
|
|
->with($this->anything())
|
|
->will($this->returnValueMap(array(
|
|
array('/', true),
|
|
array('/oldname.txt', true)
|
|
)));
|
|
|
|
|
|
$this->viewMock->expects($this->any())
|
|
->method('getFileInfo')
|
|
->will($this->returnValue(new \OC\Files\FileInfo(
|
|
'/new_name.txt',
|
|
new \OC\Files\Storage\Local(array('datadir' => '/')),
|
|
'/',
|
|
array(
|
|
'fileid' => 123,
|
|
'type' => 'file',
|
|
'mimetype' => 'text/plain',
|
|
'mtime' => 0,
|
|
'permissions' => 31,
|
|
'size' => 18,
|
|
'etag' => 'abcdef',
|
|
'directory' => '/',
|
|
'name' => 'new_name.txt',
|
|
), null)));
|
|
|
|
$result = $this->files->rename($dir, $oldname, $newname);
|
|
|
|
$this->assertTrue($result['success']);
|
|
$this->assertEquals(123, $result['data']['id']);
|
|
$this->assertEquals('new_name.txt', $result['data']['name']);
|
|
$this->assertEquals(18, $result['data']['size']);
|
|
$this->assertEquals('text/plain', $result['data']['mimetype']);
|
|
$this->assertEquals('abcdef', $result['data']['etag']);
|
|
$this->assertEquals(array('tag1', 'tag2'), $result['data']['tags']);
|
|
$this->assertEquals('/', $result['data']['path']);
|
|
|
|
\OC::$server->registerService('TagManager', function ($c) use ($oldTagManager) {
|
|
return $oldTagManager;
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Test rename inside a folder that doesn't exist any more
|
|
*/
|
|
function testRenameInNonExistingFolder() {
|
|
$dir = '/unexist';
|
|
$oldname = 'oldname';
|
|
$newname = 'newname';
|
|
|
|
$this->viewMock->expects($this->at(0))
|
|
->method('file_exists')
|
|
->with('/unexist/oldname')
|
|
->will($this->returnValue(false));
|
|
|
|
$this->viewMock->expects($this->any())
|
|
->method('getFileInfo')
|
|
->will($this->returnValue(array(
|
|
'fileid' => 123,
|
|
'type' => 'dir',
|
|
'mimetype' => 'httpd/unix-directory',
|
|
'size' => 18,
|
|
'etag' => 'abcdef',
|
|
'directory' => '/unexist',
|
|
'name' => 'new_name',
|
|
)));
|
|
|
|
$result = $this->files->rename($dir, $oldname, $newname);
|
|
|
|
$this->assertFalse($result['success']);
|
|
$this->assertEquals('sourcenotfound', $result['data']['code']);
|
|
}
|
|
|
|
/**
|
|
* Test move to invalid name
|
|
*/
|
|
function testRenameToInvalidName() {
|
|
$dir = '/';
|
|
$oldname = 'oldname';
|
|
$newname = 'abc\\';
|
|
|
|
$result = $this->files->rename($dir, $oldname, $newname);
|
|
|
|
$this->assertFalse($result['success']);
|
|
$this->assertEquals('File name contains at least one invalid character', $result['data']['message']);
|
|
$this->assertEquals('invalidname', $result['data']['code']);
|
|
}
|
|
}
|