62e3de1bdb
`json_encode` fails hard on PHP >= 5.5 if a non UTF-8 value is specified by returning false. Older PHP versions just nullify the value which makes it at least somewhat usable. This leads to very confusing errors which are very hard to debug since developers are usually not aware of this. In this case I'd consider throwing a fatal exception – since it arguably is an error situation – is a fair solution since this makes developers and administrators aware of any occurence of the problem so that these bugs can get fixed. Fixes https://github.com/owncloud/core/issues/17265
109 lines
2.7 KiB
PHP
109 lines
2.7 KiB
PHP
<?php
|
|
|
|
/**
|
|
* ownCloud - App Framework
|
|
*
|
|
* @author Bernhard Posselt
|
|
* @author Morris Jobke
|
|
* @copyright 2012 Bernhard Posselt <dev@bernhard-posselt.com>
|
|
* @copyright 2013 Morris Jobke <morris.jobke@gmail.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
|
|
* License as published by the Free Software Foundation; either
|
|
* version 3 of the License, or any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
|
|
namespace OC\AppFramework\Http;
|
|
|
|
|
|
use OCP\AppFramework\Http\JSONResponse;
|
|
use OCP\AppFramework\Http;
|
|
|
|
class JSONResponseTest extends \Test\TestCase {
|
|
|
|
/**
|
|
* @var JSONResponse
|
|
*/
|
|
private $json;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
$this->json = new JSONResponse();
|
|
}
|
|
|
|
|
|
public function testHeader() {
|
|
$headers = $this->json->getHeaders();
|
|
$this->assertEquals('application/json; charset=utf-8', $headers['Content-Type']);
|
|
}
|
|
|
|
|
|
public function testSetData() {
|
|
$params = array('hi', 'yo');
|
|
$this->json->setData($params);
|
|
|
|
$this->assertEquals(array('hi', 'yo'), $this->json->getData());
|
|
}
|
|
|
|
|
|
public function testSetRender() {
|
|
$params = array('test' => 'hi');
|
|
$this->json->setData($params);
|
|
|
|
$expected = '{"test":"hi"}';
|
|
|
|
$this->assertEquals($expected, $this->json->render());
|
|
}
|
|
|
|
|
|
public function testRender() {
|
|
$params = array('test' => 'hi');
|
|
$this->json->setData($params);
|
|
|
|
$expected = '{"test":"hi"}';
|
|
|
|
$this->assertEquals($expected, $this->json->render());
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Exception
|
|
* @expectedExceptionMessage Could not json_encode due to invalid non UTF-8 characters in the array: array (
|
|
* @requires PHP 5.5
|
|
*/
|
|
public function testRenderWithNonUtf8Encoding() {
|
|
$params = ['test' => hex2bin('e9')];
|
|
$this->json->setData($params);
|
|
$this->json->render();
|
|
}
|
|
|
|
public function testConstructorAllowsToSetData() {
|
|
$data = array('hi');
|
|
$code = 300;
|
|
$response = new JSONResponse($data, $code);
|
|
|
|
$expected = '["hi"]';
|
|
$this->assertEquals($expected, $response->render());
|
|
$this->assertEquals($code, $response->getStatus());
|
|
}
|
|
|
|
public function testChainability() {
|
|
$params = array('hi', 'yo');
|
|
$this->json->setData($params)
|
|
->setStatus(Http::STATUS_NOT_FOUND);
|
|
|
|
$this->assertEquals(Http::STATUS_NOT_FOUND, $this->json->getStatus());
|
|
$this->assertEquals(array('hi', 'yo'), $this->json->getData());
|
|
}
|
|
|
|
}
|