7760f16521
In the same way that other elements can know when a FileAction is registered or a default action is set this commit makes possible to be notified before and after a FileAction is executed. This is achieved by wrapping the registered action handler in a custom function that notifies the listeners before and after executing the handler itself. Due to this approach only FileActions registered through "registerAction" trigger the events, although that is not a problem as this is how the actions should be added to the FileActions anyway. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
752 lines
25 KiB
JavaScript
752 lines
25 KiB
JavaScript
/**
|
|
* ownCloud
|
|
*
|
|
* @author Vincent Petry
|
|
* @copyright 2014 Vincent Petry <pvince81@owncloud.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
|
|
* License as published by the Free Software Foundation; either
|
|
* version 3 of the License, or any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
describe('OCA.Files.FileActions tests', function() {
|
|
var fileList, fileActions, clock;
|
|
|
|
beforeEach(function() {
|
|
clock = sinon.useFakeTimers();
|
|
// init horrible parameters
|
|
var $body = $('#testArea');
|
|
$body.append('<input type="hidden" id="dir" value="/subdir"></input>');
|
|
$body.append('<input type="hidden" id="permissions" value="31"></input>');
|
|
$body.append('<table id="filestable"><tbody id="fileList"></tbody></table>');
|
|
// dummy files table
|
|
fileActions = new OCA.Files.FileActions();
|
|
fileActions.registerAction({
|
|
name: 'Testdropdown',
|
|
displayName: 'Testdropdowndisplay',
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: function () {
|
|
return OC.imagePath('core', 'actions/download');
|
|
}
|
|
});
|
|
|
|
fileActions.registerAction({
|
|
name: 'Testinline',
|
|
displayName: 'Testinlinedisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.registerAction({
|
|
name: 'Testdefault',
|
|
displayName: 'Testdefaultdisplay',
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
fileActions.setDefault('all', 'Testdefault');
|
|
fileList = new OCA.Files.FileList($body, {
|
|
fileActions: fileActions
|
|
});
|
|
});
|
|
afterEach(function() {
|
|
fileActions = null;
|
|
fileList.destroy();
|
|
fileList = undefined;
|
|
clock.restore();
|
|
$('#dir, #permissions, #filestable').remove();
|
|
});
|
|
it('calling clear() clears file actions', function() {
|
|
fileActions.clear();
|
|
expect(fileActions.actions).toEqual({});
|
|
expect(fileActions.defaults).toEqual({});
|
|
expect(fileActions.icons).toEqual({});
|
|
expect(fileActions.currentFile).toBe(null);
|
|
});
|
|
describe('displaying actions', function() {
|
|
var $tr;
|
|
|
|
beforeEach(function() {
|
|
var fileData = {
|
|
id: 18,
|
|
type: 'file',
|
|
name: 'testName.txt',
|
|
mimetype: 'text/plain',
|
|
size: '1234',
|
|
etag: 'a01234c',
|
|
mtime: '123456',
|
|
permissions: OC.PERMISSION_READ | OC.PERMISSION_UPDATE
|
|
};
|
|
|
|
// note: FileActions.display() is called implicitly
|
|
$tr = fileList.add(fileData);
|
|
});
|
|
it('renders inline file actions', function() {
|
|
// actions defined after call
|
|
expect($tr.find('.action.action-testinline').length).toEqual(1);
|
|
expect($tr.find('.action.action-testinline').attr('data-action')).toEqual('Testinline');
|
|
});
|
|
it('does not render dropdown actions', function() {
|
|
expect($tr.find('.action.action-testdropdown').length).toEqual(0);
|
|
});
|
|
it('does not render default action', function() {
|
|
expect($tr.find('.action.action-testdefault').length).toEqual(0);
|
|
});
|
|
it('replaces file actions when displayed twice', function() {
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action.action-testinline').length).toEqual(1);
|
|
});
|
|
it('renders actions menu trigger', function() {
|
|
expect($tr.find('.action.action-menu').length).toEqual(1);
|
|
expect($tr.find('.action.action-menu').attr('data-action')).toEqual('menu');
|
|
});
|
|
it('only renders actions relevant to the mime type', function() {
|
|
fileActions.registerAction({
|
|
name: 'Match',
|
|
displayName: 'MatchDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'text/plain',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
fileActions.registerAction({
|
|
name: 'Nomatch',
|
|
displayName: 'NoMatchDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'application/octet-stream',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
expect($tr.find('.action.action-match').length).toEqual(1);
|
|
expect($tr.find('.action.action-nomatch').length).toEqual(0);
|
|
});
|
|
it('only renders actions relevant to the permissions', function() {
|
|
fileActions.registerAction({
|
|
name: 'Match',
|
|
displayName: 'MatchDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'text/plain',
|
|
permissions: OC.PERMISSION_UPDATE
|
|
});
|
|
fileActions.registerAction({
|
|
name: 'Nomatch',
|
|
displayName: 'NoMatchDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'text/plain',
|
|
permissions: OC.PERMISSION_DELETE
|
|
});
|
|
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
expect($tr.find('.action.action-match').length).toEqual(1);
|
|
expect($tr.find('.action.action-nomatch').length).toEqual(0);
|
|
});
|
|
it('display inline icon with image path', function() {
|
|
fileActions.registerAction({
|
|
name: 'Icon',
|
|
displayName: 'IconDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
icon: OC.imagePath('core', 'actions/icon'),
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
fileActions.registerAction({
|
|
name: 'NoIcon',
|
|
displayName: 'NoIconDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action.action-icon').length).toEqual(1);
|
|
expect($tr.find('.action.action-icon').find('img').length).toEqual(1);
|
|
expect($tr.find('.action.action-icon').find('img').eq(0).attr('src')).toEqual(OC.imagePath('core', 'actions/icon'));
|
|
|
|
expect($tr.find('.action.action-noicon').length).toEqual(1);
|
|
expect($tr.find('.action.action-noicon').find('img').length).toEqual(0);
|
|
});
|
|
it('display alt text on inline icon with image path', function() {
|
|
fileActions.registerAction({
|
|
name: 'IconAltText',
|
|
displayName: 'IconAltTextDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
icon: OC.imagePath('core', 'actions/iconAltText'),
|
|
altText: 'alt icon text',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.registerAction({
|
|
name: 'IconNoAltText',
|
|
displayName: 'IconNoAltTextDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
icon: OC.imagePath('core', 'actions/iconNoAltText'),
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action.action-iconalttext').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconalttext').find('img').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconalttext').find('img').eq(0).attr('alt')).toEqual('alt icon text');
|
|
|
|
expect($tr.find('.action.action-iconnoalttext').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconnoalttext').find('img').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconnoalttext').find('img').eq(0).attr('alt')).toEqual('');
|
|
});
|
|
it('display inline icon with iconClass', function() {
|
|
fileActions.registerAction({
|
|
name: 'Icon',
|
|
displayName: 'IconDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
iconClass: 'icon-test',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
fileActions.registerAction({
|
|
name: 'NoIcon',
|
|
displayName: 'NoIconDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action.action-icon').length).toEqual(1);
|
|
expect($tr.find('.action.action-icon').find('.icon').length).toEqual(1);
|
|
expect($tr.find('.action.action-icon').find('.icon').hasClass('icon-test')).toEqual(true);
|
|
|
|
expect($tr.find('.action.action-noicon').length).toEqual(1);
|
|
expect($tr.find('.action.action-noicon').find('.icon').length).toEqual(0);
|
|
});
|
|
it('display alt text on inline icon with iconClass when no display name exists', function() {
|
|
fileActions.registerAction({
|
|
name: 'IconAltText',
|
|
displayName: '',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
iconClass: 'icon-alttext',
|
|
altText: 'alt icon text',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.registerAction({
|
|
name: 'IconNoAltText',
|
|
displayName: 'IconNoAltTextDisplay',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
altText: 'useless alt text',
|
|
iconClass: 'icon-noalttext',
|
|
permissions: OC.PERMISSION_READ
|
|
});
|
|
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action.action-iconalttext').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconalttext').find('.icon').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconalttext').find('.hidden-visually').text()).toEqual('alt icon text');
|
|
|
|
expect($tr.find('.action.action-iconnoalttext').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconnoalttext').find('.icon').length).toEqual(1);
|
|
expect($tr.find('.action.action-iconnoalttext').find('.hidden-visually').length).toEqual(0);
|
|
});
|
|
});
|
|
describe('action handler', function() {
|
|
var actionStub, $tr, clock;
|
|
|
|
beforeEach(function() {
|
|
clock = sinon.useFakeTimers();
|
|
var fileData = {
|
|
id: 18,
|
|
type: 'file',
|
|
name: 'testName.txt',
|
|
mimetype: 'text/plain',
|
|
size: '1234',
|
|
etag: 'a01234c',
|
|
mtime: '123456'
|
|
};
|
|
actionStub = sinon.stub();
|
|
fileActions.registerAction({
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
permissions: OC.PERMISSION_READ,
|
|
actionHandler: actionStub
|
|
});
|
|
$tr = fileList.add(fileData);
|
|
});
|
|
afterEach(function() {
|
|
OC.hideMenus();
|
|
// jump past animations
|
|
clock.tick(1000);
|
|
clock.restore();
|
|
});
|
|
it('passes context to action handler', function() {
|
|
var notifyUpdateListenersSpy = sinon.spy(fileList.fileActions, '_notifyUpdateListeners');
|
|
$tr.find('.action-test').click();
|
|
expect(actionStub.calledOnce).toEqual(true);
|
|
expect(actionStub.getCall(0).args[0]).toEqual('testName.txt');
|
|
var context = actionStub.getCall(0).args[1];
|
|
expect(context.$file.is($tr)).toEqual(true);
|
|
expect(context.fileList).toBeDefined();
|
|
expect(context.fileActions).toBeDefined();
|
|
expect(context.dir).toEqual('/subdir');
|
|
expect(context.fileInfoModel.get('name')).toEqual('testName.txt');
|
|
|
|
expect(notifyUpdateListenersSpy.calledTwice).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.calledBefore(actionStub)).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.calledAfter(actionStub)).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.getCall(0).args[0]).toEqual('beforeTriggerAction');
|
|
expect(notifyUpdateListenersSpy.getCall(0).args[1]).toEqual({
|
|
action: fileActions.getActions('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'],
|
|
fileName: 'testName.txt',
|
|
context: context
|
|
});
|
|
expect(notifyUpdateListenersSpy.getCall(1).args[0]).toEqual('afterTriggerAction');
|
|
expect(notifyUpdateListenersSpy.getCall(1).args[1]).toEqual({
|
|
action: fileActions.getActions('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'],
|
|
fileName: 'testName.txt',
|
|
context: context
|
|
});
|
|
|
|
// when data-path is defined
|
|
actionStub.reset();
|
|
$tr.attr('data-path', '/somepath');
|
|
$tr.find('.action-test').click();
|
|
context = actionStub.getCall(0).args[1];
|
|
expect(context.dir).toEqual('/somepath');
|
|
});
|
|
it('also triggers action handler when calling triggerAction()', function() {
|
|
var notifyUpdateListenersSpy = sinon.spy(fileList.fileActions, '_notifyUpdateListeners');
|
|
var model = new OCA.Files.FileInfoModel({
|
|
id: 1,
|
|
name: 'Test.txt',
|
|
path: '/subdir',
|
|
mime: 'text/plain',
|
|
permissions: 31
|
|
});
|
|
fileActions.triggerAction('Test', model, fileList);
|
|
|
|
expect(actionStub.calledOnce).toEqual(true);
|
|
expect(actionStub.getCall(0).args[0]).toEqual('Test.txt');
|
|
expect(actionStub.getCall(0).args[1].fileList).toEqual(fileList);
|
|
expect(actionStub.getCall(0).args[1].fileActions).toEqual(fileActions);
|
|
expect(actionStub.getCall(0).args[1].fileInfoModel).toEqual(model);
|
|
|
|
expect(notifyUpdateListenersSpy.calledTwice).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.calledBefore(actionStub)).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.calledAfter(actionStub)).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.getCall(0).args[0]).toEqual('beforeTriggerAction');
|
|
expect(notifyUpdateListenersSpy.getCall(0).args[1]).toEqual({
|
|
action: fileActions.getActions('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'],
|
|
fileName: 'Test.txt',
|
|
context: {
|
|
fileActions: fileActions,
|
|
fileInfoModel: model,
|
|
dir: '/subdir',
|
|
fileList: fileList,
|
|
$file: fileList.findFileEl('Test.txt')
|
|
}
|
|
});
|
|
expect(notifyUpdateListenersSpy.getCall(1).args[0]).toEqual('afterTriggerAction');
|
|
expect(notifyUpdateListenersSpy.getCall(1).args[1]).toEqual({
|
|
action: fileActions.getActions('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'],
|
|
fileName: 'Test.txt',
|
|
context: {
|
|
fileActions: fileActions,
|
|
fileInfoModel: model,
|
|
dir: '/subdir',
|
|
fileList: fileList,
|
|
$file: fileList.findFileEl('Test.txt')
|
|
}
|
|
});
|
|
});
|
|
it('triggers listener events when invoked directly', function() {
|
|
var context = {fileActions: new OCA.Files.FileActions()}
|
|
var notifyUpdateListenersSpy = sinon.spy(context.fileActions, '_notifyUpdateListeners');
|
|
var testAction = fileActions.get('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'];
|
|
|
|
testAction('Test.txt', context);
|
|
|
|
expect(actionStub.calledOnce).toEqual(true);
|
|
expect(actionStub.getCall(0).args[0]).toEqual('Test.txt');
|
|
expect(actionStub.getCall(0).args[1]).toBe(context);
|
|
|
|
expect(notifyUpdateListenersSpy.calledTwice).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.calledBefore(actionStub)).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.calledAfter(actionStub)).toEqual(true);
|
|
expect(notifyUpdateListenersSpy.getCall(0).args[0]).toEqual('beforeTriggerAction');
|
|
expect(notifyUpdateListenersSpy.getCall(0).args[1]).toEqual({
|
|
action: fileActions.getActions('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'],
|
|
fileName: 'Test.txt',
|
|
context: context
|
|
});
|
|
expect(notifyUpdateListenersSpy.getCall(1).args[0]).toEqual('afterTriggerAction');
|
|
expect(notifyUpdateListenersSpy.getCall(1).args[1]).toEqual({
|
|
action: fileActions.getActions('all', OCA.Files.FileActions.TYPE_INLINE, OC.PERMISSION_READ)['Test'],
|
|
fileName: 'Test.txt',
|
|
context: context
|
|
});
|
|
}),
|
|
describe('actions menu', function() {
|
|
it('shows actions menu inside row when clicking the menu trigger', function() {
|
|
expect($tr.find('td.filename .fileActionsMenu').length).toEqual(0);
|
|
$tr.find('.action-menu').click();
|
|
expect($tr.find('td.filename .fileActionsMenu').length).toEqual(1);
|
|
});
|
|
it('shows highlight on current row', function() {
|
|
$tr.find('.action-menu').click();
|
|
expect($tr.hasClass('mouseOver')).toEqual(true);
|
|
});
|
|
it('cleans up after hiding', function() {
|
|
var slideUpStub = sinon.stub($.fn, 'slideUp');
|
|
$tr.find('.action-menu').click();
|
|
expect($tr.find('.fileActionsMenu').length).toEqual(1);
|
|
OC.hideMenus();
|
|
// sliding animation
|
|
expect(slideUpStub.calledOnce).toEqual(true);
|
|
slideUpStub.getCall(0).args[1]();
|
|
expect($tr.hasClass('mouseOver')).toEqual(false);
|
|
expect($tr.find('.fileActionsMenu').length).toEqual(0);
|
|
});
|
|
});
|
|
});
|
|
describe('custom rendering', function() {
|
|
var $tr;
|
|
beforeEach(function() {
|
|
var fileData = {
|
|
id: 18,
|
|
type: 'file',
|
|
name: 'testName.txt',
|
|
mimetype: 'text/plain',
|
|
size: '1234',
|
|
etag: 'a01234c',
|
|
mtime: '123456'
|
|
};
|
|
$tr = fileList.add(fileData);
|
|
});
|
|
it('regular function', function() {
|
|
var actionStub = sinon.stub();
|
|
fileActions.registerAction({
|
|
name: 'Test',
|
|
displayName: '',
|
|
mime: 'all',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
render: function(actionSpec, isDefault, context) {
|
|
expect(actionSpec.name).toEqual('Test');
|
|
expect(actionSpec.displayName).toEqual('');
|
|
expect(actionSpec.permissions).toEqual(OC.PERMISSION_READ);
|
|
expect(actionSpec.mime).toEqual('all');
|
|
expect(isDefault).toEqual(false);
|
|
|
|
expect(context.fileList).toEqual(fileList);
|
|
expect(context.$file[0]).toEqual($tr[0]);
|
|
|
|
var $customEl = $('<a class="action action-test" href="#"><span>blabli</span><span>blabla</span></a>');
|
|
$tr.find('td:first').append($customEl);
|
|
return $customEl;
|
|
},
|
|
actionHandler: actionStub
|
|
});
|
|
fileActions.display($tr.find('td.filename'), true, fileList);
|
|
|
|
var $actionEl = $tr.find('td:first .action-test');
|
|
expect($actionEl.length).toEqual(1);
|
|
expect($actionEl.hasClass('action')).toEqual(true);
|
|
|
|
$actionEl.click();
|
|
expect(actionStub.calledOnce).toEqual(true);
|
|
expect(actionStub.getCall(0).args[0]).toEqual('testName.txt');
|
|
});
|
|
});
|
|
describe('merging', function() {
|
|
var $tr;
|
|
beforeEach(function() {
|
|
var fileData = {
|
|
id: 18,
|
|
type: 'file',
|
|
name: 'testName.txt',
|
|
path: '/anotherpath/there',
|
|
mimetype: 'text/plain',
|
|
size: '1234',
|
|
etag: 'a01234c',
|
|
mtime: '123456'
|
|
};
|
|
$tr = fileList.add(fileData);
|
|
});
|
|
afterEach(function() {
|
|
$tr = null;
|
|
});
|
|
it('copies all actions to target file actions', function() {
|
|
var actions1 = new OCA.Files.FileActions();
|
|
var actions2 = new OCA.Files.FileActions();
|
|
var actionStub1 = sinon.stub();
|
|
var actionStub2 = sinon.stub();
|
|
actions1.registerAction({
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub1
|
|
});
|
|
actions2.registerAction({
|
|
name: 'Test2',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub2
|
|
});
|
|
actions2.merge(actions1);
|
|
|
|
actions2.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action-test').length).toEqual(1);
|
|
expect($tr.find('.action-test2').length).toEqual(1);
|
|
|
|
$tr.find('.action-test').click();
|
|
expect(actionStub1.calledOnce).toEqual(true);
|
|
expect(actionStub2.notCalled).toEqual(true);
|
|
|
|
actionStub1.reset();
|
|
|
|
$tr.find('.action-test2').click();
|
|
expect(actionStub1.notCalled).toEqual(true);
|
|
expect(actionStub2.calledOnce).toEqual(true);
|
|
});
|
|
it('overrides existing actions on merge', function() {
|
|
var actions1 = new OCA.Files.FileActions();
|
|
var actions2 = new OCA.Files.FileActions();
|
|
var actionStub1 = sinon.stub();
|
|
var actionStub2 = sinon.stub();
|
|
actions1.registerAction({
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
mime: 'all',
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub1
|
|
});
|
|
actions2.registerAction({
|
|
name: 'Test', // override
|
|
mime: 'all',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub2
|
|
});
|
|
actions1.merge(actions2);
|
|
|
|
actions1.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action-test').length).toEqual(1);
|
|
|
|
$tr.find('.action-test').click();
|
|
expect(actionStub1.notCalled).toEqual(true);
|
|
expect(actionStub2.calledOnce).toEqual(true);
|
|
});
|
|
it('overrides existing action when calling register after merge', function() {
|
|
var actions1 = new OCA.Files.FileActions();
|
|
var actions2 = new OCA.Files.FileActions();
|
|
var actionStub1 = sinon.stub();
|
|
var actionStub2 = sinon.stub();
|
|
actions1.registerAction({
|
|
mime: 'all',
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub1
|
|
});
|
|
|
|
actions1.merge(actions2);
|
|
|
|
// late override
|
|
actions1.registerAction({
|
|
mime: 'all',
|
|
name: 'Test', // override
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub2
|
|
});
|
|
|
|
actions1.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action-test').length).toEqual(1);
|
|
|
|
$tr.find('.action-test').click();
|
|
expect(actionStub1.notCalled).toEqual(true);
|
|
expect(actionStub2.calledOnce).toEqual(true);
|
|
});
|
|
it('leaves original file actions untouched (clean copy)', function() {
|
|
var actions1 = new OCA.Files.FileActions();
|
|
var actions2 = new OCA.Files.FileActions();
|
|
var actionStub1 = sinon.stub();
|
|
var actionStub2 = sinon.stub();
|
|
actions1.registerAction({
|
|
mime: 'all',
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub1
|
|
});
|
|
|
|
// copy the Test action to actions2
|
|
actions2.merge(actions1);
|
|
|
|
// late override
|
|
actions2.registerAction({
|
|
mime: 'all',
|
|
name: 'Test', // override
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub2
|
|
});
|
|
|
|
// check if original actions still call the correct handler
|
|
actions1.display($tr.find('td.filename'), true, fileList);
|
|
|
|
expect($tr.find('.action-test').length).toEqual(1);
|
|
|
|
$tr.find('.action-test').click();
|
|
expect(actionStub1.calledOnce).toEqual(true);
|
|
expect(actionStub2.notCalled).toEqual(true);
|
|
});
|
|
});
|
|
describe('events', function() {
|
|
var clock;
|
|
beforeEach(function() {
|
|
clock = sinon.useFakeTimers();
|
|
});
|
|
afterEach(function() {
|
|
clock.restore();
|
|
});
|
|
it('notifies update event handlers once after multiple changes', function() {
|
|
var actionStub = sinon.stub();
|
|
var handler = sinon.stub();
|
|
fileActions.on('registerAction', handler);
|
|
fileActions.registerAction({
|
|
mime: 'all',
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub
|
|
});
|
|
fileActions.registerAction({
|
|
mime: 'all',
|
|
name: 'Test2',
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub
|
|
});
|
|
expect(handler.calledTwice).toEqual(true);
|
|
});
|
|
it('does not notifies update event handlers after unregistering', function() {
|
|
var actionStub = sinon.stub();
|
|
var handler = sinon.stub();
|
|
fileActions.on('registerAction', handler);
|
|
fileActions.off('registerAction', handler);
|
|
fileActions.registerAction({
|
|
mime: 'all',
|
|
name: 'Test',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub
|
|
});
|
|
fileActions.registerAction({
|
|
mime: 'all',
|
|
name: 'Test2',
|
|
type: OCA.Files.FileActions.TYPE_INLINE,
|
|
permissions: OC.PERMISSION_READ,
|
|
icon: OC.imagePath('core', 'actions/test'),
|
|
actionHandler: actionStub
|
|
});
|
|
expect(handler.notCalled).toEqual(true);
|
|
});
|
|
});
|
|
describe('default actions', function() {
|
|
describe('download', function() {
|
|
it('redirects to URL and sets busy state to list', function() {
|
|
var handleDownloadStub = sinon.stub(OCA.Files.Files, 'handleDownload');
|
|
var busyStub = sinon.stub(fileList, 'showFileBusyState');
|
|
var fileData = {
|
|
id: 18,
|
|
type: 'file',
|
|
name: 'testName.txt',
|
|
mimetype: 'text/plain',
|
|
size: '1234',
|
|
etag: 'a01234c',
|
|
mtime: '123456',
|
|
permissions: OC.PERMISSION_READ | OC.PERMISSION_UPDATE
|
|
};
|
|
|
|
// note: FileActions.display() is called implicitly
|
|
fileList.add(fileData);
|
|
|
|
var model = fileList.getModelForFile('testName.txt');
|
|
|
|
fileActions.registerDefaultActions();
|
|
fileActions.triggerAction('Download', model, fileList);
|
|
|
|
expect(busyStub.calledOnce).toEqual(true);
|
|
expect(busyStub.calledWith('testName.txt', true)).toEqual(true);
|
|
expect(handleDownloadStub.calledOnce).toEqual(true);
|
|
expect(handleDownloadStub.getCall(0).args[0]).toEqual(
|
|
OC.webroot + '/remote.php/webdav/subdir/testName.txt'
|
|
);
|
|
busyStub.reset();
|
|
handleDownloadStub.yield();
|
|
|
|
expect(busyStub.calledOnce).toEqual(true);
|
|
expect(busyStub.calledWith('testName.txt', false)).toEqual(true);
|
|
|
|
busyStub.restore();
|
|
handleDownloadStub.restore();
|
|
});
|
|
});
|
|
});
|
|
describe('download spinner', function() {
|
|
var FileActions = OCA.Files.FileActions;
|
|
var $el;
|
|
|
|
beforeEach(function() {
|
|
$el = $('<a href="#"><span class="icon icon-download"></span><span>Download</span></a>');
|
|
});
|
|
|
|
it('replaces download icon with spinner', function() {
|
|
FileActions.updateFileActionSpinner($el, true);
|
|
expect($el.find('.icon.icon-loading-small').length).toEqual(1);
|
|
expect($el.find('.icon.icon-download').hasClass('hidden')).toEqual(true);
|
|
});
|
|
it('replaces spinner back with download icon with spinner', function() {
|
|
FileActions.updateFileActionSpinner($el, true);
|
|
FileActions.updateFileActionSpinner($el, false);
|
|
expect($el.find('.icon.icon-loading-small').length).toEqual(0);
|
|
expect($el.find('.icon.icon-download').hasClass('hidden')).toEqual(false);
|
|
});
|
|
});
|
|
});
|