da490bdbbe
support for primary groups actually the problem is only known on AD, it is only needed to take care of their attributes adjust to ADs special behaviour this change was not intended cache the SID value so it is not requested over and over again theres only one, use singular we are access add tests for new Access methods add tests for new Group methods address scrutinizer findings, mostly doc call ldap_explode_dn from ldap wrapper, enables tests without php5-ldap PHP Doc yo dawg, i heard you like backslashes … php doc fix PHPDoc updated and typos fixed while reviewing
272 lines
7.4 KiB
PHP
272 lines
7.4 KiB
PHP
<?php
|
||
/**
|
||
* ownCloud
|
||
*
|
||
* @author Arthur Schiwon
|
||
* @copyright 2014 Arthur Schiwon <blizzz@owncloud.com>
|
||
*
|
||
* This library is free software; you can redistribute it and/or
|
||
* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
|
||
* License as published by the Free Software Foundation; either
|
||
* version 3 of the License, or any later version.
|
||
*
|
||
* This library is distributed in the hope that it will be useful,
|
||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
|
||
*
|
||
* You should have received a copy of the GNU Affero General Public
|
||
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
||
*
|
||
*/
|
||
|
||
namespace OCA\user_ldap\tests;
|
||
|
||
namespace OCA\user_ldap\tests;
|
||
|
||
use \OCA\user_ldap\GROUP_LDAP as GroupLDAP;
|
||
use \OCA\user_ldap\lib\Access;
|
||
use \OCA\user_ldap\lib\Connection;
|
||
use \OCA\user_ldap\lib\ILDAPWrapper;
|
||
|
||
class Test_Group_Ldap extends \PHPUnit_Framework_TestCase {
|
||
private function getAccessMock() {
|
||
static $conMethods;
|
||
static $accMethods;
|
||
|
||
if(is_null($conMethods) || is_null($accMethods)) {
|
||
$conMethods = get_class_methods('\OCA\user_ldap\lib\Connection');
|
||
$accMethods = get_class_methods('\OCA\user_ldap\lib\Access');
|
||
}
|
||
$lw = $this->getMock('\OCA\user_ldap\lib\ILDAPWrapper');
|
||
$connector = $this->getMock('\OCA\user_ldap\lib\Connection',
|
||
$conMethods,
|
||
array($lw, null, null));
|
||
$um = new \OCA\user_ldap\lib\user\Manager(
|
||
$this->getMock('\OCP\IConfig'),
|
||
$this->getMock('\OCA\user_ldap\lib\FilesystemHelper'),
|
||
$this->getMock('\OCA\user_ldap\lib\LogWrapper'),
|
||
$this->getMock('\OCP\IAvatarManager'),
|
||
$this->getMock('\OCP\Image')
|
||
);
|
||
$access = $this->getMock('\OCA\user_ldap\lib\Access',
|
||
$accMethods,
|
||
array($connector, $lw, $um));
|
||
|
||
return $access;
|
||
}
|
||
|
||
private function enableGroups($access) {
|
||
$access->connection->expects($this->any())
|
||
->method('__get')
|
||
->will($this->returnCallback(function($name) {
|
||
// if($name === 'ldapLoginFilter') {
|
||
// return '%uid';
|
||
// }
|
||
return 1;
|
||
}));
|
||
}
|
||
|
||
public function testCountEmptySearchString() {
|
||
$access = $this->getAccessMock();
|
||
|
||
$this->enableGroups($access);
|
||
|
||
$access->expects($this->any())
|
||
->method('groupname2dn')
|
||
->will($this->returnValue('cn=group,dc=foo,dc=bar'));
|
||
|
||
$access->expects($this->any())
|
||
->method('readAttribute')
|
||
->will($this->returnValue(array('u11', 'u22', 'u33', 'u34')));
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
$users = $groupBackend->countUsersInGroup('group');
|
||
|
||
$this->assertSame(4, $users);
|
||
}
|
||
|
||
public function testCountWithSearchString() {
|
||
$access = $this->getAccessMock();
|
||
|
||
$this->enableGroups($access);
|
||
|
||
$access->expects($this->any())
|
||
->method('groupname2dn')
|
||
->will($this->returnValue('cn=group,dc=foo,dc=bar'));
|
||
|
||
$access->expects($this->any())
|
||
->method('fetchListOfUsers')
|
||
->will($this->returnValue(array()));
|
||
|
||
$access->expects($this->any())
|
||
->method('readAttribute')
|
||
->will($this->returnCallback(function($name) {
|
||
//the search operation will call readAttribute, thus we need
|
||
//to anaylze the "dn". All other times we just need to return
|
||
//something that is neither null or false, but once an array
|
||
//with the users in the group – so we do so all other times for
|
||
//simplicicity.
|
||
if(strpos($name, 'u') === 0) {
|
||
return strpos($name, '3');
|
||
}
|
||
return array('u11', 'u22', 'u33', 'u34');
|
||
}));
|
||
|
||
$access->expects($this->any())
|
||
->method('dn2username')
|
||
->will($this->returnCallback(function() {
|
||
return 'foobar' . \OCP\Util::generateRandomBytes(7);
|
||
}));
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
$users = $groupBackend->countUsersInGroup('group', '3');
|
||
|
||
$this->assertSame(2, $users);
|
||
}
|
||
|
||
public function testPrimaryGroupID2NameSuccess() {
|
||
$access = $this->getAccessMock();
|
||
$this->enableGroups($access);
|
||
|
||
$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
|
||
|
||
$access->expects($this->once())
|
||
->method('getSID')
|
||
->with($userDN)
|
||
->will($this->returnValue('S-1-5-21-249921958-728525901-1594176202'));
|
||
|
||
$access->expects($this->once())
|
||
->method('searchGroups')
|
||
->will($this->returnValue(array('cn=foo,dc=barfoo,dc=bar')));
|
||
|
||
$access->expects($this->once())
|
||
->method('dn2groupname')
|
||
->with('cn=foo,dc=barfoo,dc=bar')
|
||
->will($this->returnValue('MyGroup'));
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
|
||
$group = $groupBackend->primaryGroupID2Name('3117', $userDN);
|
||
|
||
$this->assertSame('MyGroup', $group);
|
||
}
|
||
|
||
public function testPrimaryGroupID2NameNoSID() {
|
||
$access = $this->getAccessMock();
|
||
$this->enableGroups($access);
|
||
|
||
$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
|
||
|
||
$access->expects($this->once())
|
||
->method('getSID')
|
||
->with($userDN)
|
||
->will($this->returnValue(false));
|
||
|
||
$access->expects($this->never())
|
||
->method('searchGroups');
|
||
|
||
$access->expects($this->never())
|
||
->method('dn2groupname');
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
|
||
$group = $groupBackend->primaryGroupID2Name('3117', $userDN);
|
||
|
||
$this->assertSame(false, $group);
|
||
}
|
||
|
||
public function testPrimaryGroupID2NameNoGroup() {
|
||
$access = $this->getAccessMock();
|
||
$this->enableGroups($access);
|
||
|
||
$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
|
||
|
||
$access->expects($this->once())
|
||
->method('getSID')
|
||
->with($userDN)
|
||
->will($this->returnValue('S-1-5-21-249921958-728525901-1594176202'));
|
||
|
||
$access->expects($this->once())
|
||
->method('searchGroups')
|
||
->will($this->returnValue(array()));
|
||
|
||
$access->expects($this->never())
|
||
->method('dn2groupname');
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
|
||
$group = $groupBackend->primaryGroupID2Name('3117', $userDN);
|
||
|
||
$this->assertSame(false, $group);
|
||
}
|
||
|
||
public function testPrimaryGroupID2NameNoName() {
|
||
$access = $this->getAccessMock();
|
||
$this->enableGroups($access);
|
||
|
||
$userDN = 'cn=alice,cn=foo,dc=barfoo,dc=bar';
|
||
|
||
$access->expects($this->once())
|
||
->method('getSID')
|
||
->with($userDN)
|
||
->will($this->returnValue('S-1-5-21-249921958-728525901-1594176202'));
|
||
|
||
$access->expects($this->once())
|
||
->method('searchGroups')
|
||
->will($this->returnValue(array('cn=foo,dc=barfoo,dc=bar')));
|
||
|
||
$access->expects($this->once())
|
||
->method('dn2groupname')
|
||
->will($this->returnValue(false));
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
|
||
$group = $groupBackend->primaryGroupID2Name('3117', $userDN);
|
||
|
||
$this->assertSame(false, $group);
|
||
}
|
||
|
||
public function testGetEntryGroupIDValue() {
|
||
//tests getEntryGroupID via getGroupPrimaryGroupID
|
||
//which is basically identical to getUserPrimaryGroupIDs
|
||
$access = $this->getAccessMock();
|
||
$this->enableGroups($access);
|
||
|
||
$dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
|
||
$attr = 'primaryGroupToken';
|
||
|
||
$access->expects($this->once())
|
||
->method('readAttribute')
|
||
->with($dn, $attr)
|
||
->will($this->returnValue(array('3117')));
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
|
||
$gid = $groupBackend->getGroupPrimaryGroupID($dn);
|
||
|
||
$this->assertSame('3117', $gid);
|
||
}
|
||
|
||
public function testGetEntryGroupIDNoValue() {
|
||
//tests getEntryGroupID via getGroupPrimaryGroupID
|
||
//which is basically identical to getUserPrimaryGroupIDs
|
||
$access = $this->getAccessMock();
|
||
$this->enableGroups($access);
|
||
|
||
$dn = 'cn=foobar,cn=foo,dc=barfoo,dc=bar';
|
||
$attr = 'primaryGroupToken';
|
||
|
||
$access->expects($this->once())
|
||
->method('readAttribute')
|
||
->with($dn, $attr)
|
||
->will($this->returnValue(false));
|
||
|
||
$groupBackend = new GroupLDAP($access);
|
||
|
||
$gid = $groupBackend->getGroupPrimaryGroupID($dn);
|
||
|
||
$this->assertSame(false, $gid);
|
||
}
|
||
|
||
}
|