9e6634814e
CSP nonces are a feature available with CSP v2. Basically instead of saying "JS resources from the same domain are ok to be served" we now say "Ressources from everywhere are allowed as long as they add a `nonce` attribute to the script tag with the right nonce. At the moment the nonce is basically just a `<?php p(base64_encode($_['requesttoken'])) ?>`, we have to decode the requesttoken since `:` is not an allowed value in the nonce. So if somebody does on their own include JS files (instead of using the `addScript` public API, they now must also include that attribute.) IE does currently not implement CSP v2, thus there is a whitelist included that delivers the new CSP v2 policy to newer browsers. Check http://caniuse.com/#feat=contentsecuritypolicy2 for the current browser support list. An alternative approach would be to just add `'unsafe-inline'` as well as `'unsafe-inline'` is ignored by CSPv2 when a nonce is set. But this would make this security feature unusable at all in IE. Not worth it at the moment IMO. Implementing this offers the following advantages: 1. **Security:** As we host resources from the same domain by design we don't have to worry about 'self' anymore being in the whitelist 2. **Performance:** We can move oc.js again to inline JS. This makes the loading way quicker as we don't have to load on every load of a new web page a blocking dynamically non-cached JavaScript file. If you want to toy with CSP see also https://csp-evaluator.withgoogle.com/ Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
267 lines
9.1 KiB
PHP
267 lines
9.1 KiB
PHP
<?php
|
|
/**
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
*
|
|
* @author Bernhard Posselt <dev@bernhard-posselt.com>
|
|
* @author Lukas Reschke <lukas@statuscode.ch>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
|
* @author Stefan Weil <sw@weilnetz.de>
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
* @author Thomas Tanghus <thomas@tanghus.net>
|
|
*
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
|
|
|
|
namespace OC\AppFramework\Middleware\Security;
|
|
|
|
use OC\AppFramework\Middleware\Security\Exceptions\AppNotEnabledException;
|
|
use OC\AppFramework\Middleware\Security\Exceptions\CrossSiteRequestForgeryException;
|
|
use OC\AppFramework\Middleware\Security\Exceptions\NotAdminException;
|
|
use OC\AppFramework\Middleware\Security\Exceptions\NotLoggedInException;
|
|
use OC\AppFramework\Middleware\Security\Exceptions\StrictCookieMissingException;
|
|
use OC\AppFramework\Utility\ControllerMethodReflector;
|
|
use OC\Security\CSP\ContentSecurityPolicyManager;
|
|
use OC\Security\CSRF\CsrfTokenManager;
|
|
use OCP\AppFramework\Http\ContentSecurityPolicy;
|
|
use OCP\AppFramework\Http\EmptyContentSecurityPolicy;
|
|
use OCP\AppFramework\Http\RedirectResponse;
|
|
use OCP\AppFramework\Http\TemplateResponse;
|
|
use OCP\AppFramework\Middleware;
|
|
use OCP\AppFramework\Http\Response;
|
|
use OCP\AppFramework\Http\JSONResponse;
|
|
use OCP\AppFramework\OCSController;
|
|
use OCP\INavigationManager;
|
|
use OCP\IURLGenerator;
|
|
use OCP\IRequest;
|
|
use OCP\ILogger;
|
|
use OCP\AppFramework\Controller;
|
|
use OCP\Util;
|
|
use OC\AppFramework\Middleware\Security\Exceptions\SecurityException;
|
|
|
|
/**
|
|
* Used to do all the authentication and checking stuff for a controller method
|
|
* It reads out the annotations of a controller method and checks which if
|
|
* security things should be checked and also handles errors in case a security
|
|
* check fails
|
|
*/
|
|
class SecurityMiddleware extends Middleware {
|
|
/** @var INavigationManager */
|
|
private $navigationManager;
|
|
/** @var IRequest */
|
|
private $request;
|
|
/** @var ControllerMethodReflector */
|
|
private $reflector;
|
|
/** @var string */
|
|
private $appName;
|
|
/** @var IURLGenerator */
|
|
private $urlGenerator;
|
|
/** @var ILogger */
|
|
private $logger;
|
|
/** @var bool */
|
|
private $isLoggedIn;
|
|
/** @var bool */
|
|
private $isAdminUser;
|
|
/** @var ContentSecurityPolicyManager */
|
|
private $contentSecurityPolicyManager;
|
|
/** @var CsrfTokenManager */
|
|
private $csrfTokenManager;
|
|
|
|
/**
|
|
* @param IRequest $request
|
|
* @param ControllerMethodReflector $reflector
|
|
* @param INavigationManager $navigationManager
|
|
* @param IURLGenerator $urlGenerator
|
|
* @param ILogger $logger
|
|
* @param string $appName
|
|
* @param bool $isLoggedIn
|
|
* @param bool $isAdminUser
|
|
* @param ContentSecurityPolicyManager $contentSecurityPolicyManager
|
|
* @param CSRFTokenManager $csrfTokenManager
|
|
*/
|
|
public function __construct(IRequest $request,
|
|
ControllerMethodReflector $reflector,
|
|
INavigationManager $navigationManager,
|
|
IURLGenerator $urlGenerator,
|
|
ILogger $logger,
|
|
$appName,
|
|
$isLoggedIn,
|
|
$isAdminUser,
|
|
ContentSecurityPolicyManager $contentSecurityPolicyManager,
|
|
CsrfTokenManager $csrfTokenManager) {
|
|
$this->navigationManager = $navigationManager;
|
|
$this->request = $request;
|
|
$this->reflector = $reflector;
|
|
$this->appName = $appName;
|
|
$this->urlGenerator = $urlGenerator;
|
|
$this->logger = $logger;
|
|
$this->isLoggedIn = $isLoggedIn;
|
|
$this->isAdminUser = $isAdminUser;
|
|
$this->contentSecurityPolicyManager = $contentSecurityPolicyManager;
|
|
$this->csrfTokenManager = $csrfTokenManager;
|
|
}
|
|
|
|
|
|
/**
|
|
* This runs all the security checks before a method call. The
|
|
* security checks are determined by inspecting the controller method
|
|
* annotations
|
|
* @param Controller $controller the controller
|
|
* @param string $methodName the name of the method
|
|
* @throws SecurityException when a security check fails
|
|
*/
|
|
public function beforeController($controller, $methodName) {
|
|
|
|
// this will set the current navigation entry of the app, use this only
|
|
// for normal HTML requests and not for AJAX requests
|
|
$this->navigationManager->setActiveEntry($this->appName);
|
|
|
|
// security checks
|
|
$isPublicPage = $this->reflector->hasAnnotation('PublicPage');
|
|
if(!$isPublicPage) {
|
|
if(!$this->isLoggedIn) {
|
|
throw new NotLoggedInException();
|
|
}
|
|
|
|
if(!$this->reflector->hasAnnotation('NoAdminRequired')) {
|
|
if(!$this->isAdminUser) {
|
|
throw new NotAdminException();
|
|
}
|
|
}
|
|
}
|
|
|
|
// Check for strict cookie requirement
|
|
if($this->reflector->hasAnnotation('StrictCookieRequired') || !$this->reflector->hasAnnotation('NoCSRFRequired')) {
|
|
if(!$this->request->passesStrictCookieCheck()) {
|
|
throw new StrictCookieMissingException();
|
|
}
|
|
}
|
|
// CSRF check - also registers the CSRF token since the session may be closed later
|
|
Util::callRegister();
|
|
if(!$this->reflector->hasAnnotation('NoCSRFRequired')) {
|
|
/*
|
|
* Only allow the CSRF check to fail on OCS Requests. This kind of
|
|
* hacks around that we have no full token auth in place yet and we
|
|
* do want to offer CSRF checks for web requests.
|
|
*/
|
|
if(!$this->request->passesCSRFCheck() && !(
|
|
$controller instanceof OCSController &&
|
|
$this->request->getHeader('OCS-APIREQUEST') === 'true')) {
|
|
throw new CrossSiteRequestForgeryException();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* FIXME: Use DI once available
|
|
* Checks if app is enabled (also includes a check whether user is allowed to access the resource)
|
|
* The getAppPath() check is here since components such as settings also use the AppFramework and
|
|
* therefore won't pass this check.
|
|
*/
|
|
if(\OC_App::getAppPath($this->appName) !== false && !\OC_App::isEnabled($this->appName)) {
|
|
throw new AppNotEnabledException();
|
|
}
|
|
|
|
}
|
|
|
|
private function browserSupportsCspV3() {
|
|
$browserWhitelist = [
|
|
// Chrome 40+
|
|
'/^Mozilla\/5\.0 \([^)]+\) AppleWebKit\/[0-9.]+ \(KHTML, like Gecko\) Chrome\/[4-9][0-9].[0-9.]+ (Mobile Safari|Safari)\/[0-9.]+$/',
|
|
// Firefox 45+
|
|
'/^Mozilla\/5\.0 \([^)]+\) Gecko\/[0-9.]+ Firefox\/(4[5-9]|[5-9][0-9])\.[0-9.]+$/',
|
|
// Safari 10+
|
|
'/^Mozilla\/5\.0 \([^)]+\) AppleWebKit\/[0-9.]+ \(KHTML, like Gecko\) Version\/1[0-9.]+ Safari\/[0-9.A-Z]+$/',
|
|
];
|
|
|
|
if($this->request->isUserAgent($browserWhitelist)) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* Performs the default CSP modifications that may be injected by other
|
|
* applications
|
|
*
|
|
* @param Controller $controller
|
|
* @param string $methodName
|
|
* @param Response $response
|
|
* @return Response
|
|
*/
|
|
public function afterController($controller, $methodName, Response $response) {
|
|
$policy = !is_null($response->getContentSecurityPolicy()) ? $response->getContentSecurityPolicy() : new ContentSecurityPolicy();
|
|
|
|
if (get_class($policy) === EmptyContentSecurityPolicy::class) {
|
|
return $response;
|
|
}
|
|
|
|
$defaultPolicy = $this->contentSecurityPolicyManager->getDefaultPolicy();
|
|
$defaultPolicy = $this->contentSecurityPolicyManager->mergePolicies($defaultPolicy, $policy);
|
|
|
|
if($this->browserSupportsCspV3()) {
|
|
$defaultPolicy->useJsNonce($this->csrfTokenManager->getToken()->getEncryptedValue());
|
|
}
|
|
|
|
$response->setContentSecurityPolicy($defaultPolicy);
|
|
|
|
return $response;
|
|
}
|
|
|
|
/**
|
|
* If an SecurityException is being caught, ajax requests return a JSON error
|
|
* response and non ajax requests redirect to the index
|
|
* @param Controller $controller the controller that is being called
|
|
* @param string $methodName the name of the method that will be called on
|
|
* the controller
|
|
* @param \Exception $exception the thrown exception
|
|
* @throws \Exception the passed in exception if it can't handle it
|
|
* @return Response a Response object or null in case that the exception could not be handled
|
|
*/
|
|
public function afterException($controller, $methodName, \Exception $exception) {
|
|
if($exception instanceof SecurityException) {
|
|
if($exception instanceof StrictCookieMissingException) {
|
|
return new RedirectResponse(\OC::$WEBROOT);
|
|
}
|
|
if (stripos($this->request->getHeader('Accept'),'html') === false) {
|
|
$response = new JSONResponse(
|
|
array('message' => $exception->getMessage()),
|
|
$exception->getCode()
|
|
);
|
|
} else {
|
|
if($exception instanceof NotLoggedInException) {
|
|
$url = $this->urlGenerator->linkToRoute(
|
|
'core.login.showLoginForm',
|
|
[
|
|
'redirect_url' => urlencode($this->request->server['REQUEST_URI']),
|
|
]
|
|
);
|
|
$response = new RedirectResponse($url);
|
|
} else {
|
|
$response = new TemplateResponse('core', '403', ['file' => $exception->getMessage()], 'guest');
|
|
$response->setStatus($exception->getCode());
|
|
}
|
|
}
|
|
|
|
$this->logger->debug($exception->getMessage());
|
|
return $response;
|
|
}
|
|
|
|
throw $exception;
|
|
}
|
|
|
|
}
|