1cd255af56
While the UI is existent the feature simply doesn't work because admin privileges are required for the controller. This adds proper permission checks and also unit tests. To test this: 1. Enable external storage 2. Login as non-admin user 3. Go to personal page and try to change global credentials
118 lines
3.2 KiB
PHP
118 lines
3.2 KiB
PHP
<?php
|
|
/**
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Robin Appelman <icewind@owncloud.com>
|
|
* @author Robin McCorkell <robin@mccorkell.me.uk>
|
|
* @author Ross Nicoll <jrn@jrn.me.uk>
|
|
*
|
|
* @copyright Copyright (c) 2016, ownCloud, Inc.
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
|
|
namespace OCA\Files_External\Controller;
|
|
|
|
use OCA\Files_External\Lib\Auth\Password\GlobalAuth;
|
|
use OCP\AppFramework\Controller;
|
|
use OCP\AppFramework\Http;
|
|
use OCP\AppFramework\Http\Response;
|
|
use OCP\IGroupManager;
|
|
use OCP\IRequest;
|
|
use OCP\AppFramework\Http\JSONResponse;
|
|
use OCA\Files_External\Lib\Auth\PublicKey\RSA;
|
|
use OCP\IUserSession;
|
|
|
|
class AjaxController extends Controller {
|
|
/** @var RSA */
|
|
private $rsaMechanism;
|
|
/** @var GlobalAuth */
|
|
private $globalAuth;
|
|
/** @var IUserSession */
|
|
private $userSession;
|
|
/** @var IGroupManager */
|
|
private $groupManager;
|
|
|
|
/**
|
|
* @param string $appName
|
|
* @param IRequest $request
|
|
* @param RSA $rsaMechanism
|
|
* @param GlobalAuth $globalAuth
|
|
* @param IUserSession $userSession
|
|
* @param IGroupManager $groupManager
|
|
*/
|
|
public function __construct($appName,
|
|
IRequest $request,
|
|
RSA $rsaMechanism,
|
|
GlobalAuth $globalAuth,
|
|
IUserSession $userSession,
|
|
IGroupManager $groupManager) {
|
|
parent::__construct($appName, $request);
|
|
$this->rsaMechanism = $rsaMechanism;
|
|
$this->globalAuth = $globalAuth;
|
|
$this->userSession = $userSession;
|
|
$this->groupManager = $groupManager;
|
|
}
|
|
|
|
/**
|
|
* @return array
|
|
*/
|
|
private function generateSshKeys() {
|
|
$key = $this->rsaMechanism->createKey();
|
|
// Replace the placeholder label with a more meaningful one
|
|
$key['publicKey'] = str_replace('phpseclib-generated-key', gethostname(), $key['publickey']);
|
|
|
|
return $key;
|
|
}
|
|
|
|
/**
|
|
* Generates an SSH public/private key pair.
|
|
*
|
|
* @NoAdminRequired
|
|
*/
|
|
public function getSshKeys() {
|
|
$key = $this->generateSshKeys();
|
|
return new JSONResponse(
|
|
array('data' => array(
|
|
'private_key' => $key['privatekey'],
|
|
'public_key' => $key['publickey']
|
|
),
|
|
'status' => 'success'
|
|
));
|
|
}
|
|
|
|
/**
|
|
* @NoAdminRequired
|
|
*
|
|
* @param string $uid
|
|
* @param string $user
|
|
* @param string $password
|
|
* @return bool
|
|
*/
|
|
public function saveGlobalCredentials($uid, $user, $password) {
|
|
$currentUser = $this->userSession->getUser();
|
|
|
|
// Non-admins can only edit their own credentials
|
|
$allowedToEdit = (
|
|
$this->groupManager->isAdmin($currentUser->getUID()) || $currentUser->getUID() === $uid
|
|
) ? true : false;
|
|
|
|
if ($allowedToEdit) {
|
|
$this->globalAuth->saveAuth($uid, $user, $password);
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
}
|