9f6dcb9d3e
- VObject fixes for Sabre\VObject 3.3 - Remove VObject property workarounds - Added prefetching for tags in sabre tags plugin - Moved oc_properties logic to separate PropertyStorage backend (WIP) - Fixed Sabre connector namespaces - Improved files plugin to handle props on-demand - Moved allowed props from server class to files plugin - Fixed tags caching for files that are known to have no tags (less queries) - Added/fixed unit tests for Sabre FilesPlugin, TagsPlugin - Replace OC\Connector\Sabre\Request with direct call to httpRequest->setUrl() - Fix exception detection in DAV client when using Sabre\DAV\Client - Added setETag() on Node instead of using the static FileSystem - Also preload tags/props when depth is infinity
248 lines
5.6 KiB
PHP
248 lines
5.6 KiB
PHP
<?php
|
|
|
|
namespace Tests\Connector\Sabre;
|
|
|
|
/**
|
|
* Copyright (c) 2015 Vincent Petry <pvince81@owncloud.com>
|
|
* This file is licensed under the Affero General Public License version 3 or
|
|
* later.
|
|
* See the COPYING-README file.
|
|
*/
|
|
class CustomPropertiesBackend extends \Test\TestCase {
|
|
|
|
/**
|
|
* @var \Sabre\DAV\Server
|
|
*/
|
|
private $server;
|
|
|
|
/**
|
|
* @var \Sabre\DAV\ObjectTree
|
|
*/
|
|
private $tree;
|
|
|
|
/**
|
|
* @var \OC\Connector\Sabre\CustomPropertiesBackend
|
|
*/
|
|
private $plugin;
|
|
|
|
/**
|
|
* @var \OCP\IUser
|
|
*/
|
|
private $user;
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
$this->server = new \Sabre\DAV\Server();
|
|
$this->tree = $this->getMockBuilder('\Sabre\DAV\Tree')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$userId = $this->getUniqueID('testcustompropertiesuser');
|
|
|
|
$this->user = $this->getMock('\OCP\IUser');
|
|
$this->user->expects($this->any())
|
|
->method('getUID')
|
|
->will($this->returnValue($userId));
|
|
|
|
$this->plugin = new \OC\Connector\Sabre\CustomPropertiesBackend(
|
|
$this->tree,
|
|
\OC::$server->getDatabaseConnection(),
|
|
$this->user
|
|
);
|
|
}
|
|
|
|
public function tearDown() {
|
|
$connection = \OC::$server->getDatabaseConnection();
|
|
$deleteStatement = $connection->prepare(
|
|
'DELETE FROM `*PREFIX*properties`' .
|
|
' WHERE `userid` = ?'
|
|
);
|
|
$deleteStatement->execute(
|
|
array(
|
|
$this->user->getUID(),
|
|
)
|
|
);
|
|
$deleteStatement->closeCursor();
|
|
}
|
|
|
|
private function createTestNode($class) {
|
|
$node = $this->getMockBuilder($class)
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$node->expects($this->any())
|
|
->method('getId')
|
|
->will($this->returnValue(123));
|
|
|
|
$node->expects($this->any())
|
|
->method('getPath')
|
|
->will($this->returnValue('/dummypath'));
|
|
|
|
return $node;
|
|
}
|
|
|
|
private function applyDefaultProps($path = '/dummypath') {
|
|
// properties to set
|
|
$propPatch = new \Sabre\DAV\PropPatch(array(
|
|
'customprop' => 'value1',
|
|
'customprop2' => 'value2',
|
|
));
|
|
|
|
$this->plugin->propPatch(
|
|
$path,
|
|
$propPatch
|
|
);
|
|
|
|
$propPatch->commit();
|
|
|
|
$this->assertEmpty($propPatch->getRemainingMutations());
|
|
|
|
$result = $propPatch->getResult();
|
|
$this->assertEquals(200, $result['customprop']);
|
|
$this->assertEquals(200, $result['customprop2']);
|
|
}
|
|
|
|
/**
|
|
* Test setting/getting properties
|
|
*/
|
|
public function testSetGetPropertiesForFile() {
|
|
$node = $this->createTestNode('\OC\Connector\Sabre\File');
|
|
$this->tree->expects($this->any())
|
|
->method('getNodeForPath')
|
|
->with('/dummypath')
|
|
->will($this->returnValue($node));
|
|
|
|
$this->applyDefaultProps();
|
|
|
|
$propFind = new \Sabre\DAV\PropFind(
|
|
'/dummypath',
|
|
array(
|
|
'customprop',
|
|
'customprop2',
|
|
'unsetprop',
|
|
),
|
|
0
|
|
);
|
|
|
|
$this->plugin->propFind(
|
|
'/dummypath',
|
|
$propFind
|
|
);
|
|
|
|
$this->assertEquals('value1', $propFind->get('customprop'));
|
|
$this->assertEquals('value2', $propFind->get('customprop2'));
|
|
$this->assertEquals(array('unsetprop'), $propFind->get404Properties());
|
|
}
|
|
|
|
/**
|
|
* Test getting properties from directory
|
|
*/
|
|
public function testGetPropertiesForDirectory() {
|
|
$rootNode = $this->createTestNode('\OC\Connector\Sabre\Directory');
|
|
|
|
$nodeSub = $this->getMockBuilder('\OC\Connector\Sabre\File')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$nodeSub->expects($this->any())
|
|
->method('getId')
|
|
->will($this->returnValue(456));
|
|
|
|
$nodeSub->expects($this->any())
|
|
->method('getPath')
|
|
->will($this->returnValue('/dummypath/test.txt'));
|
|
|
|
$rootNode->expects($this->once())
|
|
->method('getChildren')
|
|
->will($this->returnValue(array($nodeSub)));
|
|
|
|
$this->tree->expects($this->at(0))
|
|
->method('getNodeForPath')
|
|
->with('/dummypath')
|
|
->will($this->returnValue($rootNode));
|
|
|
|
$this->tree->expects($this->at(1))
|
|
->method('getNodeForPath')
|
|
->with('/dummypath/test.txt')
|
|
->will($this->returnValue($nodeSub));
|
|
|
|
$this->tree->expects($this->at(2))
|
|
->method('getNodeForPath')
|
|
->with('/dummypath')
|
|
->will($this->returnValue($rootNode));
|
|
|
|
$this->tree->expects($this->at(3))
|
|
->method('getNodeForPath')
|
|
->with('/dummypath/test.txt')
|
|
->will($this->returnValue($nodeSub));
|
|
|
|
$this->applyDefaultProps('/dummypath');
|
|
$this->applyDefaultProps('/dummypath/test.txt');
|
|
|
|
$propNames = array(
|
|
'customprop',
|
|
'customprop2',
|
|
'unsetprop',
|
|
);
|
|
|
|
$propFindRoot = new \Sabre\DAV\PropFind(
|
|
'/dummypath',
|
|
$propNames,
|
|
1
|
|
);
|
|
|
|
$propFindSub = new \Sabre\DAV\PropFind(
|
|
'/dummypath/test.txt',
|
|
$propNames,
|
|
0
|
|
);
|
|
|
|
$this->plugin->propFind(
|
|
'/dummypath',
|
|
$propFindRoot
|
|
);
|
|
|
|
$this->plugin->propFind(
|
|
'/dummypath/test.txt',
|
|
$propFindSub
|
|
);
|
|
|
|
// TODO: find a way to assert that no additional SQL queries were
|
|
// run while doing the second propFind
|
|
|
|
$this->assertEquals('value1', $propFindRoot->get('customprop'));
|
|
$this->assertEquals('value2', $propFindRoot->get('customprop2'));
|
|
$this->assertEquals(array('unsetprop'), $propFindRoot->get404Properties());
|
|
|
|
$this->assertEquals('value1', $propFindSub->get('customprop'));
|
|
$this->assertEquals('value2', $propFindSub->get('customprop2'));
|
|
$this->assertEquals(array('unsetprop'), $propFindSub->get404Properties());
|
|
}
|
|
|
|
/**
|
|
* Test delete property
|
|
*/
|
|
public function testDeleteProperty() {
|
|
$node = $this->createTestNode('\OC\Connector\Sabre\File');
|
|
$this->tree->expects($this->any())
|
|
->method('getNodeForPath')
|
|
->with('/dummypath')
|
|
->will($this->returnValue($node));
|
|
|
|
$this->applyDefaultProps();
|
|
|
|
$propPatch = new \Sabre\DAV\PropPatch(array(
|
|
'customprop' => null,
|
|
));
|
|
|
|
$this->plugin->propPatch(
|
|
'/dummypath',
|
|
$propPatch
|
|
);
|
|
|
|
$propPatch->commit();
|
|
|
|
$this->assertEmpty($propPatch->getRemainingMutations());
|
|
|
|
$result = $propPatch->getResult();
|
|
$this->assertEquals(204, $result['customprop']);
|
|
}
|
|
}
|