cc88c5f4b8
VisibilityTrait -> PermissionsTrait
PermissionsTrait stores two sets of data, $permissions and
$allowedPermissions (analogous to $visibility and $allowedVisibility of
VisibilityTrait). Each set is a map of user type ('admin' or 'personal')
to permissions (mounting permission, create permission).
The result is that a backend can now be restricted for creation, while
still allowing it to be mounted. This is useful for deprecating backends
or auth mechanisms, preventing new storages being created, while still
allowing existing storages to be mounted.
130 lines
4.6 KiB
PHP
130 lines
4.6 KiB
PHP
<?php
|
|
/**
|
|
* @author Robin McCorkell <rmccorkell@owncloud.com>
|
|
*
|
|
* @copyright Copyright (c) 2015, ownCloud, Inc.
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
namespace OCA\Files_External\Tests\Service;
|
|
|
|
use \OCA\Files_External\Service\BackendService;
|
|
|
|
class BackendServiceTest extends \Test\TestCase {
|
|
|
|
/** @var \OCP\IConfig */
|
|
protected $config;
|
|
|
|
/** @var \OCP\IL10N */
|
|
protected $l10n;
|
|
|
|
protected function setUp() {
|
|
$this->config = $this->getMock('\OCP\IConfig');
|
|
$this->l10n = $this->getMock('\OCP\IL10N');
|
|
}
|
|
|
|
protected function getBackendMock($class) {
|
|
$backend = $this->getMockBuilder('\OCA\Files_External\Lib\Backend\Backend')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$backend->method('getIdentifier')->will($this->returnValue('identifier:'.$class));
|
|
$backend->method('getIdentifierAliases')->will($this->returnValue(['identifier:'.$class]));
|
|
return $backend;
|
|
}
|
|
|
|
public function testRegisterBackend() {
|
|
$service = new BackendService($this->config, $this->l10n);
|
|
|
|
$backend = $this->getBackendMock('\Foo\Bar');
|
|
|
|
$backendAlias = $this->getMockBuilder('\OCA\Files_External\Lib\Backend\Backend')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$backendAlias->method('getIdentifierAliases')
|
|
->willReturn(['identifier_real', 'identifier_alias']);
|
|
$backendAlias->method('getIdentifier')
|
|
->willReturn('identifier_real');
|
|
|
|
$service->registerBackend($backend);
|
|
$service->registerBackend($backendAlias);
|
|
|
|
$this->assertEquals($backend, $service->getBackend('identifier:\Foo\Bar'));
|
|
$this->assertEquals($backendAlias, $service->getBackend('identifier_real'));
|
|
$this->assertEquals($backendAlias, $service->getBackend('identifier_alias'));
|
|
|
|
$backends = $service->getBackends();
|
|
$this->assertCount(2, $backends);
|
|
$this->assertArrayHasKey('identifier:\Foo\Bar', $backends);
|
|
$this->assertArrayHasKey('identifier_real', $backends);
|
|
$this->assertArrayNotHasKey('identifier_alias', $backends);
|
|
}
|
|
|
|
public function testUserMountingBackends() {
|
|
$this->config->expects($this->exactly(2))
|
|
->method('getAppValue')
|
|
->will($this->returnValueMap([
|
|
['files_external', 'allow_user_mounting', 'yes', 'yes'],
|
|
['files_external', 'user_mounting_backends', '', 'identifier:\User\Mount\Allowed,identifier_alias']
|
|
]));
|
|
|
|
$service = new BackendService($this->config, $this->l10n);
|
|
|
|
$backendAllowed = $this->getBackendMock('\User\Mount\Allowed');
|
|
$backendAllowed->expects($this->never())
|
|
->method('removePermission');
|
|
$backendNotAllowed = $this->getBackendMock('\User\Mount\NotAllowed');
|
|
$backendNotAllowed->expects($this->once())
|
|
->method('removePermission')
|
|
->with(BackendService::USER_PERSONAL, BackendService::PERMISSION_CREATE | BackendService::PERMISSION_MOUNT);
|
|
|
|
$backendAlias = $this->getMockBuilder('\OCA\Files_External\Lib\Backend\Backend')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
$backendAlias->method('getIdentifierAliases')
|
|
->willReturn(['identifier_real', 'identifier_alias']);
|
|
$backendAlias->expects($this->never())
|
|
->method('removeVisibility');
|
|
|
|
$service->registerBackend($backendAllowed);
|
|
$service->registerBackend($backendNotAllowed);
|
|
$service->registerBackend($backendAlias);
|
|
}
|
|
|
|
public function testGetAvailableBackends() {
|
|
$service = new BackendService($this->config, $this->l10n);
|
|
|
|
$backendAvailable = $this->getBackendMock('\Backend\Available');
|
|
$backendAvailable->expects($this->once())
|
|
->method('checkDependencies')
|
|
->will($this->returnValue([]));
|
|
$backendNotAvailable = $this->getBackendMock('\Backend\NotAvailable');
|
|
$backendNotAvailable->expects($this->once())
|
|
->method('checkDependencies')
|
|
->will($this->returnValue([
|
|
$this->getMockBuilder('\OCA\Files_External\Lib\MissingDependency')
|
|
->disableOriginalConstructor()
|
|
->getMock()
|
|
]));
|
|
|
|
$service->registerBackend($backendAvailable);
|
|
$service->registerBackend($backendNotAvailable);
|
|
|
|
$availableBackends = $service->getAvailableBackends();
|
|
$this->assertArrayHasKey('identifier:\Backend\Available', $availableBackends);
|
|
$this->assertArrayNotHasKey('identifier:\Backend\NotAvailable', $availableBackends);
|
|
}
|
|
|
|
}
|
|
|