server/apps/comments/tests/Unit/Controller/NotificationsTest.php
Arthur Schiwon e1073cf442
Notificacations for simple @-mentioning in comments
(WIP) notify user when mentioned in comments

Fix doc, and create absolute URL for as notification link.

PSR-4 compatibility changes

also move notification creation to comments app

Do not notify yourself

unit test for controller and application

smaller fixes

- translatable app name
- remove doubles in mention array
- micro perf optimization
- display name: special label for deleted users, keep user id for users that could not be fetched from userManager

Comment Notification-Listener Unit Test

fix email adresses

remove notification when triggering comment was deleted

add and adjust tests

add missing @license tags

simplify NotificationsController registration

appinfo simplification, php docs

make string easier to translate

adjust test

replace dispatcher-based listeners with a registration method and interface

safer to not pass optional data parameter to setSubject for marking as processed. ID and mention suffices

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

update comment

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2016-10-07 17:11:19 +02:00

162 lines
5.3 KiB
PHP

<?php
/**
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
*
* @copyright Copyright (c) 2016, ownCloud, Inc.
* @license AGPL-3.0
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
namespace OCA\Comments\Tests\Unit\Controller;
use OCA\Comments\Controller\Notifications;
use OCP\Comments\NotFoundException;
use Test\TestCase;
class NotificationsTest extends TestCase {
/** @var \OCA\Comments\Controller\Notifications */
protected $notificationsController;
/** @var \OCP\Comments\ICommentsManager|\PHPUnit_Framework_MockObject_MockObject */
protected $commentsManager;
/** @var \OCP\Files\Folder|\PHPUnit_Framework_MockObject_MockObject */
protected $folder;
/** @var \OCP\IUserSession|\PHPUnit_Framework_MockObject_MockObject */
protected $session;
/** @var \OCP\Notification\IManager|\PHPUnit_Framework_MockObject_MockObject */
protected $notificationManager;
protected function setUp() {
parent::setUp();
$this->commentsManager = $this->getMockBuilder('\OCP\Comments\ICommentsManager')->getMock();
$this->folder = $this->getMockBuilder('\OCP\Files\Folder')->getMock();
$this->session = $this->getMockBuilder('\OCP\IUserSession')->getMock();
$this->notificationManager = $this->getMockBuilder('\OCP\Notification\IManager')->getMock();
$this->notificationsController = new Notifications(
'comments',
$this->getMockBuilder('\OCP\IRequest')->getMock(),
$this->commentsManager,
$this->folder,
$this->getMockBuilder('\OCP\IURLGenerator')->getMock(),
$this->notificationManager,
$this->session
);
}
public function testViewSuccess() {
$comment = $this->getMockBuilder('\OCP\Comments\IComment')->getMock();
$comment->expects($this->any())
->method('getObjectType')
->will($this->returnValue('files'));
$this->commentsManager->expects($this->any())
->method('get')
->with('42')
->will($this->returnValue($comment));
$file = $this->getMockBuilder('\OCP\Files\Node')->getMock();
$file->expects($this->once())
->method('getParent')
->will($this->returnValue($this->getMockBuilder('\OCP\Files\Folder')->getMock()));
$this->folder->expects($this->once())
->method('getById')
->will($this->returnValue([$file]));
$this->session->expects($this->once())
->method('getUser')
->will($this->returnValue($this->getMockBuilder('\OCP\IUser')->getMock()));
$notification = $this->getMockBuilder('\OCP\Notification\INotification')->getMock();
$notification->expects($this->any())
->method($this->anything())
->will($this->returnValue($notification));
$this->notificationManager->expects($this->once())
->method('createNotification')
->will($this->returnValue($notification));
$this->notificationManager->expects($this->once())
->method('markProcessed')
->with($notification);
$response = $this->notificationsController->view('42');
$this->assertInstanceOf('\OCP\AppFramework\Http\RedirectResponse', $response);
}
public function testViewInvalidComment() {
$this->commentsManager->expects($this->any())
->method('get')
->with('42')
->will($this->throwException(new NotFoundException()));
$file = $this->getMockBuilder('\OCP\Files\Node')->getMock();
$file->expects($this->never())
->method('getParent');
$this->folder->expects($this->never())
->method('getById');
$this->session->expects($this->never())
->method('getUser');
$this->notificationManager->expects($this->never())
->method('createNotification');
$this->notificationManager->expects($this->never())
->method('markProcessed');
$response = $this->notificationsController->view('42');
$this->assertInstanceOf('\OCP\AppFramework\Http\NotFoundResponse', $response);
}
public function testViewNoFile() {
$comment = $this->getMockBuilder('\OCP\Comments\IComment')->getMock();
$comment->expects($this->any())
->method('getObjectType')
->will($this->returnValue('files'));
$this->commentsManager->expects($this->any())
->method('get')
->with('42')
->will($this->returnValue($comment));
$this->folder->expects($this->once())
->method('getById')
->will($this->returnValue([]));
$this->session->expects($this->once())
->method('getUser')
->will($this->returnValue($this->getMockBuilder('\OCP\IUser')->getMock()));
$notification = $this->getMockBuilder('\OCP\Notification\INotification')->getMock();
$notification->expects($this->any())
->method($this->anything())
->will($this->returnValue($notification));
$this->notificationManager->expects($this->once())
->method('createNotification')
->will($this->returnValue($notification));
$this->notificationManager->expects($this->once())
->method('markProcessed')
->with($notification);
$response = $this->notificationsController->view('42');
$this->assertInstanceOf('\OCP\AppFramework\Http\NotFoundResponse', $response);
}
}