4971015544
This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following: ![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png) As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
316 lines
10 KiB
PHP
316 lines
10 KiB
PHP
<?php
|
|
/**
|
|
* @author Adam Williamson <awilliam@redhat.com>
|
|
* @author Bart Visscher <bartv@thisnet.nl>
|
|
* @author Bernhard Posselt <dev@bernhard-posselt.com>
|
|
* @author Christopher Schäpers <kondou@ts.unde.re>
|
|
* @author Clark Tomlinson <fallen013@gmail.com>
|
|
* @author Joas Schilling <nickvergessen@owncloud.com>
|
|
* @author Jörn Friedrich Dreyer <jfd@butonic.de>
|
|
* @author Lukas Reschke <lukas@owncloud.com>
|
|
* @author Michael Gapczynski <GapczynskiM@gmail.com>
|
|
* @author Morris Jobke <hey@morrisjobke.de>
|
|
* @author Remco Brenninkmeijer <requist1@starmail.nl>
|
|
* @author Robin Appelman <icewind@owncloud.com>
|
|
* @author Robin McCorkell <rmccorkell@karoshi.org.uk>
|
|
* @author Thomas Müller <thomas.mueller@tmit.eu>
|
|
* @author Victor Dubiniuk <dubiniuk@owncloud.com>
|
|
*
|
|
* @copyright Copyright (c) 2015, ownCloud, Inc.
|
|
* @license AGPL-3.0
|
|
*
|
|
* This code is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License, version 3,
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License, version 3,
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>
|
|
*
|
|
*/
|
|
use Assetic\Asset\AssetCollection;
|
|
use Assetic\Asset\FileAsset;
|
|
use Assetic\AssetWriter;
|
|
use Assetic\Filter\CssImportFilter;
|
|
use Assetic\Filter\CssMinFilter;
|
|
use Assetic\Filter\CssRewriteFilter;
|
|
use Assetic\Filter\JSqueezeFilter;
|
|
use Assetic\Filter\SeparatorFilter;
|
|
|
|
/**
|
|
* Copyright (c) 2012 Bart Visscher <bartv@thisnet.nl>
|
|
* This file is licensed under the Affero General Public License version 3 or
|
|
* later.
|
|
* See the COPYING-README file.
|
|
*/
|
|
|
|
class OC_TemplateLayout extends OC_Template {
|
|
|
|
private static $versionHash = '';
|
|
|
|
/**
|
|
* @var \OCP\IConfig
|
|
*/
|
|
private $config;
|
|
|
|
/**
|
|
* @param string $renderAs
|
|
* @param string $appId application id
|
|
*/
|
|
public function __construct( $renderAs, $appId = '' ) {
|
|
|
|
// yes - should be injected ....
|
|
$this->config = \OC::$server->getConfig();
|
|
|
|
// Decide which page we show
|
|
if($renderAs == 'user') {
|
|
parent::__construct( 'core', 'layout.user' );
|
|
if(in_array(OC_App::getCurrentApp(), ['settings','admin', 'help']) !== false) {
|
|
$this->assign('bodyid', 'body-settings');
|
|
}else{
|
|
$this->assign('bodyid', 'body-user');
|
|
}
|
|
|
|
// Update notification
|
|
if($this->config->getSystemValue('updatechecker', true) === true &&
|
|
OC_User::isAdminUser(OC_User::getUser())) {
|
|
$updater = new \OC\Updater(
|
|
\OC::$server->getHTTPHelper(),
|
|
\OC::$server->getConfig(),
|
|
\OC::$server->getIntegrityCodeChecker(),
|
|
\OC::$server->getLogger()
|
|
);
|
|
$data = $updater->check();
|
|
|
|
if(isset($data['version']) && $data['version'] != '' and $data['version'] !== Array()) {
|
|
$this->assign('updateAvailable', true);
|
|
$this->assign('updateVersion', $data['versionstring']);
|
|
if(substr($data['web'], 0, 8) === 'https://') {
|
|
$this->assign('updateLink', $data['web']);
|
|
}
|
|
\OCP\Util::addScript('core', 'update-notification');
|
|
} else {
|
|
$this->assign('updateAvailable', false); // No update available or not an admin user
|
|
}
|
|
} else {
|
|
$this->assign('updateAvailable', false); // Update check is disabled
|
|
}
|
|
|
|
// Code integrity notification
|
|
$integrityChecker = \OC::$server->getIntegrityCodeChecker();
|
|
if(!$integrityChecker->hasPassedCheck()) {
|
|
\OCP\Util::addScript('core', 'integritycheck-failed-notification');
|
|
}
|
|
|
|
// Add navigation entry
|
|
$this->assign( 'application', '');
|
|
$this->assign( 'appid', $appId );
|
|
$navigation = OC_App::getNavigation();
|
|
$this->assign( 'navigation', $navigation);
|
|
$settingsNavigation = OC_App::getSettingsNavigation();
|
|
$this->assign( 'settingsnavigation', $settingsNavigation);
|
|
foreach($navigation as $entry) {
|
|
if ($entry['active']) {
|
|
$this->assign( 'application', $entry['name'] );
|
|
break;
|
|
}
|
|
}
|
|
|
|
foreach($settingsNavigation as $entry) {
|
|
if ($entry['active']) {
|
|
$this->assign( 'application', $entry['name'] );
|
|
break;
|
|
}
|
|
}
|
|
$userDisplayName = OC_User::getDisplayName();
|
|
$appsMgmtActive = strpos(\OC::$server->getRequest()->getRequestUri(), \OC::$server->getURLGenerator()->linkToRoute('settings.AppSettings.viewApps')) === 0;
|
|
if ($appsMgmtActive) {
|
|
$l = \OC::$server->getL10N('lib');
|
|
$this->assign('application', $l->t('Apps'));
|
|
}
|
|
$this->assign('user_displayname', $userDisplayName);
|
|
$this->assign('user_uid', OC_User::getUser());
|
|
$this->assign('appsmanagement_active', $appsMgmtActive);
|
|
$this->assign('enableAvatars', $this->config->getSystemValue('enable_avatars', true));
|
|
$this->assign('userAvatarSet', \OC_Helper::userAvatarSet(OC_User::getUser()));
|
|
} else if ($renderAs == 'error') {
|
|
parent::__construct('core', 'layout.guest', '', false);
|
|
$this->assign('bodyid', 'body-login');
|
|
} else if ($renderAs == 'guest') {
|
|
parent::__construct('core', 'layout.guest');
|
|
$this->assign('bodyid', 'body-login');
|
|
} else {
|
|
parent::__construct('core', 'layout.base');
|
|
|
|
}
|
|
// Send the language to our layouts
|
|
$this->assign('language', OC_L10N::findLanguage());
|
|
|
|
|
|
if(empty(self::$versionHash)) {
|
|
$v = OC_App::getAppVersions();
|
|
$v['core'] = implode('.', \OC_Util::getVersion());
|
|
self::$versionHash = md5(implode(',', $v));
|
|
}
|
|
|
|
$useAssetPipeline = self::isAssetPipelineEnabled();
|
|
if ($useAssetPipeline) {
|
|
$this->append( 'jsfiles', OC_Helper::linkToRoute('js_config', array('v' => self::$versionHash)));
|
|
$this->generateAssets();
|
|
} else {
|
|
// Add the js files
|
|
$jsFiles = self::findJavascriptFiles(OC_Util::$scripts);
|
|
$this->assign('jsfiles', array());
|
|
if ($this->config->getSystemValue('installed', false) && $renderAs != 'error') {
|
|
$this->append( 'jsfiles', OC_Helper::linkToRoute('js_config', array('v' => self::$versionHash)));
|
|
}
|
|
foreach($jsFiles as $info) {
|
|
$web = $info[1];
|
|
$file = $info[2];
|
|
$this->append( 'jsfiles', $web.'/'.$file . '?v=' . self::$versionHash);
|
|
}
|
|
|
|
// Add the css files
|
|
$cssFiles = self::findStylesheetFiles(OC_Util::$styles);
|
|
$this->assign('cssfiles', array());
|
|
foreach($cssFiles as $info) {
|
|
$web = $info[1];
|
|
$file = $info[2];
|
|
|
|
$this->append( 'cssfiles', $web.'/'.$file . '?v=' . self::$versionHash);
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param array $styles
|
|
* @return array
|
|
*/
|
|
static public function findStylesheetFiles($styles) {
|
|
// Read the selected theme from the config file
|
|
$theme = OC_Util::getTheme();
|
|
|
|
$locator = new \OC\Template\CSSResourceLocator(
|
|
OC::$server->getLogger(),
|
|
$theme,
|
|
array( OC::$SERVERROOT => OC::$WEBROOT ),
|
|
array( OC::$THIRDPARTYROOT => OC::$THIRDPARTYWEBROOT ));
|
|
$locator->find($styles);
|
|
return $locator->getResources();
|
|
}
|
|
|
|
/**
|
|
* @param array $scripts
|
|
* @return array
|
|
*/
|
|
static public function findJavascriptFiles($scripts) {
|
|
// Read the selected theme from the config file
|
|
$theme = OC_Util::getTheme();
|
|
|
|
$locator = new \OC\Template\JSResourceLocator(
|
|
OC::$server->getLogger(),
|
|
$theme,
|
|
array( OC::$SERVERROOT => OC::$WEBROOT ),
|
|
array( OC::$THIRDPARTYROOT => OC::$THIRDPARTYWEBROOT ));
|
|
$locator->find($scripts);
|
|
return $locator->getResources();
|
|
}
|
|
|
|
public function generateAssets() {
|
|
$assetDir = \OC::$server->getConfig()->getSystemValue('assetdirectory', \OC::$SERVERROOT);
|
|
$jsFiles = self::findJavascriptFiles(OC_Util::$scripts);
|
|
$jsHash = self::hashFileNames($jsFiles);
|
|
|
|
if (!file_exists("$assetDir/assets/$jsHash.js")) {
|
|
$jsFiles = array_map(function ($item) {
|
|
$root = $item[0];
|
|
$file = $item[2];
|
|
// no need to minifiy minified files
|
|
if (substr($file, -strlen('.min.js')) === '.min.js') {
|
|
return new FileAsset($root . '/' . $file, array(
|
|
new SeparatorFilter(';')
|
|
), $root, $file);
|
|
}
|
|
return new FileAsset($root . '/' . $file, array(
|
|
new JSqueezeFilter(),
|
|
new SeparatorFilter(';')
|
|
), $root, $file);
|
|
}, $jsFiles);
|
|
$jsCollection = new AssetCollection($jsFiles);
|
|
$jsCollection->setTargetPath("assets/$jsHash.js");
|
|
|
|
$writer = new AssetWriter($assetDir);
|
|
$writer->writeAsset($jsCollection);
|
|
}
|
|
|
|
$cssFiles = self::findStylesheetFiles(OC_Util::$styles);
|
|
$cssHash = self::hashFileNames($cssFiles);
|
|
|
|
if (!file_exists("$assetDir/assets/$cssHash.css")) {
|
|
$cssFiles = array_map(function ($item) {
|
|
$root = $item[0];
|
|
$file = $item[2];
|
|
$assetPath = $root . '/' . $file;
|
|
$sourceRoot = \OC::$SERVERROOT;
|
|
$sourcePath = substr($assetPath, strlen(\OC::$SERVERROOT));
|
|
return new FileAsset(
|
|
$assetPath,
|
|
array(
|
|
new CssRewriteFilter(),
|
|
new CssMinFilter(),
|
|
new CssImportFilter()
|
|
),
|
|
$sourceRoot,
|
|
$sourcePath
|
|
);
|
|
}, $cssFiles);
|
|
$cssCollection = new AssetCollection($cssFiles);
|
|
$cssCollection->setTargetPath("assets/$cssHash.css");
|
|
|
|
$writer = new AssetWriter($assetDir);
|
|
$writer->writeAsset($cssCollection);
|
|
}
|
|
|
|
$this->append('jsfiles', OC_Helper::linkTo('assets', "$jsHash.js"));
|
|
$this->append('cssfiles', OC_Helper::linkTo('assets', "$cssHash.css"));
|
|
}
|
|
|
|
/**
|
|
* Converts the absolute file path to a relative path from \OC::$SERVERROOT
|
|
* @param string $filePath Absolute path
|
|
* @return string Relative path
|
|
* @throws Exception If $filePath is not under \OC::$SERVERROOT
|
|
*/
|
|
public static function convertToRelativePath($filePath) {
|
|
$relativePath = explode(\OC::$SERVERROOT, $filePath);
|
|
if(count($relativePath) !== 2) {
|
|
throw new \Exception('$filePath is not under the \OC::$SERVERROOT');
|
|
}
|
|
|
|
return $relativePath[1];
|
|
}
|
|
|
|
/**
|
|
* @param array $files
|
|
* @return string
|
|
*/
|
|
|
|
private static function hashFileNames($files) {
|
|
foreach($files as $i => $file) {
|
|
try {
|
|
$files[$i] = self::convertToRelativePath($file[0]).'/'.$file[2];
|
|
} catch (\Exception $e) {
|
|
$files[$i] = $file[0].'/'.$file[2];
|
|
}
|
|
}
|
|
|
|
sort($files);
|
|
// include the apps' versions hash to invalidate the cached assets
|
|
$files[] = self::$versionHash;
|
|
return hash('md5', implode('', $files));
|
|
}
|
|
}
|