From eb29dffbc1924e6e5034e51231f0572f776cafad Mon Sep 17 00:00:00 2001 From: William Brawner Date: Wed, 4 Sep 2024 20:00:05 -0600 Subject: [PATCH 1/4] Remove arbitrary delay when creating PDF --- app/src/main/java/com/wbrawner/skerge/MainActivity.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/app/src/main/java/com/wbrawner/skerge/MainActivity.kt b/app/src/main/java/com/wbrawner/skerge/MainActivity.kt index 33c2d35..c344708 100644 --- a/app/src/main/java/com/wbrawner/skerge/MainActivity.kt +++ b/app/src/main/java/com/wbrawner/skerge/MainActivity.kt @@ -90,7 +90,6 @@ class MainActivity : ComponentActivity() { addButtonClicked = viewModel::requestScan, shareButtonClicked = { pdfShareJob = coroutineScope.launch { - delay(10_000) val file = if (pages.size == 1) { pages.first().file ?: return@launch } else { -- 2.45.2 From d14b747ff114da03f0be352169bf8c07f992669e Mon Sep 17 00:00:00 2001 From: William Brawner Date: Wed, 4 Sep 2024 20:00:45 -0600 Subject: [PATCH 2/4] Explicitly set mime type when sharing PDFs --- app/src/main/java/com/wbrawner/skerge/PdfUtils.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/wbrawner/skerge/PdfUtils.kt b/app/src/main/java/com/wbrawner/skerge/PdfUtils.kt index 51f1568..a6a456d 100644 --- a/app/src/main/java/com/wbrawner/skerge/PdfUtils.kt +++ b/app/src/main/java/com/wbrawner/skerge/PdfUtils.kt @@ -41,7 +41,7 @@ fun File.buildShareIntent(context: Context): Intent = "com.wbrawner.skerge.pdfprovider", this@buildShareIntent ) - data = uri + setDataAndTypeAndNormalize(uri, "application/pdf") putExtra(Intent.EXTRA_STREAM, uri) addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) }, name) -- 2.45.2 From 4e0c8ffc00bb5fa5193147b5fc85408781a85103 Mon Sep 17 00:00:00 2001 From: William Brawner Date: Wed, 4 Sep 2024 20:11:36 -0600 Subject: [PATCH 3/4] Bump version for release --- app/build.gradle.kts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index 3c2605d..c33f109 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -12,8 +12,8 @@ android { applicationId = "com.wbrawner.skerge" minSdk = libs.versions.minSdk.get().toInt() targetSdk = libs.versions.maxSdk.get().toInt() - versionCode = 1 - versionName = "1.0" + versionCode = 2 + versionName = "1.1" testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner" vectorDrawables { -- 2.45.2 From 0206e47434997bbc93eb97786aa00a0bd77ab707 Mon Sep 17 00:00:00 2001 From: William Brawner Date: Tue, 1 Oct 2024 21:25:44 -0600 Subject: [PATCH 4/4] Ignore lint checks for dependency version updates Renovate bot is handling this now, no need to fail builds for it --- app/build.gradle.kts | 1 + 1 file changed, 1 insertion(+) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index c33f109..9466ea5 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -45,6 +45,7 @@ android { compose = true } lint { + disable += listOf("AndroidGradlePluginVersion", "GradleDependency") warningsAsErrors = true } } -- 2.45.2