Use makefile from calendar app, adjust npm and update gruntfile

This commit is contained in:
Raimund Schlüßler 2017-01-15 23:26:04 +01:00
parent b10d89bb57
commit 0544c1616d
3 changed files with 244 additions and 179 deletions

366
Makefile
View file

@ -1,146 +1,232 @@
# Makefile for building the project # This file is licensed under the Affero General Public License version 3 or
# later. See the COPYING file.
# @author Bernhard Posselt <dev@bernhard-posselt.com>
# @copyright Bernhard Posselt 2017
# @author Georg Ehrke <oc.list@georgehrke.com>
# @copyright Georg Ehrke 2017
# @author Raimund Schlüßler
# @copyright 2017 Raimund Schlüßler <raimund.schluessler@googlemail.com>
app_name=tasks # Generic Makefile for building and packaging a Nextcloud app which uses npm and
project_dir=$(CURDIR)/../$(app_name) # Composer.
build_dir=$(CURDIR)/build #
appstore_dir=$(build_dir)/appstore # Dependencies:
signed_dir=$(build_dir)/appstore_signed # * make
package_name=$(app_name) # * which
# * curl: used if phpunit and composer are not installed to fetch them from the web
# * tar: for building the archive
# * npm: for building and testing everything JS
#
# If no composer.json is in the app root directory, the Composer step
# will be skipped. The same goes for the package.json which can be located in
# the app root or the js/ directory.
#
# The npm command by launches the npm build script:
#
# npm run build
#
# The npm test command launches the npm test script:
#
# npm run test
#
# The idea behind this is to be completely testing and build tool agnostic. All
# build tools and additional package managers should be installed locally in
# your project, since this won't pollute people's global namespace.
#
# The following npm scripts in your package.json install and update the bower
# and npm dependencies and use gulp as build system (notice how everything is
# run from the node_modules folder):
#
# "scripts": {
# "test": "node node_modules/gulp-cli/bin/gulp.js karma",
# "prebuild": "npm install && node_modules/bower/bin/bower install && node_modules/bower/bin/bower update",
# "build": "node node_modules/gulp-cli/bin/gulp.js"
# },
app_name=$(notdir $(CURDIR))
build_tools_directory=$(CURDIR)/build/tools
source_build_directory=$(CURDIR)/build/source/tasks
source_artifact_directory=$(CURDIR)/build/artifacts/source
source_package_name=$(source_artifact_directory)/$(app_name)
appstore_build_directory=$(CURDIR)/build/appstore/tasks
appstore_artifact_directory=$(CURDIR)/build/artifacts/appstore
appstore_package_name=$(appstore_artifact_directory)/$(app_name)
npm=$(shell which npm 2> /dev/null)
gcp=$(shell which gcp 2> /dev/null)
ifeq (, $(gcp))
copy_command=cp
else
copy_command=gcp
endif
# code signing
# assumes the following:
# * the app is inside the nextcloud/apps folder
# * the private key is located in ~/.nextcloud/tasks.key
# * the certificate is located in ~/.nextcloud/tasks.crt
occ=$(CURDIR)/../../occ
configdir=$(CURDIR)/../../config
private_key=$(HOME)/.nextcloud/$(app_name).key
certificate=$(HOME)/.nextcloud/$(app_name).crt
sign=php -f $(occ) integrity:sign-app --privateKey="$(private_key)" --certificate="$(certificate)"
sign_skip_msg="Skipping signing, either no key and certificate found in $(private_key) and $(certificate) or occ can not be found at $(occ)"
ifneq (,$(wildcard $(private_key)))
ifneq (,$(wildcard $(certificate)))
ifneq (,$(wildcard $(occ)))
CAN_SIGN=true
endif
endif
endif
all: build
# Fetches the PHP and JS dependencies and compiles the JS. If no composer.json
# is present, the composer step is skipped, if no package.json or js/package.json
# is present, the npm step is skipped
.PHONY: build
build:
make npm
# Installs npm dependencies
.PHONY: npm
npm:
cd js && $(npm) run build
# Removes the appstore build
.PHONY: clean
clean: clean:
rm -rf $(appstore_dir) rm -rf ./build
rm -rf $(signed_dir)
sign: # Same as clean but also removes dependencies installed by composer, bower and
rm -rf $(signed_dir) # npm
mkdir -p $(signed_dir) .PHONY: distclean
rsync -av \ distclean: clean
$(project_dir) $(signed_dir) \ rm -rf vendor
--exclude=$(app_name)/tests \ rm -rf node_modules
--exclude=$(app_name)/.git \ rm -rf js/vendor
--exclude=$(app_name)/.idea \ rm -rf js/node_modules
--exclude=$(app_name)/.editorconfig \
--exclude=$(app_name)/.gitattributes \ # Builds the source and appstore package
--exclude=$(app_name)/.gitignore \ .PHONY: dist
--exclude=$(app_name)/.scrutinizer.yml \ dist:
--exclude=$(app_name)/.travis.yml \ make source
--exclude=$(app_name)/build.xml \ make appstore
--exclude=$(app_name)/CONTRIBUTING.md \
--exclude=$(app_name)/tasks.sublime-project \ # Builds the source package
--exclude=$(app_name)/tasks.sublime-workspace \ .PHONY: source
--exclude=$(app_name)/issue_template.md \ source:
--exclude=$(app_name)/Makefile \ rm -rf $(source_build_directory) $(source_artifact_directory)
--exclude=$(app_name)/phpunit.xml \ mkdir -p $(source_build_directory) $(source_artifact_directory)
--exclude=$(app_name)/README.md \ rsync -rv . $(source_build_directory) \
--exclude=$(app_name)/build \ --exclude=/.git/ \
--exclude=$(app_name)/img/source \ --exclude=/.idea/ \
--exclude=$(app_name)/js/.bowerrc \ --exclude=/build/ \
--exclude=$(app_name)/js/README.md \ --exclude=/js/node_modules/ \
--exclude=$(app_name)/js/.jshintrc \ --exclude=*.log
--exclude=$(app_name)/js/bower.json \ ifdef CAN_SIGN
--exclude=$(app_name)/js/Gruntfile.js \ $(sign) --path "$(source_build_directory)"
--exclude=$(app_name)/js/package.json \ else
--exclude=$(app_name)/js/README.mkdir \ @echo $(sign_skip_msg)
--exclude=$(app_name)/js/app \ endif
--exclude=$(app_name)/js/config \ tar -cvzf $(source_package_name).tar.gz -C $(source_build_directory)/../ $(app_name)
--exclude=$(app_name)/js/node_modules \
--exclude=$(app_name)/js/vendor/**/.bower.json \ # Builds the source package for the app store, ignores php and js tests
--exclude=$(app_name)/js/vendor/**/.npmignore \ .PHONY: appstore
--exclude=$(app_name)/js/vendor/**/bower.json \ appstore:
--exclude=$(app_name)/js/vendor/**/Gruntfile.js \ rm -rf $(appstore_build_directory) $(appstore_artifact_directory)
--exclude=$(app_name)/js/vendor/**/package.json \ mkdir -p $(appstore_build_directory) $(appstore_artifact_directory)
--exclude=$(app_name)/js/vendor/**/*.md \ rsync -av . $(appstore_build_directory) \
--exclude=$(app_name)/js/vendor/**/karma.conf.js \ --exclude=/tests \
--exclude=$(app_name)/js/vendor/**/*.map \ --exclude=/.git \
--exclude=$(app_name)/js/vendor/angular-mocks \ --exclude=/.idea \
--exclude=$(app_name)/js/vendor/angular/angular.js \ --exclude=/.editorconfig \
--exclude=$(app_name)/js/vendor/angular-animate/angular-animate.js \ --exclude=/.gitattributes \
--exclude=$(app_name)/js/vendor/angular-draganddrop/angular-drag-and-drop-lists.js \ --exclude=/.gitignore \
--exclude=$(app_name)/js/vendor/angular-route/angular-route.js \ --exclude=/.scrutinizer.yml \
--exclude=$(app_name)/js/vendor/angular-sanitize/angular-sanitize.js \ --exclude=/.travis.yml \
--exclude=$(app_name)/js/vendor/angular-ui-select/dist/select.js \ --exclude=/build.xml \
--exclude=$(app_name)/js/vendor/angular-ui-select/dist/select.css \ --exclude=/CONTRIBUTING.md \
--exclude=$(app_name)/js/vendor/angular-ui-select/docs \ --exclude=/tasks.sublime-project \
--exclude=$(app_name)/js/vendor/angular-ui-select/composer.json \ --exclude=/tasks.sublime-workspace \
--exclude=$(app_name)/js/vendor/angular-ui-select/deploy-docs.sh \ --exclude=/issue_template.md \
--exclude=$(app_name)/js/vendor/jstzdetect/jstz.js \ --exclude=/Makefile \
--exclude=$(app_name)/js/vendor/davclient.js/index.html \ --exclude=/phpunit.xml \
--exclude=$(app_name)/js/vendor/ical.js/build/benchmark \ --exclude=/README.md \
--exclude=$(app_name)/js/vendor/ical.js/lib \ --exclude=/build \
--exclude=$(app_name)/js/vendor/ical.js/samples \ --exclude=/img/source \
--exclude=$(app_name)/js/vendor/ical.js/sandbox \ --exclude=/js/.bowerrc \
--exclude=$(app_name)/js/vendor/ical.js/tasks \ --exclude=/js/README.md \
--exclude=$(app_name)/js/vendor/ical.js/test-agent \ --exclude=/js/.jshintrc \
--exclude=$(app_name)/js/vendor/ical.js/test-agent-server.js \ --exclude=/js/bower.json \
--exclude=$(app_name)/js/vendor/ical.js/test-agent-coverage.json \ --exclude=/js/Gruntfile.js \
--exclude=$(app_name)/js/vendor/jquery-timepicker/i18n \ --exclude=/js/package.json \
--exclude=$(app_name)/js/vendor/jquery-timepicker/include \ --exclude=/js/README.mkdir \
--exclude=$(app_name)/js/vendor/jquery-timepicker/legacy_1.2.6 \ --exclude=/js/app \
--exclude=$(app_name)/js/vendor/jquery-timepicker/tests \ --exclude=/js/config \
--exclude=$(app_name)/js/vendor/jquery-timepicker/index.html \ --exclude=/js/node_modules \
--exclude=$(app_name)/screenshots \ --exclude=/js/vendor/**/.bower.json \
--exclude=$(app_name)/timezones/INFO.md --exclude=/js/vendor/**/.npmignore \
chown -R www-data $(signed_dir) --exclude=/js/vendor/**/bower.json \
sudo -u www-data php ../../occ integrity:sign-app --privateKey=$(build_dir)/app-signing/tasks.key --certificate=$(build_dir)/app-signing/tasks.crt --path=$(signed_dir)/$(app_name) --exclude=/js/vendor/**/Gruntfile.js \
cd $(signed_dir); \ --exclude=/js/vendor/**/package.json \
zip -r $(signed_dir)/$(app_name).zip $(app_name) --exclude=/js/vendor/**/*.md \
cd $(signed_dir); \ --exclude=/js/vendor/**/karma.conf.js \
tar cvzf $(signed_dir)/$(app_name).tar.gz $(app_name) --exclude=/js/vendor/**/*.map \
rm -rf $(signed_dir)/$(app_name) --exclude=/js/vendor/angular-mocks \
openssl dgst -sha512 -sign $(build_dir)/app-signing/tasks.key $(signed_dir)/$(app_name).tar.gz | openssl base64 -out $(signed_dir)/$(app_name).sha512 --exclude=/js/vendor/angular/angular.js \
--exclude=/js/vendor/angular-animate/angular-animate.js \
--exclude=/js/vendor/angular-draganddrop/angular-drag-and-drop-lists.js \
--exclude=/js/vendor/angular-route/angular-route.js \
--exclude=/js/vendor/angular-sanitize/angular-sanitize.js \
--exclude=/js/vendor/angular-ui-select/dist/select.js \
--exclude=/js/vendor/angular-ui-select/dist/select.css \
--exclude=/js/vendor/angular-ui-select/docs \
--exclude=/js/vendor/angular-ui-select/composer.json \
--exclude=/js/vendor/angular-ui-select/deploy-docs.sh \
--exclude=/js/vendor/jstzdetect/jstz.js \
--exclude=/js/vendor/davclient.js/index.html \
--exclude=/js/vendor/ical.js/build/benchmark \
--exclude=/js/vendor/ical.js/lib \
--exclude=/js/vendor/ical.js/samples \
--exclude=/js/vendor/ical.js/sandbox \
--exclude=/js/vendor/ical.js/tasks \
--exclude=/js/vendor/ical.js/test-agent \
--exclude=/js/vendor/ical.js/test-agent-server.js \
--exclude=/js/vendor/ical.js/test-agent-coverage.json \
--exclude=/js/vendor/jquery-timepicker/i18n \
--exclude=/js/vendor/jquery-timepicker/include \
--exclude=/js/vendor/jquery-timepicker/legacy_1.2.6 \
--exclude=/js/vendor/jquery-timepicker/tests \
--exclude=/js/vendor/jquery-timepicker/index.html \
--exclude=/screenshots \
--exclude=/timezones/INFO.md
ifdef CAN_SIGN
mv $(configdir)/config.php $(configdir)/config-2.php
$(sign) --path="$(appstore_build_directory)"
mv $(configdir)/config-2.php $(configdir)/config.php
else
@echo $(sign_skip_msg)
endif
cd $(appstore_build_directory)/../; \
zip -r $(appstore_package_name).zip $(app_name)
tar -czf $(appstore_package_name).tar.gz -C $(appstore_build_directory)/../ $(app_name)
openssl dgst -sha512 -sign $(private_key) $(appstore_package_name).tar.gz | openssl base64 -out $(appstore_artifact_directory)/$(app_name).sha512
appstore: clean # Command for running JS and PHP tests. Works for package.json files in the js/
mkdir -p $(appstore_dir) # and root directory. If phpunit is not installed systemwide, a copy is fetched
tar cvzf $(appstore_dir)/$(package_name).tar.gz $(project_dir) \ # from the internet
--exclude-vcs \ .PHONY: test
--exclude=$(project_dir)/tests \ test:
--exclude=$(project_dir)/.idea \ cd js && $(npm) run test
--exclude=$(project_dir)/.editorconfig \ ifeq (, $(shell which phpunit 2> /dev/null))
--exclude=$(project_dir)/.gitattributes \ @echo "No phpunit command available, downloading a copy from the web"
--exclude=$(project_dir)/.gitignore \ mkdir -p $(build_tools_directory)
--exclude=$(project_dir)/.scrutinizer.yml \ curl -sSL https://phar.phpunit.de/phpunit.phar -o $(build_tools_directory)/phpunit.phar
--exclude=$(project_dir)/.travis.yml \ php $(build_tools_directory)/phpunit.phar -c phpunit.xml --coverage-clover build/php-unit.clover
--exclude=$(project_dir)/build.xml \ php $(build_tools_directory)/phpunit.phar -c phpunit.integration.xml --coverage-clover build/php-integration.clover
--exclude=$(project_dir)/CONTRIBUTING.md \ else
--exclude=$(project_dir)/tasks.sublime-project \ phpunit -c phpunit.xml --coverage-clover build/php-unit.clover
--exclude=$(project_dir)/tasks.sublime-workspace \ phpunit -c phpunit.integration.xml --coverage-clover build/php-unit.clover
--exclude=$(project_dir)/issue_template.md \ endif
--exclude=$(project_dir)/Makefile \
--exclude=$(project_dir)/phpunit.xml \
--exclude=$(project_dir)/README.md \
--exclude=$(project_dir)/build \
--exclude=$(project_dir)/img/source \
--exclude=$(project_dir)/js/.bowerrc \
--exclude=$(project_dir)/js/README.md \
--exclude=$(project_dir)/js/.jshintrc \
--exclude=$(project_dir)/js/bower.json \
--exclude=$(project_dir)/js/Gruntfile.js \
--exclude=$(project_dir)/js/package.json \
--exclude=$(project_dir)/js/README.mkdir \
--exclude=$(project_dir)/js/app \
--exclude=$(project_dir)/js/config \
--exclude=$(project_dir)/js/node_modules \
--exclude=$(project_dir)/js/vendor/**/.bower.json \
--exclude=$(project_dir)/js/vendor/**/.npmignore \
--exclude=$(project_dir)/js/vendor/**/bower.json \
--exclude=$(project_dir)/js/vendor/**/Gruntfile.js \
--exclude=$(project_dir)/js/vendor/**/package.json \
--exclude=$(project_dir)/js/vendor/**/*.md \
--exclude=$(project_dir)/js/vendor/**/karma.conf.js \
--exclude=$(project_dir)/js/vendor/angular-mocks \
--exclude=$(project_dir)/js/vendor/davclient.js/index.html \
--exclude=$(project_dir)/js/vendor/ical.js/build/benchmark \
--exclude=$(project_dir)/js/vendor/ical.js/lib \
--exclude=$(project_dir)/js/vendor/ical.js/samples \
--exclude=$(project_dir)/js/vendor/ical.js/sandbox \
--exclude=$(project_dir)/js/vendor/ical.js/tasks \
--exclude=$(project_dir)/js/vendor/ical.js/test-agent \
--exclude=$(project_dir)/js/vendor/ical.js/test-agent-server.js \
--exclude=$(project_dir)/js/vendor/ical.js/test-agent-coverage.json \
--exclude=$(project_dir)/js/vendor/jquery-timepicker/i18n \
--exclude=$(project_dir)/js/vendor/jquery-timepicker/include \
--exclude=$(project_dir)/js/vendor/jquery-timepicker/legacy_1.2.6 \
--exclude=$(project_dir)/js/vendor/jquery-timepicker/tests \
--exclude=$(project_dir)/js/vendor/jquery-timepicker/index.html \
--exclude=$(project_dir)/timezones/INFO.md \

View file

@ -26,10 +26,7 @@ module.exports = function(grunt) {
grunt.loadNpmTasks('grunt-contrib-watch'); grunt.loadNpmTasks('grunt-contrib-watch');
grunt.loadNpmTasks('grunt-contrib-jshint'); grunt.loadNpmTasks('grunt-contrib-jshint');
grunt.loadNpmTasks('grunt-wrap'); grunt.loadNpmTasks('grunt-wrap');
grunt.loadNpmTasks('grunt-phpunit');
grunt.loadNpmTasks('grunt-karma'); grunt.loadNpmTasks('grunt-karma');
// grunt.loadNpmTasks('grunt-newer');
grunt.loadNpmTasks('grunt-phpdocumentor');
grunt.initConfig({ grunt.initConfig({
meta: { meta: {
@ -89,35 +86,15 @@ module.exports = function(grunt) {
continuous: { continuous: {
configFile: 'config/karma.js', configFile: 'config/karma.js',
singleRun: true, singleRun: true,
browsers: ['PhantomJS'],
reporters: ['progress', 'junit'], reporters: ['progress', 'junit'],
junitReporter: { junitReporter: {
outputFile: 'test-results.xml' outputFile: 'test-results.xml'
} }
},
unit_phantom: {
configFile: 'config/karma.js',
browsers: ['PhantomJS']
}
},
phpunit: {
classes: {
dir: '../tests'
},
options: {
colors: true
}
},
phpdocumentor: {
"default": {
options: {
directory: '../appinfo,../db,../controllers,../service',
target: '../docs'
}
} }
} }
}); });
grunt.registerTask('ci', ['karma:continuous']); grunt.registerTask('ci', ['karma:continuous']);
grunt.registerTask('js', ['concat', 'wrap']); grunt.registerTask('js', ['concat', 'wrap']);
grunt.registerTask('default', 'js'); grunt.registerTask('default', 'js');
grunt.registerTask('build', ['concat', 'wrap']);
}; };

View file

@ -8,6 +8,11 @@
}, },
"private": true, "private": true,
"homepage": "", "homepage": "",
"scripts": {
"test": "node node_modules/grunt-cli/bin/grunt karma",
"prebuild": "npm install && npm update && node_modules/bower/bin/bower install && node_modules/bower/bin/bower update",
"build": "node node_modules/grunt-cli/bin/grunt build"
},
"repository": { "repository": {
"type": "git", "type": "git",
"url": "git@github.com:nextcloud/tasks.git" "url": "git@github.com:nextcloud/tasks.git"
@ -17,20 +22,17 @@
"dependencies": {}, "dependencies": {},
"devDependencies": { "devDependencies": {
"bower": "*", "bower": "*",
"grunt": "~0.4.1", "grunt": "^1.0.1",
"grunt-cli": "~0.1.6", "grunt-cli": "^1.2.0",
"grunt-contrib-jshint": "*", "grunt-contrib-jshint": "^1.0.0",
"jshint-stylish": "^2.1.0", "jshint-stylish": "^2.2.1",
"grunt-concurrent": "~1.0.0", "grunt-concurrent": "^2.3.1",
"grunt-contrib-concat": "~0.1.2", "grunt-contrib-concat": "^1.0.1",
"grunt-contrib-less": "~0.6.4", "grunt-contrib-watch": "^1.0.0",
"grunt-contrib-watch": "~0.2.0", "grunt-karma": "^2.0.0",
"grunt-karma": "~0.4.5", "grunt-wrap": "^0.3.0"
"grunt-newer": "~1.1.1",
"grunt-phpdocumentor": "^0.4.1",
"grunt-phpunit": "0.2.0",
"grunt-wrap": "~0.2.0",
"phantomjs": "~1.8.1-3"
}, },
"engine": "node >= 0.8" "engines": {
"node": ">=6"
}
} }