From b1393b7e32b39bea115b835fad97efb9c00646a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Raimund=20Schl=C3=BC=C3=9Fler?=
 <raimund.schluessler@mailbox.org>
Date: Sun, 21 Jul 2019 22:11:41 +0200
Subject: [PATCH] =?UTF-8?q?Prevent=20editing=20read-only=20tasks=20in=20li?=
 =?UTF-8?q?st=20view=20Signed-off-by:=20Raimund=20Schl=C3=BC=C3=9Fler=20<r?=
 =?UTF-8?q?aimund.schluessler@mailbox.org>?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 css/src/style.scss      | 4 ++++
 src/components/Task.vue | 4 ++--
 src/store/tasks.js      | 8 ++++++++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/css/src/style.scss b/css/src/style.scss
index 56af9bda..5f02d540 100644
--- a/css/src/style.scss
+++ b/css/src/style.scss
@@ -1153,6 +1153,10 @@
 		}
 	}
 
+	&.disabled {
+		cursor: not-allowed;
+	}
+
 	&.active {
 		opacity: .7;
 	}
diff --git a/src/components/Task.vue b/src/components/Task.vue
index a58e97d0..d083972e 100644
--- a/src/components/Task.vue
+++ b/src/components/Task.vue
@@ -47,11 +47,11 @@ License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 				role="checkbox"
 				@click="toggleCompleted(task)"
 			>
-				<span :class="{'icon-checkmark': task.completed}" class="icon icon-bw task-checkbox reactive no-nav" />
+				<span :class="{'icon-checkmark': task.completed, 'disabled': task.calendar.readOnly}" class="icon icon-bw task-checkbox reactive no-nav" />
 			</span>
 			<span class="icon task-separator" />
 			<span class="task-star" @click="toggleStarred(task)">
-				<span :class="[iconStar]" class="icon right large reactive no-nav" />
+				<span :class="[iconStar, {'disabled': task.calendar.readOnly}]" class="icon right large reactive no-nav" />
 			</span>
 			<span v-if="!task.calendar.readOnly"
 				class="task-addsubtask add-subtask"
diff --git a/src/store/tasks.js b/src/store/tasks.js
index 63ec15e4..8ff7a226 100644
--- a/src/store/tasks.js
+++ b/src/store/tasks.js
@@ -727,6 +727,10 @@ const actions = {
 	 * @param {Task} task The task to update
 	 */
 	async toggleCompleted(context, task) {
+		// Don't try to edit tasks in read-only calendars
+		if (task.calendar.readOnly) {
+			return
+		}
 		if (task.completed) {
 			await context.dispatch('setPercentComplete', { task: task, complete: 0 })
 		} else {
@@ -788,6 +792,10 @@ const actions = {
 	 * @param {Task} task The task to update
 	 */
 	async toggleStarred(context, task) {
+		// Don't try to edit tasks in read-only calendars
+		if (task.calendar.readOnly) {
+			return
+		}
 		context.commit('toggleStarred', task)
 		context.dispatch('scheduleTaskUpdate', task)
 	},