wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove now unused BackendFolder.getLastUid()

Browse source
This commit is contained in:
cketti 2022-01-05 02:19:45 +01:00
parent 2331626170
commit 17e69419b8
8 changed files with 0 additions and 67 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/core/src/main/java/com/fsck/k9/mailstore/K9BackendFolder.kt
View file

@ -35,10 +35,6 @@ class K9BackendFolder(
visibleLimit = init.visibleLimit
}
override fun getLastUid(): Long? {
return messageStore.getLastUid(folderId)
}
override fun getMessageServerIds(): Set<String> {
return messageStore.getMessageServerIds(folderId)
}

5
app/core/src/main/java/com/fsck/k9/mailstore/MessageStore.kt
View file

@ -130,11 +130,6 @@ interface MessageStore {
*/
fun getHeaders(folderId: Long, messageServerId: String): List<Header>
/**
* Get highest UID (message server ID)
*/
fun getLastUid(folderId: Long): Long?
/**
* Return the size of this message store in bytes.
*/

10
app/core/src/test/java/com/fsck/k9/mailstore/K9BackendFolderTest.kt
View file

@ -78,16 +78,6 @@ class K9BackendFolderTest : K9RobolectricTest() {
assertEquals(flags, messageFlags)
}
@Test
fun getLastUid() {
createMessageInBackendFolder("200")
createMessageInBackendFolder("123")
val lastUid = backendFolder.getLastUid()
assertEquals(200L, lastUid)
}
@Test
fun saveCompleteMessage_withoutServerId_shouldThrow() {
val message = createMessage(messageServerId = null)

4
app/storage/src/main/java/com/fsck/k9/storage/messages/K9MessageStore.kt
View file

@ -108,10 +108,6 @@ class K9MessageStore(
return retrieveMessageOperations.getHeaders(folderId, messageServerId)
}
override fun getLastUid(folderId: Long): Long? {
return retrieveMessageOperations.getLastUid(folderId)
}
override fun destroyMessages(folderId: Long, messageServerIds: Collection<String>) {
deleteMessageOperations.destroyMessages(folderId, messageServerIds)
}

15
app/storage/src/main/java/com/fsck/k9/storage/messages/RetrieveMessageOperations.kt
View file

@ -189,19 +189,4 @@ internal class RetrieveMessageOperations(private val lockableDatabase: LockableD
}
}
}
fun getLastUid(folderId: Long): Long? {
return lockableDatabase.execute(false) { database ->
database.rawQuery(
"SELECT MAX(uid) FROM messages WHERE folder_id = ?",
arrayOf(folderId.toString())
).use { cursor ->
if (cursor.moveToFirst()) {
cursor.getLongOrNull(0)
} else {
null
}
}
}
}
}

21
app/storage/src/test/java/com/fsck/k9/storage/messages/RetrieveMessageOperationsTest.kt
View file

@ -169,27 +169,6 @@ class RetrieveMessageOperationsTest : RobolectricTest() {
)
}
@Test
fun `get highest message uid`() {
val folderId = sqliteDatabase.createFolder()
sqliteDatabase.createMessage(uid = "42", folderId = folderId)
sqliteDatabase.createMessage(uid = "23", folderId = folderId)
sqliteDatabase.createMessage(uid = "27", folderId = folderId)
val highestUid = retrieveMessageOperations.getLastUid(folderId)
assertThat(highestUid).isEqualTo(42)
}
@Test
fun `get highest message uid should return null if there are no messages`() {
val folderId = sqliteDatabase.createFolder()
val highestUid = retrieveMessageOperations.getLastUid(folderId)
assertThat(highestUid).isNull()
}
@Test
fun `get oldest message date`() {
sqliteDatabase.createMessage(folderId = 1, date = 42)

1
backend/api/src/main/java/com/fsck/k9/backend/api/BackendFolder.kt
View file

@ -14,7 +14,6 @@ interface BackendFolder {
fun getAllMessagesAndEffectiveDates(): Map<String, Long?>
fun destroyMessages(messageServerIds: List<String>)
fun clearAllMessages()
fun getLastUid(): Long?
fun getMoreMessages(): MoreMessages
fun setMoreMessages(moreMessages: MoreMessages)
fun setLastChecked(timestamp: Long)

7
backend/testing/src/main/java/app/k9mail/backend/testing/InMemoryBackendFolder.kt
View file

@ -82,13 +82,6 @@ class InMemoryBackendFolder(override var name: String, var type: FolderType) : B
destroyMessages(messages.keys.toList())
}
override fun getLastUid(): Long? {
// This is using string ordering because that's what K9BackendFolder is using, too.
return messages.keys
.maxOrNull()
?.toLongOrNull()
}
override fun getMoreMessages(): MoreMessages = moreMessages
override fun setMoreMessages(moreMessages: MoreMessages) {