Don't hold 'connections' monitor while checking retrieved connection

k9mail-library/src/main/java/com/fsck/k9/mail/store/imap/ImapStore.java

@@ -308,22 +308,26 @@ public class ImapStore extends RemoteStore {
     }
 
     ImapConnection getConnection() throws MessagingException {
+        ImapConnection connection;
+        while ((connection = pollConnection()) != null) {
+            try {
+                connection.executeSimpleCommand(Commands.NOOP);
+                break;
+            } catch (IOException ioe) {
+                connection.close();
+            }
+        }
+
+        if (connection == null) {
+            connection = createImapConnection();
+        }
+
+        return connection;
+    }
+
+    private ImapConnection pollConnection() {
         synchronized (connections) {
-            ImapConnection connection;
+            return connections.poll();
-            while ((connection = connections.poll()) != null) {
-                try {
-                    connection.executeSimpleCommand(Commands.NOOP);
-                    break;
-                } catch (IOException ioe) {
-                    connection.close();
-                }
-            }
-
-            if (connection == null) {
-                connection = createImapConnection();
-            }
-
-            return connection;
         }
     }