From 22e8f4cedb71dbd85b40bdf5ceb665ec549d9262 Mon Sep 17 00:00:00 2001 From: Vincent Breitmoser Date: Fri, 7 Oct 2016 18:43:32 +0200 Subject: [PATCH] don't cache decoded message over configurations Since 773600c717f8bf79810b1a3ddd03e3c153a68fcb, the message decoding process might actually depend on theming parameters. The MessageList activity assumes that the theme will be reapplied during a call to `recreate()`, so we better drop that cache on configuration changes. --- .../src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java b/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java index c6be46a1d..d29b79181 100644 --- a/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java +++ b/k9mail/src/main/java/com/fsck/k9/activity/MessageLoaderHelper.java @@ -146,6 +146,8 @@ public class MessageLoaderHelper { * asyncStartOrResumeLoadingMessage in a new instance of this class. */ @UiThread public void onDestroyChangingConfigurations() { + cancelAndClearDecodeLoader(); + if (messageCryptoHelper != null) { messageCryptoHelper.detachCallback(); }