Remove FindBugs

It's not maintained anymore and we're not currently using it.
2019-11-13 16:41:51 +01:00 · 2019-11-13 16:41:51 +01:00 · 56a37d9e14
commit 56a37d9e14
parent 5fb94a1e14
19 changed files with 0 additions and 67 deletions
--- a/app/autodiscovery/build.gradle
+++ b/app/autodiscovery/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}"
--- a/app/core/build.gradle
+++ b/app/core/build.gradle
@ -3,7 +3,6 @@ apply plugin: 'org.jetbrains.kotlin.android'
 apply plugin: 'org.jetbrains.kotlin.android.extensions'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}"
--- a/app/crypto-openpgp/build.gradle
+++ b/app/crypto-openpgp/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}"
--- a/app/k9mail/build.gradle
+++ b/app/k9mail/build.gradle
@ -3,7 +3,6 @@ apply plugin: 'org.jetbrains.kotlin.android'
 apply plugin: 'org.jetbrains.kotlin.android.extensions'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/app/storage/build.gradle
+++ b/app/storage/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}"
--- a/app/ui/build.gradle
+++ b/app/ui/build.gradle
@ -3,7 +3,6 @@ apply plugin: 'org.jetbrains.kotlin.android'
 apply plugin: 'org.jetbrains.kotlin.android.extensions'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}"
--- a/backend/api/build.gradle
+++ b/backend/api/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    api project(":mail:common")
--- a/backend/imap/build.gradle
+++ b/backend/imap/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/backend/pop3/build.gradle
+++ b/backend/pop3/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/backend/webdav/build.gradle
+++ b/backend/webdav/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/config/findbugs/exclude_filter.xml
+++ b/config/findbugs/exclude_filter.xml
@ -1,9 +0,0 @@
-<?xml version="1.0"?>
-<FindBugsFilter>
-    <Match>
-        <Class name="~com\.fsck\.k9\.R.*" />
-    </Match>
-    <Match>
-        <Class name="~android\..*" />
-    </Match>
-</FindBugsFilter>
--- a/config/findbugs/include_filter.xml
+++ b/config/findbugs/include_filter.xml
@ -1,13 +0,0 @@
-<?xml version="1.0"?>
-<FindBugsFilter>
-    <Match>
-        <Package name="~com\.fsck\.k9.*" />
-        <Not>
-            <Or>
-                <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE" />
-                <Bug pattern="MS_CANNOT_BE_FINAL" />
-                <Bug pattern="SF_SWITCH_NO_DEFAULT" />
-            </Or>
-        </Not>
-    </Match>
-</FindBugsFilter>
--- a/gradle/plugins/findbugs-android.gradle
+++ b/gradle/plugins/findbugs-android.gradle
@ -1,29 +0,0 @@
-apply plugin: 'findbugs'
-
-afterEvaluate {
-    def variants = plugins.hasPlugin('com.android.application') ?
-            android.applicationVariants : android.libraryVariants
-
-    variants.each { variant ->
-        def task = project.task("findBugs${variant.name.capitalize()}", type: FindBugs) {
-            group = 'verification'
-            description = "Run FindBugs for the ${variant.description}."
-
-            effort = 'max'
-            ignoreFailures = true
-
-            includeFilter = file("$rootProject.projectDir/config/findbugs/include_filter.xml")
-            excludeFilter = file("$rootProject.projectDir/config/findbugs/exclude_filter.xml")
-
-            def variantCompile = variant.javaCompile
-
-            classes = fileTree(variantCompile.destinationDir)
-            source = variantCompile.source
-            classpath = variantCompile.classpath.plus(project.files(android.bootClasspath))
-
-            dependsOn(variantCompile)
-        }
-
-        tasks.getByName('check').dependsOn(task)
-    }
-}
--- a/mail/common/build.gradle
+++ b/mail/common/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/mail/protocols/imap/build.gradle
+++ b/mail/protocols/imap/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/mail/protocols/pop3/build.gradle
+++ b/mail/protocols/pop3/build.gradle
@ -1,7 +1,6 @@
 apply plugin: 'com.android.library'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/mail/protocols/smtp/build.gradle
+++ b/mail/protocols/smtp/build.gradle
@ -1,7 +1,6 @@
 apply plugin: 'com.android.library'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/mail/protocols/webdav/build.gradle
+++ b/mail/protocols/webdav/build.gradle
@ -1,7 +1,6 @@
 apply plugin: 'com.android.library'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 if (rootProject.testCoverage) {
    apply plugin: 'jacoco'
--- a/mail/testing/build.gradle
+++ b/mail/testing/build.gradle
@ -2,7 +2,6 @@ apply plugin: 'com.android.library'
 apply plugin: 'org.jetbrains.kotlin.android'

 apply from: "${rootProject.projectDir}/gradle/plugins/checkstyle-android.gradle"
-apply from: "${rootProject.projectDir}/gradle/plugins/findbugs-android.gradle"

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${versions.kotlin}"