wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move swipe refresh animation workaround from onPause() to onStop()

Browse source 
onPause() is also called when we don't want the animation to stop, e.g.
when changing the focus to another window in multi window mode.
However, adding a new Fragment will stop the old one. So onStop() is a
better place to cancel the animation.
This commit is contained in:
cketti 2017-10-14 02:28:32 +02:00
parent 7c89108cea
commit 655e86b4f5
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
k9mail/src/main/java/com/fsck/k9/fragment/MessageListFragment.java
View file

@ -664,13 +664,6 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
localBroadcastManager.unregisterReceiver(cacheBroadcastReceiver);
activityListener.onPause(getActivity());
messagingController.removeListener(activityListener);
// Workaround for Android bug https://issuetracker.google.com/issues/37008170
if (swipeRefreshLayout != null) {
swipeRefreshLayout.setRefreshing(false);
swipeRefreshLayout.destroyDrawingCache();
swipeRefreshLayout.clearAnimation();
}
}
/**
@ -2267,6 +2260,14 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
Timber.e(e, "Could not abort remote search before going back");
}
}
// Workaround for Android bug https://issuetracker.google.com/issues/37008170
if (swipeRefreshLayout != null) {
swipeRefreshLayout.setRefreshing(false);
swipeRefreshLayout.destroyDrawingCache();
swipeRefreshLayout.clearAnimation();
}
super.onStop();
}