wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't use unchecked input in format string

Browse source
This commit is contained in:
cketti 2016-12-31 20:13:18 +01:00
parent b9147f119e
commit 693449235f
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
k9mail/src/main/java/com/fsck/k9/helper/FileHelper.java
View file

@ -51,16 +51,17 @@ public class FileHelper {
}
// Get the extension of the file, if any.
int index = filename.lastIndexOf('.');
String format;
String name;
String extension;
if (index != -1) {
String name = filename.substring(0, index);
String extension = filename.substring(index);
format = name + "-%d" + extension;
name = filename.substring(0, index);
extension = filename.substring(index);
} else {
format = filename + "-%d";
name = filename;
extension = "";
}
for (int i = 2; i < Integer.MAX_VALUE; i++) {
file = new File(directory, String.format(Locale.US, format, i));
file = new File(directory, String.format(Locale.US, "%s-%d%s", name, i, extension));
if (!file.exists()) {
return file;
}