wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2195 from k9mail/rework_ClipboardManager

Browse source 
Rework ClipboardManager to avoid leaking Context
This commit is contained in:
cketti 2017-02-07 04:23:01 +01:00 committed by GitHub
commit 7aa784f16d
1 changed files with 5 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
k9mail/src/main/java/com/fsck/k9/helper/ClipboardManager.java
View file

@ -8,30 +8,16 @@ import android.content.Context;
* Access the system clipboard using the new {@link ClipboardManager} introduced with API 11 * Access the system clipboard using the new {@link ClipboardManager} introduced with API 11
*/ */
public class ClipboardManager { public class ClipboardManager {
private static ClipboardManager sInstance = null;
public static ClipboardManager getInstance(Context context) { public static ClipboardManager getInstance(Context context) {
Context appContext = context.getApplicationContext(); Context appContext = context.getApplicationContext();
return new ClipboardManager(appContext);
if (sInstance == null) {
sInstance = new ClipboardManager(appContext);
}
return sInstance;
} }
protected Context mContext; private Context context;
/** private ClipboardManager(Context context) {
* Constructor this.context = context;
*
* @param context
* A {@link Context} instance.
*/
protected ClipboardManager(Context context) {
mContext = context;
} }
/** /**
@ -44,7 +30,7 @@ public class ClipboardManager {
*/ */
public void setText(String label, String text) { public void setText(String label, String text) {
android.content.ClipboardManager clipboardManager = android.content.ClipboardManager clipboardManager =
(android.content.ClipboardManager) mContext.getSystemService(Context.CLIPBOARD_SERVICE); (android.content.ClipboardManager) context.getSystemService(Context.CLIPBOARD_SERVICE);
ClipData clip = ClipData.newPlainText(label, text); ClipData clip = ClipData.newPlainText(label, text);
clipboardManager.setPrimaryClip(clip); clipboardManager.setPrimaryClip(clip);
} }