wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #7691 from thunderbird/fix-lint-warnings

Browse source 
Fix lint warnings
This commit is contained in:
Wolf-Martell Montwé 2024-03-07 10:24:04 +00:00 committed by GitHub
commit f56d352efe
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
app/ui/legacy/src/main/java/com/fsck/k9/ui/fab/HideFabOnScrollBehavior.kt
View file

@ -1,5 +1,6 @@
package com.fsck.k9.ui.fab
import android.annotation.SuppressLint
import android.content.Context
import android.util.AttributeSet
import android.view.Gravity
@ -8,8 +9,17 @@ import androidx.coordinatorlayout.widget.CoordinatorLayout
import androidx.core.view.marginBottom
import com.google.android.material.behavior.HideBottomViewOnScrollBehavior
import com.google.android.material.floatingactionbutton.FloatingActionButton
import com.google.android.material.snackbar.Snackbar
import com.google.android.material.snackbar.Snackbar.SnackbarLayout
/**
* Hides the floating action button when the `CoordinatorLayout` is scrolled.
*
* The behavior to hide the FAB when the [CoordinatorLayout] is scrolled is provided by the super class
* [HideBottomViewOnScrollBehavior]. The code in this class adjusts the vertical position of the FAB when a [Snackbar]
* is visible. This is necessary because we (like many others) deliberately ignore the
* [guideline](https://m3.material.io/components/snackbar/guidelines) to display a `Snackbar` above the FAB.
*/
class HideFabOnScrollBehavior(context: Context, attributes: AttributeSet) :
HideBottomViewOnScrollBehavior<FloatingActionButton>(context, attributes) {
@ -23,7 +33,7 @@ class HideFabOnScrollBehavior(context: Context, attributes: AttributeSet) :
}
override fun layoutDependsOn(parent: CoordinatorLayout, child: FloatingActionButton, dependency: View): Boolean {
return dependency is SnackbarLayout || super.layoutDependsOn(parent, child, dependency)
return dependency.isSnackbarLayout() || super.layoutDependsOn(parent, child, dependency)
}
override fun onDependentViewChanged(
@ -31,7 +41,7 @@ class HideFabOnScrollBehavior(context: Context, attributes: AttributeSet) :
child: FloatingActionButton,
dependency: View,
): Boolean {
if (dependency is SnackbarLayout) {
if (dependency.isSnackbarLayout()) {
val additionalHiddenOffsetY = dependency.height + dependency.marginBottom
setAdditionalHiddenOffsetY(child, additionalHiddenOffsetY)
}
@ -42,8 +52,15 @@ class HideFabOnScrollBehavior(context: Context, attributes: AttributeSet) :
override fun onDependentViewRemoved(parent: CoordinatorLayout, child: FloatingActionButton, dependency: View) {
super.onDependentViewRemoved(parent, child, dependency)
if (dependency is SnackbarLayout) {
if (dependency.isSnackbarLayout()) {
setAdditionalHiddenOffsetY(child, 0)
}
}
// SnackbarLayout is a restricted type that shouldn't be accessed from outside of its library. However, there
// doesn't seem to be a public API we could use to implement the desired behavior.
@SuppressLint("RestrictedApi")
private fun View.isSnackbarLayout(): Boolean {
return this is SnackbarLayout
}
}

1
config/lint/lint.xml
View file

@ -1,6 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<lint>
<issue id="MissingTranslation" severity="informational" />
<issue id="MissingQuantity" severity="informational" />
<issue id="ExtraTranslation" severity="warning" />
<issue id="ImpliedQuantity" severity="warning" />
</lint>