wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7241 commits 1 branch 0 tags 100 MiB
Commit graph

1394 commits

Author SHA1 Message Date
cketti
ca5f362080 Add tests for notification code and fix bugs found along the way 2015-09-15 20:28:59 +02:00
cketti
ecd7809575 Rewrite new mail notification code 2015-09-15 20:28:59 +02:00
cketti
29bd67641b Split NotificationController into multiple classes for maintainability 2015-09-15 20:28:59 +02:00
cketti
0f696bb1c5 Clean up and refactor code 
Functionality (and bugs) should be the same as before.
 2015-09-15 20:28:59 +02:00
cketti
55bdc1e5c2 Extract code that deals with generating notification IDs 2015-09-15 20:25:14 +02:00
cketti
2c49f21a52 Reuse reference to the system's NotificationManager 2015-09-15 20:25:14 +02:00
cketti
acd18291f2 Extract notification-related code from MessagingController to NotificationController 2015-09-15 20:25:14 +02:00
cketti
5b0883e49c Use MessageReference instead of message UID as key in 'stackedNotifications' 2015-09-15 20:15:20 +02:00
cketti
5d3f6ece1f Remove unused methods 2015-09-15 20:15:20 +02:00
cketti
e95916c529 Remove unnecessary EXTRA_DONTCANCEL 2015-09-15 20:15:20 +02:00
cketti
8be56fab90 Don't reinvent the wheel when creating MessageReferences 
Also, we don't care about flags when dealing with MessageReferences for notifications.
 2015-09-15 20:15:20 +02:00
cketti
4508e12504 Remove double synchronization 2015-09-15 20:15:20 +02:00
Marcus Wolschon
9c8fa32303 Add Android Wear support 2015-09-15 20:15:20 +02:00
cketti
065088feb2 Merge pull request #776 from k9mail/GH-744_attachment_mime_type 
Prefer attachment MIME type from content provider over information from intent

Fixes #744
 2015-09-13 03:03:16 +02:00
cketti
696579fcd5 Merge pull request #775 from k9mail/GH-765_folders_export 
Fix folder settings export

Fixes #765
 2015-09-13 02:39:54 +02:00
cketti
d4d701ae10 Merge pull request #774 from k9mail/GH-773_hide_load_more_button 
Hide "Load up to X more" button

Fix issue #773
 2015-09-13 02:14:57 +02:00
gaionim
83eadbbbea add poste + vodafone 2015-09-08 17:34:10 +02:00
calimou
ebc73c9138 Update providers.xml 
added posteo.net domain
 2015-09-08 10:20:02 +02:00
cketti
a6b9384635 Don't crash when callback is called after the fragment has been detached 
Fixes issue #690
 2015-09-07 06:51:53 +02:00
cketti
bb5d0682c3 Clean up MessageViewFragment a bit 2015-09-07 04:12:55 +02:00
cketti
1f16002685 Don't needlessly write message reference when saving instance state 2015-09-07 03:27:42 +02:00
cketti
c4bbae288b Hide the "Load up to X more" footer when there are no more relevant messages on the server 
This is tricky for IMAP because we only care about non-deleted messages and
there's no easy way to count these. So when necessary we list all remaining
messages on the server to check whether any of them are relevant for us.
 2015-09-06 21:06:18 +02:00
cketti
82b2e0280f Prefer MIME type from content provider over information from intent 2015-09-05 03:58:25 +02:00
cketti
4b11974e0d Bugfix: Export settings for folders containing "." 
Fixes issue #765
 2015-09-05 02:50:16 +02:00
cketti
62a1f2bd26 Merge pull request #731 
Make K9 themeable by layers
 2015-09-04 23:11:19 +02:00
cketti
d89bf8f33e Remove compatibility theme attributes 2015-09-04 23:01:04 +02:00
cketti
7fbaba9280 Add comment to explain why we have empty base themes 2015-09-04 22:55:16 +02:00
cketti
e16778f72e Remove duplicate attributes 2015-09-04 22:55:16 +02:00
cketti
ebfd5b398c Reformat CREATE TABLE statement 2015-09-03 22:48:13 +02:00
Dominik Schürmann
16bd8a53ed Remove debug log that slipped in 2015-08-25 08:30:31 +02:00
Dominik Schürmann
be18d06afd Update OpenPGP API to v8, use jcenter dependency, remove sub-project 2015-08-24 02:34:57 +02:00
cketti
129f9a74a1 Fix wording 2015-08-21 22:58:05 +02:00
Guillaume Smaha
5cf39dde44 Fix an issue when passphrase is cancelled 
Cancel the window asking passphrase crash the app due a missing error.
 2015-08-21 22:58:05 +02:00
cketti
767976c973 Use helper method to case-insensitively compare MIME types 
Fixes #741
 2015-08-21 21:14:30 +02:00
cketti
ed6655fc18 Merge pull request #720 from dalevizo/master 
Add autoconfig settings for some Greek providers
 2015-08-21 17:44:27 +02:00
cketti
cb8c11e767 Add message discard confirmation setting to settings import/export 2015-08-21 16:55:35 +02:00
cketti
ff369cc922 Use framework to show confirmation dialog 2015-08-21 16:53:53 +02:00
cketti
46ac437d7b Fix naming and code style 2015-08-21 16:53:53 +02:00
jcontno
207ee0f359 added a confirm dialog if accidently pressed the menu entry discard in the 
message compose string. The dialog is default on and can be disabled in
global settings > interaction > notifications
 2015-08-21 16:53:53 +02:00
dalevizo
e857ca1f54 Update providers.xml 
fix typo in mycosmos.gr provider
 2015-08-17 00:48:18 +03:00
Allan W
93f8965164 Make K9 themeable by layers. 
Moved all custom attributes from the base theme to the light/dark theme. That way, the parent theme for the base can be easily changed.
 2015-08-03 11:01:06 -07:00
Dimos Alevizos
66e379c6fd Add autoconfig settings for some Greek providers 2015-07-24 13:09:21 +03:00
Doug Sparling
ecd5239c2b Don't use StringReader in HtmlConverter as calls to read have unnecessary locking. 2015-07-23 00:07:21 -05:00
cketti
9050ef16a2 Merge pull request #686 from k9mail/art/more-static-analysis-fixes 
Fix static analysis warnings and stop using nulls everywhere
 2015-07-16 08:39:34 +02:00
cketti
fde7b985fc Merge pull request #700 from k9mail/issue-661_disable_notifications_during_quiet_time 
Add setting to completely disable notifications during Quiet Time
 2015-07-06 22:23:45 +02:00
cketti
d8aef84127 Don't overwrite delete policy when editing incoming server settings 
Fixes #616
 2015-07-06 20:40:10 +02:00
cketti
ecb6893e6c Properly encode folder name in MessageProvider delete URI 
Fixes #706
 2015-07-06 20:02:19 +02:00
Art O Cathain
e935feb068 extract variable per review comment 2015-07-01 16:59:57 +01:00
Art O Cathain
32cc97207c do not throw exception in MessagingController per review comment 2015-07-01 16:57:13 +01:00
cketti
54d30833fc Merge pull request #694 from k9mail/send_error_handling 
Improve send failure handling
 2015-06-28 05:54:43 +02:00
cketti
d08942cc50 Add 'notificationDuringQuietTimeEnabled' to settings import/export 2015-06-28 05:24:30 +02:00
cketti
7959033f26 Change naming/wording 2015-06-28 05:14:21 +02:00
Sander Baas
07c12e83d0 Add option to disable notifications in quiet time 
Fixes #661
 2015-06-28 05:14:21 +02:00
cketti
d301d63274 Add support for saving message/rfc822 parts 
Fixes #603
 2015-06-26 06:15:32 +02:00
cketti
9d44f0e062 Improve send failure handling 
We now no longer parse the exception message in MessagingController to find
out if it was a permanent SMTP failure.
Overall the code is still a mess, but the error handling should be a little
bit better and more readable now.
 2015-06-22 00:43:31 +02:00
Art O Cathain
7fc8767a5c fix static analysis warnings and stop using nulls everywhere 2015-06-13 16:47:35 +01:00
Art O Cathain
591785a3ab fix up some dodgy nulls 2015-06-13 16:24:58 +01:00
Art O Cathain
2d45e53739 fix potential NPE 2015-06-13 15:29:58 +01:00
cketti
e01b1b189f Merge pull request #653 from k9mail/change_folder_sync 
Don't write messages without (partial) body to database
 2015-06-10 02:29:50 +02:00
cketti
6138afb579 Don't write messages without (partial) body to database 
Opening such messages during download will display "No text" and (probably
due to a bug) might lead to the synchronization process being aborted. Instead
of fixing the UI issue we now don't write these incomplete messages to the
database. This has the potential to massively speed up the sync process. But
it will take longer for messages to show up in the message list, especially
with slow connections.
 2015-05-22 07:25:17 +02:00
cketti
1cd7df1369 Don't write the new push state to the database for every message 2015-05-22 07:25:14 +02:00
cketti
916929e507 Fix getting code coverage on CI builds 2015-05-21 14:52:50 +02:00
cketti
a24d85d754 Move library tests to k9mail-library module 2015-05-21 02:21:38 +02:00
cketti
4b273c1749 Move some tests from 'androidTest' to 'test' folder 2015-05-20 21:00:43 +02:00
cketti
0f66cacf10 Move JVM tests into main k9mail module 
Use Robolectric for the tests that use framework classes.
 2015-05-20 21:00:43 +02:00
cketti
b660d45b6c Merge branch '5.103_with_bugfixes' 2015-05-02 18:11:40 +02:00
cketti
ce86e773e0 Use Greenmail 1.4.1 release instead of (now removed) snapshot 2015-04-30 10:10:54 +02:00
cketti
3e833580ac Use numbered parameters in format string 
… because Transifex is stupid and complains when a parameter doesn't show
up in a translation exactly like it's defined in the source language.
 2015-04-30 09:58:31 +02:00
Marcus Wolschon
05934d75d8 wrong parameter order in format string. 
(Found via Android Studio Lint tool)
 2015-04-28 23:08:17 +02:00
Marcus Wolschon
64e22a72ed Some first android wear support for enhancement 
#619  "Add android wear support"

No reply with voice yet (as requested in the ticket).
No user-configurable actions yet, just delete+archive+spam
No stacked notification for multiple messages yet.
 2015-04-28 22:26:17 +02:00
Marcus Wolschon
0f848ee51f reverting accidental commit 1dfc2a5490 2015-04-28 22:17:02 +02:00
Marcus Wolschon
1dfc2a5490 Merge remote-tracking branch 'origin/master' 2015-04-28 22:05:37 +02:00
Marcus Wolschon
c37934ea16 Fixed wrong parameter order leading to broken MessageReferences. 2015-04-28 22:04:22 +02:00
cketti
d538278be6 Don't write HtmlConverterTest results to a file 
Fixes issue #618
 2015-04-28 05:43:35 +02:00
cketti
83bb97b0c5 Revert "Potentially avoid creating new Typeface instances" 
This reverts commit 9df1a3ee80.
 2015-04-04 01:46:53 +02:00
cketti
017ae1d2f3 Merge pull request #590 
WebView: Open links in external Browser
 2015-04-04 01:20:08 +02:00
cketti
babd3a530f Add activity flags to browser view intent 2015-04-04 01:06:14 +02:00
cketti
ba8cb6c85d Set EXTRA_CREATE_NEW_TAB to 'true' in browser view intent 2015-04-04 00:57:47 +02:00
cketti
09babb6e88 Restructure the code a bit 2015-04-04 00:55:53 +02:00
cketti
8bcf9b1d50 Remove comments 2015-04-04 00:50:14 +02:00
cketti
80fa468ec2 Merge pull request #581 
MessageReference class refactor
 2015-04-03 21:36:26 +02:00
cketti
24b61e0743 Fix code formatting 2015-04-03 21:33:38 +02:00
cketti
a3375d7030 Make MessageReference fields private 2015-04-03 20:43:49 +02:00
cketti
9275bb2943 Remove unused constructor 2015-04-03 20:35:33 +02:00
cketti
af36129449 Extract local variables for easier readability 2015-04-03 20:27:11 +02:00
cketti
632517be81 Remove trivial comments 2015-04-03 19:50:50 +02:00
Art O Cathain
1ec2c5b095 Clarify 2015-03-31 20:29:51 +01:00
Art O Cathain
6a03e62f52 ensure account also removed from memories on delete 2015-03-31 20:10:25 +01:00
m0viefreak
46f74bd11c WebView: Open links in external Browser 
1a20ca06f1 connected a WebViewClient
to the WebView. But as soon as a client is connected, the WebView
stops handling links itself and tries to display everything on
its own.

Override shouldOverrideUrlLoading() and replicate what Android's
default WebView does if no WebViewClient is connected to work
around this.

This fixes #587.
 2015-03-26 02:27:10 +01:00
Dominik Schürmann
ffc5ba2cf3 PGP: Set correct encryption state in message crypto annotation via RESULT_TYPE 2015-03-21 15:40:15 +01:00
Valentin CAULIER
ebcd10d1b1 Merge remote-tracking branch 'upstream/master' into MessageReferenceImmutability 2015-03-21 11:53:40 +01:00
Valentin CAULIER
13f6b42250 MessageReference is now immutable 2015-03-21 11:12:16 +01:00
Valentin CAULIER
3e84c20c9b Updating other classes to use new constructor and getters of 
MessageReference
 2015-03-21 11:12:13 +01:00
Dominik Schürmann
16f09611fe PGP: Introduce key preference per account for OpenPGP APIv7 2015-03-20 15:14:48 +01:00
Valentin CAULIER
bf0333ba31 Beginning MessageReference update to immutable object 2015-03-16 16:29:42 +01:00
cketti
ab964cf8af Merge branch 'pgp_mime_preparations' 2015-03-16 16:14:45 +01:00
cketti
54831fba73 Remove test for openpgp-api-library code 2015-03-16 16:05:25 +01:00
Dominik Schürmann
e4cfd3c886 Update openpgp-api-library for APIv7 2015-03-16 14:29:12 +01:00
cketti
f0e1b14b58 Merge pull request #567 
Move NetworkType to k9mail-library, use on StoreConfig
 2015-03-16 13:39:59 +01:00
cketti
494b16196d Rename AccountCreator.calculateDefaultDeletePolicy() 2015-03-16 13:28:11 +01:00
cketti
5f14e3b4e1 Use switch statement inside calculateDefaultDeletePolicy() 
With this - at least in theory  - the JIT compiler can produce better code
than is possible with the static HashMap.
 2015-03-16 13:26:44 +01:00
cketti
f733cc38ba Merge pull request #566 
Rationalize default ports
 2015-03-16 13:15:43 +01:00
cketti
00528f5d24 Move throw statement outside of switch body 
This way static analysis can detect when we're missing a switch case.
 2015-03-16 13:11:01 +01:00
cketti
855da35f3a Code style fixes 2015-03-16 13:06:40 +01:00
cketti
d528864a25 Merge branch '5.103_with_bugfixes' 
Make sure 5.105 can be found in master branch
 2015-03-14 12:28:20 +01:00
cketti
08beb212c2 Fix crashes when selecting messages in the message list 
Throughout the code we make the assumption that onPrepareActionMode() is
called right after starting the action mode. However, this is not the case on
Android 5.1.
With this change we call ActionMode.invalidate() right after starting the
action mode which causes onPrepareActionMode() to be invoked.
 2015-03-13 21:12:21 +01:00
cketti
42419fc4e5 Bump version to 5.104 2015-03-13 13:10:11 +01:00
cketti
20a1fa384c Prepare changelog for 5.104 2015-03-13 12:53:17 +01:00
cketti
9f2bbe9ae4 Add Serbian translation 2015-03-13 12:48:50 +01:00
cketti
e0a249098b Update translations 2015-03-13 12:42:16 +01:00
Art O Cathain
110400a85b move NetworkType to k9mail-library, use on StoreConfig 2015-03-08 12:59:15 +00:00
Art O Cathain
520e327775 remove duplication 2015-03-08 11:26:54 +00:00
Art O Cathain
810d0cf6b4 Move default port and default TLS port to a single location 2015-03-08 11:05:53 +00:00
cketti
147db8cc5e Configure 'developer mode' via BuildConfig 2015-03-07 00:30:50 +01:00
cketti
2f832e5fa4 Merge pull request #562 from artbristol/art/tidy-check-settings-async-task 
Refactor to make code more readable
 2015-03-06 23:52:22 +01:00
cketti
46bac187d5 Merge pull request #557 from artbristol/art/account-creation-refactor-2 
Remove duplication, enum-ify String
 2015-03-06 23:47:46 +01:00
cketti
67404b1883 Merge pull request #553 
Remove redundant variable assignments
Minimize scope of local variables
 2015-03-06 23:13:54 +01:00
cketti
abd2b20850 Minimize scope of local variables 2015-03-06 23:12:28 +01:00
cketti
29f7552c3a Merge pull request #548 
Rename Searchfield to SearchField
 2015-03-06 23:00:18 +01:00
cketti
b826d4e98d Use imports for inner classes 2015-03-06 21:19:27 +01:00
cketti
bf344dee5d Merge branch 'master' into pgp_mime_preparations 2015-03-03 00:33:45 +01:00
cketti
2a404b30d2 Small refactoring of MessageBuilder 2015-03-03 00:26:43 +01:00
cketti
cb0a99281a Refactor IdentityHeaderBuilder to make it a bit more readable 2015-03-03 00:11:59 +01:00
cketti
bc284584d1 Move code to build messages outside of MessageCompose 2015-03-02 23:52:35 +01:00
cketti
5330fe5b27 Extract code to parse a message header to its own class 2015-02-25 03:36:48 +01:00
Art O Cathain
d0fa82269f review comments 2015-02-23 17:28:42 +00:00
cketti
dd20ff5aa3 Merge pull request #561 
Reduce code duplication in AccountSetupAccountType
 2015-02-23 03:39:07 +01:00
cketti
737e0d2ac8 Minor code style fixes 2015-02-23 03:36:34 +01:00
cketti
d443a6d4eb Add more tests 2015-02-23 02:58:16 +01:00
cketti
a979accb54 Add helper methods to get more readable tests 2015-02-23 02:58:16 +01:00
cketti
af491fdb41 Remove comments 2015-02-23 02:23:00 +01:00
cketti
084e7a1687 Change names of test methods 2015-02-23 02:22:10 +01:00
cketti
8fbb3edd1c Fix code style 2015-02-23 01:45:30 +01:00
Art O Cathain
5035e7e3d1 review comments, also use == in preference to equals for enums 2015-02-22 21:30:26 +00:00
Valentin CAULIER
23c01b0390 MessageReference class, method equals() unit tests 2015-02-22 21:11:13 +01:00
Art O Cathain
a656a61c65 tidy method 2015-02-22 17:01:14 +00:00
Art O Cathain
d5d42469b0 Avoid confusing reuse of local variables 2015-02-22 16:03:58 +00:00
Art O Cathain
492d65feed reduce duplication 2015-02-22 15:52:16 +00:00
cketti
e7f706b78d Show new decrypt/verify error conditions in crypto header 2015-02-21 04:31:44 +01:00
cketti
bcb668300f Refactor OpenPgpHeaderView for readability 2015-02-21 03:24:41 +01:00
cketti
6def0be158 Add helper methods to shorten code 2015-02-21 02:57:02 +01:00
cketti
fd99c279e5 Remove "m" prefix of field names 2015-02-21 02:52:55 +01:00
cketti
ab877453d9 Use enum instead of int constants 2015-02-21 02:50:47 +01:00
cketti
d61ac959a9 Limit method/field accessibility 2015-02-21 02:39:34 +01:00
cketti
ae258f5761 Remove unused method 2015-02-21 02:39:34 +01:00
cketti
b40749547c Don't show parts we can't (yet) decrypt as attachments 2015-02-21 02:39:34 +01:00
cketti
e5e4c29736 Save type of crypto part for later use 2015-02-21 02:39:34 +01:00
cketti
6f3f555986 Add support for new decrypt/verify error conditions 
We can decrypt or verify a message if it was only partly downloaded.
 2015-02-21 02:39:33 +01:00
cketti
c6abb50d10 Refactor code to get smaller methods 2015-02-20 18:31:42 +01:00
Art O Cathain
1a706c3113 formatting 2015-02-18 19:48:17 +00:00
Art O Cathain
583a637d79 Remove duplication, enum-ify String 2015-02-18 19:42:33 +00:00
cketti
d8448c3510 Only make http or https URIs trigger the "Show pictures" button 2015-02-17 23:42:26 +01:00
cketti
ab8746ffe9 Hide side bar when not showing the crypto header view 2015-02-17 23:18:46 +01:00
cketti
132ede425b Make it easier to check if a crypto provider is configured 2015-02-17 20:17:34 +01:00
cketti
cac1f1ca0d Do MessageTopView initialization in onFinishInflate() 2015-02-17 18:04:52 +01:00
cketti
160b9eb354 Do MessageContainerView initialization in onFinishInflate() 2015-02-17 17:42:28 +01:00
cketti
f887348953 Set background color of message view in one place 2015-02-17 04:15:10 +01:00
cketti
e15cda8504 Fix "Show pictures" button functionality 2015-02-17 03:54:13 +01:00
cketti
68147880ce Move "Show pictures" button into MessageTopView 
We can also get rid of the "Show message" and "Show attachments" buttons.
 2015-02-17 02:32:20 +01:00
cketti
c64ae008c1 Code cleanup 2015-02-17 01:54:40 +01:00
cketti
6b52f41e2c Better name for method argument 2015-02-17 01:43:53 +01:00
cketti
e16f8af667 Don't pass Fragment reference to MessageContainerView 2015-02-17 01:30:41 +01:00
cketti
15cb58fe42 Add placeholder for application ID to K9FileProvider 2015-02-17 00:58:03 +01:00
cketti
9659bee8c5 Merge branch 'master' into pgp_mime_preparations 2015-02-17 00:56:42 +01:00
cketti
ebef8eccb9 Add missing placeholder for application ID 2015-02-17 00:45:36 +01:00
Art O Cathain
ffb4507776 Enums instead of int/String constants (#547) 
simplify and add logging

simplify

use == for enum comparison to avoid type mistakes

enum name needs to match previous constant

simplify

Address review comments - formatting, and remove superfluous comment

Shorten DeletePolicy values since not used in settings strings; import enums to reduce clutter

fix whitespace

remove comment per review

address review comment

review comments

remove another superfluous qualification

Last changes
 2015-02-16 22:22:05 +00:00
cketti
24e6b39dc0 Stop using Intent.setClassName() 
Use the type-safe Intent constructor to reference internal classes.
 2015-02-16 22:44:55 +01:00
cketti
461778ed11 Merge branch 'configurable_application_id' 2015-02-16 21:53:44 +01:00
cketti
1301645387 Use different application ID for debug builds 
This way debug builds can be installed next to the release version.
 2015-02-16 21:45:04 +01:00
cketti
ebeed31705 Fix search for non-default application ID 2015-02-16 21:38:16 +01:00
cketti
d703ac9148 Revert substitution of "com.fsck.k9" in implementation details 
We don't need to change strings that are not exposed to the system/users.
 2015-02-16 21:02:52 +01:00
cketti
9f1ecf7220 Merge pull request #555 from BombTeam/UnusedImportsRemoval 
Remove unused import
 2015-02-16 19:47:38 +01:00
cketti
b4900cc6af Merge pull request #551 from BombTeam/remove-redundant-cast 
Remove redundant casts
 2015-02-16 18:46:15 +01:00
cketti
62c2894fce Merge pull request #544 from BombTeam/StringGlitchCorrection 
Fix height of buttons in wizard screens
 2015-02-16 18:30:51 +01:00
Valentin CAULIER
80f8e4a81d Removing java.util.Arrays import 2015-02-16 17:37:15 +01:00
Levrifon
0d0b80f142 Added placeholder for application ID 2015-02-16 16:53:38 +01:00
Marine
c4e202ecd9 remove redundant assignment to FolderSettings 
removed null affectation because it’s done automatically
 2015-02-16 15:31:03 +01:00
Marine
9bf546b33b removed redundant assignment to AccountSetupBasics 
removed null affectation because it’s done automatically
 2015-02-16 15:25:36 +01:00
Marine
f5cac2c71f remove redundant cast Button to WelcomeMessage 
findViewById(R.id.next) and
findViewById(R.id.import_settings)
are Button so it’s redundant to cast it to Button
 2015-02-16 15:10:34 +01:00
Marine
63047e0ac6 remove redundant cast (Button) 
findViewById(R.id.pop) ,
findViewById(R.id.imap) and
findViewById(R.id.webdav)
are Button so it’s redundant to cast it to Button
 2015-02-16 15:03:11 +01:00
Marine
980d799087 Rename from Searchfield to SearchField 2015-02-16 14:07:41 +01:00
qvandekadsye
9b1a0b3614 Applying "match-parent" value to "next" buttons. 2015-02-16 13:48:31 +01:00
cketti
aae71125c6 Merge pull request #523 
Make sure to keep font meta info on view recycling
 2015-02-15 17:43:11 +01:00
cketti
9df1a3ee80 Potentially avoid creating new Typeface instances 2015-02-15 17:38:10 +01:00
cketti
ba1fc1305f Merge branch 'master' into pgp_mime_preparations 2015-02-14 05:10:15 +01:00
cketti
9c3cab2354 Don't show changelog dialog during UI tests 
This will hopefully make the UI tests more stable.
 2015-02-14 04:23:54 +01:00
qvandekadsye
5013f36ba4 re-correcting String glitch by changing layout-height attribute 2015-02-13 15:21:09 +01:00
Gabriel Burca
9ba2725ab1 Fixes issue 6703 
- onPrepareActionMode must be called before computeBatchDirection
  because computeBatchDirection ends up referencing mMarkAsRead /
  mMarkAsUnread and mFlag / mUnflag which could be null otherwise.
 2015-02-12 21:27:44 -06:00
cketti
e0abcc3f67 Decouple MessageCryptoHelper from MessageList 2015-02-09 20:02:16 +01:00
cketti
5d3cdc2724 Remove unused variable 2015-02-09 19:44:33 +01:00
cketti
bb3f84fda6 Move MessageCryptoAnnotations to upper level 2015-02-09 19:43:23 +01:00
cketti
d301efea58 Move MessageCryptoHelper 2015-02-09 19:37:46 +01:00
cketti
3a527cbcf6 Decouple MessageCryptoHelper from MessageViewFragment 2015-02-09 19:35:53 +01:00
cketti
948cb971ad Rename method 
Since the crypto code no longer lives in MessageViewFragment it shouldn't
make references to what happens after its work is done.
 2015-02-09 19:05:56 +01:00
cketti
5c036e2991 Simplify control flow 2015-02-09 19:05:45 +01:00
cketti
26eb1f52e5 Don't attempt to verify/decrypt if no crypto provider is configured 2015-02-06 23:26:46 +01:00
cketti
b515e947cf Fix typo 2015-02-06 23:12:26 +01:00
cketti
ee1180e34c Use Part from MessageViewContainer for K9WebViewClient 
Now K9WebViewClient can find encrypted attachments referenced by Content-ID.
 2015-02-06 20:11:58 +01:00
cketti
cadac6dd89 Add reference to root part to MessageViewContainer 2015-02-06 20:04:03 +01:00
cketti
49c4115e46 Refactor code; no functional changes 2015-02-06 20:01:14 +01:00
cketti
3377e50352 Fix code style 2015-02-06 19:57:30 +01:00
cketti
fce12b2450 Remove unused constructor 2015-02-06 19:53:39 +01:00
cketti
1a20ca06f1 Handle "cid:" URIs in HTML message body 2015-02-06 18:31:26 +01:00
cketti
80221dace8 Mark DownloadImageTask as deprecated 2015-02-04 21:43:45 +01:00
cketti
1f27897679 Extract methods to make code more readable 2015-02-04 21:42:09 +01:00
cketti
5175ff9df4 Extract method 2015-02-04 21:17:54 +01:00
cketti
9814442de4 Extract constant for default file name 2015-02-04 21:16:08 +01:00
cketti
36abde2c0b Extract method 2015-02-04 21:14:04 +01:00
cketti
937ca7e17a Move inner class DownloadImageTask to upper level 2015-02-04 21:07:54 +01:00
cketti
d7da286098 Remove unused imports 2015-02-04 21:03:25 +01:00
cketti
0241001c63 Display attachment size for decrypted parts 2015-02-01 05:41:40 +01:00
cketti
19db6c703b Don't display -1 as attachment size 2015-02-01 04:24:02 +01:00
cketti
474efa1831 Fix NullPointerExceptions introduced by conditionally inflating the crypto layout 2015-02-01 00:21:52 +01:00
Vincent Breitmoser
dc8fd39c7e move crypto data into an annotation structure, and fix pgp/inline 
note that we currently lack proper confirmation about whether data was
actually decrypted or not, so for now we always assume it wasn't
 2015-01-30 16:16:11 +01:00
Vincent Breitmoser
4bec165fdc preliminary support for pgp/inline 2015-01-30 16:11:57 +01:00
cketti
de8da4dab4 Write decrypted bodies to temporary files 
Use FileProvider to be able to open decrypted attachments
 2015-01-30 14:27:33 +01:00
Vincent Breitmoser
0374dc9cb1 display pendingIntent button when there is a pendingIntent only 2015-01-30 11:30:36 +01:00
Vincent Breitmoser
a0b4faf688 pass OpenPgpError to display, delete old layout 2015-01-30 10:55:06 +01:00
Vincent Breitmoser
d57f6c0ed5 buffer data after decryption before mime parsing 2015-01-30 10:34:46 +01:00
Vincent Breitmoser
3077e6a2d7 close piped streams after use 2015-01-29 20:24:59 +01:00
cketti
0a07250417 Fix class name 2015-01-29 20:07:30 +01:00
Vincent Breitmoser
d678ccc160 extract crypto methods from MessageViewFragment into MessageCryptoHelper 2015-01-29 20:00:28 +01:00
Vincent Breitmoser
00b7b74878 pass pendingIntent, and some refactoring 2015-01-29 19:27:48 +01:00
Vincent Breitmoser
712acf4481 early support for detached signatures 2015-01-29 19:01:44 +01:00
cketti
38d3564c57 Merge pull request #537 2015-01-29 17:48:28 +01:00
cketti
41ac5a9fed Fix indentation 2015-01-29 17:47:37 +01:00
cketti
edf75a32d8 Fix LocalMessageExtractorTest 2015-01-29 17:41:46 +01:00
cketti
8627e65cab Merge pull request #536 from ligi/ligi/refactor/pgp_utils 
Test & refactor OpenPgpUtils
 2015-01-29 17:32:59 +01:00
cketti
fed15a01e5 Merge branch 'store_decryption_result' into pgp_mime_preparations 
Conflicts:
	k9mail/src/main/java/com/fsck/k9/mailstore/LocalMessageExtractor.java
 2015-01-29 16:43:50 +01:00
ligi
033c1502db Reduce LOC even more 2015-01-29 16:43:45 +01:00
ligi
a51b608e5e Reduce MessageCompos LOC 2015-01-29 16:36:15 +01:00
ligi
828a580eb8 Move this View out ( the hosting class is already too long with ~4000 Lines ..) 2015-01-29 16:30:01 +01:00
ligi
4075b72b72 Cleanup and Optimize ( no need to prepare some layout when it is never used ) 2015-01-29 16:24:44 +01:00
cketti
fbfa6d146f Pass OpenPgpSignatureResult to LocalMessageExtractor 2015-01-29 16:16:29 +01:00
Vincent Breitmoser
ba79779758 break message into multiple MessageViewContainers 2015-01-29 16:10:03 +01:00
cketti
9e47686277 Code style fixes 2015-01-29 15:24:06 +01:00
cketti
7b67d054a4 Don't save reference to multipart/encrypted "root" in decrypted parts 2015-01-29 15:16:59 +01:00
Vincent Breitmoser
1046308a38 converge threads after decryption, and handle PendingIntents 2015-01-29 12:57:04 +01:00
ligi
4bc9d94831 Test & Refactor OpenPgpUtils 2015-01-29 12:30:19 +01:00
Vincent Breitmoser
bcd570f884 always show OpenPgpHeader if crypto-provider is set 2015-01-28 18:11:51 +01:00
cketti
4827b4c437 Merge pull request #535 2015-01-28 17:42:34 +01:00
cketti
7f811fce2c First attempt at decrypting PGP/MIME messages 2015-01-28 17:24:05 +01:00
Dominik Schürmann
6f156498ed Callback to execute signature button click 2015-01-28 15:40:19 +01:00
cketti
bb83fdc0e8 Add support for loading parts with DataLocation.ON_DISK 2015-01-28 15:29:49 +01:00
Dominik Schürmann
fdc597aadf Display signer name and email 2015-01-28 15:22:38 +01:00
Dominik Schürmann
d112344780 Smaller sidebar 2015-01-28 15:09:19 +01:00
Dominik Schürmann
28e9c2a8ec Merge remote-tracking branch 'vincent/pgp_mime_preparations' into pgp_mime_preparations_view 2015-01-28 14:55:51 +01:00
Dominik Schürmann
d46d355f69 OpenPGP status texts and sidebar improvements 2015-01-28 14:54:43 +01:00
Vincent Breitmoser
cced35b3b8 parse MessageViewContainers from Parts (from dummy mime structure) 2015-01-28 14:35:18 +01:00
Dominik Schürmann
e513af9529 Sidebar 2015-01-28 12:26:34 +01:00
Dominik Schürmann
b781ace4fa OpenPGP header and sidebar tests 2015-01-28 11:30:29 +01:00
Dominik Schürmann
4c78d12fc6 Merge remote-tracking branch 'vincent/pgp_mime_preparations' into pgp_mime_preparations_view 
Conflicts:
	k9mail/src/main/java/com/fsck/k9/ui/messageview/MessageContainerView.java
 2015-01-28 09:31:11 +01:00
Dominik Schürmann
e3fef1af98 Work on new pgp header 2015-01-27 17:50:40 +01:00
Vincent Breitmoser
581d32acd6 show attachments inline 2015-01-27 17:33:50 +01:00
Vincent Breitmoser
445c978f31 extract header view for multiple MessageContainerViews (intermediate state) 2015-01-27 16:48:33 +01:00
Vincent Breitmoser
29ad0f0f99 rename SingleMessageView to MessageContainerView 2015-01-27 16:42:31 +01:00
Vincent Breitmoser
40b6228756 new MessageViewInfo structure (with transitional methods) 2015-01-27 12:55:47 +01:00
cketti
d92be22ce3 Merge branch 'master' into pgp_mime_decrypt 2015-01-27 12:44:08 +01:00
cketti
74fdbb7859 Update openpgp-api-library to latest version 2015-01-27 12:15:47 +01:00
cketti
8f7f656355 Add method to find multipart/encrypted parts 2015-01-26 20:37:27 +01:00
cketti
0e03f262b3 Make sure to close underlying InputStream after decoding attachments 2015-01-25 20:06:29 +01:00
cketti
378acbd313 Write large message parts to file system 
Actually, we just move the temporary file to avoid having to copy the
data to a new file.
 2015-01-25 19:25:00 +01:00
cketti
977d15c190 Refactor to improve readability 2015-01-23 15:08:56 +01:00
cketti
6825eafb87 Make column 'message_parts.data' a BLOB 2015-01-23 14:41:29 +01:00
cketti
564e2432e1 Get size of decoded body content when saving 
Before downloading we show the encoded size of attachments. After download we
strip the transport encoding to find out the size of the decoded content.
 2015-01-23 03:58:06 +01:00
cketti
d2d85393d3 Save attachment count 2015-01-22 06:12:26 +01:00
cketti
5e4743bf66 Extract preview of message text 2015-01-22 05:18:50 +01:00
cketti
64e92ab1c1 Remove unused LocalAttachment* classes 2015-01-22 04:18:20 +01:00
cketti
c9b2ec533c Add MessagePreviewExtractor 2015-01-21 01:21:02 +01:00
cketti
23c9398c03 Merge branch 'master' into pgp_mime_preparations 
Conflicts:
	k9mail/src/androidTest/java/com/fsck/k9/mailstore/LocalMessageTest.java
 2015-01-20 18:35:07 +01:00
cketti
395b70fa22 Remove unused code 2015-01-20 16:37:30 +01:00
cketti
da51bdf1b3 Save attachments in background thread 2015-01-19 23:35:14 +01:00
cketti
a7b16c1210 Refresh thumbnail after downloading attachment 2015-01-19 23:08:41 +01:00
cketti
9363c5b276 Download missing parts before viewing or saving 2015-01-19 22:37:15 +01:00
cketti
585d9cbe7f Fix "Download complete message" 2015-01-18 01:33:50 +01:00
cketti
1e628e7177 Reduce exposure of SingleMessageView internals 2015-01-16 23:37:37 +01:00
cketti
658657447e Fix viewing attachment with alternative MIME type 2015-01-16 23:37:37 +01:00
cketti
de2eb25446 Use Glide for thumbnail generation + image loading 2015-01-16 23:37:37 +01:00
cketti
cb94b5b192 Store attachment information in LocalBodyPart 2015-01-16 05:05:11 +01:00
cketti
ac365567ee Replace dummy URI in AttachmentViewInfo instances 
This is a first step towards fixing viewing of attachments.
 2015-01-16 00:12:47 +01:00
cketti
41bd420213 Include database ID in message parts reconstructed from the database 2015-01-15 23:48:11 +01:00
cketti
8fce9e3654 Move functionality from AttachmentView to AttachmentController 2015-01-15 11:37:23 +01:00
cketti
087238f507 Move AttachmentView to 'messageview' package 2015-01-15 08:25:43 +01:00
cketti
2e05127c97 Use a Loader to extract text of a message in a background thread 2015-01-14 09:58:31 +01:00
Jan Berkel
ecd316d0af Simplify ImapConnection#connect 2015-01-14 04:41:21 +01:00
Jan Berkel
9523a589fc use @Test(expected = 2015-01-14 04:31:36 +01:00
Jan Berkel
c79256684d simplify gradle config 2015-01-14 04:31:32 +01:00
Jan Berkel
dfb025033d Convert remaining tests to JUnit4 2015-01-14 04:05:42 +01:00
Jan Berkel
4808406739 Make deleteCertificate null-safe 2015-01-14 03:45:09 +01:00
Jan Berkel
833d9c5de8 Base class is already annotated 2015-01-14 03:34:57 +01:00
Jan Berkel
79b03b5e4f Remove account after creation 
* Avoid side-effects in static preferences which might interfere with other tests
 2015-01-14 03:30:38 +01:00
Jan Berkel
4e964e271c Convert to JUnit4 test 2015-01-14 03:09:48 +01:00
Jan Berkel
0153766dd5 Convert to JUnit4 2015-01-14 03:09:00 +01:00
Jan Berkel
0f312f012e Create test mailboxes 2015-01-14 03:08:44 +01:00
Jan Berkel
055d4104b7 log ChangeLog click failure 2015-01-13 16:12:39 +01:00
Jan Berkel
a15583a080 Start server early 2015-01-13 15:52:31 +01:00
Jan Berkel
bdbe976396 Test connection w/o server 2015-01-13 10:09:42 +01:00
Jan Berkel
e98f323222 Initialize settings in setUp() 2015-01-13 10:05:15 +01:00
Jan Berkel
f7da704007 WS 2015-01-13 09:34:13 +01:00
cketti
78ed2a23b1 Use a Loader to load the message to view from the database 2015-01-13 04:17:25 +01:00
Jan Berkel
60070b7883 Add more tests + descriptive names 2015-01-13 01:59:51 +01:00
Jan Berkel
111212b391 Setup and tear down server between tests 2015-01-13 01:11:09 +01:00
Jan Berkel
7958467503 Convert from thread to AsyncTask for espresso tests 2015-01-13 01:11:09 +01:00
Jan Berkel
b481d3f978 Adding tests for IMAP connection, use greenmail snapshot 2015-01-13 01:10:56 +01:00
cketti
787c014265 Create new package for UI code related to message viewing 2015-01-12 22:46:56 +01:00
cketti
1bf159a300 Get rid of unused LocalTextBody 2015-01-12 22:09:55 +01:00
cketti
bcd64017e3 Extract text to display before viewing the message 2015-01-12 21:52:44 +01:00
cketti
63abf05776 Sanitize HTML to remove meta refresh 
Using
  <meta http-equiv="Refresh" content="1; URL=http://example.com/">
in a HTML message causes WebView to load the URL in the default browser.
Overriding WebViewClient.shouldOverrideUrlLoading() allows us to cancel
loading this URL. Sadly, I found no way to find out whether the method was
called because of a meta refresh or because the user clicked on a link.

So now we're using HtmlCleaner to parse the HTML and remove all "meta" elements
containing an "http-equiv" attribute with a value of "refresh".
 2015-01-11 11:29:53 +01:00
cketti
2532362ed5 Add test for updating a message with a missing part 2015-01-10 04:39:02 +01:00
cketti
bd97004ebd Fix downloading/saving single message parts 2015-01-10 04:38:57 +01:00
cketti
743e640d8c Remove references to 'text_content' and 'html_content' 2015-01-10 01:22:39 +01:00
cketti
ce862c88f8 Change AttachmentProvider to use the new database structure 2015-01-07 02:34:44 +01:00
cketti
e5f0bec6bc Get rid of "backward compatibility" in AttachmentProvider 2015-01-07 00:16:37 +01:00
cketti
c5ba202a56 Code style fixes 2015-01-07 00:13:28 +01:00
cketti
34b5d56ab1 Get rid of 'attachments' table 2015-01-06 23:59:58 +01:00
cketti
1a5ecfea1d Also delete local messages when using "clear messages" on an account 
We have been throwing away all attachments already, so it doesn't make
too much sense to keep local messages. And when we're not keeping local
messages we can remove all entries from the 'threads' table.
 2015-01-06 23:48:22 +01:00
cketti
30e37000f9 Remove remnants of the "headers" table 2015-01-06 21:36:31 +01:00
cketti
d7edb0ed4f Minimal version that reconstructs original message from the database 
This change breaks all kinds of things, e.g.
- deleting messages
- updating messages
- downloading attachments
- deleting attachments
- searching in message bodies
 2015-01-06 03:20:38 +01:00
cketti
523ebd0f2a Remove 'dirty' check for LocalMessage 2015-01-05 02:25:17 +01:00
cketti
3eb25a011f Don't automatically create Message-ID when none is found 2015-01-05 02:25:17 +01:00
cketti
abbad18283 Code style fixes 2015-01-05 00:45:05 +01:00
notfoss
4bc003e173 Add Zoho Mail (personal) to providers.xml 
Added settings for Zoho Mail personal account (@zoho.com).
 2015-01-03 16:43:01 +05:30
cketti
7b5c73b43c Add (failing) test for reconstructing a message from the database 2015-01-03 09:38:49 +01:00
cketti
ad8da49991 Remove unused code 2015-01-03 04:27:27 +01:00
cketti
b6315b15b0 Fix equals() method to work with all objects 2015-01-03 04:10:15 +01:00
cketti
6804ee04e3 Fix some MS_SHOULD_BE_FINAL Findbugs warnings 2015-01-03 03:51:47 +01:00
cketti
65d2de0fcc Fix bug caused by edge case of Math.abs() 2015-01-03 03:51:47 +01:00
cketti
928c7f33a3 Add missing hashCode() method to SearchCondition 2015-01-03 03:51:47 +01:00
cketti
b69bba01da Fix DM_BOXED_PRIMITIVE_FOR_PARSING findbugs warning 2015-01-03 02:02:54 +01:00
cketti
e2a9dd3042 Upgrade to Espresso 2.0 2015-01-02 23:43:46 +01:00
cketti
82736f3a8b Merge pull request #524 from k9mail/merge_pgp_mime_branch 
Merge changes from PGP/MIME repository
 2015-01-02 22:04:28 +01:00
Jan Berkel
78758714c2 Add testcase for #525 2014-12-31 00:43:28 +01:00
m0viefreak
e8c6a56fd2 Use correct sub-part of a multipart message when getting text. 
946565347a passed 'this' to
getTextFromPart() which could be a multipart. This caused
all multipart messages to show 'No text' as the body.

Fix it by passing it the correct 'part' that was found.
 2014-12-25 14:48:05 +01:00
cketti
704cb35d7e Fix Espresso tests 2014-12-22 23:52:34 +01:00
cketti
c96a11212e Update dependencies 2014-12-22 23:09:05 +01:00
cketti
6c172f94a1 Add missing global settings to settings export 2014-12-22 19:47:15 +01:00
Frank Du
c473ddc90a Make sure to keep font meta info on view recycling 2014-12-20 14:50:15 -08:00
cketti
4f8fc5bc5b Merge remote-tracking branch 'k9mail_pgp_mime/master' 
Fixed lots of conflicts
 2014-12-20 08:07:46 +01:00
cketti
52b3974c4f Run checkstyle and findbugs on k9mail-library 2014-12-20 01:49:09 +01:00
cketti
105bca735b Move 'mail' package to library project 2014-12-20 01:31:33 +01:00
Jan Berkel
6a24aca343 Move TracingPowerManager into mail package 2014-12-20 00:50:09 +01:00
cketti
9e7721ca62 Make ckChangeLog an external dependency 2014-12-20 00:33:00 +01:00
cketti
4d61a6407d Move lint configuration file into 'config' folder 2014-12-20 00:10:38 +01:00
cketti
1212f9d0f2 Move main application from root project to subproject 'k9mail' 2014-12-20 00:10:38 +01:00