Commit graph

1431 commits

Author SHA1 Message Date
Jesse Vincent
8ca034c3db Patch for issue 946: Only able to get contacts from a primary google
account by cketti
2010-03-23 03:19:12 +00:00
Jesse Vincent
50d1d7e7aa Fix for issue 1138: New emails after the first do not play new mail ringtone until notifications are cleared by skister2 2010-03-23 02:41:45 +00:00
Daniel Applebaum
fa73f71e95 Fixes Issue 790
Tolerate malformed UIDL response.  Thanks to @bengnc for thorough
analysis in Issue 790.
2010-03-18 03:43:39 +00:00
Daniel Applebaum
76f33ba5ff Fixes Issue 1330
Flush the output stream so that small messages have bodies.  (And
presumably so that the entirety of big messages are sent.)
2010-03-18 03:23:45 +00:00
Daniel Applebaum
ec9f395498 Fixes Issue 1090
Don't try to fetch content while reporting errors.

Generate unique URL for each upload.
2010-03-18 02:50:05 +00:00
Daniel Applebaum
24d96c36da Fixes Issue 1284
Remove notifications for removed accounts
2010-03-13 05:00:01 +00:00
Daniel Applebaum
bbedf7b9e0 Fixes Issue 1314 2010-03-13 04:49:15 +00:00
Daniel Applebaum
9d5803b174 Fixes Issue 981
Allow user to turn off gesture-based control.

Also, consolidate so that gestures could be used by other subclasses
of K9Activity.  Probably should be made usable to K9ListActivity, too,
by making MyGestureDetector its own class and make it used by
K9Activity and K9ListActivity, and have the Activities implement a
callback interface for onNext and onPrevious.
2010-03-07 23:43:27 +00:00
Daniel Applebaum
f0808fb3e0 Fixes Issue 1291
Provides for the user to elect to have certain folders displayed first
in the FolderList.  Folders so elected are displayed in alphabetical
order first, then folders not so elected are displayed alphabetical
order.

No special handling is done for Inbox any more, except that it is in
"top group" by default, to preserve current behavior until the user
changes the settings.
2010-03-07 17:02:21 +00:00
Daniel Applebaum
ecc10e572f Fixes Issue 1224
Implement DEFLATE compression for IMAP communication, enabled by
default.  User can disable compression for Wi-Fi, Mobile, or Other
networks, if it causes problems or if uncompressed communication is
faster, which is possible on Wi-Fi and wired networks, especially.

"Other" is to allow for the Android platform to introduce new
networking types without having to immediately change K-9 Mail.
However, as those arise, new network types should be added as explicit
types in K-9 Mail.
2010-03-07 00:30:40 +00:00
Daniel Applebaum
c0e4220b82 Fixes Issue 1116
Fixes Issue 1278
Fixes Issue 119
Fixes Issue 1077
Fixes Issue 1238

Worked performed by danapple0 and cketti in
https://k9mail.googlecode.com/svn/k9mail/branches/issue1116

Add support for most batch ops (except move and copy) in search
results.  Add support for batch move and copy on real folders.

Increase efficiency of bulk IMAP moves and copies by doing as multiple
UID operations.

Eliminated serialization of Account objects.

Provide up-references in useful places to make all future code cleaner
and more efficient.

Fixed a bunch of draft handling

Merged from issue1116 branch, except for Account.java, which was
copied wholesale.  Account.java was manually merged in issue1116
branch at r1489

svn merge -r 1459:1489 https://k9mail.googlecode.com/svn/k9mail/branches/issue1116 .
cp ../issue1116/src/com/fsck/k9/Account.java src/com/fsck/k9/Account.java
2010-03-04 04:00:30 +00:00
cketti
6fb59467b7 Changed SmtpTransport.writeLine() to only use one OutputStream.write() call. Apparently some servers got the "be liberal in what you accept from others" part of the robustness principle wrong. When we used multiple calls in writeLine() (command + CR + LF) a separate TCP packet was send each time. It appears that those broken servers accepted the DATA command after DATA + CR and interpreted the LF as part of the actual data. This caused our headers to become part of the body because that LF was interpreted as the empty line that separates headers and body.
As a side effect of this fix sending mail could be slightly faster now due to less packets being sent.

Big thanks to Kevin Newland of Michigan Technological University for organizing a test account.

Fixes issue 799
2010-03-02 02:48:52 +00:00
Daniel Applebaum
97c7bf1d65 Hopeful (but untested code) to get updated capabilities after
successful CRAM-MD5 authentication.
2010-02-27 17:48:00 +00:00
Daniel Applebaum
f6e7d5d4c0 Fixes Issue 1252
Handle CAPABILITY response in following cases:
1) When sent as part of the banner, no longer sends explicit
CAPABILITY command

2) When sent as an UNTAGGED response to LOGIN, updates stored
   capabilities.

3) When sent as part of the TAGGED response to LOGIN, updates stored
   capabilities.

Due to odd implementation of the CRAM-MD5 authentication, the
capability updates will not happen as part of the CRAM-MD5
authentication.
2010-02-27 17:34:38 +00:00
Bao-Long Nguyen-Trong
6b5ea9feda Reverted the revered version of AttachmentProvider so that people who used the attachment on sd card can still get to their attachments 2010-02-20 20:15:21 +00:00
cketti
ec3d9eb9ea Removed code from ImapStore.internalOpen() that tried to get the path delimeter before SELECTing a mailbox. This shouldn't be a problem since the delimeter
a) is already known if the server supports the NAMESPACE capability.
b) is included in the prefix anyway (=also known if namespace was set manually).
c) isn't needed when selecting a mailbox because we currently don't support folder hierarchy. So the delimeter is included in the folder name.

Fixes issue 1217
2010-02-20 01:07:38 +00:00
Jesse Vincent
f9d39e4814 Back out Attachments-on-SD support (it's on a feature branch now, while
Bao-Long makes it extra-awesome)

This commit should revert:
r1445
r1437
r1436
r1449
r1442
r1441
r1419
r1414
r1413
2010-02-18 03:28:31 +00:00
Bao-Long Nguyen-Trong
c5851f2866 Fixed issue 698: Set default attachment preview image in the code (and not only in layout) so that whne moving from a message to another we get the right preview 2010-02-16 06:53:02 +00:00
cketti
f7094a2a8e I broke email address validation with r1447. I changed EmailAddressValidator.isValid() to only accept email addresses without name part ('foo@bar.com' but not '"snafu" foo@bar.com') because AccountSetupBasics used it to verify the email address for an account. With the old validator spaces were allowed in the email field but lead to an exception later (issue 849). Unfortunately I missed the fact that there are implicit calls to isValid() to validate email addresses e.g. in the 'To field 2010-02-15 12:51:38 +00:00
cketti
51b92aaf80 Fixes issue 1225 2010-02-14 15:51:09 +00:00
cketti
6d84f199c5 Enforce maximum line length for 8-bit encoded messages transmitted via SMTP (998 characters + CRLF).
Fixes issue 1176
2010-02-13 23:45:45 +00:00
cketti
ab4e2ca2ec Commented out enhancements introduced in r1443 so we don't loose Android 1.5 support. 2010-02-13 19:35:47 +00:00
Bao-Long Nguyen-Trong
e435d9d616 Fixed issue 1205: Attachment storage location setting now takes effect immediatly. LocalStore is also better at handling when attachment are stored in a mix of internal and external storage (migration state after a setting change) 2010-02-13 19:07:10 +00:00
cketti
7b75b07f1f Fixes issue 849 2010-02-13 17:26:54 +00:00
Daniel Applebaum
2c3da067c3 Fixes Issue 1219
At cketti's suggestion, change the methodology for counting
server-side unread messages on an IMAP server from STATUS (UNSEEN) to
SEARCH UNSEEN NOT DELETED.  STATUS (UNSEEN) does not ignore DELETED
but unexpunged messages and leads to incorrect results.

http://www.mail-archive.com/c-client@u.washington.edu/msg00929.html
http://www.mail-archive.com/c-client@u.washington.edu/msg00931.html

This variant only checks for unread messages in the last 300 messages
in the folder, so will be wrong if there are unread messages earlier
in the folder.  However, it'll be more often correct than the old
version for the marjority of users.

Also, change the opening of folders for IMAP IDLE purposes to
read-only using EXAMINE instead of SELECT.
2010-02-13 17:02:27 +00:00
Daniel Applebaum
645ce28e18 Throwing the Exception will, at least, cause the exponential back-off
to take effect.
2010-02-13 15:14:28 +00:00
cketti
ae12453a57 Implement support for android.intent.action.SEND_MULTIPLE (e.g. send multiple images from gallery)
Fixes issue 1210
2010-02-12 15:21:10 +00:00
Bao-Long Nguyen-Trong
6fe2dad5cc Added some defensive code to prevent crashes caused by the LocalStore getting in a bad state due to issue 1205 (still being worked on). This fixes issue 1214. 2010-02-11 21:16:37 +00:00
Bao-Long Nguyen-Trong
8d8233bcc0 Store attachment on sd card is now off by default (which is what it should have been in the first place) 2010-02-11 05:37:50 +00:00
cketti
2bd4f9632b Better handling of IMAP FETCH responses.
Fixes issue 1068
2010-02-10 13:52:25 +00:00
Daniel Applebaum
e83a428107 Far more advanced poll scheduler. Now it remembers that finish time
of the last successful periodic mail and computes the next start time
as an offset from that successful finish.  The ramifications of this
new method is that changing polling interval on an account does not
force delaying all accounts to poll next in the future by the new
interval.  Instead, K-9 Mail now adjusts the next poll time based on
what the next poll time should be based on the last poll finish and
the new interval.  

Example 1: In the old way, if the old polling interval was 1 hour, and
the next poll was 50 minutes away (10 minutes have passed), and you
changed the interval to 15 minutes, the poll would happen 15 minutes
from now.  In the new way, the next poll will happen only 5 minutes
from now, which is 15 minutes since the last poll.

Example 2: In the old way, if the old polling interval was 1 hour, and
the next poll was 10 minutes away (50 minutes have passed), and you
changed the interval to 30 minutes, the poll would happen 30 minutes
from now.  The next poll would then happen actually 80 minutes after
the previous poll completed.  In the new way, it'll actually happen
immediately, because the time for the next poll, based on the new
schedule, has already passed.

Similar scenarios happen when a loss of network connectivity
occurs. In the old way, polling would resume using the restoration of
connectivity as the starting point.  Each time network connectivity
was lost and restored, the next poll would be further delayed.  *If
connectivity was lost and restored frequently, a poll might never
happen!* In the new way, the next poll is rescheduled based on the
time of the last successful poll, so will be rescheduled just like it
was before the loss of connectivity.  If the time has already been
passed, the poll will happen immediately.
2010-02-10 06:18:35 +00:00
cketti
48c7189d03 Fix r1436 2010-02-09 16:57:30 +00:00
cketti
80ae0402e5 Fixes issue 1199 2010-02-09 15:41:40 +00:00
Daniel Applebaum
03a06696dc Pre-r660 we didn't have this line, and things worked better. Also see
Troy Engel's comments in Issue 936.  If this commit isn't
satisfactory, perhaps try Troy's suggestion.

Fixes Issue 936.
2010-02-09 03:34:49 +00:00
Daniel Applebaum
23e5a132d4 Provide title bar display of next polling time 2010-02-09 03:26:40 +00:00
Daniel Applebaum
c12f720ba0 Lower logging level for CoreService and provide instance class name. 2010-02-09 03:11:15 +00:00
Daniel Applebaum
49534f22fc Fixes Issue 834
Provide for setting Sent folder to -NONE- which suppresses actually
saving sent mail in any folder.

Also, eliminate logging which folders are not configured for pushing.
It was just too much logging.
2010-02-09 03:03:40 +00:00
Daniel Applebaum
790ae2e25c Fixes Issue 1194
Do both a poll and push reset when connectivity or background data
status changes.
2010-02-09 01:14:55 +00:00
cketti
7cafc8547b Removed unnecessary FIXME comment 2010-02-08 19:12:40 +00:00
cketti
033e0d40de Optional signatures on per identity basis. Original patch by jiri.tyr (thanks!) slightly modified by me.
Fixes issue 461
2010-02-08 17:47:00 +00:00
cketti
3b6cccdf7a Use Reflection to call WebSettings.setBlockNetworkLoads() to prevent info leaks via external resource loading.
Fixes issue 1183
2010-02-08 03:23:41 +00:00
Daniel Applebaum
164ee7cbfd Fixes Issue 1059
Only reschedule polling and setup pushing when necessary due to
particular setting changes.  Makes the K-9 Mail UI much more
responsive to setting changes that do not affect polling and pushing.

The poll schedule is deliberately only rescheduled when the period is
decreased.  An increase in period will still allow the next scheduled
check to happen as originally scheduled.
2010-02-07 21:23:33 +00:00
Daniel Applebaum
2f8f52fb0b Fixes Issue 1112
Fixes Issue 1034

Refresh Account from Preferences, so that it'll have a fresh copy of
all information.  Failure to do this caused the AccountSettings
Activity to show stale information when invoked repeatedly from the
same prior Activity.
2010-02-07 16:05:29 +00:00
Bao-Long Nguyen-Trong
c497485b2f Better message flag management so that we don't end up with (POP3) messages having both X_DOWNLOADED_FULL and X_DOWNLOADED_PARTIAL 2010-02-07 06:05:11 +00:00
Bao-Long Nguyen-Trong
46bff831d1 Using X_DOWNLOADED_FULL flag instead of the X_DOWNLOADED_PARTIAL on to determine if we need to show the downloading icon. Some POP3 messages carry both flags. 2010-02-07 06:00:28 +00:00
Bao-Long Nguyen-Trong
131280c3f2 Still init LocalStore.mExternalAttachmentsDir even if sd card is not ready so that the object does not end up in a bad state 2010-02-07 05:58:04 +00:00
Daniel Applebaum
1fb03a45a0 Fixes Issue 1059
Provides for menu items to quickly change the mode of displayed
folders.  Also, reorganizes the menu to have an Advanced sub-menu,
like Accounts page has.

Desparately needs a new icon for the Folders menu item.
2010-02-06 23:23:22 +00:00
Daniel Applebaum
4fa4f22f2c Fixes Issue 494
Allow for setting the Outbox to have any name, as tying it to a server
side folder does not make sense.  It is never synced.
2010-02-06 22:36:22 +00:00
Bao-Long Nguyen-Trong
8403a265d9 We still need to be able to instanciate the LocalStore when the sd card is not mounted. So we do no throw an exception then. Exception will be thrown when we try to do attachment related things 2010-02-06 15:44:21 +00:00
Bao-Long Nguyen-Trong
55dac7ee4e Added option to have attachments store on sd card
(this is still a rough implementation)
2010-02-06 15:22:59 +00:00
Bao-Long Nguyen-Trong
49b223e20c Fixed issue 140 and issue 950: for partially downloaded messages, displaying what we already have while downloading the full message in the background
TODO: Need better icon indicating that the message is being fetched
2010-02-06 14:49:36 +00:00
Daniel Applebaum
6f064e1193 Partial implementation for Issue 1059. Doesn't help those without
physical keyboards, though, and should be modified to only re-setup
pushers.  Current implementation causes a wasteful reschedule of
polling.

Also gets the help Toast for the folder up-to-date after the
FolderList/MessageList split.
2010-02-06 05:55:40 +00:00
Daniel Applebaum
9ec77a9f9a Fixes Issue 1182
Never set up K9mail-errors or the Outbox for pushing
2010-02-06 05:35:15 +00:00
cketti
f1fba69790 Added comment that states the quoted-printable encoder was taken from Apache Mime4j version 0.6. 2010-02-05 16:10:21 +00:00
cketti
c64c0a1c30 Replaced base64 as default encoding for text bodies with quoted-printable. Please use issue 1176 for discussion. 2010-02-05 14:26:09 +00:00
cketti
14ee970b18 Fixed EOLConvertingOutputStream.
write('\r');flush();write('\n'); would lead to "\r\n\r\n" instead of simply "\r\n";
2010-02-05 02:36:52 +00:00
cketti
0422cae33e Implemented data stuffing. 2010-02-05 02:32:32 +00:00
cketti
45036ae5c8 Use 8bit transfer encoding for the text body if SMTP server advertises 8BITMIME. In all other cases base64 is still used (including saved copies in IMAP "Sent" folder).
Feel free to revert this if anything breaks.
2010-02-04 23:37:50 +00:00
cketti
6480e78b97 r1396 caused trouble for some clients due to a missing "MIME-Version" header. This should fix the problem. 2010-02-04 17:28:35 +00:00
Jesse Vincent
a9b538fd09 stop views from "resetting" to previous intents on rotate. 2010-02-04 02:38:30 +00:00
Jesse Vincent
5ce80cadaa Move FolderList initialization a bit earlier so as to not explode on reuse of the activity.
Fixes issue 1164
2010-02-04 01:49:56 +00:00
cketti
88854f4123 Fixes issue 1171. 2010-02-03 23:27:33 +00:00
cketti
c6d29cb10e Fixes issue 21 (All messages are turned into multipart messages) 2010-02-03 19:56:20 +00:00
cketti
8049e90b8c Changed IMAP command "UID SEARCH (HEADER MESSAGE-ID %s)" to "UID SEARCH HEADER MESSAGE-ID %s"
Fixes issue 1031.
2010-02-03 17:25:15 +00:00
Jesse Vincent
74aac85048 Use a real hostname rather than localhost.localdomain.
Fixes Issue 45

Patch by cketti
2010-02-02 02:06:35 +00:00
Jesse Vincent
a58095aae1 URLEncode username and password for accounts, so as to not fall apart on
nice simple characters like ':' in passwords.

Patch by cketti

Fixes Issue 1155.
2010-02-02 02:06:29 +00:00
Bao-Long Nguyen-Trong
5566c79e07 Fixed issue 1143: Calling finish() on Accounts activity when auto jumping to the only one existing account 2010-02-01 15:24:27 +00:00
Daniel Applebaum
ef1abffa26 Revert r1386 because it will break many folks email sending. 2010-01-31 19:11:51 +00:00
Daniel Applebaum
d114fa1bc3 Fixes Issue 1058
Add 's' hotkey for Select/deselect
2010-01-31 15:41:26 +00:00
Daniel Applebaum
a91e3e10e2 May have some beneficial impact on Issue 21 and Issue 799.
Just removes the base64 encoding on the text/plain body parts.  Does
not make the sent messages non-multipart.
2010-01-31 15:26:02 +00:00
Jesse Vincent
c38384e134 Further refactoring to MessageList and FolderList to (hopefully) address
force-closes and inconsistent data on activity reuse. Also, removing
broken/unused code to preserve activity state across invocations.
across invocations.
2010-01-30 03:26:45 +00:00
Jesse Vincent
22e1a3f574 Rather than manually managing the back button, try to give android better back button hinting
fix our notification -> intent behavior
2010-01-29 03:57:37 +00:00
Bao-Long Nguyen-Trong
e2edcd6d66 Fixed issue 1066: Better handling on mailto URI. Code adapted from AOSP. 2010-01-28 06:25:10 +00:00
Jesse Vincent
1945dc4ad4 Clean up our back button support to be actually consistent and to not leak nearly as many activities. 2010-01-28 00:29:27 +00:00
Jesse Vincent
3ffad03e9b Fix a force-quit by going to the Accounts page after creating an account 2010-01-28 00:29:18 +00:00
Jesse Vincent
cd7432b663 astyle 2010-01-28 00:29:12 +00:00
Jesse Vincent
68efec3782 Improve our "got mail" notifications to include "To:" when they're for messages we've sent 2010-01-26 02:48:22 +00:00
Jesse Vincent
c237ffc803 Tweak our message swipes to be a little harder to accidentally trigger 2010-01-25 04:28:11 +00:00
Jesse Vincent
7fb17b889e Fix a number of assumptions about accounts in MessageLists.
Fixes Issue 1079
2010-01-24 22:26:21 +00:00
Jesse Vincent
ff390b388a Bullet-proofing for database upgrades and better fallback for failures 2010-01-24 20:41:04 +00:00
Daniel Applebaum
a68168d55e Only alert once for each poll or push, even if multiple new unread
messages are found.
2010-01-23 23:44:03 +00:00
Daniel Applebaum
ac14826485 Store push state whether or not the messages arrived already deleted. 2010-01-23 17:54:11 +00:00
Daniel Applebaum
4f65b4270e Fixes Issue 1060
Don't show messages that are already deleted on the server when we
first download them.

Also, correct item 1 from my comments on r1355.  No longer notify for
mails I sent when I selected not to be notified for mails I sent.
2010-01-23 17:39:28 +00:00
Daniel Applebaum
9cd52d5ef3 Change WakeLock management logging to verbose level (now that it is
working)
2010-01-22 05:55:58 +00:00
Daniel Applebaum
4ced2fa0e1 Only cause MailService refresh when changing a setting that needs it.
Addresses part of Issue 1059.
2010-01-22 05:54:52 +00:00
Jesse Vincent
c59aeb2c78 Patch from Scott Kister to give us better new-message notifications,
somewhat worked over by me
2010-01-21 18:49:11 +00:00
Jesse Vincent
c6058686b3 Fix a crash on swipe in the message list. Thanks to cketti.
Fixes issue 1054
2010-01-20 22:10:10 +00:00
Bao-Long Nguyen-Trong
08e570d40f Fixed issue 1046 bu ending FolderList activity after auto-opening the default folder 2010-01-20 00:21:48 +00:00
Jesse Vincent
c5fa25151a unselect->deselect 2010-01-19 02:58:17 +00:00
Jesse Vincent
2c406a58b0 When disconnecting from an SMTP server, send a quit command to be a
better internet citizen. Fixes Issue 1044.
2010-01-19 02:20:24 +00:00
Jesse Vincent
a145d3c616 "Deselect all" -> "Unselect all" (at a code level)
"Deslect all" -> "Done" (at a UI level)
2010-01-19 00:51:02 +00:00
Jesse Vincent
ae029762cf Add a new preference to always show multiselect checkboxes. 2010-01-19 00:43:52 +00:00
Jesse Vincent
23af9f3e6d Guard against fling events that only have one motionevent defined 2010-01-19 00:15:21 +00:00
Jesse Vincent
4493044340 astyle pass 2010-01-18 00:11:02 +00:00
Jesse Vincent
9301aabc8c CRAM-MD5 for SMTP is now configurable 2010-01-18 00:10:49 +00:00
Jesse Vincent
22e771ef2a Disable our not-so-hot preview generation as part of database upgrade
for now. it took a long time and got mediocre results.
2010-01-17 22:54:08 +00:00
Jesse Vincent
591ca5bc5e Fix batch operations menu
* Add an explicit configuration option for stars
* Replace now-outdated "left handed" widgets config option, now that
  select widgets are always on the left.
* since the multi-modality of the message list was now only a "toggle
  stars" option, kill that, as it was lots of code and rather redundant
2010-01-17 22:49:03 +00:00
Daniel Applebaum
4aca44c1aa Hide the explicit "ring enabled" boolean behind the ringtone selection. 2010-01-17 18:14:17 +00:00
Jesse Vincent
f3275a8473 When we've entered "selection mode" actually make sure we _show_ the
selected-item check mark.
2010-01-17 05:52:22 +00:00
Jesse Vincent
591a3af6dc Eliminate "select" mode in favor of a unified swipe and context menu -based
always-available select action.  For the moment, this means
that widgets_on_left does nothing at all. based on feedback, I may kill
the preference and multi-mode behaviour entirely in favor of "show stars?"
(and possibly "show stars on left"

Stars, "checkboxes" and color bars updated to actually fit in wide mode.
2010-01-17 04:20:39 +00:00
Jesse Vincent
0de7b15aa1 Swipe to select/deselect from touchmode 2010-01-17 04:20:22 +00:00
Daniel Applebaum
64552e2ebe Fixes Issue 977 by correcting defect introduced in r1195. 2010-01-16 16:33:23 +00:00
Daniel Applebaum
f4ceb8d2bc Fixes Issue 673
Fixes Issue 806

Make sure to close opened folders in finally blocks in
MessagingController.

Don't make another connection when deleting or copying a
message.  (Nicely speeds up copy and delete, as well.)

Another connection is still created for creating a folder while
copying or deleting (a pretty rare event), and the IMAP IDLE
connections are not re-used for user initiated activity.
2010-01-16 16:22:20 +00:00
Daniel Applebaum
a89bd8e081 Only use the IDLE timeout for the folder while actually in IDLE state.
May help with Issue 1022, Issue 952, Issue 895
2010-01-16 14:14:12 +00:00
Daniel Applebaum
f3e06b4ef5 Adjust imports for new location of remote control classes 2010-01-15 05:05:41 +00:00
Daniel Applebaum
d245e81679 Reorganize remote control pieces.
Automatically build jar file for external applications.
Create convenience functions in K9RemoteControl so that external
applications do not need to know the details of handling the Intents
and broadcasts.
Send a permission string in the broadcasts so that unauthorized
applications cannot intercept communication to authorized
applications, such as K-9 Mail.
2010-01-15 05:02:27 +00:00
Daniel Applebaum
6c22507dfb Implementation of a Receiver and Service to provide for the capability
to accept control from other Android applications.  Allows for
changing both Account-level and global settings.  Account-level
settings can be applied to a single Account or to all Accounts.

The file class file derived from src/com/fsck/k9/K9RemoteControl.java
will be bundled into a JAR file for use by external applications.

This facility will be used for:
Issue 215
Issue 730
Issue 864
Issue 884
2010-01-14 04:33:50 +00:00
Jesse Vincent
d95705af4d Speed up the page-flip animation now that we load message views so much faster. 2010-01-14 01:26:09 +00:00
Jesse Vincent
64469e4b4e ran artistic style against src/com/fsck/k9/ 2010-01-14 01:07:28 +00:00
Jesse Vincent
34379dc9be Improved batch button behavior for touch view 2010-01-14 01:07:13 +00:00
Jesse Vincent
25b9f41491 Don't automatically show the batch buttons when entering multiselect mode 2010-01-14 00:33:13 +00:00
Jesse Vincent
e7807e0cf7 "Advanced" account context menu now works right 2010-01-14 00:00:38 +00:00
Jesse Vincent
9bfc01ca32 Add a preference for the new "touch friendly" view. 2010-01-13 03:37:13 +00:00
Jesse Vincent
d5c185545b Add a "done" to the batch buttons.
Make the "done" entry in batch buttons only show up in touch mode
2010-01-13 03:37:04 +00:00
Jesse Vincent
6343f3af5a If we're in touch mode and have selected items, any item click is now a select 2010-01-13 03:36:49 +00:00
Jesse Vincent
7ab9b8ee3c Added a first-pass view optimized for high-rez devices with both select and star 2010-01-13 03:36:43 +00:00
Jesse Vincent
5617b629d3 Added a "preview" column to messages containing a brief summary of the message 2010-01-13 03:36:36 +00:00
Jesse Vincent
23e46b82ce Batch-update buttons now show up when you actually have selected items. 2010-01-13 03:36:30 +00:00
Bao-Long Nguyen-Trong
1c5d240564 Made batch op button's text sensitive to which messages are selected 2010-01-12 19:39:20 +00:00
Daniel Applebaum
14587c3f30 Eliminate pointless, useless, deprecated, NOOP, incorrectly commented call. 2010-01-12 19:28:21 +00:00
Daniel Applebaum
64525028de Move execute into a re-usable location 2010-01-12 14:09:30 +00:00
Bao-Long Nguyen-Trong
11b7157772 Guess mime type (when not specified) of attachments of received messages using file name extension so that we can open them 2010-01-12 02:06:46 +00:00
Bao-Long Nguyen-Trong
f965417479 Exclude deleted messages from search results 2010-01-12 00:59:13 +00:00
Bao-Long Nguyen-Trong
230428d16a Fixed issue 1017: Added 'Search' menu option in account list screen 2010-01-12 00:56:51 +00:00
Jesse Vincent
0bdb02dc24 Minor reformatting 2010-01-09 23:49:44 +00:00
Jesse Vincent
e49fdc9913 Added a comment about why we're setting a click handler 2010-01-09 23:49:36 +00:00
Jesse Vincent
fb223ea61d rename a paremeter to better reflect its use: nextWidget->showWidget 2010-01-09 23:49:31 +00:00
Jesse Vincent
553625b72b Comment an attribute 2010-01-09 23:49:25 +00:00
Jesse Vincent
497ca01586 swap the order of compared values for a bit more logical sanity 2010-01-09 23:25:15 +00:00
Jesse Vincent
5802b84e16 Reorder methods for better logical grouping 2010-01-09 23:25:10 +00:00
Jesse Vincent
9db97e214d Restore Bao-long's original design for "widgets on the left" being a
global config option rather than a per-account one. (But with a new
implementation.) - As we now have views that show messages across
accounts, this needed to become a global)
2010-01-09 23:02:40 +00:00
Jesse Vincent
512177cded Remove more of the old messagepassing ui update code in favor of 'runonuithread' 2010-01-09 21:47:10 +00:00
Daniel Applebaum
e0b98cac21 Correct Exception text 2010-01-09 19:49:54 +00:00
Jesse Vincent
19adadae11 actually specify the size of our BufferedOutputStream as 1k to parallel
other implementations and quiet down a consistent warning in our android
logs
2010-01-08 23:47:34 +00:00
Jesse Vincent
e1c686d40d Fix NullPointerException when the user clicks on a "new mail"
notification.  Resolves Issue 1001
2010-01-08 23:18:44 +00:00
Daniel Applebaum
81fd4749cc Properly synchronize some new methods 2010-01-08 16:55:36 +00:00
Daniel Applebaum
f29f5adc4b Eliminate carriage returns from reply and forward text.
Fixes Issue 518
2010-01-08 04:27:58 +00:00
Jesse Vincent
8285766506 Now that messageview is faster, don't start displaying the new message
until _after_ we flip.
2010-01-07 01:29:59 +00:00
Daniel Applebaum
57acd3232e Don't show account-level chips until unread count is known. 2010-01-06 14:12:19 +00:00
Daniel Applebaum
9c761419c9 Preparatory code for providing move/delete/copy/setFlag capabilities
across multiple folders.
2010-01-06 05:41:19 +00:00
Daniel Applebaum
56a4b94748 Put the color chip with read/unread controlled brightness at all
levels except MessageView
2010-01-06 05:23:32 +00:00
Daniel Applebaum
a5166e3c2d Fixes Issue 963
MessagingController was calling the MessagingListener twice for
deleted messages.  By the time the second call was made, some
Activities already had removed the message holder, so a null holder
was being put on the list.

This change should prevent the double calls, and adds protection
against have the MessageList MessagingListener called with a message
that is no longer in the MessageList.

Also, some logical cleanups.
2010-01-06 04:54:24 +00:00
Daniel Applebaum
2b37fe6864 Restore long-lost debugging line 2010-01-06 03:44:23 +00:00
Daniel Applebaum
29947ef3c9 Delete obsolete commented out code. 2010-01-06 03:40:24 +00:00
Jesse Vincent
a4510696aa It turns out that blindly enabling/disabling views is _Very_ expensive.
Now we only do it when switching messageview entries if it's actually
necessary
2010-01-04 02:11:33 +00:00
Jesse Vincent
a926086f4b Replace old message passing code with more modern runonuithread code 2010-01-04 02:06:40 +00:00
Daniel Applebaum
60a2ceb604 Fixes Issue 934 by removing excess calls to finish() 2010-01-04 00:50:19 +00:00
Daniel Applebaum
d58d1c60c0 Proper super call 2010-01-04 00:48:33 +00:00
Daniel Applebaum
c86a46deb1 Preparatory for more BroadcastReceivers 2010-01-04 00:47:11 +00:00
Daniel Applebaum
33495135ac Respect account ring setting for notifications 2010-01-04 00:41:26 +00:00
Daniel Applebaum
41729af9b2 Add explicit ring setting for notifications 2010-01-04 00:40:41 +00:00
Jesse Vincent
6caec1100c Incorrect (and ancient code) would accidentally clobber the wrong attachment
(and only one, rather than all) when deleting a message.
2010-01-03 23:23:13 +00:00
Jesse Vincent
483655fa20 Log.w shouldn't be wrapped in an "if debug" statement. 2010-01-03 20:34:22 +00:00
Jesse Vincent
6a8ea924c9 Further log cleanup 2010-01-03 02:07:21 +00:00
Jesse Vincent
eb54a99aab EOLs got twisted by something. fixing 2010-01-03 02:07:14 +00:00
Jesse Vincent
0e273893bd Further log tweaking 2010-01-03 02:00:20 +00:00
Jesse Vincent
a926911e7f rerun astyle 2010-01-03 01:50:51 +00:00
Jesse Vincent
1c5073039a Further debug/info/verbose logging cleanup 2010-01-03 01:50:41 +00:00
Jesse Vincent
875dc31d5a Log message cleanup 2010-01-03 01:50:32 +00:00
Jesse Vincent
f9e8c877ff Wrap looging in if (DEBUG) statements. 2010-01-03 01:50:25 +00:00
Jesse Vincent
953b784fb9 First pass at fixing Issue 963 (explosions when trying to iterate over a
remotely deleted message) introduced in r1204.

(Before my all-day meeting)
2009-12-29 17:06:13 +00:00
Jesse Vincent
fb6d11222a Switch from old, scary message passing to more modern "run on ui thread" for Accounts.java
40 fewer lines of code.
2009-12-29 17:05:44 +00:00
Jesse Vincent
2ef3b15c87 make sure we don't accidentally open the context menu on a message when we're in multiselect mode. 2009-12-29 17:05:17 +00:00
Jesse Vincent
3e3b4d447d Fix reversed color chip alpha 2009-12-28 12:56:59 +00:00
Daniel Applebaum
60b02909a3 Announce folder status changes when syncing gets updated unread count.
Adjust logging levels for folder sync.
2009-12-27 20:19:41 +00:00
Jesse Vincent
bbd9e56770 Actually display 250/500/1000 options for "number of messages to sync" 2009-12-27 17:47:30 +00:00
Jesse Vincent
794f515bc8 Numerous small fixes to search results 2009-12-27 17:22:57 +00:00
Jesse Vincent
a53e9d1b89 on search, only fire one start event and one end event 2009-12-27 17:22:51 +00:00
Jesse Vincent
6c383256a2 Remove duplicate code from onCompose. make starting message composition without an account actually work 2009-12-27 17:22:44 +00:00
Jesse Vincent
0a2d9b9c9f make sure search results aren't updated incorrectly on incoming messages 2009-12-27 17:22:38 +00:00
Jesse Vincent
bfaba499fe Fix the Search header on search results 2009-12-27 17:22:32 +00:00
Jesse Vincent
63b6f6bf62 Refactoring to better propagate "folder" along with messages as they're instantiated 2009-12-27 17:22:26 +00:00
Jesse Vincent
d60521f06f further push down our "is this message for us" logic. 2009-12-27 17:20:56 +00:00
Jesse Vincent
6c7782b4bd remove another alternate calling convention for addOrUpdateMessage. Code
will get still cleaner when we start propagating back message folders as objects
2009-12-27 17:20:50 +00:00
Jesse Vincent
c608ffb672 Eliminate a variant of addOrUpdateMessage that was only called once 2009-12-27 17:20:28 +00:00
Jesse Vincent
1c4a0be0da enable searching of messages 2009-12-27 17:20:21 +00:00
Jesse Vincent
21238a3084 If we get a message from listLocalMessages and we're doing a search,
assume it's for us. Later, we may want to be smarter about that.
2009-12-27 17:20:13 +00:00
Jesse Vincent
a736a4267c Only trigger our "loading" indicator if the account matches "our" account 2009-12-27 17:20:06 +00:00
Jesse Vincent
204289a4ff when opening a message for display or edit, use its notion of account, not the folder's. 2009-12-27 17:19:56 +00:00
Jesse Vincent
f6756879ef Temporarily disable "left-handed" controls if we're doing a search.
view configuration needs to move to be global for this to work right.
2009-12-27 17:19:49 +00:00
Jesse Vincent
bc61c90e1a make the auto-open folder not trigger if we're doing a search 2009-12-27 17:15:46 +00:00
Jesse Vincent
81d72a2d8c make the color chip genuinely calculated per message 2009-12-27 17:15:38 +00:00
Jesse Vincent
ed19a8284e Propagate per-message account info into MessageInfoHolder and FolderInfoHolder 2009-12-27 16:54:23 +00:00
Jesse Vincent
302deea53e addOrUpdateMessage calls now propagate the account of the found message 2009-12-27 16:54:12 +00:00
Jesse Vincent
3ad69c799d When listing off messages, make sure that our "refresh the list" fires,
even if we didn't start off empty.

This could have prevented updated messages from showing up
2009-12-27 16:54:06 +00:00
Jesse Vincent
1b74c176a2 Add multi-account search to the MessagingController 2009-12-27 16:53:59 +00:00
Jesse Vincent
70f35a537e If we loaded a message from the local store without an associated folder, load up its folder. 2009-12-27 16:53:51 +00:00
Jesse Vincent
da45b81866 minor query reformatting 2009-12-27 16:53:45 +00:00
Jesse Vincent
580a562085 Lift the generic getMessages and searchForMessages up to the "store"
level from the "folder" level so we can search for messages across
folders
2009-12-27 16:53:37 +00:00
Jesse Vincent
6dcb10add6 Lift our column list for "load messages" out to the LocalStore, as the
first part of lifting "get messages" out of "folder" for search
2009-12-27 16:53:31 +00:00
Jesse Vincent
ddd6db3a7c Made our search activity actually exist 2009-12-27 16:53:24 +00:00
Jesse Vincent
09ecd2bc9a Make it possible to instantiate a localFolder by id. 2009-12-27 16:53:16 +00:00
Jesse Vincent
4cec247699 Make it possible to populate a MessageInfoHolder without a FolderInfoHolder 2009-12-27 16:53:09 +00:00
Jesse Vincent
fe67f0a40c temporarily disable new unfinished search code 2009-12-27 16:53:03 +00:00
Jesse Vincent
47b338fb94 Move message population to the message class. 2009-12-27 16:52:57 +00:00
Jesse Vincent
0005a8ea60 Remove lies from a comment 2009-12-27 16:52:50 +00:00
Jesse Vincent
54ad16edb8 Push a "is this the right folder?" check into our "add/remove messages from the message list, to better support search 2009-12-27 16:52:45 +00:00
Jesse Vincent
81a5820e5d swap the order of two methods for readability 2009-12-27 16:52:39 +00:00
Jesse Vincent
7c8a7b1f27 Remove an old comment/obsolete code 2009-12-27 16:52:33 +00:00
Jesse Vincent
2a77001acc First steps toward adding search results 2009-12-27 16:52:26 +00:00
Jesse Vincent
9a40457a2a Remove giant commented out method - that's what we have version control history for 2009-12-27 16:52:17 +00:00
Jesse Vincent
854da2664c Unify our "guard" against syncing the outbox or errors folder 2009-12-27 16:52:06 +00:00
Jesse Vincent
e2f84c4fa8 wrap a debug message in a debug-mode check; eliminate a temporary variable 2009-12-27 16:51:59 +00:00
Jesse Vincent
94e61ab62c Extract out the listener we're using when we ask for new messages.
It may eventually get further extracted.
2009-12-27 16:51:45 +00:00
Jesse Vincent
9d417133b5 reduce duplication of code 2009-12-27 16:51:38 +00:00
Jesse Vincent
c953ff2c1b Bulletproof MessageList against not having a folder loaded 2009-12-27 16:51:32 +00:00
Jesse Vincent
5c8a0a908c Remove a lie from a comment 2009-12-27 16:51:25 +00:00
Jesse Vincent
5e0bbf18aa Extract parts of title setting code into their own methods 2009-12-27 16:51:19 +00:00
Jesse Vincent
5b907c2d94 Remove an overridden subroutine that's now a noop 2009-12-27 16:51:13 +00:00
Jesse Vincent
c8bcad6a21 Refactor and reverse logic to be a bit cleaner 2009-12-27 16:51:06 +00:00
Jesse Vincent
721e298542 Invert some logic to clean up MessageList a bit 2009-12-27 16:51:00 +00:00
Jesse Vincent
56cdfa88c9 tiny grammar fix 2009-12-27 16:50:44 +00:00
Jesse Vincent
151ae5a2a3 First pass at adding "Searchable" infrastructure 2009-12-27 16:50:37 +00:00
Jesse Vincent
9ba102599f Fix SQL statmeent 2009-12-27 16:50:28 +00:00
Jesse Vincent
9bcc991ec8 Extract out the code to "load mesages from SQL" from inside our "load messages in this folder" code 2009-12-27 16:50:21 +00:00
Jesse Vincent
9796cb6487 First rouind of extracting the "load messages from the db" column list 2009-12-27 16:50:14 +00:00
Daniel Applebaum
1ea96796d6 Add a global preference for enabling animations, beyond those that are
necessary.  Defaults to "enabled."
2009-12-27 00:54:19 +00:00
Daniel Applebaum
ea65007b99 Disable inter-message animations, except when initiated by a swipe.
Fixes Issue 926.
2009-12-26 18:31:55 +00:00
Daniel Applebaum
070fd635d4 Allow user to set a limit on the number of folders to be handled with
push technology.  This provide a layer of safety in case of
misconfiguration (accidentally setting too many folders to push using
classes), which can bog down the device till it is unusable.  On a G1,
25 folders is a very large load.  Fixes Issue 871.

Also, move some pending commands to the background to make way for
more important user interface activity.
2009-12-24 18:08:23 +00:00
Jesse Vincent
8fca99bef4 Fixes to unbreak incoming account setup after CRAM_MD5 implementation 2009-12-21 17:49:16 +00:00
Daniel Applebaum
4859ff7e8f Add wakelocks for calling between MailService and Push/PollServices.
I don't know if these are truly necessary, but they should not be
harmful and might be a big reliability boost.
2009-12-21 01:48:15 +00:00
Daniel Applebaum
41d7ca51a3 Implementation of complete IMAP two-phase "delete/expunge" behavior.
On each IMAP account, the expunge behavior can be set to expunge
messages in a folder as soon as a move or delete is performed on the
folder ("immediately"), each time the folder is polled, or only when
executed manually.

In the Message List, there is now an Expunge action in the option
menu.

In the Folder List, there is now an Expunge action in the context
menu (long-press on the folder).

For IMAP accounts, it is also possible to disable the copying of deleted messages to the
Trash folder, by setting the Trash folder to -NONE-.

Fixes Issue 536.

Separately, in WebDAV accounts, the user can now choose the
server-side equivalents of the special folders, just like for IMAP.
2009-12-20 23:13:49 +00:00
Jesse Vincent
e82bb72a97 non-downloaded messages once again have a grey background.
Fixes Issue 899
2009-12-20 06:54:30 +00:00
Jesse Vincent
7e967c6110 removed now-unused subject coloring code 2009-12-20 06:54:23 +00:00
Jesse Vincent
b8b9e20e81 Hang onto our messaging controller rather than constantly reacquiring
it.
2009-12-20 06:14:10 +00:00
Jesse Vincent
2c9fc8b997 Backwards compatibility for the CRAM-MD5 implementation 2009-12-20 06:14:04 +00:00
Jesse Vincent
3914a78b53 xargs astyle --style=ansi --mode=java --indent-switches \
--indent=spaces=4 --convert-tabs --unpad=paren
2009-12-20 05:41:43 +00:00
Jesse Vincent
5a85446779 Initial implementation of CRAM-MD5 support for IMAP and SMTP.
Patch contributed by Russ Weeks <rweeks@gmail.com> in
<605ac1c0-808a-4f67-8c4d-736eec9587f8@e27g2000yqd.googlegroups.com>
2009-12-20 05:15:20 +00:00
Daniel Applebaum
921b022fb5 Enhanced header in Accounts, MessageList and Folder to show the unread
count, scoped for the Activity, the in-progress operation, the account
on which the operation is in progress, the folder for the operation,
when appropriate, and the progress of the operation, when it applies
to multiple items.  For the MessageList, also use the determinate
progress bar to show progress for synchronization of the folder being
displayed.

Fixes Issue 924.

Also, a minor change that might help with Issue 913, by putting the
insertion of the pending command into a background thread.
2009-12-20 00:02:46 +00:00
Jesse Vincent
4f42907315 preferences doesn't actually tie to an account. it shouldn't be in the account context menu 2009-12-18 03:49:52 +00:00
Jesse Vincent
462d4098e0 Removed debugging log messages that clutter and slow the runtime app 2009-12-18 03:49:19 +00:00
Jesse Vincent
91ad70cd5d Killed a bunch of debug logging that clutters (and slows) production apps 2009-12-18 03:48:24 +00:00
Jesse Vincent
83409d78fa remove a bunch of debug logging that was cluttering production logs 2009-12-18 03:46:46 +00:00
Jesse Vincent
3f841d1494 removing debugging messages 2009-12-18 03:46:05 +00:00
Jesse Vincent
f94823cba4 Enable the new synchronous messagelist population. Perhaps
counter-intuitive, but it's a whole lot faster
2009-12-18 02:39:41 +00:00
Jesse Vincent
25306fad83 unify the synchronous and asynchronous codepaths for listlocalmessages 2009-12-18 02:36:37 +00:00
Jesse Vincent
157455f26b As part of a refactoring move the "start" callback into the subthread. 2009-12-18 02:35:46 +00:00
Jesse Vincent
dc543fa9e3 now that we have more messages coming out of the database faster,
there's less use in special-casing the first 5
2009-12-18 02:34:50 +00:00
Jesse Vincent
c3e903942d we no longer need to check the deleted flag at this layer as we do it further in. 2009-12-18 02:34:13 +00:00
Jesse Vincent
5789b385a8 first pass at working around messaging controller perf insanity
port listLocalMessagesSynchronous back into the MessagingController

revert some stuff
2009-12-18 02:33:18 +00:00
Jesse Vincent
48e1f31b43 Revert commit 829 @gcode - it was a performance optimization which added
nontrivial code complexity for what's now a nil performance gain
2009-12-18 02:32:17 +00:00
Jesse Vincent
c8bd377e76 minor refactoring to cut down on repeated method calls 2009-12-17 05:24:48 +00:00
Jesse Vincent
ce44165634 Fix our auto-expand folder behavior - Fixes issue 918 2009-12-17 03:45:37 +00:00
Jesse Vincent
9ae7934cad improve the MessageList->FolderList flow. Should fix Issue 916 2009-12-16 05:26:43 +00:00
Jesse Vincent
85b4c43e10 Revert "Initial implementation of loading only 25 rows from the message list"
This reverts commit 7056cb918e3bc71465053bff4070b8d3b28761a7.
2009-12-16 05:26:21 +00:00
Bao-Long Nguyen-Trong
18ea30d00f More fix for issue 810: Delete intents are not also broadcasted when we delete a message because it was deleted on the server 2009-12-15 19:43:46 +00:00
Jesse Vincent
dc2f752f11 Bulletproofing against running IMAP Copy/Move commands with null messagelists. Fixes Issue 914 2009-12-15 17:40:04 +00:00
Jesse Vincent
bf4e37d3b5 Revert "An attempt to make message lists start displaying messages earlier by precomputing a list item."
Sadly, it caused explosions
This reverts commit 5b321f4d0893ad5538d229b1c84f6806d0d8cbfe.
2009-12-15 04:26:53 +00:00
Jesse Vincent
34c111eb47 Kill the no-op Welcome activity to improve startup performance 2009-12-15 04:06:32 +00:00
Jesse Vincent
a1302afe75 Initial implementation of loading only 25 rows from the message list
from SQLite at once. The hope is that this will improve perceived
performance on large folders by starting message display sooner.

In the case of a background sync while we're loading, we _may_ end up
doing more work than necessary, since we implement paging by "date
received"
2009-12-15 02:52:01 +00:00
Jesse Vincent
aa4f3535eb When we load up the "Accounts" activity as K-9 starts up, jump straight
to either the FolderList or the MessageList rather than always going
through the FolderList
2009-12-15 02:51:52 +00:00
Jesse Vincent
5d34ef2f19 An attempt to make message lists start displaying messages earlier by precomputing a list item. 2009-12-15 02:51:44 +00:00
Jesse Vincent
e82bbc25ab formatting from astyle 2009-12-15 02:51:34 +00:00
Jesse Vincent
647dc827d8 Replace MessageList's outdated message-passing mechanism with runOnUiThread for improved code clarity and performance. 2009-12-15 02:51:25 +00:00
Jesse Vincent
7b811e45a1 lazify loading of message headers in LocalFolder, since they're not needed in most of our use cases. 2009-12-15 02:51:18 +00:00
Jesse Vincent
f31b2702a4 Massive rename to K9, step 1.
Conflicts:

	src/com/android/email/Email.java
2009-12-15 02:50:53 +00:00
Bao-Long Nguyen-Trong
1cd67f8e16 Fixed issue 810: Implemented delete intent broadcast using a modified patch from stephane.lajeunesse 2009-12-15 00:03:22 +00:00
Daniel Applebaum
0cd2dfb77d Implements new "Batch ops" option menu in Message List. Provides for
flag/unflag, mark as read/unread and delete.  Also provides explicit
mode changing, and select/deselect all.  Move and copy are partially
implemented, but disabled.

Desperately needs a new icon.

The "Sort by..." menu now toggles ascending/descending when the
currently selected sort mode is clicked.

Also, an ineffective change to setting the title in the Message List.
A bit more work is in order on that.
2009-12-10 05:26:16 +00:00
Jesse Vincent
5b1c5b2289 Basic code style cleanups suggested by IntelliJ 2009-12-10 03:16:51 +00:00
Jesse Vincent
54c7d93f78 Let IntelliJ optimize our import statements 2009-12-10 03:16:42 +00:00
Jesse Vincent
cd7de68186 reimplement the "list widgets on the left?" preference I'd previously complained about as an account preference 2009-12-08 07:08:05 +00:00
Jesse Vincent
6fdf69d45b Revert "Fixed issue 858: Added option to choose which side the widgets in message list will be on"
This reverts commit b334e397431225280f30e5297f73392f331f2dc3.
2009-12-08 07:07:03 +00:00
Jesse Vincent
dc61614443 Switch to UUIDs for message-id generation. They're just as unique and lighter weight to calculate 2009-12-08 04:58:33 +00:00
Jesse Vincent
95159d8121 Defer creation of a MessageId until we actually need it. This was ~75% of our message load-from-db time 2009-12-08 04:58:10 +00:00
Bao-Long Nguyen-Trong
4117175b0f Fixed issue 858: Added option to choose which side the widgets in message list will be on 2009-12-08 01:32:59 +00:00
Jesse Vincent
3ffc447302 LocalMessage doesn't bother to populate the headers of the MimeMessage backing it until writeTo is called 2009-12-07 04:46:42 +00:00
Jesse Vincent
08588779f7 Added a setMessageId method to MimeMessage rather than just explicitly setting a header 2009-12-07 04:46:36 +00:00
Jesse Vincent
244bad1115 Cleaned up style drift using astyle 1.23
find  src/com/android/email/ -name \*.java|xargs astyle --style=ansi --mode=java  --indent-switches --indent=spaces=4 --convert-tabs --unpad=paren
2009-12-07 00:56:06 +00:00
Jesse Vincent
88e6c59e7e Get K-9 building on Java 1.5 again 2009-12-06 22:41:19 +00:00
Daniel Applebaum
b47ee0b492 Fixes Issue 860
By reinstating obsolete methods that should eventually be removed.
2009-12-05 14:17:32 +00:00
Daniel Applebaum
fe01446af6 Fixes Issue 856 2009-12-05 13:47:28 +00:00
Daniel Applebaum
514b4cf121 Fixes Issue 844
Definitely, some optimizations could be made

Also, reliably display the folder name at the top of the MessageList
Activity
2009-12-04 19:13:29 +00:00
Daniel Applebaum
2c7853c539 Fixes Issue 870 2009-12-04 04:22:07 +00:00
Daniel Applebaum
8a79690c42 Fixes Issue 850
Don't try to move, copy, or delete a K9mail-errors message on the
server-side.
2009-12-02 04:09:51 +00:00
Jesse Vincent
bb3d6f352b Updated regexes for text->html
Tested to not break unix logfiles ;)

Comment #7 on issue 819 by jessev: Hide empty CC: lines in Message View
http://code.google.com/p/k9mail/issues/detail?id=819

My intent is to default to showing Subject. Date and From or To (depending   on whether you're the sender) with a button/widget/hyperlink/something to fold down   and show more detail.

--
You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

Dec  1 19:15:48 mar-adentro kernel: [ 4291.016228] usb 1-6: reset high speed USB device using ehci_hcd and address 4
Dec  1 19:15:48 mar-adentro kernel: [ 4291.308225] usb 2-5: reset high speed USB device using ehci_hcd and address 2
Dec  1 19:15:48 mar-adentro kernel: [ 4291.552221] usb 3-1: reset full speed USB device using uhci_hcd and address 2
Dec  1 19:15:48 mar-adentro kernel: [ 4292.136224] usb 5-1: reset full speed USB device using uhci_hcd and address 2
Dec  1 19:15:48 mar-adentro kernel: [ 4292.425282] usb 3-1.1: reset full speed USB device using uhci_hcd and address 3
Dec  1 19:15:48 mar-adentro kernel: [ 4292.613282] usb 3-1.2: reset full speed USB device using uhci_hcd and address 4
Dec  1 19:15:48 mar-adentro kernel: [ 4292.780373] Restarting tasks ... done.
Dec  1 19:15:48 mar-adentro kernel: [ 4292.784292] usb 3-1.3: USB disconnect, address 7
Dec  1 19:15:49 mar-adentro kernel: [ 4293.230042] ADDRCONF(NETDEV_UP): eth0: link is not ready
Dec  1 19:15:49 mar-adentro kernel: [ 4293.987736] usb 3-1.3: new full speed USB device using uhci_hcd and address 8
Dec  1 19:15:50 mar-adentro kernel: [ 4294.141687] usb 3-1.3: configuration #1 chosen from 1 choice
Dec  1 19:15:54 mar-adentro pulseaudio[1548]: ratelimit.c: 82 events suppressed
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825436] Registered led device: iwl-phy0::radio
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825459] Registered led device: iwl-phy0::assoc
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825479] Registered led device: iwl-phy0::RX
Dec  1 19:16:06 mar-adentro kernel: [ 4310.825500] Registered led device: iwl-phy0::TX
Dec  1 19:16:06 mar-adentro kernel: [ 4310.879827] ADDRCONF(NETDEV_UP): wlan0: link is not ready
Dec  1 19:16:20 mar-adentro kernel: [ 4324.261675] ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
Dec  1 19:16:22 mar-adentro kernel: [ 4326.254795] padlock: VIA PadLock not detected.
Dec  1 19:44:22 mar-adentro kernel: [ 6006.712166] usb 2-4: new high speed USB device using ehci_hcd and address 5
Dec  1 19:44:22 mar-adentro kernel: [ 6006.865987] usb 2-4: configuration #1 chosen from 1 choice
Dec  1 19:44:22 mar-adentro kernel: [ 6006.869856] scsi7 : SCSI emulation for USB Mass Storage devices
Dec  1 19:44:27 mar-adentro kernel: [ 6011.871419] scsi 7:0:0:0: Direct-Access     HTC      Android Phone    0100 PQ: 0 ANSI: 2
Dec  1 19:44:27 mar-adentro kernel: [ 6011.873138] sd 7:0:0:0: Attached scsi generic sg2 type 0
Dec  1 19:44:27 mar-adentro kernel: [ 6011.906600] sd 7:0:0:0: [sdb] Attached SCSI removable disk
Dec  1 19:44:34 mar-adentro kernel: [ 6018.102244] sd 7:0:0:0: [sdb] 3862528 512-byte logical blocks: (1.97 GB/1.84 GiB)
Dec  1 19:44:34 mar-adentro kernel: [ 6018.110282]  sdb: sdb1
Dec  1 20:00:57 mar-adentro pulseaudio[1548]: ratelimit.c: 1 events suppressed
Dec  1 20:28:13 mar-adentro pulseaudio[1548]: ratelimit.c: 2 events suppressed
2009-12-02 03:16:31 +00:00
Jesse Vincent
bd09b880e9 Cache the message subject in a localMessage, rather than roundtripping through a MIME message 2009-12-01 13:45:28 +00:00
Bao-Long Nguyen-Trong
e354ba17b6 Added unset functionality to batch 'Read' and 'Flag' buttons. We are giving priority to setting the flags. So unsetting only happens if all selected messages do not have the flag set. 2009-12-01 00:50:19 +00:00
Daniel Applebaum
1593678cfe Fixes Issue 847 2009-11-30 23:37:46 +00:00
Jesse Vincent
c796897f36 Fix focus of flag/read toggles in bulk-update mode 2009-11-30 23:23:27 +00:00
Daniel Applebaum
87673c91a5 Implement Bao-Long's suggestion to modify
LocalStore.purgeToVisibleLimit only to work on undeleted messages.

Convert LocalStore.clear() to use the new DELETED column.

Make markAllAsRead only work on undeleted messages.
2009-11-30 04:57:29 +00:00
Jesse Vincent
b54dab0c7f remembering next/prev will work better if they don't use the same constant 2009-11-30 04:14:24 +00:00
Jesse Vincent
9552114075 actually set the deleted flag when purging a message. should help perf a bit 2009-11-30 04:03:16 +00:00
Jesse Vincent
2c1dad5554 when we go into a folder for the first time, jump to the first message being displayed rather than the widget at the end of the list 2009-11-30 04:03:08 +00:00
Jesse Vincent
da8ad69366 deleting messages in messageView now preserves the direction the user was "travelling" in before the delete 2009-11-30 04:03:00 +00:00
Jesse Vincent
4f5c9c8b3c Now that our not-deleted-messages mode works, actually use it in messagelists 2009-11-30 04:02:51 +00:00
Jesse Vincent
299cd9a07c add "deleted" to our default database indexes. (wants some query analysis at the SQLite level) 2009-11-30 04:02:43 +00:00
Jesse Vincent
ed4685e82d we need to generate valid sql in the not-yet-used "not deleted" mode. Thanks to danapple0++ 2009-11-30 04:02:34 +00:00
Daniel Applebaum
3126298b46 Bulk delete for WebDAV 2009-11-29 18:33:42 +00:00
Daniel Applebaum
1b3d0eb992 The closest thing to bulk delete for POP3. Stupid POP3 has no
multiple delete command, but at least we can index UIDs in one shot.
2009-11-29 18:18:52 +00:00
Daniel Applebaum
c7e7b9beda Bulk deletion for IMAP and stub for other Stores. 2009-11-29 18:07:34 +00:00
Daniel Applebaum
f1abdbb769 Bulk flagging (read/unread, flag/unflag) implemented.
Message List batch ops wired to bulk flagging.

Manage batch button state when messages are deleted (from outside
agents) while in batch mode.

Remove throws clause from Folder.close() to make it easier to close
folders where necessary.

Eliminate some cruft from MessageList

Consolidate unreadMessageCount fetching in notifyAccount
2009-11-29 16:55:35 +00:00
Daniel Applebaum
61319d8c21 Fixes Issue 835 2009-11-29 06:25:03 +00:00
Daniel Applebaum
d871d2d2ee Fixes Issue 827
Fixes Issue 734

On reconnection, IMAP IDLE folders will now fetch up to the most
recent 10 message that arrived while a IDLE connection was not
available.

Fixes Issue 232

A serving of NAMESPACE-based auto-configuration on the side.  If the
IMAP prefix is empty, and the IMAP server supports NAMESPACE, use the
IMAP prefix supplied by NAMESPACE.  Also, if the user manually puts
the separator as the last character in the prefix, don't append the
separator.

Also:
Improved reliability of IMAP IDLE incoming message and flag state
change handling.  Reduction (but not elimination) of multiple
connections under startup conditions.
2009-11-28 14:51:44 +00:00
Jesse Vincent
900bcb434c Now that we have multiselect mode, kill the "quick delete" mode. 2009-11-28 05:09:28 +00:00
Jesse Vincent
96958569b0 huge improvements to render quality of plaintext messages. 2009-11-28 04:56:58 +00:00
Jesse Vincent
46ddc7d8e5 text->html now does a better job converting
---------------------------------------------------------
2009-11-28 04:56:47 +00:00
Jesse Vincent
cdf0693e27 remove unused constants 2009-11-28 01:59:52 +00:00
Jesse Vincent
8216640fe8 if chain -> switch 2009-11-27 23:45:30 +00:00
Jesse Vincent
7707270b31 Remove 100loc of custom date formatting code which worked around a deficiency in the android 1.0 API 2009-11-27 21:52:48 +00:00
Jesse Vincent
5727cb3c3b remove a temp variable 2009-11-27 21:52:36 +00:00
Jesse Vincent
e2fd488e66 Fix multiselect so that one can use touch or the dpad or scroll ball to select
TODO: a preference to disable this behavior for folks who don't think like me
2009-11-27 03:28:26 +00:00
Jesse Vincent
ae33aab57a only making the buttons active on the first click leads to weird race
conditions.
2009-11-27 03:28:16 +00:00
Jesse Vincent
769985dd48 cleaned up enable/disable activate/deactivate of multi-select action widgets. 2009-11-26 19:51:54 +00:00
Jesse Vincent
ab706b6b31 abstract out the batch-button visibility settings 2009-11-26 17:43:51 +00:00
Bao-Long Nguyen-Trong
3525337075 1st wired up version of multi-select + delete button (still rough on the edges) 2009-11-26 15:47:58 +00:00
Daniel Applebaum
69e7243480 Naive, untested, bulk operations for the new multi-select
user-interface work.

Performance optimizations to be done later.
2009-11-26 05:30:13 +00:00
Daniel Applebaum
fc91603429 Major IMAP IDLE rework:
1) Actual message sync on MessagingController uses same connection as
   IDLE for faster and more efficient push operation.  Uses fewer
   connections to the server.

2) More aggressive handling of untagged responses should more reliably
   get flag changes and new messages when many events happen at once.

3) Simplification of new mail notification

4) Push mail now respects the folder visible limit

5) When multiple untagged FETCH responses arrive en bloc, the actual
   message flags and UIDs are fetched with a single request
2009-11-26 05:10:12 +00:00
Jesse Vincent
e4427f4f17 Added a "show no widgets" entry into the widgets rotation.
Eventually, we should have a preference per account for whether listview
starts in no-widgets or flag mode.
2009-11-25 16:21:01 +00:00
Jesse Vincent
0f85f22495 remove a useless focus handler 2009-11-25 15:41:40 +00:00
Jesse Vincent
ae26b0eb0c better dpad left/right to cycle widgets 2009-11-25 15:35:25 +00:00
Jesse Vincent
0e821f575a first pass at toggling all widgets at once 2009-11-25 02:52:33 +00:00
Jesse Vincent
622155a57a make the Delete, Select and Star buttons share the same screenspace.
right now we toggle per row. next up is toggle all at once
2009-11-25 02:25:56 +00:00
Jesse Vincent
695aa42347 added code for inline delete buttons 2009-11-25 02:25:44 +00:00
Jesse Vincent
9cac2cd5b7 applied compromise code reformatting:
find  src/com/android/email/ -name \*java|xargs astyle --style=ansi \
    --mode=java  --indent-switches --indent=spaces=4 --convert-tabs \
    --unpad=paren
2009-11-25 00:40:29 +00:00
Bao-Long Nguyen-Trong
e3727e1d91 Very early shot at batch message action UI 2009-11-24 18:05:53 +00:00
Daniel Applebaum
9971b9e8c5 Fix notifications for messages that arrive via IDLE 2009-11-23 03:17:03 +00:00
Daniel Applebaum
694ba471d4 Eliminate race condition which causes multiple connections to IDLE
simultaneously
2009-11-23 03:16:44 +00:00
Jesse Vincent
ee463b32ff Overhaul our setup wizard to have a more reasonable bottom bar and to reuse that layout code where possible; standardize the id of the 'next' button 2009-11-23 00:23:34 +00:00
Jesse Vincent
8e0655d915 add double-tap at top or bottom to jump to the top or bottom of the message 2009-11-22 21:23:49 +00:00
Jesse Vincent
30459125aa Add a message-flip animation. Long-term, we want a ViewSwitcher instead 2009-11-22 21:23:36 +00:00
Jesse Vincent
027e213bb2 With this change, K-9 does a better job of loading embedded images by default for me. 2009-11-22 21:23:27 +00:00
Jesse Vincent
47cbf87e6d Disable built-in zoom controls for now. they make flipping way too hard. 2009-11-22 21:23:09 +00:00
Jesse Vincent
7a46a584c6 When flipping messages, be sure we jump to the top as we display 2009-11-22 21:23:00 +00:00
Daniel Applebaum
3f98e3204b Fixes Issue 784 2009-11-22 19:42:44 +00:00
Daniel Applebaum
0f24c6a28b Fix defect in r996
Prepare for disabling notification on messages the account identities sent.
2009-11-22 19:02:57 +00:00
Daniel Applebaum
5977809fe0 Fixes Issue 657
The Nays have it.
2009-11-22 17:34:29 +00:00
Daniel Applebaum
c732f14c3d Fixes Issue 801 2009-11-22 17:15:11 +00:00
Daniel Applebaum
2e50cc5444 Log when attachment viewer cannot be found 2009-11-22 17:13:06 +00:00
Daniel Applebaum
b551850827 Fixes Issue 188
Fixes Issue 394
Fixes Issue 763

Completely new Services architecture providing proper Service
lifecycle management.
  Long running tasks in MailService are executed in a separate thread,
  but the service is not stopped until the tasks are complete.

  SleepService for providing synchronous sleeps with proper WakeLock
  integration.

  Mail polling logic moved from MailService to PollService

  PushService to keep application from being killed while push is
  running.

Improved logging of IMAP protocol, including logging folder name,
thread and connection hashcode.

Don't put a failed connection back into the IMAP mConnections
storage. 

IMAP IDLE uses new SleepService for delaying between failed connection
attempts (allows phone to sleep and provides better reliability)

Use a ThreadLocal for ImapPusher wakelocks

Component enablement/disablement in Email is done only when components
are out of phase with desired state. (Issue 188)
2009-11-22 17:01:04 +00:00
Jesse Vincent
c6b15012e0 tidied activity code: astyle --style=java -s4 --brackets=attach --convert-tabs 2009-11-21 22:45:39 +00:00
Jesse Vincent
094215ebe0 Reindent MessageView.java in advance of refactoring 2009-11-21 22:45:14 +00:00
Bao-Long Nguyen-Trong
04717b817a Fixed error handling code when trying to view a message that does not exists
This code was lost during the merge of issue4-1.x branch
2009-11-21 00:11:57 +00:00
Jesse Vincent
8a6180fa21 Swap swipes based on people with real devices pointing out that I got em backwards. 2009-11-19 15:26:45 +00:00
Daniel Applebaum
a7a46ac6fa Fixes Issue 673 2009-11-19 15:19:23 +00:00
Jesse Vincent
031c1e5358 left and right swipes in message view. 2009-11-19 06:03:59 +00:00
Bao-Long Nguyen-Trong
59bc0ac467 Merge from 2.0-MAINT branch 2009-11-19 00:42:27 +00:00
Jesse Vincent
1e57188f38 First pass at stopping the "Sending messages" notification when there's nothing to send
A better fix would take into account not sending flagged messages
2009-11-18 03:06:23 +00:00
Jesse Vincent
582682b99d make docs lie a little less 2009-11-18 03:06:14 +00:00
Jesse Vincent
b91aad8f59 FolderUids -> MessageUids (working to remove assumptions about folders) 2009-11-18 03:06:05 +00:00
Jesse Vincent
c392e778e6 Add "starring" to MessageView 2009-11-18 01:59:41 +00:00
Jesse Vincent
fcd8ee9aeb Implement References/In-Reply-To/X-User-Agen. Fixes issue 42. Patch from e.w.stemle 2009-11-17 21:13:29 +00:00
Jesse Vincent
35ab566f43 Cleanup of the LocalFolder perf optimization from last night. 2009-11-17 19:25:46 +00:00
Jesse Vincent
c6b5a626bd Merge branch 'skip-deleted-in-sqlite'
* skip-deleted-in-sqlite:
  Create branch skip-deleted-in-sqlite
  First pass at doing our "don't show deleted messages in lists" filtering in SQL
2009-11-17 16:54:50 +00:00
Jesse Vincent
b328cbe991 A first implementation of "starred" messages in portrait list views 2009-11-17 16:52:23 +00:00
Jesse Vincent
3bc8a0a8d4 Make item-clicks in MessageList a little less convoluted 2009-11-17 16:52:10 +00:00
Bao-Long Nguyen-Trong
3f4c4a97cf Added file missed in r948 2009-11-17 00:04:10 +00:00
Bao-Long Nguyen-Trong
1a64826e32 Fixed issue 44
. Added content-type detection using file name extension
. This adds better integration with OI File Manager which implements the ACTION_GET_CONTENT intent
2009-11-16 20:51:34 +00:00
Bao-Long Nguyen-Trong
aa18be9c96 Fixed issue 762
+ more draft handling fixes
2009-11-16 20:47:27 +00:00
Jesse Vincent
4cc22f8208 Remove duplicated "make this account the default" option during setup 2009-11-16 19:33:23 +00:00
Jesse Vincent
84ab290046 Give the user the choice of whether to enable Push as they create a new IMAP account.
TODO: explanatory prose underneath
2009-11-16 19:33:01 +00:00
Jesse Vincent
849a1de91e rephrase the status message to put Push back to first with the space I so desperately craved 2009-11-16 19:32:39 +00:00
Bao-Long Nguyen-Trong
8557cefabc Fixed issue 761 2009-11-16 19:27:57 +00:00
Jesse Vincent
ae4af71379 remove dead code that someone commented out rather than delete. 2009-11-16 18:35:16 +00:00
Jesse Vincent
1c5289f412 Make the status messages for folders that are being synced with push a bit prettier 2009-11-16 18:34:46 +00:00
Jesse Vincent
b9509e73f2 Fix Issue 774 - Don't show folder choosers before we have a working account 2009-11-16 18:23:56 +00:00
Jesse Vincent
21481af667 Slightly better MessageView fit-to-screen and scrollbar flow 2009-11-16 16:42:15 +00:00
Daniel Applebaum
f14ecdd66e Fixes Issue 574 2009-11-15 15:19:39 +00:00
Jesse Vincent
6596fb901d First pass attempt at fixing the "Android 2.0 breaks contacts lookup" issue 2009-11-15 05:59:16 +00:00
Daniel Applebaum
eec4a96617 Fixes Issue 587
"Delete from server" is now the default delete policy for IMAP and
WebDAV accounts.  POP3 accounts still default to "Do not delete from
server"
2009-11-15 01:21:19 +00:00
Daniel Applebaum
730352c08c Fixes Issue 752 2009-11-15 01:12:26 +00:00
Daniel Applebaum
133964fbf3 Fixes Issue 59 (provides 2 - 24 poll check periods)
Improves Issue 742 (makes push settings more obvious)
2009-11-14 15:07:12 +00:00
Daniel Applebaum
84a1e0647d Fixes Issue 742 2009-11-14 14:25:09 +00:00
Daniel Applebaum
4a2c94938a Record permanent failures into K9mail-errors 2009-11-13 13:52:09 +00:00
Bao-Long Nguyen-Trong
27caf93e11 Fixed issue 589 2009-11-13 08:14:10 +00:00
Bao-Long Nguyen-Trong
ff2be7e643 Fixed issue 753 2009-11-13 07:36:05 +00:00
Jesse Vincent
df16bb2766 Add the German version of "re:" to our reply regex 2009-11-13 04:03:36 +00:00
Jesse Vincent
719f7dcd2d Enable fast scroll from "pick a folder" dialogs 2009-11-13 03:20:40 +00:00
Jesse Vincent
6daeb6b749 Sort the "NONE" folder to the top of the auto-expand folder list 2009-11-13 03:20:31 +00:00
Jesse Vincent
393519d352 Now that we are 1.5+, untodo the 1.5 style quick-sliders in message and list views 2009-11-13 00:55:52 +00:00
Daniel Applebaum
eb7fd69ed6 Fixes Issue 747. 2009-11-11 00:45:19 +00:00
Bao-Long Nguyen-Trong
cf143cda86 Fixed issue with reply icon in subject in message view screen not being set properly when navigating around using up and down arrows 2009-11-09 06:02:46 +00:00
Bao-Long Nguyen-Trong
5f96961cd6 Fixed bug where intent is broadcasted for non new emails 2009-11-09 03:52:59 +00:00
Daniel Applebaum
22bfa74ddf Fixes Issue 733 2009-11-07 20:27:30 +00:00
Daniel Applebaum
0baf9d6134 Fixes Issue 722 2009-11-07 20:16:15 +00:00
Daniel Applebaum
90198382a4 Increase chance of Push mail picking up messages when connectivity is
restored.
2009-11-07 16:51:08 +00:00
Daniel Applebaum
b9642ee5f3 Fixes Issue 738
Fixes Issue 133

Really, just displays a Toast and allows K-9 to continue in some
situations that otherwise cause a crash.  Will hopefully allow users
of Android 2.0 to use K-9, but may just provide better info about what
is going wrong.
2009-11-07 16:21:47 +00:00
Daniel Applebaum
2f4b9a1178 Issue 737
Don't crash if unable to find the owner name.  The actual owner name
fetching code will need to be updated for Android 2.0, but this will
help for now.
2009-11-07 15:32:05 +00:00
Daniel Applebaum
1983a7e2a7 Correct unread message counts for stores (like Pop3Store) which are
unable to provide a server-side tracked unread message count.
2009-11-03 03:21:42 +00:00
Daniel Applebaum
eabc9af9b3 Fixes Issue 668
Fixes Issue 577

K-9 has earned its Canine Good Citizen.

K-9 now respects the Android-global Background data preference, by
default.  However, there is an override, allowing K-9 to ignore the
global preference, by either always running around and synchronizing
in the background, or staying put and not synchronizing.

A user can now elect to turn off mail synchronization across all
accounts in either the K-9 Preferences page by setting Background
synchronization to Never, or leaving that value as "When 'Background
data' is checked" and deselecting the Android-global Background data
preference.
2009-10-31 18:51:59 +00:00
Daniel Applebaum
581486fbd5 Eliminate secret debug preferences activity. Add debug preferences to
global preferences.
2009-10-31 17:10:54 +00:00
Daniel Applebaum
8951363442 Fixes Issue 448
Fixes Issue 651
2009-10-28 12:45:22 +00:00
Daniel Applebaum
25e36da75d Fixes Issue 712. 2009-10-25 23:56:25 +00:00
Daniel Applebaum
ffe930442f Fixes Issue 573
Patch from mpredosin, supplied in Issue 573 on Aug 05, 2009.
2009-10-25 13:58:08 +00:00
Daniel Applebaum
f43b13446e Comment out intended comment. 2009-10-25 13:47:59 +00:00
Daniel Applebaum
75868b5aa4 Enhancements to WebDAV (Exchange) capabilities:
1) Automatically add / separators if not supplied by user.  Fixes
   Issue 290

2) Enable Move and Copy.

3) Enable setting a message to unread state.

4) Set authentication header for downloading and sending messages, so
   that those functions work with sites using Basic authentication.

5) Don't swallow log Exceptions.  Instead, allow Exceptions to
   percolate up to higher levels so that they can be logged into
   K9mail-errors.

6) Provide appendMessages function, so that Drafts get stored on the
   server.

7) Enable server-side message deletion, using user-selected Trash
   folder.
2009-10-25 02:58:26 +00:00
Daniel Applebaum
ec25d145d6 Added Account Settings to the message list option menu. Did this
because a user that has auto-open set to a particular folder might
never get to the actual folder list which contains the option menu
containing Account Settings.  (There's been one comment in the Market
pertaining to this.)
2009-10-24 17:10:02 +00:00
Daniel Applebaum
99b239fa71 Issue 675
Prevent a crash, and puts up a Toast, but you have to start over
setting up the account again.

This page needs an effective Back button.
2009-10-23 01:20:12 +00:00
Daniel Applebaum
e315ee9156 Issue 708
Basically, patch submitted by themaninthesuitcase in Issue 708, but
consolidated into a single method.
2009-10-23 01:03:51 +00:00
Bao-Long Nguyen-Trong
09fa19affa Fixed issue 556 2009-10-22 15:54:49 +00:00
Daniel Applebaum
959404cc68 Issue 4: Implements Push Mail for IMAP accounts using IMAP IDLE
This commit contains the entirety of the changes performed in the
issue4-1.X branch from revision 718 through revision 851.  Because the
issue4-1.X branch was up-to-date with trunk revision 847 at revision
849, the source of this commit was not an "svn merge".  Instead, it is
merely a copy of all changed files from the issue4-1.X branch to my
trunk working copy and a straight commit.

Also:
Issue 551
Issue 628
Issue 650
Issue 654
Issue 656
Issue 682
Issue 696
2009-10-22 00:41:06 +00:00
Bao-Long Nguyen-Trong
78da963031 . MessageListener.synchronizeMailboxNewMessage() does not requires a context to be passed anymore.
. We use the application as context when broadcasting message received intents
2009-10-21 04:48:28 +00:00
Bao-Long Nguyen-Trong
4ffe75fa85 Refactored intent constant classes 2009-10-20 05:27:06 +00:00
Bao-Long Nguyen-Trong
7323fe67fd Minor cleanup so that we only broadcast the message received intent once 2009-10-20 04:59:02 +00:00
Bao-Long Nguyen-Trong
a59fcf3e89 . Fixed issue 607
. Added intent for viewing individial messages
2009-10-19 19:35:31 +00:00
Bao-Long Nguyen-Trong
5186c3610f Fixed issue 331: Now delete temporary draft created by screen rotation when email is sent or discarded 2009-10-18 03:34:54 +00:00
Bao-Long Nguyen-Trong
b8f4fdb882 Fixed issue 684: Only accept callbacks if the message uid of the callback is the same one we invoked the controller with. 2009-10-18 03:30:42 +00:00
Bao-Long Nguyen-Trong
4e2ba837aa Fixed issue 663: The source message of the reply was re-loaded every time the screen is rotated populating all fields on top of the framework handling the screen rotation 2009-10-18 03:22:17 +00:00
Bao-Long Nguyen-Trong
b3616e379d Moving a few more things to UI thread as message are not displayed reliably 2009-10-07 18:19:56 +00:00
Bao-Long Nguyen-Trong
791d99fc7a Putting the switch from loading... to downloading.. to the UI thread for this to happen more reliably 2009-10-07 17:23:34 +00:00
Bao-Long Nguyen-Trong
82491ab42b Fixed issue 671 by reverting the part of r788 that introduced it 2009-10-05 04:41:26 +00:00
Daniel Applebaum
b414e4d77d svn merge -c 806 ../issue4-1.X/ .
r806 merged to trunk from issue4-1.X
2009-10-03 16:08:42 +00:00
Daniel Applebaum
02889cfe37 svn merge -c 794 ../issue4-1.X/ .
svn merge -c 800 ../issue4-1.X/ .
svn merge -c 803 ../issue4-1.X/ .

Issue 654
2009-10-03 06:11:29 +00:00
Bao-Long Nguyen-Trong
3bb0d08855 Fixed issue 620
+ removed some dead code in the way

Note: K9 crashed once over ~48hrs so we may need to rework how we use message listener in general
2009-10-03 04:26:22 +00:00
Bao-Long Nguyen-Trong
02e41e6da0 Minor perf optimization using addHeader() instead of setHeader() 2009-09-26 22:47:13 +00:00
Bao-Long Nguyen-Trong
41563f1d64 Minor changes to help with issue 636 2009-09-25 21:06:10 +00:00
Bao-Long Nguyen-Trong
931cc4c243 Minor changes to help with issue 636 2009-09-25 21:02:25 +00:00
Bao-Long Nguyen-Trong
ac022ce467 . Fixed issue 626 and issue 528:
Date header was  not set properly
2009-09-25 19:12:37 +00:00
Bao-Long Nguyen-Trong
c2ca739293 . Added defensive code against empty self BCC address
This fixed issues 639 & 646
2009-09-25 17:02:50 +00:00
Daniel Applebaum
f3312eb064 Eliminate failing Toast. Perhaps it can be restored, if the Toast is
generated in the message handling thread.
2009-09-24 02:09:57 +00:00
Daniel Applebaum
b4b1b081a7 Issue 624
Don't bother going to server while creating an ImapMessage from a UID
2009-09-24 01:06:24 +00:00
Bao-Long Nguyen-Trong
75636b697c Display 'Downloading...' instead of 'Loading...' when we are fetching a message from remote store 2009-09-17 17:40:05 +00:00
Daniel Applebaum
08cd19e5a8 svn merge -x -w -c 760 ../issue4-1.X/ .
Improve reliability of message viewing and composing while still using
MessagingController worker queues

svn merge -x -w -c 761 ../issue4-1.X/ .

Put loading a message from the LocalStore into a ThreadPool executor,
like was done previously in MessageView.  Remote loading still goes
through the work queue.
2009-09-17 03:43:02 +00:00
Daniel Applebaum
5d5c65bee3 svn merge -x -w -c 756 ../issue4-1.X/ .
Increase reliability of MessageView when it is paused then resumed
2009-09-16 12:31:52 +00:00
Bao-Long Nguyen-Trong
d61c7a192c Removed some logging (too verbose) 2009-09-15 05:20:12 +00:00
Daniel Applebaum
ac6358ec5c svn merge -c 749 ../issue4-1.X .
ImapStore.ImapFolder is not thread-safe, so all access to the remote
folders must be done through the work processing of the
MessagingController.
2009-09-15 04:28:37 +00:00
Bao-Long Nguyen-Trong
a4965f042c Fixed issue with encoding of email addresses in the header with non ascii characters. The way were doing it was only compatible with certain email clients (Thunderbird) but not with K-9 itself 2009-09-10 17:33:19 +00:00
Bao-Long Nguyen-Trong
736d330e38 Fixed issue 560: This was happening only when the user has only one account 2009-09-10 17:31:11 +00:00
Bao-Long Nguyen-Trong
c11c484718 Fixed issue 261:Commas within diplay names were considered as delimiters
--> Using built in Rfc822Tokenizer
2009-09-08 07:31:02 +00:00
Daniel Applebaum
3ca12e2bb9 Issue 478 2009-09-03 16:13:00 +00:00
Daniel Applebaum
e9a17ada17 Prevent crashes if user attempts to sort while folder is loading. 2009-08-29 23:08:07 +00:00
Daniel Applebaum
44a52d54a7 Don't crash when no suitable intent found 2009-08-29 22:55:14 +00:00
Daniel Applebaum
d50a16c6b4 Issue 530 2009-08-29 22:40:52 +00:00
Daniel Applebaum
65d7f2180a Issue 505 2009-08-29 22:17:49 +00:00
Daniel Applebaum
8785762986 Issue 575
Partially the patch supplied by mpredosin.

Partially restoration of other lost code.
2009-08-29 22:11:13 +00:00
Daniel Applebaum
033632b3ba Issue 503
Restore lost confirmation dialog.
2009-08-29 21:49:19 +00:00
Daniel Applebaum
280ed0dadd Issue 530
This new method will be useful later.
2009-07-24 05:12:17 +00:00
Daniel Applebaum
f6c6012e11 Issue 553 2009-07-24 03:55:54 +00:00
Daniel Applebaum
f1232a119a Addresses mpredosin's comments on r420 2009-07-24 03:48:49 +00:00
Jesse Vincent
16a31428b5 patch from typester to fix UTF8 headers (such as subject) Resolves issue 534 2009-07-02 05:49:09 +00:00
Bao-Long Nguyen-Trong
6c820c9f75 Removed image/gif from exclusion list so that the images can be viewed and save to SD card 2009-07-02 00:27:17 +00:00
Bao-Long Nguyen-Trong
a912f7aed5 Cleaned up message loading threading solving issues 249 and 524 2009-07-01 21:31:51 +00:00
Bao-Long Nguyen-Trong
2521e032a7 Fixed issue 522 and some minor navigation issue 2009-06-26 18:15:41 +00:00
Bao-Long Nguyen-Trong
c1ec077720 Added comment to document why we override MimeMessage.setRecipients() 2009-06-26 07:03:25 +00:00
Bao-Long Nguyen-Trong
6f8c83e8e3 Restored LocalMessage.setRecipients() and added checks for null and empty address list that allow to unset a recipient list 2009-06-26 06:55:32 +00:00
Bao-Long Nguyen-Trong
99562b8e01 Fixed issue 499 by removing LocalMessage.setRecipients() method to use the super implementation instead.
Anyone knows why was this method overridden in the first place?
2009-06-25 20:25:05 +00:00
Bao-Long Nguyen-Trong
b572c8e065 Fixed issue 497 2009-06-25 17:05:50 +00:00
Bao-Long Nguyen-Trong
3707e0e666 Fixed issue 519 and more navigation issues 2009-06-24 17:51:41 +00:00
Bao-Long Nguyen-Trong
9bf3c9b45a . Fixed navigation issue when going back from message 2009-06-23 16:48:08 +00:00
Bao-Long Nguyen-Trong
e6132286a0 FIxed issue 501 2009-06-23 14:57:16 +00:00
Bao-Long Nguyen-Trong
13cc3899d6 . Fixed issue 504: Added feedback (spinning progress on top right) when checking email in message list
. Added error message toast when checking email fails in message list
2009-06-21 17:20:37 +00:00
Bao-Long Nguyen-Trong
47a8537f08 . Clicking on the new mail notification gets you to the default folder if any else to the folder list 2009-06-20 04:06:44 +00:00
Jesse Vincent
2cb5bdebb3 Set the MessageId header, rather than Adding it when restoring from the local store. Hopefully, this will fix issue 498 2009-06-18 14:54:06 +00:00
Bao-Long Nguyen-Trong
98fe0cc25f Fixed issue 476
TODO: Add confirm dialog
2009-06-16 15:05:11 +00:00
Bao-Long Nguyen-Trong
3ea149bd37 Fixed issue 496
Note: No putting 'Account Settints' and 'Accounts' menu option on MessageList as it does not belong there
TODO: Add more menu options: Mark All As Read, Folder Settings, etc...
2009-06-16 13:58:27 +00:00
Bao-Long Nguyen-Trong
33b1d1b04f Fixed issue 496
Note: No putting 'Account Settints' and 'Accounts' menu option on MessageList as it does not belong there
TODO: Add more menu options: Mark All As Read, Folder Settings, etc...
2009-06-16 13:55:49 +00:00
Bao-Long Nguyen-Trong
c6f6e995f6 . Fixed issue 77 and issue 489: It was a bug in Cc and Reply-To header parsing 2009-06-15 05:04:03 +00:00
Bao-Long Nguyen-Trong
9dfe3d8f7b Fixed issue 126
+ display both date and time on old emails
2009-06-14 14:03:30 +00:00
Daniel Applebaum
339c8e247b Restore case-insensitive sort, but fall back on case sensitive, just
in case the case-insensitive version returns that the two folders are
equal during the insensitive comparison.
2009-06-09 04:01:04 +00:00
Daniel Applebaum
770032d960 Issue 481
When in MessageList, Check mail should only sync the displayed folder.
2009-06-09 03:23:07 +00:00
Daniel Applebaum
10b9b0a05b Issue 117
Issue 30

Provide support for multiple identities.  Identities can be managed in
the Account Settings.  While composing a message, an identity can be
chosen for sending.  Identity information and signature edits are
saved in a header field, so that they survive being synced to the
server and back.

Provide support for editing the quoted text, either for replies or
forwards.  The quoted text is immediately editable, in a separate
editor from the main body.  When saved in a draft, the two are
contatenated, but the length of the main body is saved with the
identity information, and is used to split the two parts again, when
opening the draft.
2009-06-09 03:11:35 +00:00
Daniel Applebaum
8e52a4efed Fix for my comment on r581 2009-06-09 02:10:49 +00:00
Bao-Long Nguyen-Trong
b7a846492a Minor performance optimization 2009-06-08 00:41:29 +00:00
Bao-Long Nguyen-Trong
84d7e0081b . Fixed 'Compose' and 'Accounts' menu options 2009-06-07 23:43:42 +00:00
Bao-Long Nguyen-Trong
b20649f2ad Added 'add to contact' feature when one clicks on the from address in message view (code taken from AOSP) 2009-06-06 15:55:26 +00:00
Bao-Long Nguyen-Trong
2a7c2fcfb2 Removed some commented out code no longuer needed 2009-06-06 15:50:06 +00:00
Bao-Long Nguyen-Trong
f6b4cbc43e . Fixed sdk 1.5 build and made it the default one
. Imported JARs for classes not exposed in teh sdk anymore
  . Imported src code from Android core for for classes not exposed in the sdk anymore
  . Updated MessageView implementation of UrlInterceptHandler modified in sdk 1.5 (pls review)
2009-06-06 15:46:17 +00:00
Bao-Long Nguyen-Trong
5e28b65c76 . Choosing '-NONE-' as default folder, was opening the MessageList of the '-NONE-' folder
--> It now opens, the FolderList
TODO: Externalize the '-NONE-' string
2009-06-06 15:42:33 +00:00
Jesse Vincent
a7d316ecdd Fix for Issue 328 and 332
Contributed by: Ludovic LANGE / ludovic.lange.android
2009-06-01 01:55:39 +00:00
Jesse Vincent
7d47328b2e Bring MIME4J current to match AOSP upstream as of 9e5757b5316f88d252b5d80fab1e3964ce19bbdf - Thanks to Ludovic LANGE / ludovic.lange.android 2009-06-01 01:53:13 +00:00
Jesse Vincent
909f677f91 r62972@17h: jesse | 2009-05-07 10:49:32 -0400
First stab at a folderlist that doesn't know or care about messages
r62973@17h:  jesse | 2009-05-07 10:50:11 -0400
A very broken first stab at a message list that only knows about one folder.
r62974@17h:  jesse | 2009-05-07 10:50:44 -0400
When you go from an account list to an individual account, open a folderlist, not an fml
r62975@17h:  jesse | 2009-05-07 10:51:24 -0400
Update Welcome activity to open an ml instead of an fml
r62976@17h:  jesse | 2009-05-07 10:51:59 -0400
When setting up accounts is over, open an fl instead of an fml
r62977@17h:  jesse | 2009-05-07 10:52:51 -0400
Update MessageView to use folderinfoholders and messageinfoholders from the 'correct' classes.
r62978@17h:  jesse | 2009-05-07 10:59:07 -0400
MailService now notifies the fl instead of the fml. Not sure if it should also notify the ml. - will require testing
r62979@17h:  jesse | 2009-05-07 11:01:09 -0400
Switch MessagingController's notifications from notifying the FML to notifying an ML
r62980@17h:  jesse | 2009-05-07 11:25:22 -0400
Update AndroidManifest to know about the new world order
r62981@17h:  jesse | 2009-05-07 11:26:11 -0400
Try to follow the android sdk docs for intent creation
r62982@17h:  jesse | 2009-05-07 11:28:30 -0400
reset MessageList for another try at the conversion
r62983@17h:  jesse | 2009-05-07 11:47:33 -0400
This version doesn't crash and has a working 'folder' layer. now to clean up the message list layer
r62984@17h:  jesse | 2009-05-07 15:18:04 -0400
 move step 1
r62985@17h:  jesse | 2009-05-07 15:18:37 -0400
move step 1
r62986@17h:  jesse | 2009-05-07 15:22:47 -0400
rename step 1
r62987@17h:  jesse | 2009-05-07 17:38:02 -0400
 checkpoint to move
r62988@17h:  jesse | 2009-05-07 17:40:01 -0400
checkpointing a state with a working folder list and a message list that doesn't explode
r62989@17h:  jesse | 2009-05-07 17:40:26 -0400
Remove debugging cruft from Welcome
r62990@17h:  jesse | 2009-05-07 22:00:12 -0400
Basic functionality works.
r62991@17h:  jesse | 2009-05-08 04:19:52 -0400
added a tool to build a K-9 "Beta" 
r62992@17h:  jesse | 2009-05-08 04:20:03 -0400
remove a disused file
r62993@17h:  jesse | 2009-05-09 06:07:02 -0400
upgrading build infrastructure for the 1.5 sdk
r62994@17h:  jesse | 2009-05-09 06:22:02 -0400
further refine onOpenMessage, removing more folder assumptions 
r62995@17h:  jesse | 2009-05-09 20:07:20 -0400
Make the Welcome activity open the autoexpandfolder rather than INBOX
r62996@17h:  jesse | 2009-05-09 20:14:10 -0400
MessageList now stores the Folder name it was working with across pause-reload
r62997@17h:  jesse | 2009-05-09 20:14:26 -0400
Removing dead code from FolderList
r63060@17h:  jesse | 2009-05-10 00:07:33 -0400
Replace the old message list refreshing code which cleared and rebuilt the list from scratch with code which updates or deletes existing messages.
Add "go back to folder list" code
r63061@17h:  jesse | 2009-05-10 00:07:50 -0400
fix message list menus for new world order
r63062@17h:  jesse | 2009-05-10 00:08:11 -0400
Remove message list options from folder list menus
r63063@17h:  jesse | 2009-05-10 00:10:02 -0400
remove more message list options from the folder list
r63064@17h:  jesse | 2009-05-10 00:10:19 -0400
fix build.xml for the new android world order
r63065@17h:  jesse | 2009-05-10 00:39:23 -0400
reformatted in advance of bug tracing
r63066@17h:  jesse | 2009-05-10 05:53:28 -0400
fix our 'close' behavior to not leave extra activities around
clean up more vestigal code
r63067@17h:  jesse | 2009-05-10 18:44:25 -0400
Improve "back button / accounts" workflow from FolderList -> AccountList
r63068@17h:  jesse | 2009-05-10 19:11:47 -0400
* Add required code for the 'k9beta' build
r63069@17h:  jesse | 2009-05-10 19:12:05 -0400
Make the folder list white backgrounded.
r63070@17h:  jesse | 2009-05-10 19:12:26 -0400
* Include our required libraries in build.xml 
r63071@17h:  jesse | 2009-05-10 19:13:07 -0400
Added directories for our built code and our generated code
r63072@17h:  jesse | 2009-05-10 19:13:36 -0400
Added a "back" button image
r63073@17h:  jesse | 2009-05-10 20:13:50 -0400
Switch next/prev buttons to triangles for I18N and eventual "more easy-to-hit buttons" win
r63074@17h:  jesse | 2009-05-10 20:17:18 -0400
Tidy Accounts.java for some perf hacking.
r63081@17h:  jesse | 2009-05-10 22:13:33 -0400
First pass reformatting of the MessagingController
r63082@17h:  jesse | 2009-05-10 23:50:28 -0400
MessageList now correctly updates when a background sync happens
r63083@17h:  jesse | 2009-05-10 23:50:53 -0400
Tidying FolderList
r63084@17h:  jesse | 2009-05-10 23:51:09 -0400
tidy
r63085@17h:  jesse | 2009-05-10 23:51:27 -0400
tidy
r63086@17h:  jesse | 2009-05-11 00:17:06 -0400
Properly update unread counts in the FolderList after sync

r63087@17h:  jesse | 2009-05-11 01:38:14 -0400
Minor refactoring for readability. replace a boolean with a constant.
r63090@17h:  jesse | 2009-05-11 02:58:31 -0400
 now that the foreground of message lists is light, we don't need the light messagebox
r63091@17h:  jesse | 2009-05-11 17:15:02 -0400
Added a string for "back to folder list"
r63092@17h:  jesse | 2009-05-11 17:15:24 -0400
Added a message list header with a back button
r63093@17h:  jesse | 2009-05-11 17:15:54 -0400
Remove the "folder list" button from the options menu. no sense duplicating it
r63094@17h:  jesse | 2009-05-11 17:17:06 -0400
Refactored views, adding our replacement scrollable header 
r63184@17h:  jesse | 2009-05-12 07:07:15 -0400
fix weird bug where message lists could show a header element for a child
r63185@17h:  jesse | 2009-05-12 07:08:12 -0400
Add new-style headers to folder lists. reimplement "get folder by name" to not use a bloody for loop
r63211@17h:  jesse | 2009-05-12 18:37:48 -0400
Restore the former glory of the "load more messages"  widget.  it still needs an overhaul
r63296@17h:  jesse | 2009-05-12 23:23:21 -0400
Get the indeterminate progress bar to show up again when you click "get more messages"
r63297@17h:  jesse | 2009-05-13 02:40:39 -0400
Fixed off-by-one errors in click and keybindings for messagelist
r63298@17h:  jesse | 2009-05-13 06:04:01 -0400
Put the folder title in the name of the folderSettings popup
r63299@17h:  jesse | 2009-05-13 06:04:49 -0400
Reformatting. Removing debug logging
r63300@17h:  jesse | 2009-05-13 06:05:32 -0400
Fixing "wrong item selected" bugs in the FolderList 
r63328@17h:  jesse | 2009-05-13 13:20:00 -0400
Update MessageView for 1.5
r63329@17h:  jesse | 2009-05-13 13:50:29 -0400
A couple fixes to "picking the right item"
Titles on the message context menu
r63330@17h:  jesse | 2009-05-13 13:58:37 -0400
Added an "open" context menu item to the folder list
r63347@17h:  jesse | 2009-05-13 18:00:02 -0400
Try to get folderlists to sort in a stable way, so they jump around less in the ui
r63349@17h:  jesse | 2009-05-13 20:37:19 -0400
Switch to using non-message-passing based notifications for redisplay of message lists, cut down redisplay frequency to not overload the display
r63432@17h:  jesse | 2009-05-16 13:38:49 -0400
Android 1.5 no longer gives us apache.commons.codec by default and apache.commons.logging by default. Import them so we have em.
There's probably something smarter to do here.
r63438@17h:  jesse | 2009-05-16 14:12:06 -0400
removed dead code
r63439@17h:  jesse | 2009-05-16 14:30:57 -0400
Minor tidy
r63440@17h:  jesse | 2009-05-16 14:39:34 -0400
First pass implementation making MessageList streamy for faster startup
r63441@17h:  jesse | 2009-05-16 21:57:41 -0400
There's no reason for the FolderList to list local messages
r63442@17h:  jesse | 2009-05-16 21:58:57 -0400
Switch to actually refreshing the message list after each item is loaded
r63450@17h:  jesse | 2009-05-16 22:34:18 -0400
Default to pulling items out of the LocalStore by date, descending. (since that's the uneditable default ordering)
This makes our messages come out of the store in the order the user should see them
r63451@17h:  jesse | 2009-05-16 22:34:44 -0400
Set some new defaults for the FolderList
r63452@17h:  jesse | 2009-05-16 22:35:43 -0400
set some new message list item defaults
r63456@17h:  jesse | 2009-05-17 12:56:10 -0400
It's not clear that Pop and WebDav actually set us an InternalDate. I'd rather use that so that spam doesn't topsort. But I also want this to _work_
r63457@17h:  jesse | 2009-05-17 12:56:47 -0400
actually check to make sure we have a message to remove before removing it.
r63458@17h:  jesse | 2009-05-17 13:10:07 -0400
Flip "security type" to before the port number, since changing security type is the thing more users are likely to know/care about and resets port number
r63469@17h:  jesse | 2009-05-17 18:42:39 -0400
Provisional fix for "see the FoldeRList twice" bug
r63471@17h:  jesse | 2009-05-17 20:47:41 -0400
Remove title bar from the message view
r63544@17h:  jesse | 2009-05-20 23:53:38 -0400
folderlist tidying before i dig into the jumpy ordering bug
r63545@17h:  jesse | 2009-05-20 23:56:00 -0400
Killing dead variables
r63546@17h:  jesse | 2009-05-21 00:58:36 -0400
make the whole title section clicky
r63556@17h:  jesse | 2009-05-21 01:48:13 -0400
Fix where we go when someone deletes a message 
r63558@17h:  jesse | 2009-05-21 22:44:46 -0400
Working toward switchable themes
r63563@17h:  jesse | 2009-05-21 23:53:09 -0400
Make the MessageList's colors actually just inherit from the theme, rather than hardcoding black

r63567@17h:  jesse | 2009-05-22 10:14:13 -0400
Kill a now-redundant comment
r63571@17h:  jesse | 2009-05-22 19:43:30 -0400
further theme-independence work
r63572@17h:  jesse | 2009-05-22 19:55:23 -0400
gete -> get (typo fix)
r63573@17h:  jesse | 2009-05-22 22:48:49 -0400
First cut of a global prefs system as well as a theme preference. not that it works yet
r63577@17h:  jesse | 2009-05-24 14:49:52 -0400
Once a user has actually put in valid user credentials, start syncing mail and folders in the background instantly.
This gives us a much better "new startup" experience
r63578@17h:  jesse | 2009-05-24 14:55:00 -0400
MessageList doesn't need FolderUpdateWorker
r63579@17h:  jesse | 2009-05-24 17:57:15 -0400
Fix "get message by uid"
Switch to showing messages 10 by 10, rather than 1 by 1 for huge loadtime performance improvements
r63587@17h:  jesse | 2009-05-24 19:19:56 -0400
Cut down LocalMessage creation to not generate a MessageId or date formatter.
r63589@17h:  jesse | 2009-05-24 22:22:32 -0400
Switch to null-escaping email address boundaries, rather than a VERY expensive URL-encoding
r63590@17h:  jesse | 2009-05-24 22:23:21 -0400
Clean up our "auto-refresh the list when adding messages after a sync"
r63593@17h:  jesse | 2009-05-24 22:53:45 -0400
replace isDateToday with a "rolling 18 hour window" variant that's more likely to give the user a useful answer and is 30x faster.
r63595@17h:  jesse | 2009-05-24 23:54:14 -0400
When instantiating messges from the LocalStore, there's no need to clear headers before setting them, nor is there a need to set a generated message id
r63596@17h:  jesse | 2009-05-24 23:54:39 -0400
make an overridable setGeneratedMessageId
r63597@17h:  jesse | 2009-05-24 23:54:55 -0400
Remove new lies from comments
r63598@17h:  jesse | 2009-05-24 23:55:35 -0400
Replace insanely expensive message header "name" part quoting with something consistent and cheap that does its work on the way INTO the database
r63605@17h:  jesse | 2009-05-25 17:28:24 -0400
bring back the 1.1 sdk build.xml
r63606@17h:  jesse | 2009-05-25 22:32:11 -0400
Actually enable switchable themese and compilation on 1.1
r63692@17h:  jesse | 2009-05-29 23:55:17 -0400
Switch back to having titles for folder and message lists.
Restore auto-open-folder functionality
r63694@17h:  jesse | 2009-05-30 18:50:39 -0400
Remove several off-by-one errors introduced by yesterday's return to android titlebars
r63696@17h:  jesse | 2009-05-30 23:45:03 -0400
use convertView properly for performance and memory imrpovement in FolderList and MessageList
r63698@17h:  jesse | 2009-05-31 19:42:59 -0400
Switch to using background shading to indicate "not yet fetched"
r63701@17h:  jesse | 2009-05-31 21:28:47 -0400
Remving code we don't actually need these bits of apache commons on 1.1
2009-06-01 01:35:05 +00:00
Bao-Long Nguyen-Trong
93b95b85b2 Fixed NullPointerException when trying to send message with to text body (attachment only for example). The message would end up being stuck in the outbox. 2009-05-22 05:42:16 +00:00
Bao-Long Nguyen-Trong
f64de34d2f Made MAX_SMALL_MESSAGE_SIZE match Store.FETCH_BODY_SANE_SUGGESTED_SIZE for consistency. See r623 2009-05-21 20:02:44 +00:00
Bao-Long Nguyen-Trong
49426f3107 Removed some logging that should not have made it to SVN 2009-05-21 18:53:27 +00:00
Bao-Long Nguyen-Trong
f4d7b54fb6 Bumped back FETCH_BODY_SANE_SUGGESTED_SIZE to 50K 2009-05-21 18:49:39 +00:00
Bao-Long Nguyen-Trong
73ded7170b . Greying out partially downloaded messages
--> All messages that will require download in order to be read are now "greyed" out
2009-05-20 04:46:55 +00:00
Bao-Long Nguyen-Trong
bae5fba355 Better HTMLization of plain text emails using <pre>: spaces / identation are now properly displayed 2009-05-20 04:44:45 +00:00
Bao-Long Nguyen-Trong
d8724784dd . Minor memory usage optimization of how we HTMLize plain text emails 2009-05-20 04:39:51 +00:00
Bao-Long Nguyen-Trong
23797b62ee . Fixed issue 423:
. HTMLized version of plain text email is not loaded up as a MIME part of the message anymore. We use a custom seperate variable in the text body class.
2009-05-20 04:36:20 +00:00
Bao-Long Nguyen-Trong
435e2c3532 Fixed issue 404:
. Free up memory as we go in MessagingController.synchronizeMailboxSynchronous()
  . IMAP: We only do a partial fetch of the text body of large messages during background sync. This allow for faster syncs and avoid expensive parsing that lead to OutOfMemoryError
2009-05-20 04:27:51 +00:00
Daniel Applebaum
130e00d72a Reflect Seen and Flag states while messages are not fully downloaded 2009-05-18 04:40:24 +00:00
Bao-Long Nguyen-Trong
d222a48a18 Added option setting/preference to specify the signature location. This fixed issue 74 2009-05-17 06:02:02 +00:00
Bao-Long Nguyen-Trong
42194562c1 Minor optimization to avoid the OutOfMemoryError we have been getting 2009-05-17 05:59:28 +00:00
Daniel Applebaum
8e51d6cf14 Issue 418
When no accounts are set for automatic sync, the MailService is
stopped.  When the MailService is stopped, the Android platform is
given greater leeway in killing the entire K9 process in order to free
system resources.
2009-05-14 02:26:23 +00:00
Bao-Long Nguyen-Trong
4a6f2e419b . Fixed bug where always BCC address is added again when editing a draft 2009-05-14 00:09:43 +00:00
Bao-Long Nguyen-Trong
536133daf1 . Fixed issue 419
. Moved signature to the bottom of the message body view so that it is not editable
TODO: Add signature location preference / settings
2009-05-14 00:03:19 +00:00
Bao-Long Nguyen-Trong
724c0aed31 Minor optiomization to help with the OutOfMemoryError pbs we have been getting 2009-05-12 05:31:21 +00:00
Bao-Long Nguyen-Trong
6caccc4ead . Rolled back some code from r505 that are not usefull. The code that really prevents the double message in POP3 is when we set the X_DOWNLOADED_FULL in the POP3 folder class 2009-05-11 23:31:59 +00:00
Bao-Long Nguyen-Trong
5ab77dcd64 Refactored message loading for view
--> Perfomance improvement: the code was doing duplicates calls to the server to set SEEN flag and duplicate access to the db.
2009-05-11 04:39:03 +00:00
Bao-Long Nguyen-Trong
7d98ed60ad Reverted signature formatting code that was not meant to be committed 2009-05-10 13:55:28 +00:00
Bao-Long Nguyen-Trong
bb8629abe8 . Potential fix for issue 404: now doing all HTMLization in one pass to minimize the amount of String objects 2009-05-10 07:05:24 +00:00
Bao-Long Nguyen-Trong
5b0dee8cc0 . Large messages are now only retrieved once for POP3 servers that don't support the TOP command 2009-05-10 05:47:26 +00:00
Bao-Long Nguyen-Trong
e844f4ab0c Fixed issue 191 2009-05-10 05:39:47 +00:00
Daniel Applebaum
97a4f97b64 Issue 234
Fix POP3 deletes.  Verizon uses - in their POP3 UIDs, and K9 was
assuming that only Local UIDs have -.  Removed that assumption.  Also,
after issuing DELE on POP3 connection, need to also issue a QUIT.  The
delete code in MessagingController now closes the folder after
deleting a message, which will slow down IMAP deletes, but also
conserve connections, so is probably a net benefit.
2009-05-09 15:22:36 +00:00
Jesse Vincent
718e27dab9 WebDavStore updates to fix authentication issues - based on design and counselling from ismarc31 2009-05-07 03:17:26 +00:00
Daniel Applebaum
96c98e3070 Reformat executeSimpleCommand 2009-05-06 00:16:47 +00:00
Daniel Applebaum
27e0ec1b80 Decrement mMessageCount when an untagged EXPUNGE is received 2009-05-06 00:12:30 +00:00
Bao-Long Nguyen-Trong
5be7ee8517 . Added Z as keyboard shortcut to toggle read flag
. Removed duplicate adapter notification and hence data reload
2009-05-05 16:26:04 +00:00
Jesse Vincent
1d7fdbeb92 expose download status of messages. slightly grey out messages that haven't yet been downloaded fully 2009-05-05 04:51:11 +00:00
Daniel Applebaum
aac64b03a5 Make sure not to lose an untagged EXISTS, even if it came during a
command that we didn't handle properly.
2009-05-05 04:03:56 +00:00
Jesse Vincent
4ed1c82855 Proposed fix for "unreopenable" folders bug 2009-05-05 03:15:07 +00:00
Jesse Vincent
d20fbc09fc Stop using a custom WebViewClient - it caused keybinding and url-opening bugs.
If anything the new version feels a bit faster
2009-05-05 02:13:02 +00:00
Jesse Vincent
7dcd346e0f MessageView shouldn't swallow keybindings 2009-05-05 01:56:41 +00:00
Daniel Applebaum
651642faeb Automatically re-synchronize the IMAP protocol. Previously, losses of
synchronization could happen if an Exception was thrown while parsing
an untagged response without using executeSimpleCommand.  For
instance, while doing a fetch.  Once synchronization was lost, later
commands would fail in surprising ways.  One manifestation of such
failures was spontaneously emptying of folders when search results
were not returned properly.  The new code makes sure to only accept OK
responses with the tag of the command, and discards the untagged
responses from previous command.
2009-05-05 00:42:05 +00:00
Jesse Vincent
7daf4ef1e6 We don't actually want to clear out the plaintext version of the message. K-9 uses that for replies 2009-05-05 00:29:15 +00:00
Jesse Vincent
dec4a6371f Fix auto-open of INBOX per danapple0 2009-05-05 00:24:18 +00:00
Jesse Vincent
323c294250 Move our linkification and htmlification of mesages from on-display to on-sync.
There's no need to defer this work until the user is waiting for it
2009-05-03 20:52:32 +00:00
Jesse Vincent
f2fa5ae2f6 FolderMessageList performance improvement from debauchedsloth++ (Partial application of his patch from Issue 285) 2009-05-03 04:39:13 +00:00
Jesse Vincent
2dda469255 MessageView performance improvlements by debauchedsloth++ (This includes all changes from Issue 285's MessageView.java patch) 2009-05-03 04:36:33 +00:00
Jesse Vincent
4b444b2bcf don't try to recreate the indexes on every db update as it will surely fail 2009-05-03 04:22:34 +00:00
Jesse Vincent
46eef4589d Fixed issue 160 - Applied a patch to enable K9 to respond to addtional SEND intents 2009-05-02 22:30:08 +00:00
Jesse Vincent
ab82b10918 Add a few indexes to the message and folder lists 2009-05-02 22:14:45 +00:00
Jesse Vincent
d185adfc27 Fix up text/plain message view to escape < and > and & when converting plain text to html for display 2009-05-02 22:06:42 +00:00
Daniel Applebaum
0ffe1621a2 Issue 394
Issue 252

394: Replace code change lost with move of DAmail MailService.java to
K-9.  Eliminate the stopSelfs.  Without the stopSelfs, the Service
remains active and the Android platform is far less likely to kill the
process, although not absolutely forbidden from doing so.  Better will
be to implement the full BroadcastReceiver methodology referred to in
Issue 394, which would allow replacing the stopSelfs, which would make
K-9 a better good citizen.

252: Fix logic for raising and canceling notifications based on number
of new unread messages and total unread messages.
2009-05-02 14:49:29 +00:00
Daniel Applebaum
b603d899db Issue 395
Fix database connection leak
2009-05-02 00:37:22 +00:00
Daniel Applebaum
509fa8c8d3 Issue 386 2009-04-28 12:23:57 +00:00
Daniel Applebaum
d1661ee1f5 Reset mMessageCount before executing SELECT. Only handle untagged
responses to SELECT once.
2009-04-21 05:34:57 +00:00
Daniel Applebaum
f0f07c36de Issue 63
Issue 201
Issue 224
Issue 342

Handle untagged EXISTS messages at any time.  Should increase
synchronization speed and accuracy.

Handle IMAP servers that send a NIL where a literal is normally.
Avoids failure to sync when folder contains certain messages.

Throw Exception if folder message count is less than 0, avoiding
accidentally emptying a folder.
2009-04-21 04:22:02 +00:00
Jesse Vincent
b0a295e1a3 Re-add the code I removed twice, now that dan explained what it works around 2009-04-20 06:27:51 +00:00
Jesse Vincent
d0d6eb5442 Set the landscape-mode text colors to something more reasonable (and really "default") in the landscape xml layout templates
Re-remove the explicit subject color hardcoding in FolderMessageList.java
2009-04-20 00:58:50 +00:00
Daniel Applebaum
c00eb30524 Restore text color handling 2009-04-19 14:59:18 +00:00
Jesse Vincent
64eda5106c Switch to a light visual theme more in keeping with every other mail client on the planet.
Start to improve padding/spacing/layout
2009-04-19 09:10:32 +00:00
Jesse Vincent
e24b3429dc Allow the user to continue setup, even if their server settings don't work 2009-04-19 07:20:38 +00:00
Daniel Applebaum
47f5230bed Issue 248
Issue 192

Do not remove markers for deleted messages, even if the corresponding
remote message is not returned by the remote store.  The remote
message may not be returned simply because the query did not encompass
it on this run.  If the account's delete policy is set to "Do not
delete from server", or the delete hasn't succeeded before a folder
refresh, a message for which the deleted marker has been removed can
errorneously reappear.

This will lead to the local store eventually having a large number of
deleted message markers.  In the long term, we'll need a way to manage
and possibly automatically remove them.
2009-04-17 03:22:45 +00:00
Daniel Applebaum
4ad4216de5 Fix problems connecting to POP3 servers which lack the CAPA command. 2009-04-15 13:05:29 +00:00
Daniel Applebaum
03dd89b3f9 Get rid of @Overrides that cause compilation failures with Java 1.5 2009-04-12 01:51:54 +00:00
Daniel Applebaum
aa4a92a541 Application of patch submitted by cnehren for Issue 356, with
generalization.
2009-04-11 15:24:22 +00:00
Daniel Applebaum
932adf5ed2 Issue 143
Merged from branch issue143 @ revision 426:

Complete replacement for SharedPreferences.  Uses SQLite database
stored in application's databases folder.

Will load from legacy preferences if DB-backed preferences are empty.

Editor conforms to atomic commit contract.
2009-04-11 14:33:54 +00:00
Daniel Applebaum
5711abdee5 Issue 234 Issue 366 Issue 329
Hardening of POP3 and SMTP communication:

SMTP: Decrement failure counter when no possible message send
occurred.  This way, K-9 will only stop attempting to send messages
for which a possible successful send occurred, but K-9 could not
detect.  Any message that is known to have completely failed to send
will be reattempted indefinitely.

POP3: Some reworking of Exception handling.  Also, if it is not
possible to get a "message number" for the UID of the message that is
being deleted, conclude that the message has already been deleted on
the server.  Mark this as a permanent error, so that it gets removed
from the pending actions queue.

MessagingController: Look for the permanentFailure flag on the
MessagingException, and if a pending action raised a permanent
failure, remove the pending action from the queue so that it will not
be re-attempted nor block later requests.
2009-04-11 02:11:17 +00:00
Daniel Applebaum
388969d76c Automatically fix folder selections. 2009-04-11 01:26:44 +00:00
Daniel Applebaum
bf98b5c2af Issue 366
Significant hardening of the email sending process.

A given message in the Outbox is only attempted to be sent 5 times.
Once the threshold is reached, the message is flagged.  asses through
the Outbox skip flagged messages.  The message can be tried again by
manually unflagging.  When any messages are flagged during a pass
through the Outbox, K-9 raises a notification with a fast flashing red
LED, alerting the user to the failure to send.  A note is also placed
in the K9mail-errors.

The read timeout on SMTP connections has been changed to 300000ms (5
minutes)

The send attempt counter is kept in memory, not stored with the
message, so a phone or application restart will clear the counters,
but not the flagged state.  As the intent of this revision is to avoid
runaway message sending, this is deemed to be acceptable for now.

The moving of messages from the Outbox to the Sent folder has been
changed to an atomic move.

Extra error checking has been added to the SMTP communication code.

The flashing LED may be excessive.
2009-04-09 17:48:05 +00:00
Daniel Applebaum
e92ac38052 Fix for empty real folder name issue identified in Comment 10 of Issue
366

Affected POP3 and WebDAV accounts
2009-04-09 15:05:24 +00:00
Daniel Applebaum
ee4ac07788 Issue 364
Provide preference for which folder is automatically expanded when
entering the Folder/Message list.

Can be set to -NONE-, so that no folder is automatically expanded.

Defaults to Inbox, which is like the default behavior of the core
Android Email.

Fails to move the automatically opened folder to the top of the
screen.  This needs more work.

The already selected folder should be highlighted (or otherwise
indicated) in the ChooseFolder Activity.  This needs more work.
2009-04-08 18:14:52 +00:00
Daniel Applebaum
f307bfc1eb Issue 235
Added dialog box for confirmation for "Mark all messages as read"
2009-04-06 01:37:35 +00:00
Matthew Brace
1b5fdb99d9 Fix for authentication issue describe in issue 359. 2009-04-02 01:52:00 +00:00
Daniel Applebaum
b210762ac7 Revert unintentional change 2009-04-01 03:38:55 +00:00
Daniel Applebaum
8ca1830afb Add "Check mail" menu items:
Accounts: Option menu->Check mail = check mail in all
   folders of all accounts
Accounts: Context (long-press on account) menu->Check mail = check mail
   in all folders of this account

Folder/Message List: Option menu->Check mail = check mail in all
   folders of this account
Folder/Message List: Contet (long-press on folder) menu->Check mail = check mail in this
   folder*

*All "Check mail" options, except for the long-press on an individual
folder, respect the normal synchronization class settings.

Eliminate all Refresh menu items.

Add progress indicators to Accounts activity.  Indeterminite progress
indicator while email checking is in progress.  Determinite progress
indicator while fetching unread counts.
2009-04-01 03:25:16 +00:00
Matthew Brace
f699361390 Prevent multiple appendages of the email signature (Issue 66). 2009-03-26 06:06:04 +00:00
Robert Jacob
b0cf11d64c IMAP "system" folders can be selected with pick list (Patch for Issue 182) 2009-03-24 18:20:16 +00:00
Daniel Applebaum
9f7a4b05d8 Elminate harmful selection of delete policy on Incoming settings page. 2009-03-12 01:50:06 +00:00
Daniel Applebaum
272bb699c9 Use format, instead of hardcoded concatenation, for formatting
recipient display.  (suggested by dumbfile in Comment 12 of Issue 10)
2009-03-12 01:31:55 +00:00
Daniel Applebaum
49c2708f4c Patch ImapFolders.r389.patch submitted in Comment 3 of Issue 214 by
dumbfile on Feb 28, 2009.

One change of my own, putting the actual folders name outside the
parentheses, and the functional/special name inside the parentheses.
2009-03-12 01:13:26 +00:00
Daniel Applebaum
45227e2708 Delete now uses LocalFolder.moveMessages
Copy now copied body (but attachments might not work right).

Move is now reliable (needed to open the destination folder), and
leaves a placeHolder message behind in the source folder so that
messages are not resynced.
2009-03-07 07:20:15 +00:00
Daniel Applebaum
6d5b158787 Restore ability to delete server-side messages for POP3 and WebDAV 2009-03-05 13:43:05 +00:00
Daniel Applebaum
014691bac9 Fix reverse sorting when in sort-by-date mode. 2009-03-05 08:08:37 +00:00
Daniel Applebaum
7b2a754009 Cleanup of minor issues with r395. r395 and this revision are to
address Issue 2, not Issue 3 as previously stated.
2009-03-05 07:50:53 +00:00
Daniel Applebaum
15e5cb4eaf Provides the ability to move and copy messages between folders. Issue
3.

Each remote Store (IMAP, POP3, WebDAV) can provide indications to the
higher level classes as to whether copy and move are implemented.
Currently, copy and move are only provided by ImapStore.java.  When
the facilities are not available, the user interface suppresses the
menu options.

The available destination folders can be configured using folder
classes.

Copy results in null message bodies in the destination copy of the
message until the next sync.  This is a problem that occurred with
deletes previously, and is likely a fault with the copyMessages method
of LocalStore.java.

Utilizes a modified version of the ChooseFolder.java Activity that
debuachedsloth contributed in a patch attached to Issue 285 on 16 Feb
2008.
2009-03-05 07:32:45 +00:00
Bao-Long Nguyen-Trong
db426c44b7 . Applied patch from dumbfile which fixes issue 307 and issue 265 related to date format when running on a device with a non US locale 2009-03-04 19:49:39 +00:00
Daniel Applebaum
73d5e16178 Fix for problem with r386 found by kanisdragon. 2009-03-02 00:47:27 +00:00
Daniel Applebaum
19c93d1816 Issue 10
All messages in all folders that were sent from the email address
associated with the account display the recipient, preceeded by To:,
instead of the sender.
2009-02-28 17:40:39 +00:00
Matthew Brace
91573e19ac Fix for null pointer exception when there is an exception thrown and the caught in processRequest without properly terminating checks (ie, during the recursive calls, resulting in a null data set being returned). 2009-02-26 06:56:30 +00:00
Daniel Applebaum
6f8a243bcc Issue 318
When performing a database upgrade, clear all cached attachments and
attachment thumbnails
2009-02-25 03:35:25 +00:00
Daniel Applebaum
2615d70a1d Issue 321
Add null checks around more uses of mMessage
2009-02-25 02:32:20 +00:00
Daniel Applebaum
2d31b4e52d Issue 179 and Issue 320
Puts quotes around username and password for IMAP authentication.

Also, if authentication fails, closes the connection so that it will
be retried.  Otherwise, there is no way to fix the problem, say, by
changing the password in the Incoming Settings.
2009-02-25 01:50:20 +00:00
Daniel Applebaum
0e9d1f195e Issue 319
Do not reset all folder settings when a database upgrade occurs. (Or
any other event that wipes all of the local folders.
2009-02-24 05:03:28 +00:00
Matthew Brace
acea3ab3b5 Pull destination url from OWA login page. Order of priority for destination is: User specified mailbox path, destination form value on OWA login page, "/" character. 2009-02-19 04:35:15 +00:00
Bradley Young
16252e4ad4 Removed @Override flag from compareTo method, since it isn't in the superclass. 2009-02-15 16:30:37 +00:00
Matthew Brace
7e492a0505 Prevent needlessly downloading every message > 5K the first time it's opened (affected POP3 and WebDav) 2009-02-12 22:59:02 +00:00
Daniel Applebaum
0bf5dcf95b Required for r371 2009-02-12 21:49:20 +00:00
Bradley Young
61aba8fa78 Changed host from static to instance. Should help to prevent conflicts with multiple accounts. 2009-02-11 21:07:25 +00:00
Daniel Applebaum
ca9d220a52 Issue 262
ConcurrentHashMap seems to serialize as a HashMap.  Not sure why or
how.

This change has re-enabled the saving of the unread counts during an
orientation change, giving somewhat fast response.  If it fails again,
just comment out the block of code.
2009-02-10 04:11:34 +00:00
Daniel Applebaum
3e4843e756 Issue 131
Provide two options for each Account:
Compact (which VACUUMs the accounts and prunes recreatable
attachments)

Clear all data (danger!) (which wipes all messages and attachments in
the account, except placeholder deleted messages)

Displays a Toast when the Compact or Clear is queued, and another
Toast with the shrinkage results.

(Also, a small change to increase probability of seeing messages after
a sync, by setting the needsRefresh on all folders when a sync is done.)
2009-02-10 03:18:42 +00:00
Matthew Brace
8c466c35ba Add proper handling for relative paths from initial login page for WebDav. Provides support for Exchange 2007. 2009-02-09 06:48:57 +00:00
Matthew Brace
da46773f74 Fix potential index issues when less than 10 emails are in the folder when fetching messages in WebDavStore. 2009-02-09 01:50:31 +00:00
Daniel Applebaum
7a5b4d27e1 Changed terminology from Thread to Sort. Added sorting on sender,
flag, unread and attachments.

Really, really, needs better icons.
2009-02-07 19:41:33 +00:00
Daniel Applebaum
cd386b17b3 Didn't mean to undo Bao-Long's change 2009-02-07 19:36:30 +00:00
Daniel Applebaum
c0b3c9dafa Disable restoring unread message counts on Accounts page after
orientation change (onResume) until I figure out the
ClassCastException

Will slow down display of unread message counts, but they will show up
after a slight delay.
2009-02-07 03:11:58 +00:00
Daniel Applebaum
98ff7af644 Just can't believe the prior code was right. Possible fix for Issue 234. 2009-02-06 20:11:36 +00:00
Daniel Applebaum
465172f1c7 Fix threading in Accounts main screen. Move all UI updates to UI
thread.  

Push unread message counting into the background.

Should increase startup performance and reduce black-screens-of-death
that some Market "commentators" report.

Also, updates the per-account unread message count when email account
is finished synchronizing.
2009-02-06 04:28:29 +00:00
Daniel Applebaum
8fd9c4e77c Get rid of suppression logging 2009-02-04 04:56:11 +00:00
Bao-Long Nguyen-Trong
c78db1c327 . Automatically open inbox folder when opening an account 2009-02-01 07:22:26 +00:00
Bao-Long Nguyen-Trong
8721b64e66 . Nofifications are not cancelled anymore when viewing account screen 2009-02-01 07:21:30 +00:00
Bao-Long Nguyen-Trong
f4c8f88251 . Now displays the number of new messages on the new email notification icon 2009-02-01 07:20:49 +00:00
Bao-Long Nguyen-Trong
41dc1ca8d8 Now display a new email notification per account. Each notification now opens the account (does not go to the Accounts screen anymore)
Note: Notifications are displayed after all accounts are sync'ed but are delayed to be 1sec. apart
TODO: Display notifications at the end of each individual sync
2009-02-01 07:19:08 +00:00
Daniel Applebaum
3dfabbbd0c Provide folder threading support. When threading is on, messages in
folders are sorted first by subject, then by date.  Subject sorting is
case insensitive and disregards leading re:, fw: and fwd: prefixes.

Threading can be toggled via the T hotkey or the option menu.

The icons could use improvement.

Threading state is maintained during a run of K-9, among all
accounts.
2009-02-01 00:08:14 +00:00
Matthew Brace
f184350aec Fix for index out of bounds exception (regression) from r330 2009-01-31 22:09:16 +00:00
Daniel Applebaum
fe2dfb76d0 Refactor suppression of deleted messages into MessagingController.
Re-enable instant deletes in MessageView

Deleted message suppression should be generalized into a flag cache,
serving Seen, Flagged, and Answered flags, as well.

Copy message to Trash still needs work, so that no duplicates are ever
visible and server-sync is more clean.  This will be especially
important, as the same code will be needed for the future "message
copy/move" facility.
2009-01-29 13:35:43 +00:00
Matthew Brace
0a6bc9bdd4 Changed authentication method. Added support for authentication if the server returns a 401 status code. No longer requires form based authentication. 2009-01-27 05:39:41 +00:00
Daniel Applebaum
1bd3f31b95 Attempt to fix Issue 192; making deleted messages stay deleted. 2009-01-27 03:13:54 +00:00
Matthew Brace
de24b6a166 Added support for optional Form Based Authentication login path and user mailbox path in account settings. 2009-01-25 07:37:10 +00:00
Daniel Applebaum
7d5d473563 Fix for Issue 238
Only fixes display of attachment filenames for newly downloaded
messages.  Will not correct display for message already in the
LocalStore.
2009-01-24 19:35:57 +00:00
Daniel Applebaum
cf359c95ad Major ergonomic re-work of MessageView controls. Provide options (in
Account settings) for scrolling the navigation buttons with the
message, or keeping the buttons on screen.  Scrolling mode can be
automatically switched based on availability of keyboard. (Issue 197
and Issue 194)

Add ability to flag/unflag message from options menu
2009-01-24 18:58:40 +00:00
Daniel Applebaum
b6e9910e00 Needed for r326 Issue 91 2009-01-24 18:54:47 +00:00
Daniel Applebaum
e1da49109f Flag "Sent" messages as Seen Issue 91
"Instant" Empty trash
2009-01-24 18:52:58 +00:00
Bradley Young
b4ea7f34a4 catch Throwable, rather than MessagingException, to prevent a crash on stray exceptions. 2009-01-23 23:17:21 +00:00
Matthew Brace
483857ed74 A missed hardcoded value. This should resolve most 400 Bad Request issues. It is unknown if this affects the Invalid Verb responses. 2009-01-22 03:53:09 +00:00
Matthew Brace
357418a396 Removed ability to add slashes/url type parameters onto the server. 2009-01-21 05:33:27 +00:00
Matthew Brace
1cda221fa3 Added support for Exchange path. This is not specifying the path for authentication or for the mailbox. This is support for situations like "https://www.myserver.com/owapath" for authentication. 2009-01-21 05:27:22 +00:00
Daniel Applebaum
b7ad91b7a5 Eliminate "space" as an alias for Next. I didn't realize it was used
by WebKit for scrolling down, and there are already two other Next
hotkeys
2009-01-19 16:09:06 +00:00
Daniel Applebaum
4f5ed839ff Major ergonomic changes to control buttons in the MessageView
1) Eliminate the top row Next Message and Previous Message

2) In the bottom buttons for portrait mode, replace Reply and Forward
   with Prev and Next
   Justification: if you're going to be replying or forwarding, you're
   about to embark on a lot of typing, anyway.  Having to hit Menu
   isn't an undue burden.

3) Prev goes to the adjacent *older* message, next goes to the
   adjacent *newer* message

4) In the bottom buttons for landscape mode, added Prev and Next as the
   outer buttons

5) Add Account option for hiding the bottom buttons when the keyboard
   is available.

Also, temporarily (hopefully!) reverted the instant delete from the
MessageView because it isn't working right.  The method here is slower
but safer.
2009-01-19 14:54:05 +00:00
Matthew Brace
7f2601df17 Updated regular expression to allow directory path in server field. Some whitespace cleanup (tabs to spaces). 2009-01-19 00:48:20 +00:00
Daniel Applebaum
a5de5ceb0e Eliminate use of Android-private APIs for getting user-selected
date/time formats.  With this change, K-9 can run on original master
or cupcake versions for the platform.

This seems like an excessive amount of code.  Perhaps there is a
public API that accomplishes this work.  Alternatively, the code in
MessageView.java and FolderMessageList.java should be consolidated
into a utility class used by both of the classes needing this
functionality.
2009-01-18 16:46:08 +00:00
Daniel Applebaum
0706b7de45 Patch from debauchedsloth for issue 190 that makes the ongoing
notifications duing email send/receive optional.
2009-01-18 16:42:55 +00:00
Daniel Applebaum
dc40026b31 Meant to add to revision 313 notes:
Patches were handling uppercase MIME types were submitted by gwillen
in K-9 issue 94 (MimeBodyPart.java and MimeMessage.java)
and
Josh Guilfoyle as part of Android patch 1539 (MimeUtility.java)

Sorry for missing the attribution on the original commit
2009-01-18 16:35:47 +00:00
Daniel Applebaum
2c51862087 Issue 190
Handle uppercase MIME type sent by non-compliant MUAs such as Pine.
2009-01-18 16:31:37 +00:00
Matthew Brace
b50a782c1c New DataSet data model for XML parses from HTTP responses. Much less memory used for a negligible hit in processor usage. Some additional whitespace cleanup. 2009-01-18 02:43:15 +00:00
Daniel Applebaum
172adeee22 Add ability to Flag/Unflag messages. Flagged messages are shown with
a red/bold subject.  Can be done in the FolderMessageList using the
hotkey G (toggle) or by long-pressing the message to bring up the
message context menu.  Can be done while viewing an individual message
by using the hotkey G (toggle).  To-do: add a Flag/Unflag option to a
menu in the individual message view.

Add sending the Answered flag to the IMAP server when replying to a
message.  This is currently done as soon as the reply is started.
Perhaps it would be better to wait until the reply is sent, but that
would require keeping additional state with the draft.  Messages to
which the user has replied are indicated with a white arrow next to
the subject.

To-do: In the MessageView, provide visual indication of Flagged and
Answered states.
2009-01-13 05:52:37 +00:00
Daniel Applebaum
5b49112a98 Fix linkification of text/plain messages with URLs starting at index 0
of the body.

Possibly the fix for issue 213 and maybe also issue 55
2009-01-13 03:39:59 +00:00
Daniel Applebaum
65bbc7e68a Improved synchronization timing and WakeLock algorithm. This new
approach should guarantee that the syncing never stalls just because a
single attempt exceeds the (currently 10 minute) WakeLock timeout.  At
the sync frequency, K-9 will wakeup again and refresh the WakeLock for
another go at syncing.  This should make synchronization much more
reliable in the face of slow or unavailable connections, in particular
ones which hit the socket read timeouts.

Also, fixed the audible notifications so that the ringtone selected
is always for one of the accounts with new unread mail.

Developers now have the option to turn on a fast-flashing LED during
synchronization in order to observe whether synchronization is
happening while the handset is apparently asleep.  I think this option
would be aggravating to non-developer users.  See
Email.NOTIFICATION_LED_WHILE_SYNCING


Issue 175
Issue 170
2009-01-11 23:43:32 +00:00
Daniel Applebaum
f0867387c8 Eliminated redundant commit of Preferences 2009-01-09 06:13:28 +00:00
Daniel Applebaum
1f9bf1ec50 Issues 199 & 201
No fixes, just extra details in thrown Exceptions to try to track down
problems.
2009-01-09 05:42:59 +00:00
Daniel Applebaum
95c47fcddc Restore ability for FolderMessageList "Refresh" to get a new list of
folders

Automatically clean up deleted messages in Outbox (make deleted
messages destroyed); don't try to send deleted messages, destroy
messages in outbox when deleting.  (Yep, the first and third items are
redundant, but will automatically clean up damaged outboxes)
2009-01-09 05:39:43 +00:00
Daniel Applebaum
a81facc6e7 Issue 192
Keep deleteUid in list until confirmation that message has been
deleted from LocalStore
2009-01-09 05:03:55 +00:00
Daniel Applebaum
d0a354ead0 Delete needs to know how to use Imap prefix 2009-01-09 05:01:05 +00:00
Matthew Brace
7d5d29e078 Added support for non-Exchange 2003 standard login paths (web scraping for login URL).
Added support for default mailbox path setting if we can't automatically determine what it is.
Fixed a bug exposed by changes relating to a fix for non-relative email paths being returned.
2009-01-08 05:47:10 +00:00
Daniel Applebaum
7954b02da6 Experimental deletedUids list in FolderInfoHolder to avoid race
conditions when using instance delete
2009-01-08 04:42:56 +00:00
Daniel Applebaum
1bc879c30c Eliminate assumption that item 1 will be a String 2009-01-07 06:37:44 +00:00
Daniel Applebaum
2eaa99bb3a Do not delete remote messages during sync. Trust the delete routines
to send the proper delete requests (delete, mark read, nothing).
Otherwise, this code will delete on the server any message deleted on
the handset, no matter option the user selects.
2009-01-07 06:36:46 +00:00
Daniel Applebaum
3a3dc2da43 Instant deletes from FolderMessageList. Faster deletes from
MessageView

Deleting a message in Trash deletes it for real (permanently)

All message operations are allowed on messages in the Outbox.  Special
handling for deleting, so that the message is copied to Trash, then
copied asynchronously to the remote Trash.

Add some more items to the hotkey help
2009-01-07 06:02:04 +00:00
Brock Tice
efb2801bab Updated Debug screen to pull version number from the package info.
Fixed "loading more messages" to use the cleaner String.format way of doing things, and changed the corresponding entries in strings.xml.
Deleted the now-unused build_number.xml file.
2009-01-07 05:20:03 +00:00
Brock Tice
0ac17da6cd Added help 'Toasts' to the message and folder message list views. Pressing 'h' brings up a list of shortcut keys. 2009-01-07 04:43:25 +00:00
Brock Tice
7df272d161 Externalized load up to $number more message to strings.xml 2009-01-07 04:20:23 +00:00
Bradley Young
2e4ee5b59f Fix for sending mail; additional logging when there is an invalid (non-http-2xx) response. 2009-01-06 01:31:57 +00:00
Bradley Young
8221094570 self-signed cert support for WebDav. 2009-01-05 00:05:43 +00:00
Daniel Applebaum
d9dd06a620 Make folder unread counters work properly with new faster delete and
marking
2009-01-03 14:35:41 +00:00
Bradley Young
73006c65a3 Disabling self-signed certs for webdav (not IMAP); they are currently causing issues. 2009-01-03 10:15:56 +00:00
Bradley Young
b2b9d8d624 remove @Override : this causes breakage in jdk 1.5. 2009-01-03 04:55:16 +00:00
Daniel Applebaum
828ceba503 Set to use new folder display and sync class defaults.
Accounts are now set:
Folder display mode = All except 2nd Class
Folder sync mode = Only 1st Class

Only the Inbox is set for:
Folder sync class = 1st Class
All other folders have class set to None for sync and display

Also restored an optimization on opening local folders that I
removed.  It is now optimistic, and in the normal case does not have
to make an explicit existence check
2009-01-03 01:47:24 +00:00
Daniel Applebaum
41d6598e22 Speed up Delete, Mark as read/unread, and Mark all as read. 2009-01-03 01:13:50 +00:00
Bradley Young
51b6a03f8c Added self-signed/mismatched domain handling for HTTP over SSL connections in WebDav. 2009-01-01 08:56:19 +00:00
Daniel Applebaum
4cc1ea489a Restored automatic creation of a local folder on open. Why was this
removed in K9?  I can't find the history of LocalStore.java to find
the answer.  Eliminated now redundant creation of Outbox and Drafts
folders.
2008-12-31 16:05:03 +00:00
Daniel Applebaum
334d64141f Complete merge of DAmail functionality into K9mail. Following
features are added to K9mail:

1) Show unread message count on each folder
2) Sum unread count of all shown folders in an account to the account display
3) Periodically check selected folders for new mail, not just Inbox
4) Don't refresh folder when opened (unless folder is empty)
5) Show date and time of last sync for each folder
6) Fix timer for automatic periodic sync (use wakelock to assure completion)
7) Optimize local folder queries (speeds up account and folder lists)
8) Show Loading... message in status bar indicating which folder is being synced
9) Eliminate redundant sync of new messages (performance enhancement)
10) Improve notification text for multiple accounts
11) Do not automatically sync folders more often than the account-specific period
12) Use user-configured date and time formats
13) Select which folders are shown, using configurable Classes
14) Select which folders are synced, using configurable Classes
15) Added context (long press) menu to folders, to provide for Refresh
and Folder Settings
16) Status light flashes purple when there are unread messages
17) Folder list more quickly eliminates display of deleted and out-of-Class folders.
18) Delete works 
19) Mark all messages as read (in the folder context menu)
20) Notifications only for new unread messages
21) One minute synchronization frequency
22) Deleting an unread message decrements unread counter
23) Notifications work for POP3 accounts
24) Message deletes work for POP3 accounts
25) Explicit errors show in folder list
26) Stack traces saved to folder K9mail-errors
27) Clear pending actions (danger, for emergencies only!)
28) Delete policy in Account settings
29) DNS cache in InetAddress disabled
30) Trapped some crash-causing error conditions
31) Eliminate duplicate copies to Sent folder
32) Prevent crashes due to message listener concurrency
33) Empty Trash
34) Nuclear "Mark all messages as read" (marks all messages as read in
server-side folder, irrespective of which messages have been downloaded)
35) Forward (alternate) to allow forwarding email through other programs
36) Accept text/plain Intents to allow other programs to send email through K9mail
37) Displays Outbox sending status
38) Manual retry of outbox sending when "Refresh"ing Outbox
39) Folder error status is persisted
40) Ability to log to arbitrary file

Fixes K9 issues 11, 23, 24, 65, 69, 71, 79, 81, 82, 83, 87, 101, 104,
107, 120, 148, 154
2008-12-31 03:49:09 +00:00
Matthew Brace
72c4095ceb Finished initial refactoring of fetch(). Some slight formatting and cleanup changes as well. 2008-12-29 00:25:19 +00:00
Matthew Brace
34be0269f8 Added stubs for the added functions needed for the DAMail merge. Did not add @Override. Doing it this way to allow easier testing/modifications in preparation for the merge to trunk. All trunk changes will be committed to the DAMail merge branch next. 2008-12-26 06:52:07 +00:00
Matthew Brace
2dede98463 Refactored how the HTTP calls were to reduce the growing volume of duplicated code. 2008-12-26 06:47:00 +00:00
Bradley Young
60b03f3dc2 Should fix attachment issues 2008-12-26 03:06:42 +00:00
Matthew Brace
409acd0134 Added support for proper deletions in WebDAV. Deleting a message the first time moves it to the (currently hardcoded) Deleted Items. Deleting an item in 'Deleted Items' will remove it completely. 2008-12-25 08:38:55 +00:00
Matthew Brace
46d4619ffb Fix for date/time issues prior to fetch(BODY) or fetch(BODY_SANE) is called. 2008-12-25 01:08:34 +00:00
Matthew Brace
dc7a1a0532 Fixed an issue where some Exchange servers wouldn't mark messages as read. Fixed incorrect URL encoding in some folder path names. Removed some unneccessary headers from the envelope request. 2008-12-24 03:09:37 +00:00
Bradley Young
70ab4d7a37 Moved findSurroundingMessagesUid() above the block it was in (which was only present if the next and previous buttons are visible (and they are not visible in horizontal orientation (and that's the only time you can use the keyboard in a non-emulated device))).
Fixes issue #50.
2008-12-23 07:18:36 +00:00
Bradley Young
266a3eddcf Correcting issue with message body being the target, regardless of action (reply, forward, compose).
Should target the message body on reply, reply all, and edit draft.
2008-12-23 02:01:51 +00:00
Matthew Brace
18c51bae5c Removed unneeded header fields from WebDav requests. Fix for some instances of subfolders not working. 2008-12-22 22:14:02 +00:00
Bao-Long Nguyen-Trong
f5c4982c1d . Replaced 'Reply All' with 'Delete' button in message view 2008-12-21 17:44:18 +00:00
Bao-Long Nguyen-Trong
7f81a1ed5d . Replaced 'Delete' button in message view with 'Forward' one (too many accidental deletes) 2008-12-21 15:52:21 +00:00
Bradley Young
5d576f899f If the message is a reply, set focus to the message body. Adding addresses is not the default behavior when a user replies. 2008-12-21 06:20:32 +00:00
Bao-Long Nguyen-Trong
56d1ede846 . Added silent 'on going' notification when checking email 2008-12-19 22:30:55 +00:00
Bao-Long Nguyen-Trong
b9dec4064e . Fixed background sync broken by package name change 2008-12-19 22:27:37 +00:00
Bao-Long Nguyen-Trong
b76c0aba0b . Externalized notification ids 2008-12-19 19:59:49 +00:00
Bao-Long Nguyen-Trong
b3a4b758dc . Fixed typo in LED time off
I forgot: Thanks danapple0 for the LED blickng code
2008-12-19 19:52:51 +00:00
Bao-Long Nguyen-Trong
081cb8f76d . New email notification now includes purple blicking LED 2008-12-19 19:46:47 +00:00
Bao-Long Nguyen-Trong
1e67bbee6b . More reliable background sync by using wake lock
--> Background sync now work even when the device is asleep
(Thanks danapple0)
2008-12-19 19:32:27 +00:00
Jesse Vincent
d55e335f48 merge extra crap 2008-12-19 00:31:17 +00:00
Jesse Vincent
9cf84ee2c8 Merge 'rename' into 'trunk'
r55941@173-101-60-247 (orig r204):  jessev | 2008-12-16 14:58:33 -0800

r55942@173-101-60-247 (orig r205):  jessev | 2008-12-16 15:07:33 -0800
* step 1 of rename
r55943@173-101-60-247 (orig r206):  jessev | 2008-12-16 15:08:52 -0800
step 2 of rename
r55944@173-101-60-247 (orig r207):  jessev | 2008-12-16 15:09:23 -0800
 oops
r55945@173-101-60-247 (orig r208):  jessev | 2008-12-16 15:34:01 -0800
* Even more progressive rename/unfork work
r55947@173-101-60-247 (orig r210):  jessev | 2008-12-16 16:16:43 -0800
* Doesn't work, but close to what danapple has recommended
r56039@173-101-60-247 (orig r213):  young.bradley | 2008-12-18 16:14:49 -0800
This is a working semi-deforked application.  i.e. most of it is still in the com.android.email namespace, but choice bits are in com.fsck.k9 so that it won't try to overwrite the builtin client.

Changes: corrected the package (or something equally simple for K9.java
build.xml has an additional stanza that copies the R.java file from fsck to android namespace, and changes the package inside the file.
AndroidManifest.xml has the package set to fsck, and all the activities are now explicity named.
r56040@173-101-60-247 (orig r214):  jessev | 2008-12-18 16:20:56 -0800
* merged from trunk as of r213
2008-12-19 00:29:29 +00:00
Jesse Vincent
5a55389835 merged from trunk as of r213 2008-12-19 00:20:56 +00:00
Bradley Young
14e6b87ee7 This is a working semi-deforked application. i.e. most of it is still in the com.android.email namespace, but choice bits are in com.fsck.k9 so that it won't try to overwrite the builtin client.
Changes: corrected the package (or something equally simple for K9.java
build.xml has an additional stanza that copies the R.java file from fsck to android namespace, and changes the package inside the file.
AndroidManifest.xml has the package set to fsck, and all the activities are now explicity named.
2008-12-19 00:14:49 +00:00
Bradley Young
b000da55d1 Added about dialog. 2008-12-18 05:44:47 +00:00
Bradley Young
abd81a81c1 Update the domain validator to accept ip addresses and "localhost" 2008-12-17 00:39:06 +00:00
Jesse Vincent
b5ab3c0dfc Doesn't work, but close to what danapple has recommended 2008-12-17 00:16:43 +00:00
Bradley Young
171648aa41 block server entries in AccountSetupIncoming.java and AccountSetupOutgoing.java that are not valid domain names. 2008-12-16 23:54:02 +00:00
Jesse Vincent
28e8827827 Even more progressive rename/unfork work 2008-12-16 23:34:01 +00:00
Jesse Vincent
ac55d3034b oops 2008-12-16 23:09:23 +00:00
Jesse Vincent
9204c61044 step 2 of rename 2008-12-16 23:08:52 +00:00
Jesse Vincent
eedfc0a839 step 1 of rename 2008-12-16 23:07:33 +00:00
Matthew Brace
b877a52b01 Update for folders to display the "path" that the folder resides in (ie, Inbox/Work/To Me) rather than just the name of the folder. Allows an easier understanding of the hierarchy until true folder trees can be implemented. 2008-12-16 02:06:39 +00:00
Jesse Vincent
dfa11df41b 0.22 2008-12-16 01:42:17 +00:00
Matthew Brace
a4a07ebe19 Fixed an authentication issue with WebDav support that caused by the last update. Added support for scrolling on 2 of the screens in the account setup process to allow the full steps to be done in landscape mode. There are some graphical regressions in portrait mode from it that aren't resolved yet. 2008-12-15 04:59:03 +00:00
Matthew Brace
c544596d8f Removed display of path prefix. System now pulls all folders/subfolders. Does not display in a hierarchy, but will load messages from each folder. Only the final folder name is displayed instead of the path off of Inbox right now 2008-12-15 02:18:02 +00:00
Matthew Brace
453406a5a5 Added change to populate the url for the mailbox each time authentication occurs (url is in the response). Updated initial message population to use reverse order so initial display has newest first (only noticeable on slow connections). 2008-12-14 19:33:34 +00:00
Bao-Long Nguyen-Trong
401e5ecf37 . Added the following 2 keyboard shortcuts in message list view:
. S: Setttings
  . L: Last auto sync date time
2008-12-14 08:25:08 +00:00
Bao-Long Nguyen-Trong
ec29561d8b . Fixe bug # 122: Some keyboard shortcuts only work when a message is selected 2008-12-14 06:37:58 +00:00
Bao-Long Nguyen-Trong
3217d4b772 . fixed bug # 87: Acccounts all refresh at the same freqency 2008-12-14 06:29:28 +00:00
Bao-Long Nguyen-Trong
dba525739e . Fixed bug # 82: Messages lose their read status when getting new emails from POP3 server 2008-12-14 06:23:03 +00:00
Bao-Long Nguyen-Trong
97d10d0d25 . FIxed bug # 81: Notifications never show up wen using POP3. 2008-12-14 06:18:24 +00:00
Bao-Long Nguyen-Trong
b0d68929a5 Added back auto-start of background message sync (most likely removed during merge) 2008-12-14 03:21:39 +00:00
Jesse Vincent
f961cac9ac Allow notification without ringtone 2008-12-11 19:13:55 +00:00
Jesse Vincent
1d6fa64d51 Revert commit 180, as it tries to do math with UIDs, which doesn't work 2008-12-11 18:32:34 +00:00
Jesse Vincent
2abc374f60 no need to version R.java 2008-12-11 18:13:14 +00:00
Matthew Brace
20b46255c0 devsk's patch to fix incorrect IMAP message fetching. Fix utilizes UIDNEXT to determine which messages to grab. 2008-12-11 07:03:00 +00:00
Matthew Brace
f273805ee3 Added user preference for the display limit of messages. The display limit is also used for the visible limit increment. If no limit is specified, the default limit is used. The limit is also account specific and not global. 2008-12-11 05:25:59 +00:00
Matthew Brace
8d3579fe74 More performance improvements. Still get occasional connection errors with 50+ messages viewable due to timeout issues. 2008-12-10 23:30:00 +00:00
Bradley Young
8b6a8c4bfa This should add the ability to change the "Sent Items" and "Deleted Items/Trash" folders in AccountSetupComposition.java. 2008-12-09 21:07:09 +00:00
Matthew Brace
852e513281 Modified fetch() to call fetchEnvelope() which runs recursively, grabbing message ENVELOPEs 10 at a time rather than attempting all 100 at once. Shows a significant performance increase and a significant reduction in memory usage. 2008-12-07 20:55:26 +00:00
Jesse Vincent
d1d8345278 Merge into 'trunk'
r51837@31b (orig r127):  ismarc31 | 2008-11-10 19:10:50 -0500
Experimental branch for Exchange WebDAV support

r51838@31b (orig r128):  ismarc31 | 2008-11-10 19:24:52 -0500
Initial proof-of-concept code for WebDav support

r51839@31b (orig r129):  ismarc31 | 2008-11-10 22:02:37 -0500
Fixed a couple of migration issues and enabled WebDav as a mail type

r53269@31b (orig r132):  ismarc31 | 2008-11-21 21:55:55 -0500
Mostly rewritten class and organization.  Better implementation of message fetching.
Consolidated response parsing.  Removed a large number of redundant calls.  There is still 
some unused functions needing cleaning up, and some unimplemented actions

r53338@31b (orig r133):  ismarc31 | 2008-11-22 16:50:02 -0500
Removed more redundant and unused calls.  Implemented checking read status

r53453@31b (orig r134):  ismarc31 | 2008-11-24 20:13:24 -0500
Added support for marking messages as read.

r53454@31b (orig r135):  ismarc31 | 2008-11-24 22:04:04 -0500
Added support for deleting messages server side

r53455@31b (orig r136):  ismarc31 | 2008-11-25 01:32:19 -0500
Improved flag setting functionality, do bulk HTTP request instead of lots of little ones

r53589@31b (orig r138):  young.bradley | 2008-11-29 16:18:25 -0500
Missing some ports (webDavPorts); this causes an array index out of bounds exception when anything other than "None" or "SSL (Optional)" are selected.

Adding the three additional ports solves this issue.
r53590@31b (orig r139):  young.bradley | 2008-11-30 00:47:42 -0500
Initial support for sending via WebDav
r53591@31b (orig r140):  ismarc31 | 2008-11-30 20:12:41 -0500
Fix for display names being URL Encoded for folders.  Initial support of Uid Hashmaps instead 
of plain arrays.

r53592@31b (orig r141):  ismarc31 | 2008-11-30 21:46:06 -0500
Fix to constructor of HttpGeneric(final String uri).  URLs returned from Exchange aren't 
always fully encoded, this fixes the encoding before creating the method.

r53593@31b (orig r142):  ismarc31 | 2008-12-01 02:22:16 -0500
Completed support for using hashmaps instead of arrays for indexing urls to emails and read 
status.  Delete is safe again and read status is correct the first time through.

r53594@31b (orig r143):  ismarc31 | 2008-12-01 22:20:50 -0500
Fix for double-Inbox display issue.  Removed volumous amounts of Log.d messages.

r53644@31b (orig r157):  young.bradley | 2008-12-04 15:14:28 -0500
Fix for wildcard certificates (e.g. issued to *.example.com).  Only checking the
trust of the certificate itself, since apparently the full chain causes it to
not work.
r53765@31b (orig r161):  ismarc31 | 2008-12-06 18:55:08 -0500
Implemented new functionality for pulling message envelope.  Uses a WebDAV call for all messages rather than parsing the stream.  Message size is properly set now as well.

r54055@31b (orig r163):  jessev | 2008-12-06 19:28:24 -0500
* merge fixes
2008-12-07 00:29:11 +00:00
Bradley Young
b8e686039f Removed some commented lines of code-- testing check in to the mainline 2008-12-04 22:15:43 +00:00
Jesse Vincent
c21097af65 2008-12-04 22:03:53 +00:00
Brock Tice
33d8d3bc24 Should fix issue 111. Checks to make sure that the selected folder matches what we're generating with prefix + delimeter. 2008-12-03 19:08:03 +00:00
Jesse Vincent
505ddcab52 Add a D keybinding to the FolderMessageList 2008-12-03 04:20:51 +00:00
Jesse Vincent
aba87657e7 switch from pages of 25 messages to pages of 100 2008-12-03 04:14:41 +00:00
Brock Tice
9d45b3604e Fixed prefix separator issues. Separators are now pulled from the separator column of folder listings. Also switched the default gmail IMAP server to imap.googlemail.com (from imap.gmail.com). 2008-12-03 04:14:39 +00:00
Jesse Vincent
351c825433 It helps when I don't back out the actual changes 2008-12-03 04:10:59 +00:00
Jesse Vincent
505d2866fc revert a mismerge from bradleyy's branch 2008-12-03 04:07:16 +00:00
Jesse Vincent
ebfbb9e5b2 small layout fixes 2008-12-03 04:02:54 +00:00
Jesse Vincent
a3d6e699ef layout cleanups 2008-12-03 00:50:35 +00:00
Jesse Vincent
194d673f91 Merge into 'trunk'
r124@hotel-dan (orig r123):  jessev | 2008-11-07 03:35:09 -0500
Branch for Bradley Young
r126@hotel-dan (orig r125):  young.bradley | 2008-11-08 17:27:30 -0500
Initial checkin of self signed certificates capability.

Missing ability to save updated KeyStore.
r127@hotel-dan (orig r126):  young.bradley | 2008-11-10 13:04:49 -0500
Update to allow saving updated keys to keystore
r17200@hotel-dan (orig r131):  young.bradley | 2008-11-17 14:09:24 -0500
Updates to handle chains properly, and handle default behavior.
r17206@hotel-dan (orig r137):  young.bradley | 2008-11-29 14:14:25 -0500
Checkin for beta 2: this should be the release candidate.
2008-12-03 00:04:24 +00:00
Jesse Vincent
9dbcae5eed shrink down the message list views to get toward something sane 2008-11-13 21:22:24 +00:00
Jesse Vincent
96653e828c * typo fix 2008-11-06 06:55:56 +00:00
Jesse Vincent
fa829ea9ff * Fix for Issue 65 - Intermittent failure of K-9 to background sync.
* Based on a patch provided by baolongnt++
    http://code.google.com/p/k9mail/issues/detail?id=65#c10
2008-11-06 06:55:41 +00:00
Jesse Vincent
38748c59ca * Fix for "Consistently getting 'Connection Error' messages when getting new mail on a POP3 account"
Patch for Issue 67 from baolongnt++.
2008-11-06 06:55:29 +00:00
Brock Tice
15ba4d0f39 Made "Load more messages" cue a little more informative.
Now pulls k9.VISIBLE_LIMIT_INCREMENT and says "Load up to (increment value) more".
Also, the build number was auto-updated by my build script. This shows up in the debug menu. It would be nice to have ant handle this, but I'm not sure how to make it do that.
2008-11-04 19:40:44 +00:00
Jesse Vincent
4e75e1b81b Added keyboard control for message zooming 2008-11-03 07:17:42 +00:00
Brock Tice
c1ad8cffaa Changed a += of a null string back to the appropriate = sign. 2008-11-03 07:14:31 +00:00
Brock Tice
734606f261 Fixed my fix for the IMAP prefixes and removed debugging/self-help lines. 2008-11-03 07:01:46 +00:00
Jesse Vincent
9838849b21 Enable saving all attachments to SD 2008-11-03 06:46:13 +00:00
Jesse Vincent
43adde216c restore linkifies HTTP URLs in plaintext mail messages 2008-11-03 06:36:53 +00:00
Brock Tice
be49a0c707 Removed eclipse files that appeared to be user-specific (sorry?)
Believe this fixes the IMAP prefix issue (27)
Trash still deletes itself, which is technically a separate issue, but now it deletes the *right* trash. :)

Create local branch for IMAP prefix fix (Issue 27)
r110@stilgar:  brock | 2008-11-03 00:08:29 -0500
Fixed IMAP prefix problem.
2008-11-03 06:12:04 +00:00
Jesse Vincent
0bbdeaaa6e FolderMessageList was lowercasing and comparing two strings. Using case-insensitve comparisons is much, much cheaper 2008-11-02 23:18:38 +00:00
Jesse Vincent
8bd2f9c260 Switch from using the mime4j charset list to the Java 1.5 java.nio.charset Charset class.
Based on this comment in MIME4J, this seems like a win:


 * Utility class for working with character sets. It is somewhat similar to
 * the Java 1.4 <code>java.nio.charset.Charset</code> class but knows many
 * more aliases and is compatible with Java 1.3. It will use a simple detection
 * mechanism to detect what character sets the current VM supports. This will
 * be a sub-set of the character sets listed in the
 * <a href="http://java.sun.com/j2se/1.5.0/docs/guide/intl/encoding.doc.html">
 * Java 1.5 (J2SE5.0) Supported Encodings</a> document.
 * <p>
 * The <a href="http://www.iana.org/assignments/character-sets">
 * IANA Character Sets</a> document has been used to determine the preferred
 * MIME character set names and to get a list of known aliases.
 * <p>
2008-11-02 23:17:59 +00:00
Jesse Vincent
27a0efcf1d Added a "d" keybinding for delete. from the message view 2008-11-02 23:13:58 +00:00
Richard Tibbetts
6cd5ce7dee Fix similar empty-cursor bug when creating a folder on open.
Turn tabs into spaces in code I changed last commit.
2008-11-02 03:56:13 +00:00
Richard Tibbetts
4f798ae9cc Fix local folder query to not die when there are no local folders, like on first install 2008-11-02 03:28:29 +00:00
Jesse Vincent
1548da7efd 0.12 releng 2008-11-01 23:10:56 +00:00
Jesse Vincent
4eb607d781 stop trying to count messages in every folder for folder lists that don't display them 2008-11-01 22:48:57 +00:00
Jesse Vincent
79c140378d 0.11 2008-11-01 22:30:21 +00:00
Jesse Vincent
5feb435b0f removing that empty call to the heavy query helps performance even more. 2008-11-01 22:24:15 +00:00
Jesse Vincent
046943b340 Remove O(n) deep SQL queries per folderlist by cleaning up the folder "exists" check on Local message stores
* Replace the extra SQL query before each folder 'open' with an exception if the open fails. (Optimize for the common case, not the exception)
2008-11-01 21:36:23 +00:00
Jesse Vincent
cd7a7a67fb Refactor the MessagingController to be a bit easier to tease apart. 2008-11-01 21:34:50 +00:00
Jesse Vincent
5491dee81b Damn it. Weird symlink-in-checkout bug. There goes our commit history. Sorry, all.
Guess I should go back to svk
2008-11-01 21:32:06 +00:00
Jesse Vincent
12c6e53141 bin directory should never have been checked in 2008-11-01 21:23:45 +00:00
Jesse Vincent
416aafb940 extract the 'upgrade database' method. Since K-9 never had a pre-v18 database, I'm inclined to kill it, except it may serve as a useful template for the future 2008-11-01 04:26:03 +00:00
Jesse Vincent
521783ffff typo in comment 2008-11-01 04:25:17 +00:00
Jesse Vincent
f8eb22f168 Factor out signature generation
* No longer generate a signature when we don't have one defined
2008-10-31 22:39:00 +00:00
Jesse Vincent
ac14fe8d02 Replace handrolled linkifier with android.text.util.Linkify. 2008-10-31 04:38:51 +00:00
Jesse Vincent
21f2d934b6 slightly tighter regex for the cheesy "do I show images" button 2008-10-31 04:08:55 +00:00
Jesse Vincent
8431087ca9 0.8 R file 2008-10-31 02:25:29 +00:00
Jesse Vincent
3962145185 Moving more composition preferences to the Composition settings page 2008-10-31 02:01:25 +00:00
Brock Tice
a49fc1c0a0 Undoing erroneous and not-agreed-upon removal of buttons in the message view 2008-10-30 20:01:24 +00:00
Brock Tice
68a2763f39 Removed bottom buttons in message view (reply, delete, etc...) 2008-10-30 17:55:30 +00:00
Brock Tice
f66bc47763 Removed the commented-out lines related to button removal. Should have been done on the last commit. Sorry. :( 2008-10-30 17:43:02 +00:00
Brock Tice
5e5d148bb7 Removed on-screen buttons in message compose view. 2008-10-30 17:38:26 +00:00
Jesse Vincent
36e67b111d removing a weirdly placed "add another account" from within an existing account's preferences 2008-10-30 05:09:32 +00:00
Jesse Vincent
36e5628a68 - stub out adding a mua header 2008-10-30 05:07:56 +00:00
Jesse Vincent
2a8b7a00e3 Added a "Signature" preference.
* Broke out mail composition preferences to their own page
2008-10-30 03:24:48 +00:00
Jesse Vincent
9de986ce04 Added the ability for users to change their accounts' return addresses
rspier++ for the idea
2008-10-29 07:09:16 +00:00
Jesse Vincent
0d0fb8a3b3 use 'localhost.localdomain' instead of 'localhost' when sending mail by smtp. This makes more mail servers happy 2008-10-29 06:24:48 +00:00
Jesse Vincent
cb900a83fe Release 0.5 2008-10-29 04:32:42 +00:00
Jesse Vincent
1f90bc1ea3 Fix for http://code.google.com/p/k9mail/issues/detail?id=18
- Empty messages now generate valid MIME
- Fix by brock.tice++
2008-10-29 04:29:29 +00:00
Jesse Vincent
0df7dff688 Fix for http://code.google.com/p/k9mail/issues/detail?id=19
- Support for tabs in IMAP ID response (for OS X Leopard Server support)
- Author: yostinso++
2008-10-29 04:20:50 +00:00
Jesse Vincent
cf6a2379a0 Actually save the AlwaysBcc preference 2008-10-29 04:17:10 +00:00
Jesse Vincent
ba3539df89 Added the code to make MessageComposition include the Bcc header. if only we could get it to save 2008-10-29 03:57:17 +00:00
Jesse Vincent
6b2f737982 more settings UI for "AlwaysBcc" 2008-10-29 03:52:20 +00:00
Jesse Vincent
3d4bfc1aa5 add an "always bcc this address" preference 2008-10-29 03:21:27 +00:00
Jesse Vincent
72443b0ee7 Fix for gcode issue #1 - - Can't use the hardware "back" button to back out of the message view 2008-10-28 15:17:24 +00:00
Jesse Vincent
bc6929e964 Added key bindings in message view 2008-10-28 06:20:22 +00:00
Jesse Vincent
ca569d9988 added more keybindings (Reply, reply All, Compose, Forward, Quit-to-index 2008-10-28 05:03:03 +00:00
Jesse Vincent
c7de66484d more renaming. 2008-10-28 02:14:16 +00:00
Jesse Vincent
70aeb47eda rename the app baseclass from Email to K9 2008-10-28 02:03:20 +00:00
Jesse Vincent
c00ec35921 Grand insane rename, step 3 2008-10-28 01:22:17 +00:00
Jesse Vincent
7051cf8cc0 move step 2 2008-10-28 01:19:57 +00:00
Jesse Vincent
0c8fd8496a move step 1, take 2 2008-10-28 01:19:26 +00:00
Jesse Vincent
a6956b5bae Added a "DELETE" keybinding in the FolderMessageList 2008-10-28 01:12:03 +00:00
Jesse Vincent
822b3b3daa Added support for propagating "Deleted" flags back to IMAP servers.
* Fixed a typo in original method names (really should have been another commit, but this is the initial upload)
2008-10-28 01:11:05 +00:00
Jesse Vincent
ffd7766384 Initial commit - This source code should be EXACTLY what the current version of the 'Email' application in the android repo looks like as of this date. 2008-10-28 01:04:44 +00:00