cketti
6f0bae80b9
Fix test in 'SmtpTransportTest'
...
We tested whether the connection was still open. But we should test
whether the connection was closed. The test passed most of the time
because closing a connection takes some time.
2019-05-24 13:45:29 +02:00
cketti
3ccabbf95f
Remove unused code
2019-03-09 19:31:54 +01:00
cketti
7c7ce6eb84
Remove Message.setRecipients() and manually set recipient headers
...
Use AddressHeaderBuilder to encode the recipient addresses and fold the
header value.
2019-02-14 02:28:36 +01:00
cketti
58d72e0df3
Add AddressHeaderBuilder to correctly fold recipient headers
2019-02-14 02:28:36 +01:00
cketti
47deb4e5ba
Switch to androidx artifacts
2019-02-09 22:08:25 +01:00
cketti
eeb820b958
Remove Folder.delete(boolean)
2019-01-10 00:15:35 +01:00
cketti
e4d7482bef
Add test to make sure hasCapability() opens a connection if necessary
2019-01-09 19:06:47 +01:00
cketti
2a4f1c4314
Don't only list special folders when SPECIAL-USE capability is present
2019-01-07 02:02:46 +01:00
cketti
0422268efc
Make sure connection has been opened before checking capability
2019-01-06 23:32:17 +01:00
cketti
2861d93a7f
Check for LIST-EXTENDED capability before issuing LIST with SPECIAL-USE
2018-12-21 18:57:16 +01:00
cketti
b5588a8d02
Remove compatibility code for pre-API 19 versions
2018-12-16 02:49:49 +01:00
Vincent Breitmoser
af09f7b02e
Merge pull request #3799 from k9mail/smtp-pipeline-first-error
...
Return first, rather than last, response for pipelined SMTP commands
2018-12-12 12:05:29 +01:00
Vincent Breitmoser
fda70cbea7
respect first overall negative reply in smtp pipelining
2018-12-10 17:21:10 +01:00
Vincent Breitmoser
d1c4701256
Merge pull request #3808 from artbristol/remove-exception-todo
...
Remove TODO
2018-12-10 12:55:12 +01:00
Art O Cathain
5e3141d236
Remove TODO
2018-12-09 14:06:17 +01:00
Vincent Breitmoser
3c663098b3
Use local ip statically for SMTP HELO/EHLO
2018-12-05 22:26:17 +01:00
Vincent Breitmoser
bad3f20852
add unit test for negative response in smtp pipeline
2018-12-05 15:58:23 +01:00
Vincent Breitmoser
64c6a14e77
Return first, rather than last, response for pipelined SMTP commands
2018-12-05 14:50:57 +01:00
Vincent Breitmoser
4333a3a16f
remove "hideHostnameWhenConnecting" from global settings
2018-12-05 14:39:08 +01:00
Vincent Breitmoser
c06e1a9d9b
always just send IP instead of hostname in SMTP EHLO message
...
Clients are very often behind NATs, which makes the hostname in
HELO/EHLO messages virtually useless these days. Attempting to figure
out a hostname we could use also led to issues with some strict Postfix
configurations (see https://github.com/k9mail/k-9/issues/3387 ). This
commit changes our behavior to simply send the local IP always, getting
rid of this metadata.
Fixes #3387
2018-12-05 14:36:06 +01:00
Vincent Breitmoser
e6e0d7c1c2
Merge pull request #3772 from k9mail/cleanup-localkeystore
...
Clean up LocalKeyStore and related
2018-12-02 05:08:03 +01:00
Vincent Breitmoser
268ccfc0ff
Stop ImapFolderPusher on CertificateValidationException
...
This is a permanent error, but apparently not treated as one. I got
a certificate error notification every two seconds just now (because
LocalKeyStore is broken, see #3772 ). This PR simply stops the pusher on
a certificate error.
2018-12-01 14:15:42 +01:00
Vincent Breitmoser
8fd2b56a67
clean up some warnings in trust management classes
2018-11-30 15:50:38 +01:00
Vincent Breitmoser
df85d7b0f3
Clean up TrustManager, KeyStore and SocketFactory use
2018-11-30 15:47:57 +01:00
Vincent Breitmoser
7819045e1b
Extract deletion and saving of accounts into AccountManager
2018-11-29 18:19:07 +01:00
Wiktor Kwapisiewicz
4e6d642ddd
Disallow Addresses with null
address part
...
This change ensures that Address objects are always created with a valid
`address` part. If an Address contains only `personal` part then it is
silently skipped from parsed list.
Unit tests have been adjusted to this new requirement.
Removed inserting Address with `null` address component introduced in
commit 68cecb168e
.
Fixes #3652 .
See: https://github.com/k9mail/k-9/pull/3739#issuecomment-441242481
2018-11-28 20:42:14 +01:00
cketti
72a664458e
Remove StoreConfig.set*Folder()
2018-11-13 20:38:46 +01:00
cketti
aecdbf5a6a
Add FolderType support to WebDavStore + WebDavBackend
2018-11-13 16:57:32 +01:00
cketti
cea3c41269
Add FolderType support to ImapStore + ImapBackend
2018-11-13 16:57:32 +01:00
cketti
91ae94d432
Add FolderType support to (Local)Folder
2018-11-13 16:57:32 +01:00
cketti
9711b42412
Remove unused Folder.FolderType
2018-11-09 14:19:36 +01:00
cketti
cda778e491
Remove unused method Message.clone()
2018-09-03 01:17:25 +02:00
cketti
83b6ab0620
Merge pull request #3570 from k9mail/mime_parameter_decoder
...
Add proper header parameter parser/decoder
2018-09-03 00:43:30 +02:00
cketti
56882dc6c3
Fix unresolved references in Javadoc comments
2018-09-03 00:13:58 +02:00
BO41
c043eb0df4
Replace explicit type arguments with <>
2018-09-02 23:35:09 +02:00
cketti
ffd57c4e86
Merge pull request #3589 from k9mail/BO41_code_cleanup
...
[Cleanup] Improve accessibility, correctness and performance
2018-09-02 23:04:02 +02:00
BO41
f24cb76d9e
Improve accessibility, correctness and performance
2018-09-02 22:49:48 +02:00
cketti
ae76f07ada
Merge pull request #3588 from k9mail/simplify_if_statements
...
[Cleanup] Simplify if statements
2018-09-02 22:48:21 +02:00
BO41
86dde4dabf
Remove unused imports
2018-09-02 22:31:34 +02:00
BO41
dbea2cafa6
Simplify if statements
2018-09-02 22:27:28 +02:00
cketti
5d98c15bce
Use MimeParameterEncoder and MimeParameterDecoder in MimeMessageHelper
2018-08-26 18:09:29 +02:00
cketti
5f7dac4556
Remove unwarranted usage of MimeUtility.unfoldAndDecode()
2018-08-26 17:18:22 +02:00
cketti
942ecb5a4e
Use MimeParameterDecoder to extract header parameters
2018-08-26 17:18:21 +02:00
cketti
4ea798fdf6
Make MimeParameterEncoder use functions in MimeExtensions.kt
2018-08-26 16:02:15 +02:00
cketti
95465ea6d7
Add proper parser for header parameters (RFC 2045 + RFC 2231)
2018-08-26 16:02:15 +02:00
cketti
5c50f367e4
Change AuthenticationFailedException to expose alert text from server
2018-08-14 16:08:30 +02:00
cketti
1f0f4285d2
Add support for local_only column to LocalFolder
2018-07-23 14:25:30 +02:00
cketti
87132562f8
Remove unused parameter
2018-07-22 18:31:41 +02:00
cketti
0af83029cc
Change ServerSettings#type to a String
2018-07-19 12:40:57 +02:00
cketti
50e955d2da
Remove default port information from ServerSettings.Type
2018-07-18 19:25:43 +02:00