Commit graph

249 commits

Author SHA1 Message Date
cketti
4c8dd420cf Merge pull request #2194 from philipwhiuk/removeNewLinesFromSubject
Remove trailing new lines from subject
2017-02-07 04:54:14 +01:00
Philip Whitehouse
be67e849c2 Remove new lines and rich-text formatting from subject field 2017-02-06 21:38:18 +00:00
Dominik Schürmann
e829196034 Set robolectric sdk to 22 2017-02-06 11:25:02 +01:00
cketti
da2012be1d Merge pull request #2186 from philipwhiuk/json-pending-command-rebase
Use json for serializing pending commands
2017-02-06 02:04:57 +01:00
cketti
78c7f01719 Clean up MigrationTo60Test 2017-02-06 01:41:03 +01:00
Dominik Schürmann
874943885f Update robolectric, use Runner classes 2017-02-05 23:44:35 +01:00
Dominik Schürmann
513a29ad3a Add encrypted.asc filename to PGP/MIME emails 2017-02-05 23:13:18 +01:00
Philip Whitehouse
af0c47c325 Additional tests for migration 2017-02-05 21:25:50 +00:00
cketti
5d2e28e8ed Avoid runtime type checks/casts 2017-02-05 07:13:25 +01:00
Philip Whitehouse
a2e33fcc23 Merge branch 'upstream-master' into json-pending-command-rebase 2017-02-05 01:21:36 +00:00
cketti
8c55e571f8 Merge pull request #2169 from k9mail/GH-1822_remove_parcelable_from_intent
Fix notification actions
2017-02-05 01:39:11 +01:00
Philip
f491e00bc5 Merge pull request #2158 from philipwhiuk/databaseMigrationVerification
Test and fix database upgrade process
2017-02-04 23:36:27 +00:00
Philip
d5a6286cb7 Merge pull request #2172 from philipwhiuk/emailHelperTest
Tests for EmailHelper
2017-02-04 22:49:35 +00:00
Philip
981ef44b55 Merge pull request #2171 from philipwhiuk/openPgpApiHelperTest
Tests for OpenPgpApiHelper
2017-02-04 22:49:10 +00:00
Philip
929f91ab56 Merge pull request #2170 from philipwhiuk/cacheTests
Basic behavioural tests of the EmailProviderCache
2017-02-04 22:48:51 +00:00
cketti
2d84b41e5c Merge pull request #2159 from k9mail/jsoup_preparation
Code refactoring in preparation of HtmlCleaner replacement
2017-02-04 23:36:26 +01:00
cketti
a52e0bd60a Avoid exception in MigrationTo43 during database tests 2017-02-04 22:50:06 +01:00
cketti
c3b4e0cfc2 Clean up StoreSchemaDefinitionTest 2017-02-04 22:34:31 +01:00
cketti
4805af02bf Code style fixes 2017-02-04 21:43:25 +01:00
Philip Whitehouse
8e06956d98 Tests for OpenPgpApiHelper 2017-02-04 11:21:15 +00:00
cketti
0a76ea609c Simplify MessageReference.equals() and hashCode() and add tests 2017-02-04 02:03:18 +01:00
Philip Whitehouse
0b9fb4c2ad Tests for EmailHelper 2017-02-04 00:25:22 +00:00
Philip Whitehouse
39804b8e3c Basic behavioural tests of the EmailProviderCache 2017-02-03 23:41:05 +00:00
cketti
8760849f79 Refactor MessageReference 2017-02-03 03:12:32 +01:00
cketti
c60f97fb7e Merge pull request #2069 from k9mail/optimize-message-sync
Don't load all local message metadata into memory during synchronize
2017-01-31 20:24:53 +01:00
cketti
e8cddf6a28 Remove unnecessary import 2017-01-31 17:29:28 +01:00
cketti
1ffaf1d392 Move classes related to message quoting to dedicated package 2017-01-31 05:58:24 +01:00
cketti
695432f6cf Add tests for signature removers 2017-01-31 05:58:24 +01:00
Philip Whitehouse
0c5fedb504 Add tests for database migration 2017-01-30 23:49:44 +00:00
Philip Whitehouse
67ade96101 Better determination of whether a draft needs saving 2017-01-30 21:22:07 +00:00
cketti
2c04f66346 Move HTML-related classes to 'html' package 2017-01-29 23:04:36 +01:00
Vincent Breitmoser
79c65d4cff don't load all local message metadata into memory during synchronize 2017-01-27 19:33:17 +01:00
Vincent Breitmoser
7bf9d7ec08 Merge pull request #2131 from k9mail/settings-cleanup
Settings classes cleanup
2017-01-25 17:36:35 +01:00
cketti
24a4e3a4fb Fix typo 2017-01-24 23:43:49 +01:00
Philip Whitehouse
4ae85ddd38 Fix behaviour of summary notifications 2017-01-23 22:03:13 +00:00
Philip
0dd7a4aafe Merge pull request #2118 from philipwhiuk/handleInvalidHtmlBetter
Handle invalid HTML better
2017-01-22 20:40:22 +00:00
Philip Whitehouse
b15636a3ca Tidying up existing HtmlSanitizer tests to use standard style 2017-01-22 19:50:45 +00:00
Philip Whitehouse
5301639045 Handle invalid HTML better 2017-01-22 19:50:30 +00:00
Philip Whitehouse
0383fbe4fa Fix 'Fetching headers null:Folder' 2017-01-21 15:28:05 +00:00
cketti
fb1de9453a Merge pull request #2076 from jca02266/master
Don't use default charset to pass the test
2017-01-17 14:56:11 +01:00
Koji Arai
5633ddbeaf Don't use default charset to pass the test 2017-01-17 22:10:39 +09:00
cketti
6d104bd860 Merge pull request #2035 from GoneUp/importNameFix2
Fixed empty account name at import dialog
2017-01-15 23:16:16 +01:00
cketti
f5e837cc21 Merge pull request #2036 from k9mail/encrypted-multipart-alternative
Handle encrypted parts in multipart/alternative
2017-01-15 22:57:24 +01:00
cketti
25d977a813 Code style fixes 2017-01-12 06:29:45 +01:00
cketti
dbb5180e1e Merge pull request #1983 from k9mail/draft-fixes
Don't upload draft if PgpMessageBuilder is used
2017-01-12 06:19:40 +01:00
cketti
da7ea43f77 Add some tests for MessageDecryptVerifier 2017-01-12 04:49:42 +01:00
GoneUp
f457de3821 Added tests 2017-01-10 21:10:44 +01:00
Vincent Breitmoser
085debbb5b don't save draft iff PgpMessageBuilder is used 2017-01-10 15:12:44 +01:00
Vincent Breitmoser
0644fa0481 more tests for RecipientPresenter 2017-01-10 15:12:44 +01:00
Vincent Breitmoser
a44129b7a9 Revert "remove support for clearsigned messages in PgpMessageBuilder"
This reverts commit ef3cda97e2.
2017-01-06 02:28:51 +01:00
cketti
0fe74e59cc Don't hardcode check for version in SettingsExporterTest
Otherwise every time we add a setting this test needs to be touched.
2017-01-04 23:56:59 +01:00
Vincent Breitmoser
a055ed42a8 don't handle format parameter in setBody(), style fixes 2016-12-12 14:24:30 +01:00
Vincent Breitmoser
dc3d1f0e87 support display of format=flowed (rfc2646) 2016-12-12 14:24:30 +01:00
cketti
db1b97d23f Fix tests 2016-12-12 06:51:28 +01:00
cketti
29dc3dd03c Merge pull request #1808 from philipwhiuk/testingSettingsImportExport
Testing for settings import and export
2016-12-12 01:04:58 +01:00
cketti
5fca3c871d Merge pull request #1847 from k9mail/multipart-attachments
Handle attachments with CHILD_PART_CONTAINS_DATA data location
2016-12-11 02:45:00 +01:00
Vincent Breitmoser
0ecbf441c1 handle attachments with CHILD_PART_CONTAINS_DATA data location (message/rfc822) 2016-12-11 02:33:56 +01:00
cketti
87e13ef800 Merge pull request #1836 from k9mail/multipart-digest-content-type
Properly handle multipart/digest content type
2016-12-09 00:18:59 +01:00
Vincent Breitmoser
7bd85189ce add test for multipart/digest message 2016-12-07 00:23:28 +01:00
Vincent Breitmoser
422806f622 ignore leading whitespace for pgp/inline messages in MessageDecryptVerifier (fixes #1823) 2016-11-29 19:22:31 +01:00
Philip Whitehouse
f03a01f6dc BDD new lines 2016-11-27 02:16:15 +00:00
Philip Whitehouse
6f82dea315 Testing for SettingsExporter 2016-11-22 01:52:57 +00:00
Philip Whitehouse
68b670e7d8 Testing for SettingsImporter 2016-11-22 01:24:41 +00:00
Vincent Breitmoser
ef3cda97e2 remove support for clearsigned messages in PgpMessageBuilder 2016-11-14 18:56:26 +01:00
Vincent Breitmoser
640322d46d add "name" parameter to signature content-type header 2016-11-12 22:08:43 +01:00
Vincent Breitmoser
4e17fdf1a6 remove "always sign, encrypt if possible" mode of operation from PgpMessageBuilder 2016-11-12 21:53:02 +01:00
Vincent Breitmoser
cedaecb38e Merge pull request #1769 from k9mail/attachment-ninjafix
use AttachmentTempFileProvider to expose file-backed content uris
2016-11-08 11:21:39 +01:00
cketti
bc41d9124e Merge pull request #1714
Added some more coverage to the MessageReferenceTest
2016-11-08 11:16:39 +01:00
cketti
5b0544cbab Clean up new tests 2016-11-08 11:13:57 +01:00
Vincent Breitmoser
be45380415 use AttachmentTempFileProvider to expose file-backed content uris 2016-11-03 13:57:19 +01:00
Vincent Breitmoser
380fd94b22 some more tests for PgpMessageBuilder 2016-11-02 14:30:51 +01:00
Vincent Breitmoser
c7a637f21b don't sign in opportunistic mode if sign-only isn't supported 2016-10-31 07:57:08 +01:00
cketti
ffd051b0ec Don't use same notification group key for all accounts 2016-10-18 06:21:25 +02:00
Jonas Lundqvist
21df74f7f4
Added test for MessageReference.withModifiedFlag() 2016-10-12 23:45:59 +02:00
Jonas Lundqvist
6ab4c3b3e6
Added test for MessageReference.withModifiedUid() 2016-10-12 23:45:55 +02:00
cketti
2087f0476c Merge pull request #1691
Improve Activity operation text

Fixes #1685
2016-10-12 16:23:57 +02:00
cketti
e511b8b7c1 Further clean up of ActivityListenerTest
* \u0020 is a hack required to have spaces at the beginning of resource
  strings. But there's no need to replicate this inside our tests.
* Dependencies shouldn't be static finals.
* Initialization of dependencies is usually boring. I like to extract that
  code to methods and put them at the end of the file.
* Using different values for 'current progress' and 'total' has the
  advantage of breaking tests when the two accidentally get mixed up.
2016-10-12 16:18:23 +02:00
Vincent Breitmoser
a88ccfd9e8 avoid indirect call to invalidateOptionsMenu() before recipientPresenter is initialized 2016-10-11 11:42:20 +02:00
Philip Whitehouse
0fff2ffd08 Update to Robolectric 3.1.1 and tidy up code 2016-10-09 02:21:14 +01:00
Philip
302b668d58 On removing notification, mark it's ID no longer in use (#1677)
On removing notification, mark it's ID no longer in use

Fixes #1662
2016-10-08 00:54:15 +02:00
Philip Whitehouse
53f3d549f7 Set account name when syncing headers & use correct folder name to generate display name 2016-10-07 23:14:54 +01:00
cketti
91c0b4274b Clean up MessageBuilderTest 2016-10-07 05:40:20 +02:00
Philip Whitehouse
0cd52bc26b Use the correct order for alternatives when building HTML messages
Fixes #1625
2016-10-07 01:09:31 +01:00
Vincent Breitmoser
f6e19680b0 add test for message/rfc822 attachment 2016-08-19 22:21:43 +02:00
Vincent Breitmoser
77a3892b0f fix unit tests for 7bit/quoted-printable encoding 2016-08-19 22:21:43 +02:00
Vincent Breitmoser
08ef3d5ce5 clean up TextBody, make it slightly more failfast
Previously, TextBody supported only 8bit or quoted printable encodings,
defaulting to quoted printable if the encoding was not equal to "8bit".
This behavior is now changed to throw a runtime exception when an
unsupported encoding has been selected. The `setEncoding` method also
throws if an unsupported encoding is selected.
2016-08-16 12:21:09 +02:00
cketti
0bc5b49bb5 Fix MessageBuilderTest 2016-08-16 00:40:23 +02:00
cketti
77f9e82b41 Merge pull request #1559 from k9mail/deferred-file-body-fix
Fix DeferredFileBody
2016-08-16 00:07:41 +02:00
cketti
411ec0ec34 Use 'newInstance' as name for static factory methods 2016-08-15 11:48:36 +02:00
cketti
84cef1d8b1 Get rid of trivial static factory methods 2016-08-15 11:42:47 +02:00
cketti
7719153cc0 Extract code to generate Message-Id header value
This moves Message closer to being a dumb data class and avoids having to
pass around a UuidGenerator reference.
2016-08-15 10:22:17 +02:00
Vincent Breitmoser
f5656c331d add tests for DeferredFileBody 2016-08-11 15:54:25 +02:00
Vincent Breitmoser
1e97f1ce16 inject UuidGenerator into MimeMessage via constructor instead of parameter 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
bb8e5a68df rename UUIDGenerator to UuidGenerator 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
1c28e1c601 add MessageBuilder test for message with attachment 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
cd011349fe make send date and timezone hiding build parameters in MessageBuilder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
874b981ba6 get message boundaries from injected BoundaryGenerator in MessageBuilder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
f4b0521bbb get uuid from injected generator in message builder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
d6c50b4db6 add unit tests for PendingCommand serialization 2016-08-10 13:45:02 +02:00
Vincent Breitmoser
73c2b1e9ad add unit tests for PendingCommand migration 2016-08-10 13:45:02 +02:00