cketti
c234578271
Don't inject BoundaryGenerator into MimeMultipart
2016-08-15 11:14:38 +02:00
cketti
7719153cc0
Extract code to generate Message-Id header value
...
This moves Message closer to being a dumb data class and avoids having to
pass around a UuidGenerator reference.
2016-08-15 10:22:17 +02:00
Vincent Breitmoser
4d9283f124
construct MessageBuilder classes in factory methods
2016-08-10 14:49:12 +02:00
Vincent Breitmoser
1e97f1ce16
inject UuidGenerator into MimeMessage via constructor instead of parameter
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
bb8e5a68df
rename UUIDGenerator to UuidGenerator
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
1c28e1c601
add MessageBuilder test for message with attachment
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
cd011349fe
make send date and timezone hiding build parameters in MessageBuilder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
874b981ba6
get message boundaries from injected BoundaryGenerator in MessageBuilder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
f4b0521bbb
get uuid from injected generator in message builder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
438576b547
minimize visibility in MessagingController (and some small code style fixes)
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
8647b4c8dd
minor fixes for clarity of foreground priority commands
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
0dfcdbdfc4
hide the Runnable interface as an implementation detail of MessagingController
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
6596c85a9f
clean up fields a bit in MessagingController
2016-08-10 10:41:39 +02:00
Vincent Breitmoser
03baf1afc2
make memorizingMessagingListener final, and respect that it can't actually be null
2016-08-10 10:41:32 +02:00
Vincent Breitmoser
a0a341e479
move MemorizingListener into its own class
2016-08-10 10:41:32 +02:00
Vincent Breitmoser
8d24e036b7
fix a bunch of warnings in MessagingController (no semantic changes)
2016-08-10 10:41:32 +02:00
cketti
904c80dd22
Merge pull request #1555 from k9mail/alternate-recip-fix
...
Small fix for alternate recipient adapter
2016-08-10 05:33:15 +02:00
cketti
b40d64eee4
Merge pull request #1545 from k9mail/safecontentresolver_update
...
Update SafeContentResolver to 0.9.0
2016-08-10 05:14:18 +02:00
Vincent Breitmoser
a2674efff1
compose: small fixes for alternate recipient adapter
...
this slightly alters behavior when a non-contact address is picked, to
make sure a crypto status is shown in the alternate dropdown.
2016-08-09 13:36:19 +02:00
cketti
ecb0044cc4
Merge pull request #1527 from k9mail/message-reference-ops
...
pass MessageReference instead of LocalMessage to MessagingController operations
2016-08-05 05:56:07 +02:00
cketti
915f44ab14
Merge pull request #1537 from k9mail/compose-attachments-from-viewinfo
...
Load attachments from AttachmentViewInfo in AttachmentPresenter
2016-08-05 04:33:03 +02:00
cketti
07a99137d1
Update SafeContentResolver to 0.9.0
2016-08-05 02:22:42 +02:00
Vincent Breitmoser
ed84f2958c
remove a couple of unused icons
...
I kept the sources around, so they can more easily be restored should we
need some of those again.
2016-08-03 17:11:22 +02:00
Vincent Breitmoser
4449e5c0d7
use vector drawables for all openpgp icons
2016-08-03 16:46:53 +02:00
Vincent Breitmoser
0f3ce1bf1c
pass MessageReference instead of LocalMessage to MessagingController operations
...
The most significant change here is that LocalMessage data is loaded in
MessagingController, instead of every calling site individually.
2016-08-02 18:47:04 +02:00
cketti
403323c94f
Merge pull request #1529 from k9mail/fix-crash-on-no-headers
...
Don't crash if headers aren't available
2016-08-02 18:23:47 +02:00
cketti
a47e5bf3d2
Merge pull request #1536 from k9mail/compose-complete-on-send
...
Try performing recipient completion on send
2016-08-02 18:07:24 +02:00
cketti
9fd2cf3bf1
Merge pull request #1535 from k9mail/compose-non-ascii-error
...
Show parse error for non-ASCII characters in address
2016-08-02 18:05:12 +02:00
cketti
54b3bac672
Merge pull request #1528 from k9mail/fix-mlh-loadMessageRemoteFinished
...
Fix logic in MessageLoaderHelper
2016-08-02 17:22:15 +02:00
cketti
2626cb1115
Merge pull request #1523 from k9mail/server_name_suggestion
...
Suggest server name based on server type
2016-08-02 15:40:01 +02:00
Vincent Breitmoser
d276bbda3e
load draft attachments from AttachmentViewInfo
2016-08-01 16:53:12 +02:00
Vincent Breitmoser
450356b577
add flag whether data is available to AttachmentViewInfo
2016-08-01 16:03:22 +02:00
Vincent Breitmoser
b3f2974962
compose: try performing recipient completion on send ( fixes #1495 )
...
This commit performs completion on recipient fields when the send button
is clicked (uncompleted text is usually present if the cursor is on the
recipient field at that time).
If any completion was performed, sending is quietly aborted. This avoids
sending mail to the wrong recipient if the uncompleted text doesn't
resolve to what the user thought.
2016-08-01 15:33:05 +02:00
Vincent Breitmoser
43cd25cfa3
compose: show parse error for non-ascii characters in address
2016-08-01 15:04:27 +02:00
Vincent Breitmoser
8399c9f161
don't crash if headers aren't available
2016-07-29 20:57:26 +02:00
Vincent Breitmoser
0b0a8a46ef
fix logic in MessageLoaderHelper
2016-07-29 20:56:14 +02:00
Vincent Breitmoser
a40a33e1da
delete abandoned CryptoHelper class
2016-07-28 14:53:58 +02:00
Vincent Breitmoser
f87a9cad49
don't throw MessagingExceptions for getting headers from parts
2016-07-28 14:53:58 +02:00
Vincent Breitmoser
2b5064ea55
always load headers immediately for LocalMessage
2016-07-28 14:53:57 +02:00
Vincent Breitmoser
3f0fb9fd3e
change tests to use more actual Part/Body classes instead of mocks
2016-07-28 14:53:57 +02:00
cketti
1cb32b0ce5
Suggest server name based on server type
2016-07-25 05:45:07 +02:00
Vincent Breitmoser
fa998981f7
add handling for LocalMessage parts to AttachmentInfoExtractor
2016-07-25 01:39:06 +02:00
Vincent Breitmoser
e03df3d991
improve error handling when opening missing parts (don't crash at least)
2016-07-25 01:39:06 +02:00
cketti
d80a1d415a
Merge pull request #1510
...
Loader helper fixes
2016-07-25 01:01:34 +02:00
Vincent Breitmoser
af5856d28f
avoid leaking data to MessagingController via MessageLoaderHelper after detach
...
null handling is already present: no ui methods should ever be called
after onDestroy or onDetachChangingConfigurations, and pending result
callbacks are handled by a null-check for the callback field.
2016-07-25 00:59:07 +02:00
Vincent Breitmoser
0993d91473
only care for our own MessageReference in MessageLoaderHelper
2016-07-25 00:59:07 +02:00
Vincent Breitmoser
471754241d
Merge pull request #1514 from k9mail/dont-trust-downloaded-flag
...
don't trust X_DOWNLOADED_FULL flag, consider messages with missing data incomplete (WIP)
2016-07-24 23:43:02 +02:00
Vincent Breitmoser
489cf354fd
don't pass LocalMessage from onMessageViewInfoLoadFinished/Failed
2016-07-24 23:40:12 +02:00
Vincent Breitmoser
174f99b94c
don't trust X_DOWNLOADED_FULL flag, consider messages with missing on-disk data incomplete
2016-07-24 23:40:12 +02:00
cketti
9c46f68b7f
Merge pull request #1515 from k9mail/hidden-attachments
...
Ditch "hidden attachments"
2016-07-24 22:54:32 +02:00