Commit graph

1295 commits

Author SHA1 Message Date
Vincent Breitmoser
01df652dc7 don't create superfluous RetainFragments 2017-02-08 03:16:12 +01:00
Philip Whitehouse
6ebe298fa0 Clear folder using the MessagingController instead of on the UI thread 2017-02-07 21:37:21 +00:00
cketti
47a5b5288f Avoid NULL values in result set of sub-query 2017-02-07 21:12:05 +01:00
cketti
19b7d4491d Merge pull request #2193 from k9mail/robolectric-update
Update robolectric, use Runner class instead of annotations
2017-02-07 05:06:39 +01:00
cketti
4c8dd420cf Merge pull request #2194 from philipwhiuk/removeNewLinesFromSubject
Remove trailing new lines from subject
2017-02-07 04:54:14 +01:00
cketti
17863cfeaf Merge pull request #2196 from k9mail/rework_AttachmentInfoExtractor
Avoid static reference to AttachmentInfoExtractor
2017-02-07 04:23:22 +01:00
cketti
7aa784f16d Merge pull request #2195 from k9mail/rework_ClipboardManager
Rework ClipboardManager to avoid leaking Context
2017-02-07 04:23:01 +01:00
Philip Whitehouse
be67e849c2 Remove new lines and rich-text formatting from subject field 2017-02-06 21:38:18 +00:00
cketti
5d52fb0bb7 Merge pull request #2198 from bug-bulletin-forks/fix-parsing-errors
Fix two unparsable Javadoc comments
2017-02-06 14:49:51 +01:00
Dominik Schürmann
e829196034 Set robolectric sdk to 22 2017-02-06 11:25:02 +01:00
Sebastian Kürten
f4b3ef3b41 Fix a few Javadoc typos 2017-02-06 08:48:24 +01:00
Sebastian Kürten
fca9eaf113 Fix two unparsable Javadoc comments 2017-02-06 08:16:04 +01:00
cketti
e96718f3a0 Avoid static reference to AttachmentInfoExtractor 2017-02-06 03:55:31 +01:00
cketti
15b6a91914 Clean up ClipboardManager 2017-02-06 03:30:34 +01:00
cketti
f82beb4287 Change ClipboardManager to no longer be a singleton
This avoids holding onto a Context instance in a static field.
2017-02-06 03:28:09 +01:00
cketti
da2012be1d Merge pull request #2186 from philipwhiuk/json-pending-command-rebase
Use json for serializing pending commands
2017-02-06 02:04:57 +01:00
cketti
78c7f01719 Clean up MigrationTo60Test 2017-02-06 01:41:03 +01:00
Dominik Schürmann
874943885f Update robolectric, use Runner classes 2017-02-05 23:44:35 +01:00
Dominik Schürmann
513a29ad3a Add encrypted.asc filename to PGP/MIME emails 2017-02-05 23:13:18 +01:00
Philip Whitehouse
af0c47c325 Additional tests for migration 2017-02-05 21:25:50 +00:00
cketti
5d2e28e8ed Avoid runtime type checks/casts 2017-02-05 07:13:25 +01:00
cketti
8179d88113 Clean up MigrationTo60 2017-02-05 06:05:28 +01:00
Philip Whitehouse
a2e33fcc23 Merge branch 'upstream-master' into json-pending-command-rebase 2017-02-05 01:21:36 +00:00
cketti
1c1be7ff8e Merge pull request #2178 from philipwhiuk/fixArrayResourceLintWarning
SliderPreference - Fix lint warning
2017-02-05 01:40:44 +01:00
cketti
8c55e571f8 Merge pull request #2169 from k9mail/GH-1822_remove_parcelable_from_intent
Fix notification actions
2017-02-05 01:39:11 +01:00
Philip
f491e00bc5 Merge pull request #2158 from philipwhiuk/databaseMigrationVerification
Test and fix database upgrade process
2017-02-04 23:36:27 +00:00
Philip
b79673bf6f Merge pull request #2174 from philipwhiuk/addDebugToMessagingController
Add additional debug to diagnose message sync issues
2017-02-04 23:25:22 +00:00
Philip
4564f57f01 Merge pull request #2182 from philipwhiuk/fixHardcodedText
Move hardcoded text to string resources
2017-02-04 23:25:02 +00:00
Philip
7aa4462115 Merge pull request #2184 from philipwhiuk/abstractK9Activity
Make base activities abstract
2017-02-04 23:24:12 +00:00
Philip
d5a6286cb7 Merge pull request #2172 from philipwhiuk/emailHelperTest
Tests for EmailHelper
2017-02-04 22:49:35 +00:00
Philip
981ef44b55 Merge pull request #2171 from philipwhiuk/openPgpApiHelperTest
Tests for OpenPgpApiHelper
2017-02-04 22:49:10 +00:00
Philip
929f91ab56 Merge pull request #2170 from philipwhiuk/cacheTests
Basic behavioural tests of the EmailProviderCache
2017-02-04 22:48:51 +00:00
cketti
2d84b41e5c Merge pull request #2159 from k9mail/jsoup_preparation
Code refactoring in preparation of HtmlCleaner replacement
2017-02-04 23:36:26 +01:00
Philip Whitehouse
5efe6b2cf7 Make base activities abstract 2017-02-04 22:04:32 +00:00
cketti
a52e0bd60a Avoid exception in MigrationTo43 during database tests 2017-02-04 22:50:06 +01:00
cketti
c3b4e0cfc2 Clean up StoreSchemaDefinitionTest 2017-02-04 22:34:31 +01:00
Philip Whitehouse
b7ed3b9d88 Move hardcoded text to string resources 2017-02-04 21:21:19 +00:00
cketti
4805af02bf Code style fixes 2017-02-04 21:43:25 +01:00
Philip Whitehouse
4cd7fd6e47 MessageProviderTest - Clean up cursor usage 2017-02-04 18:01:27 +00:00
Philip Whitehouse
76b9860e09 SliderPreference - Fix lint warning 2017-02-04 17:56:24 +00:00
Philip Whitehouse
859db0ce10 MessageProvider - Test basic behaviour 2017-02-04 15:56:42 +00:00
Philip Whitehouse
15f199de36 MessageProvider - Refactor declaration of projections and ensure accounts are listed in unread queries 2017-02-04 15:56:14 +00:00
Philip Whitehouse
07416badc8 Fix issue performing searches when a special folder is null 2017-02-04 15:55:02 +00:00
Philip Whitehouse
8512b23633 Update Espresso-Core test library to v2.2.2 2017-02-04 15:54:01 +00:00
Philip Whitehouse
8e06956d98 Tests for OpenPgpApiHelper 2017-02-04 11:21:15 +00:00
Philip Whitehouse
67e304a42a Add additional debug to diagnose message sync issues 2017-02-04 11:06:45 +00:00
cketti
0a76ea609c Simplify MessageReference.equals() and hashCode() and add tests 2017-02-04 02:03:18 +01:00
Philip Whitehouse
0b9fb4c2ad Tests for EmailHelper 2017-02-04 00:25:22 +00:00
Philip Whitehouse
39804b8e3c Basic behavioural tests of the EmailProviderCache 2017-02-03 23:41:05 +00:00
cketti
957b618092 Don't use Parcelable in Intents that can be launched from notifications 2017-02-03 06:05:45 +01:00
cketti
9b7ed6e9a6 Make MessageReference not implement Parcelable anymore 2017-02-03 06:00:36 +01:00
cketti
8760849f79 Refactor MessageReference 2017-02-03 03:12:32 +01:00
cketti
7fd404c1dd Remove unused method 2017-02-02 20:56:01 +01:00
cketti
f1457d58f6 Remove unused imports 2017-02-02 19:37:28 +01:00
cketti
3380ea986e Fix order of modifiers 2017-02-02 19:36:38 +01:00
cketti
c60f97fb7e Merge pull request #2069 from k9mail/optimize-message-sync
Don't load all local message metadata into memory during synchronize
2017-01-31 20:24:53 +01:00
cketti
e8cddf6a28 Remove unnecessary import 2017-01-31 17:29:28 +01:00
Philip Whitehouse
4a8d93b572 Add missing indexes in new database migration step 2017-01-31 12:51:47 +00:00
cketti
1ffaf1d392 Move classes related to message quoting to dedicated package 2017-01-31 05:58:24 +01:00
cketti
695432f6cf Add tests for signature removers 2017-01-31 05:58:24 +01:00
Philip Whitehouse
0c5fedb504 Add tests for database migration 2017-01-30 23:49:44 +00:00
Philip Whitehouse
67ade96101 Better determination of whether a draft needs saving 2017-01-30 21:22:07 +00:00
cketti
fc0e83cca2 Extract code to remove a message signature 2017-01-30 03:32:03 +01:00
cketti
d5194a1c34 Extract BodyTextExtractor from QuotedMessageHelper 2017-01-29 23:19:43 +01:00
cketti
2c04f66346 Move HTML-related classes to 'html' package 2017-01-29 23:04:36 +01:00
cketti
f228abd348 Avoid NullPointerException and creation of Date instances 2017-01-29 20:43:14 +01:00
Vincent Breitmoser
79c65d4cff don't load all local message metadata into memory during synchronize 2017-01-27 19:33:17 +01:00
cketti
2f14e6fcbc Reorder methods 2017-01-26 21:21:49 +01:00
cketti
646893f5fb Clean up MessageProvider 2017-01-26 21:16:41 +01:00
cketti
2825f88520 Code style fixes 2017-01-26 21:02:07 +01:00
cketti
86ca14558b Remove unused parameter 2017-01-26 20:29:40 +01:00
cketti
0d4d39acaa Code style fixes 2017-01-26 20:27:38 +01:00
cketti
a357963d32 Code style fixes 2017-01-26 19:45:32 +01:00
cketti
9180c2c1e3 Clean up switch statements 2017-01-26 19:45:32 +01:00
cketti
417f273bac Remove unused parameters 2017-01-26 19:45:32 +01:00
Vincent Breitmoser
7a39e7c48b clean up compose and related classes (no semantic changes) 2017-01-26 19:45:32 +01:00
Vincent Breitmoser
a77a632b72 Display warning on encrypted-only messages 2017-01-26 18:01:02 +01:00
cketti
9e102a571b Merge pull request #2137 from k9mail/GH-2103_fix_database_trigger
Add database migration to clean up orphaned data
2017-01-26 14:41:14 +01:00
cketti
4b83da75ee Merge pull request #2068 from k9mail/fix-alternate-selection
Fix broken referencing of recipient token in RecipientSelectView
2017-01-26 10:38:37 +01:00
cketti
c478f64a13 Merge pull request #2126 from philipwhiuk/notificationCategory
Set appropriate categories for notifications
2017-01-26 10:31:55 +01:00
Philip Whitehouse
65c4f86105 Set appropriate categories for notifications 2017-01-26 00:30:42 +00:00
Vincent Breitmoser
7bf9d7ec08 Merge pull request #2131 from k9mail/settings-cleanup
Settings classes cleanup
2017-01-25 17:36:35 +01:00
cketti
bf881cd3c2 Merge pull request #2124 from philipwhiuk/summaryNotificationFix
Fix behavior of summary notifications
2017-01-25 16:25:27 +01:00
cketti
9254e7a052 Add database migration to clean up orphaned data
Also extend database trigger to remove entries from messages_fulltext.
2017-01-25 16:11:44 +01:00
cketti
1697be33fa Remove mostly useless JavaDoc comments 2017-01-25 00:04:18 +01:00
cketti
38a19dbd28 Reformat code 2017-01-24 23:52:03 +01:00
cketti
24a4e3a4fb Fix typo 2017-01-24 23:43:49 +01:00
cketti
23603278ea Remove 'm' prefix from fields 2017-01-24 23:41:28 +01:00
cketti
62acbfcd81 Use T as type parameter name 2017-01-24 23:11:08 +01:00
cketti
2710fd3d8d Remove unnecessary line breaks 2017-01-24 23:00:53 +01:00
Vincent Breitmoser
f5b8a56c8a add non-null assertion to Settings.upgrade 2017-01-24 19:47:18 +01:00
Vincent Breitmoser
7e1482636d clean up SettingsImporter 2017-01-24 19:47:18 +01:00
Vincent Breitmoser
2583a5336b clean up SettingsExporter 2017-01-24 19:17:47 +01:00
Vincent Breitmoser
a9a69a031e break down Settings.upgrade method into submethods 2017-01-24 19:17:47 +01:00
Vincent Breitmoser
045fd63760 clean up more warnings (no semantic changes) 2017-01-24 16:46:53 +01:00
Vincent Breitmoser
cad7da10d6 use generics for all SettingsDescription subclasses 2017-01-24 16:45:32 +01:00
Vincent Breitmoser
a6dfa14af2 refactor settings (no semantic changes) 2017-01-24 15:42:22 +01:00
Vincent Breitmoser
434cd7735a add missing pgpSignOnlyDialogCounter to GlobalSettings 2017-01-24 13:39:04 +01:00
Vincent Breitmoser
48e3b4293e fix broken referencing of recipient token in RecipientSelectView
Passing through the actual recipient object was broken in
a2674efff1. I changed the code to no
longer rely on the actual object being passed through correctly, but
just one that fulfills `equals`.
2017-01-24 13:06:49 +01:00
Vincent Breitmoser
a14cd9f0e0 Merge pull request #2047 from k9mail/apg-deprecation-warning
show warning about APG being deprecated if still selected
2017-01-24 11:55:47 +01:00
cketti
330aef8577 Fix dialog handling 2017-01-24 07:14:54 +01:00
Philip Whitehouse
4ae85ddd38 Fix behaviour of summary notifications 2017-01-23 22:03:13 +00:00
Vincent Breitmoser
e49bfec2d4 other way to prevent activity leak in apg deprecation dialog 2017-01-23 14:05:22 +01:00
Vincent Breitmoser
407d6d7ec9 incorporate feedback 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
485029c5c2 get rid of magic and inline strings 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
ce6f080e83 dismiss apg deprecation dialog on pause, to avoid potential memory leak 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
164f38c5b0 display apg in list of choices, show warning dialog when selected 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
152d1cd2c1 change link to point to blog post 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
3adc981e51 extract method for making links clickable 2017-01-23 13:18:44 +01:00
Vincent Breitmoser
9f51ab627e show warning about APG being deprecated if still selected 2017-01-23 13:18:44 +01:00
Philip
0dd7a4aafe Merge pull request #2118 from philipwhiuk/handleInvalidHtmlBetter
Handle invalid HTML better
2017-01-22 20:40:22 +00:00
Philip Whitehouse
b15636a3ca Tidying up existing HtmlSanitizer tests to use standard style 2017-01-22 19:50:45 +00:00
Philip Whitehouse
5301639045 Handle invalid HTML better 2017-01-22 19:50:30 +00:00
cketti
cf15e8a2c5 Merge pull request #2104 from philipwhiuk/fixFetchNull
Fix 'Fetching headers null:Folder'
2017-01-22 04:56:11 +01:00
Philip Whitehouse
21a684b243 Update labels used for application permissions - shown to the end user in later versions of Android 2017-01-21 20:42:08 +00:00
Philip Whitehouse
0383fbe4fa Fix 'Fetching headers null:Folder' 2017-01-21 15:28:05 +00:00
Philip Whitehouse
b77dfa0004 Don't bother handling an intent if we're finishing anyway 2017-01-21 04:01:35 +01:00
Vincent Breitmoser
c94804df26 use CHILD_PART_CONTAINS_DATA as data location for multipart (fixes #1899) 2017-01-19 16:18:30 +01:00
Vincent Breitmoser
c2cf9c8772 fix NPE introduced in #2036 2017-01-19 16:03:06 +01:00
cketti
dbc62e38f5 Merge pull request #2082 from bertob/material-icon
Replace icon with new material design icon
2017-01-19 13:12:28 +01:00
Tobias Bernard
e00cc9f629 revert to old k9small icon 2017-01-18 18:22:19 +01:00
cketti
4b745ca62e Merge pull request #2084 from philipwhiuk/fixRemoveIcon_InDarkTheme
Use attribute for delete icon so it works in dark theme
2017-01-18 01:57:58 +01:00
Philip Whitehouse
78f99c314d Use attribute for delete icon so it works in dark theme 2017-01-18 00:49:34 +00:00
cketti
bdf21431f7 Merge pull request #2062 from philipwhiuk/stopOutboxFlagSyncAttempt
Stop trying to process flags on messages in the outbox
2017-01-18 01:10:36 +01:00
cketti
fb1de9453a Merge pull request #2076 from jca02266/master
Don't use default charset to pass the test
2017-01-17 14:56:11 +01:00
Koji Arai
5633ddbeaf Don't use default charset to pass the test 2017-01-17 22:10:39 +09:00
cketti
6b06b75224 Avoid NullPointerException 2017-01-16 23:36:36 +01:00
Tobias Bernard
6391766aa7 replace icon with new material design icon 2017-01-16 19:49:52 +01:00
Philip Whitehouse
d0511c676a Stop trying to process flags on messages in the outbox 2017-01-15 23:20:05 +00:00
cketti
6d104bd860 Merge pull request #2035 from GoneUp/importNameFix2
Fixed empty account name at import dialog
2017-01-15 23:16:16 +01:00
cketti
f5e837cc21 Merge pull request #2036 from k9mail/encrypted-multipart-alternative
Handle encrypted parts in multipart/alternative
2017-01-15 22:57:24 +01:00
cketti
d51b90f307 Merge pull request #2059 from philipwhiuk/autocompleteFix
Autocomplete fix v2
2017-01-15 22:44:25 +01:00
Philip Whitehouse
02eb84a1f0 Don't prevent sending due to address conversion 2017-01-15 20:10:24 +00:00
cketti
1a74420eb7 Extract method to construct account display name 2017-01-12 06:42:03 +01:00
cketti
25d977a813 Code style fixes 2017-01-12 06:29:45 +01:00
cketti
dbb5180e1e Merge pull request #1983 from k9mail/draft-fixes
Don't upload draft if PgpMessageBuilder is used
2017-01-12 06:19:40 +01:00
cketti
76b66472d4 Fix failing tests 2017-01-12 05:04:36 +01:00
cketti
da7ea43f77 Add some tests for MessageDecryptVerifier 2017-01-12 04:49:42 +01:00
GoneUp
bb514f7140 Just convert the actual address and not perform wild guesses #1950 2017-01-11 00:16:20 +01:00
GoneUp
f457de3821 Added tests 2017-01-10 21:10:44 +01:00
GoneUp
7df4ad00ad Fixed empty account name at import dialog 2017-01-10 21:10:29 +01:00
Vincent Breitmoser
95f6fba382 handle encrypted parts in multipart/alternative 2017-01-10 18:08:58 +01:00
Vincent Breitmoser
085debbb5b don't save draft iff PgpMessageBuilder is used 2017-01-10 15:12:44 +01:00
Vincent Breitmoser
0644fa0481 more tests for RecipientPresenter 2017-01-10 15:12:44 +01:00
cketti
92196c0128 Merge pull request #2025 from k9mail/GH-1908_fix_pinch_to_zoom
Extend NonLockingScrollView to support adding/removing views
2017-01-10 12:11:13 +01:00
cketti
c7c0ad0b7b Extend NonLockingScrollView to support adding/removing views
Fixes #1908
2017-01-10 12:05:17 +01:00
cketti
217c61430d Merge pull request #2005 from philipwhiuk/clearFullTextSearch
Delete data from Full-Text-Search table
2017-01-10 11:52:17 +01:00
cketti
bf0fe6e25a Merge pull request #2022 from philipwhiuk/addToolsText
Add some useful tools text to the custom actionbar
2017-01-10 11:45:03 +01:00
Philip Whitehouse
2de1a0c79c Add some useful tools text to the custom actionbar 2017-01-09 23:52:22 +00:00
cketti
d344a6898d Merge pull request #2014 from philipwhiuk/rework2004
Rework where we wrap message content
2017-01-09 21:33:47 +01:00