wbrawner/thunderbird-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7225 commits 1 branch 0 tags 100 MiB
Commit graph

413 commits

Author SHA1 Message Date
cketti
4855d48ba3 Merge pull request #1805 from philipwhiuk/unsupportedEncodingHandling 
Handle e-mails with unsupported encoding better
 2016-12-05 18:05:16 +01:00
Philip Whitehouse
53e8d92066 Handle NIL date - per RFC3501 4.5 2016-11-27 03:09:41 +00:00
Philip Whitehouse
1497b5f781 Simplify based on feedback 2016-11-24 23:11:03 +00:00
Philip Whitehouse
3e6625dd24 Rename exception and update test 2016-11-21 12:46:40 +00:00
Philip Whitehouse
d220b29a2b Handle e-mails with unsupported encoding 2016-11-21 12:15:03 +00:00
cketti
48581bd53c Throw instead of returning null when Body.getInputStream() is not supported 
Inspired by trying to find out what happened in issue #1794
 2016-11-14 12:18:08 +01:00
Vincent Breitmoser
cedaecb38e Merge pull request #1769 from k9mail/attachment-ninjafix 
use AttachmentTempFileProvider to expose file-backed content uris
 2016-11-08 11:21:39 +01:00
cketti
fbecc40d01 Use okio with AttachmentTempFileProvider 2016-11-08 09:07:52 +01:00
Philip Whitehouse
76536ce5c9 WebDAV: Improve logging when we get an unexpected redirect during sync 2016-11-05 17:25:44 +01:00
Philip Whitehouse
79c1f921f9 Clean-up following code review thanks to Valodim 2016-10-27 02:15:53 +01:00
Philip Whitehouse
25cba114a6 Minor changes to front-end and interface to handle no implementation 2016-10-24 12:40:31 +01:00
Philip Whitehouse
7774ebc788 Back-end changes for Google XOAUTH2 2016-10-24 12:27:45 +01:00
Jan Berkel
8b1c768483 Inject config from properties file 2016-10-19 12:35:28 +02:00
Jan Berkel
0342648568 Merge pull request #1734 from k9mail/test_cleanup 
Clean up ImapFolderTest
 2016-10-19 10:53:54 +02:00
cketti
e2f5719826 Override hostname used for EHLO command in tests 2016-10-19 10:20:27 +02:00
cketti
81245150d7 Tweak test names 2016-10-19 09:57:52 +02:00
cketti
457f69a94e Add missing assertions to SmtpTransportTest 2016-10-19 09:57:52 +02:00
cketti
5ab9de5f55 Make tests more concise to improve readability 2016-10-19 09:57:52 +02:00
cketti
2ecd7f0e4e Add nicer API to build test messages 2016-10-19 09:57:52 +02:00
cketti
edbda6df26 Move test helper classes to different package 2016-10-19 09:57:52 +02:00
cketti
82bc18673c Code style fixes 2016-10-19 09:56:16 +02:00
Philip Whitehouse
a2b545fc39 SMTP: Further test coverage for various cases 2016-10-19 09:56:16 +02:00
Philip Whitehouse
d1904900c8 SMTP: Add test for 8-bit encoding behaviour 2016-10-19 09:56:16 +02:00
Philip Whitehouse
0d339ef56c SMTP: Test sendMessage 2016-10-19 09:56:16 +02:00
Philip Whitehouse
215cbb6d9a SMTP: Testing SmtpTransport using new MockSmtpServer 2016-10-19 09:56:16 +02:00
cketti
61662c5b4a Don't use numerals in test names 2016-10-19 09:38:41 +02:00
cketti
89212cd10c Use okio's Buffer instead of ByteArrayOutputStream 2016-10-19 09:33:06 +02:00
cketti
1a60a91ddf Stop using "result" as variable name to store result of tested method 2016-10-19 09:31:30 +02:00
cketti
6caada1b48 Fix warnings 2016-10-19 09:31:30 +02:00
cketti
f9853dce08 Code style fixes 2016-10-19 09:19:48 +02:00
Jan Berkel
7956c3aa83 Merge pull request #1654 from philipwhiuk/imapTesting 
IMAP: Tests for fetchPart and other uncovered areas of code
 2016-10-19 08:30:27 +02:00
Philip Whitehouse
2feb367de1 Changes from code review by jberkel 2016-10-19 01:34:05 +01:00
Jan Berkel
6b76a727e2 On my system this test fails with SocketTimeoutException 2016-10-18 13:52:23 +02:00
Philip Whitehouse
10b46e2f49 Reformat to match coding standards 2016-10-13 23:14:40 +01:00
Philip Whitehouse
dfc3212ca5 IMAP: Finish test when index 1 passed to areMoreMessagesAvailable 2016-10-13 23:06:44 +01:00
Philip Whitehouse
0a7de4b645 IMAP: Add proper test for fetchPart() 2016-10-13 23:06:44 +01:00
Philip Whitehouse
9a6009d8d4 IMAP: Test coverage improvements 2016-10-13 23:06:44 +01:00
Philip Whitehouse
8b4fc30f4a IMAP: Clarify location of unimplemented functionality 2016-10-13 23:06:44 +01:00
cketti
96216e6d44 Fix bug in TextBody.getSize() 2016-08-20 01:20:32 +02:00
cketti
71dca79726 Add test to demonstrate bug in TextBody.getSize() 2016-08-20 01:19:40 +02:00
Vincent Breitmoser
042fc3de6d remove 8bit encoding tests 2016-08-19 22:21:43 +02:00
Vincent Breitmoser
674cd3bf5a remove 7 bit reencoding routines 2016-08-19 22:21:42 +02:00
Vincent Breitmoser
1c837930c8 encode textual bodies as quoted printable by default 2016-08-16 12:23:43 +02:00
Vincent Breitmoser
08ef3d5ce5 clean up TextBody, make it slightly more failfast 
Previously, TextBody supported only 8bit or quoted printable encodings,
defaulting to quoted printable if the encoding was not equal to "8bit".
This behavior is now changed to throw a runtime exception when an
unsupported encoding has been selected. The `setEncoding` method also
throws if an unsupported encoding is selected.
 2016-08-16 12:21:09 +02:00
cketti
946114ef2d Optimize BoundaryGenerator 2016-08-16 02:28:13 +02:00
cketti
b0e5912891 Merge pull request #1414 from k9mail/build_speed_improvements 
Build speed improvements
 2016-08-16 01:38:13 +02:00
cketti
716432c82f Increase timeouts for ImapConnectionTest 2016-08-16 01:30:25 +02:00
cketti
1cc7c499f9 Merge pull request #1553 from k9mail/message-builder-tests 
MessageBuilder refactorings for tests
 2016-08-16 00:02:49 +02:00
cketti
411ec0ec34 Use 'newInstance' as name for static factory methods 2016-08-15 11:48:36 +02:00
cketti
84cef1d8b1 Get rid of trivial static factory methods 2016-08-15 11:42:47 +02:00
cketti
a7abf62dc1 Add tests for BoundaryGenerator 2016-08-15 11:26:02 +02:00
cketti
c234578271 Don't inject BoundaryGenerator into MimeMultipart 2016-08-15 11:14:38 +02:00
cketti
7719153cc0 Extract code to generate Message-Id header value 
This moves Message closer to being a dumb data class and avoids having to
pass around a UuidGenerator reference.
 2016-08-15 10:22:17 +02:00
cketti
0c61ba2e66 Merge pull request #1564 from ligi/addEspass 
Add esPass MIME type
 2016-08-14 23:21:58 +02:00
ligi
00ff1d4789 Add esPass MIME type 2016-08-14 15:17:00 +02:00
Vincent Breitmoser
4d9283f124 construct MessageBuilder classes in factory methods 2016-08-10 14:49:12 +02:00
Vincent Breitmoser
1e97f1ce16 inject UuidGenerator into MimeMessage via constructor instead of parameter 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
bb8e5a68df rename UUIDGenerator to UuidGenerator 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
874b981ba6 get message boundaries from injected BoundaryGenerator in MessageBuilder 2016-08-10 14:30:53 +02:00
Vincent Breitmoser
f4b0521bbb get uuid from injected generator in message builder 2016-08-10 14:30:53 +02:00
cketti
f518365bd7 Don't add additional newline when sending message via SMTP 2016-08-08 16:23:28 +02:00
Vincent Breitmoser
f87a9cad49 don't throw MessagingExceptions for getting headers from parts 2016-07-28 14:53:58 +02:00
Vincent Breitmoser
3f0fb9fd3e change tests to use more actual Part/Body classes instead of mocks 2016-07-28 14:53:57 +02:00
Vincent Breitmoser
174f99b94c don't trust X_DOWNLOADED_FULL flag, consider messages with missing on-disk data incomplete 2016-07-24 23:40:12 +02:00
Vincent Breitmoser
600537f5fb use mimeType and boundary values from BodyDescriptor rather than header values 2016-07-19 17:14:46 +02:00
Vincent Breitmoser
bb9f857d86 add Attachment* tests, and some annotations 2016-07-06 21:48:38 +02:00
Vincent Breitmoser
fcf6e9e9ff move text/plain up in extension list 
This list is used for extension lookup, higher values will be preferred.
For text/plain, we want to default to a .txt extension.
 2016-07-06 21:47:55 +02:00
cketti
e75d3ca1c4 Merge pull request #1479 from k9mail/imap_fix_alert_response_text 
Fix extracting alert text from negative IMAP responses
 2016-07-05 02:50:25 +02:00
Vincent Breitmoser
4d3bc41c0a unfold+decode header value in getContentType() and getDisposition() 2016-07-01 18:40:48 +02:00
Vincent Breitmoser
240c5c8ea8 messageview: support mutt's application/pgp mimetype for pgp/inline messages (fixes #1271) 2016-06-30 10:49:04 +02:00
Vincent Breitmoser
b73805c598 first steps towards primary-part-centered MessageViewInfo structure 
This most importantly means moving away from the find*Parts family of
methods in MessageDecryptVerifier. at the moment, the initial detection
of parts to process in MessageCryptoHelper still uses the old methods,
which are strictly more inclusive about what is processed.
 2016-06-30 10:49:04 +02:00
cketti
4e7f081396 Fix extracting alert text from negative IMAP responses 2016-06-28 00:36:05 +02:00
cketti
90e3a337d4 Alternate approach to fixing MessageTest 2016-06-25 05:09:35 +02:00
Richard Neish
df877fb470 Fix failing com.fsck.k9.mail.MessageTest 2016-06-24 23:00:39 +01:00
cketti
eca66c1a34 Don't load Gradle plugins for code quality during development 2016-05-28 15:18:11 +02:00
cketti
1eb0ef4a6b Merge pull request #1390 
Fix reply to all, and some refactorings for initFromReplyTo
 2016-05-21 00:00:37 +02:00
cketti
7e829bbfb7 Fix test instead of adding null check to ListHeaders 2016-05-20 23:39:55 +02:00
Vincent Breitmoser
43899da77c same signature to get replyTo and replyToAll addresses in ReplyToParser 2016-05-20 11:26:13 +02:00
cketti
2e480e7463 Merge pull request #1355 from philipwhiuk/webDavSubFolders 
Fetch sub-folders when fetching folder list for WebDAV
 2016-05-19 19:34:20 +02:00
cketti
120c72a0fc Merge pull request #1386 from k9mail/download-messagebody 
Fetch message on view if body unavailable
 2016-05-19 15:18:31 +02:00
Vincent Breitmoser
e3593a14bf ensure that multipart/* parts always have a non-null boundary field 2016-05-19 14:56:40 +02:00
cketti
af0c8aab75 Merge pull request #1337 from k9mail/webDavPollingFix 
WebDav polling fix
 2016-05-19 14:51:31 +02:00
Vincent Breitmoser
b7e668cc61 allow null-parameters in MessageExtractor.findViewablesAndAttachments 2016-05-19 14:27:58 +02:00
Vincent Breitmoser
e57c82238d some refactorings for Message*Extractor classes 
This commit contains no semantic changes. One significant change is the
return type of MessageExtractor.findViewablesAndAttachments, which was
changed from a mixed return type (viewables as return value, attachments
as output parameter) to two output parameters, both for consistency and
performance.
 2016-05-19 14:27:55 +02:00
Vincent Breitmoser
8d631fd905 compose: small refactorings for readability in RecipientPresenter 2016-05-17 15:52:16 +02:00
Vincent Breitmoser
7644abb142 messagingcontroller: optimize imports, remove unused parameter 2016-05-16 23:22:03 +02:00
Vincent
94b9da3d16 Merge pull request #1331 from k9mail/compose-mime-combined 
PGP/INLINE and build in combined mime format
 2016-05-13 14:44:40 +02:00
Vincent Breitmoser
b6f540bfd9 compose: apply transfer encoding *after* PGP/INLINE signing 2016-05-09 09:54:06 +02:00
Vincent Breitmoser
6064e814a9 add charset parameter only to text/* content-types 2016-05-09 09:54:06 +02:00
Philip Whitehouse
3c439d285c Add pkpass MIME type 2016-05-07 21:30:48 +01:00
Philip Whitehouse
58e24e2c9d Fetch sub-folders when fetching folder list for WebDAV 2016-05-06 01:25:16 +01:00
Philip Whitehouse
dfe3372447 WebDAV: Stop notifying of message retrieval when flags are fetched 2016-05-05 21:45:23 +01:00
Vincent Breitmoser
e92bb14d0b compose: save inline mode setting as flag for drafts 2016-05-03 21:24:10 +02:00
cketti
e7d7b3f15c Don't reuse connection after exception in ImapFolderPusher 2016-05-01 04:24:37 +02:00
cketti
9240e25921 Merge pull request #1316 from philipwhiuk/webDavFixes 
WebDAV fixes
 2016-04-29 03:16:57 +02:00
Philip Whitehouse
969a66489c Improving test coverage of Folder and Store 2016-04-22 20:11:40 +01:00
Vincent Breitmoser
8c4fcaec4b fts: working fts, first iteration 2016-04-22 13:22:17 +02:00
Vincent Breitmoser
126a75c12f use BoundedInputStream to limit checked preview length 2016-04-22 13:22:17 +02:00
cketti
3d34d24a70 Merge pull request #1300 from k9mail/prevent_ImapConnection_reuse 
Prevent ImapConnection reuse
 2016-04-21 21:42:56 +02:00
ligi
e7d022de30 Add test for Address quotation and fix javadoc 2016-04-20 04:56:59 +02:00
ligi
6f26ac6caa Add support-annotations 2016-04-20 04:41:49 +02:00
cketti
aa084b93e5 Rename ImapConnection.isOpen() to isConnected() 2016-04-18 03:55:35 +02:00
cketti
d7cc579391 Don't allow ImapConnection to be opened twice 2016-04-18 03:24:23 +02:00
cketti
f65b95a0cb Throw if ImapConnection.open() is called after it has been closed 2016-04-18 00:55:01 +02:00
cketti
1cd4d87068 Apply current code style 2016-04-16 20:52:14 +02:00
Philip Whitehouse
af7e0ac4cb Close underlying streams 2016-04-16 20:46:37 +02:00
cketti
78715ed29f Merge pull request #1248 from k9mail/GH-879_notify_on_authentication_failure 
Notify user on authentication failure
 2016-04-11 22:57:00 +02:00
cketti
3840b875f5 Merge pull request #1260 from k9mail/optionalSizeParam 
Size extension parameter is optional - ignore null/empty value
 2016-04-09 10:51:40 +02:00
cketti
1c5a343fa8 Merge pull request #1211 
Refactor and add tests for MessageExtractor.getTextFromPart()
 2016-04-09 10:25:37 +02:00
cketti
7c05e0c592 Clean up MessageExtractorTest 2016-04-09 10:07:39 +02:00
Philip Whitehouse
8f0b7b5059 Refactor size parameter code 2016-04-08 21:05:40 +01:00
cketti
9393b34809 Merge pull request #1263 from k9mail/gh-1261-stopCrashOnBadMimeData 
Better handling of bad MIME messages
 2016-04-08 15:20:57 +02:00
cketti
c7562a9ff2 Merge pull request #1197 
Add debugging for when file I/O fails
 2016-04-08 12:53:43 +02:00
cketti
35c8ef2a37 Code style fixes 2016-04-08 12:51:20 +02:00
Philip Whitehouse
48097d6bb9 Stop throwing Errors everywhere 2016-04-06 00:51:53 +01:00
Philip Whitehouse
d4204689de Size extension parameter is optional - ignore null/empty value 2016-04-05 20:47:16 +01:00
cketti
a1d8c8a393 Stop ImapFolderPusher when authentication fails 2016-04-01 23:14:30 +02:00
Philip Whitehouse
3ba421b07e Refactor and add tests for MessageExtractor.getTextFromPart 2016-03-24 11:45:53 +00:00
cketti
9bacb2d5bc Merge pull request #1196 
Testing improvements for various components
 2016-03-24 09:16:02 +01:00
cketti
f6b32f2983 Code cleanup 2016-03-24 09:12:48 +01:00
Philip Whitehouse
36ba10ebc8 New testing of WebDavStore and SmtpTransport 2016-03-24 05:42:41 +01:00
Philip Whitehouse
e8af6a89ec Fix example 2016-03-24 05:42:41 +01:00
Philip Whitehouse
8ffd250f47 Add test coverage to POP3 store and Account Creator. Document some area to improve 2016-03-24 05:42:41 +01:00
cketti
1463bbb5f8 Merge pull request #1149 
Add support for List-Post header
 2016-03-23 04:47:49 +01:00
cketti
95b6f44ab9 Avoid ParseException by only passing mailto URIs to MailTo.parse() 2016-03-23 04:46:36 +01:00
cketti
2dd689d1a6 Refactor/clean up code 2016-03-23 04:46:36 +01:00
Philip Whitehouse
2e33e0dd94 Add functionality for using List-Post as an option for replying to emails 2016-03-23 04:46:36 +01:00
Philip Whitehouse
a602b63224 Fix lots more un-checked values 2016-03-21 16:47:01 +00:00
Philip Whitehouse
4a095089be Use strict hostname verification 2016-03-14 22:15:33 +01:00
Philip Whitehouse
95da33d226 Add tests for unusual email formats 2016-03-14 07:19:59 +00:00
Philip Whitehouse
5cd5b5fc55 Improving the WebDAV fetchMessage code and testing of it 2016-03-10 01:04:28 +00:00
Philip Whitehouse
9e67555407 Tests for WebDavMessage 2016-03-10 01:04:28 +00:00
Philip Whitehouse
1970b3f333 Create test infrastructure for WebDavMessage 2016-03-10 01:04:28 +00:00
Philip Whitehouse
aa602643d3 Add comment for future work 2016-03-10 01:04:27 +00:00
Philip Whitehouse
5ca1fd4575 Adding tests similar to those on ImapFolder to WebDavFolder 2016-03-10 01:04:27 +00:00
Philip Whitehouse
6daa513704 Improving test coverage of WebDAV 2016-03-10 01:04:27 +00:00
Philip
42da31c3b9 Rename WebDavHTTPClient.java to WebDavHttpClient.java 2016-03-10 01:04:27 +00:00
Philip Whitehouse
60a4cc7efa Extract another class 2016-03-10 01:04:27 +00:00
Philip Whitehouse
044564f843 Clean up prior to submitting a PR 2016-03-10 01:04:27 +00:00
Philip Whitehouse
2137e8bc68 Fix another bug with synchronizing messages 2016-03-10 01:04:26 +00:00
Philip Whitehouse
950dad02db Refactoring of WebDAV code 2016-03-10 01:04:08 +00:00
Philip Whitehouse
2bc92441e9 Fix bug fetching flags and envelopes 2016-03-10 00:34:58 +00:00
Philip Whitehouse
b12c048190 Support binary encoding 2016-03-05 14:46:05 +00:00
cketti
14054ec977 Avoid ClassCastException in ImapResponseParser 
Fixes #811
 2016-03-02 23:21:57 +01:00
cketti
a349398f4f Explicitly set time zone when testing date formatting 
This should fix the test failure on CloudBees.
 2016-02-27 07:13:34 +01:00
Vincent
f99dd61bc4 Merge pull request #1098 from k9mail/imap_store_refactoring 
Refactor ImapStore
 2016-02-26 14:40:55 +01:00
cketti
07c5f0ffba Use ThreadLocal for RFC3501_DATE 
… instead of serializing access to one single SimpleDateFormat instance.
 2016-02-24 11:34:03 +01:00
cketti
126a8766d6 Avoid incrementing field inside expression 2016-02-24 11:08:34 +01:00
cketti
f88a915a5d Don't hang on to ImapConnection for too long 2016-02-18 00:28:43 +01:00
cketti
ca4a6b6cfc Close connection when IDLE command fails 2016-02-17 20:14:01 +01:00