shonramamurthy
0fafe3dc18
Issue#2210 : Unit Tests for SmtpDataStuffing.
2017-02-21 10:14:41 +01:00
cketti
fc90a8eadb
Merge pull request #2234 from philipwhiuk/testSendPendingMessages
...
MessagingController improvements
2017-02-17 16:18:48 +01:00
Philip Whitehouse
c45251f66e
Rename getInstance() to getTransport()
2017-02-16 23:17:30 +00:00
cketti
329ed78c5d
Merge pull request #2215 from philipwhiuk/webDavAppendTimeout
...
WebDAV: Use the proper sendRequest mechanism to append messages
2017-02-15 01:33:24 +01:00
cketti
56adeb8129
Merge pull request #2229 from philipwhiuk/encodedPersonalTest
...
AddressTest - Refactor and test UTF-8 encoding
2017-02-15 00:40:57 +01:00
Philip Whitehouse
2e01043a28
Test sending of pending messages
2017-02-13 23:52:31 +00:00
Philip Whitehouse
805420d3fc
AddressUTF-8Test
2017-02-12 22:45:19 +00:00
Philip Whitehouse
2cec47491d
WebDAV: Use the proper sendRequest mechanism to append messages
2017-02-12 21:58:36 +00:00
Joël Troch
7d628cf719
Make Hex.encodeHex returns a String (was char[])
2017-02-09 14:54:27 +01:00
Philip Whitehouse
9207afdc69
Address: Handle getHostname when mAddress is null
2017-02-08 22:53:08 +00:00
cketti
19b7d4491d
Merge pull request #2193 from k9mail/robolectric-update
...
Update robolectric, use Runner class instead of annotations
2017-02-07 05:06:39 +01:00
Dominik Schürmann
e829196034
Set robolectric sdk to 22
2017-02-06 11:25:02 +01:00
Sebastian Kürten
f4b3ef3b41
Fix a few Javadoc typos
2017-02-06 08:48:24 +01:00
Dominik Schürmann
874943885f
Update robolectric, use Runner classes
2017-02-05 23:44:35 +01:00
cketti
3bd84de9c9
Merge pull request #2144 from k9mail/GH-2134_authentication_failure_handling
...
Handle connection closing after authentication failure
2017-01-31 20:17:57 +01:00
Philip Whitehouse
5a51523cc9
Address file clean-up
2017-01-29 11:27:20 +00:00
cketti
f34abe36c0
Handle connection closing after authentication failure
...
Fixes #2134
2017-01-27 03:29:11 +01:00
cketti
6738b497f0
Merge pull request #2115 from philipwhiuk/addressFixes
...
Improve behaviour of Address.equals with partial information
2017-01-26 10:52:58 +01:00
cketti
c24c89e76a
Use IntelliJ-generated equals() method for Address
2017-01-25 16:29:28 +01:00
cketti
0f8b4cc144
Merge pull request #1778 from philipwhiuk/newCiphers
...
Don't reorder TLS ciphers on newer Android versions
2017-01-22 15:10:01 +01:00
Philip Whitehouse
c8eaba861c
Fix Address.equals
2017-01-22 13:44:49 +00:00
Philip Whitehouse
059064c9f1
Don't reorder TLS ciphers on newer Android versions
2017-01-22 12:27:34 +00:00
Philip Whitehouse
252aedccd4
Separate WebDAV URI handling into separate classes
2017-01-21 16:22:56 +00:00
cketti
5f4fc19f1d
Fix test names
2017-01-13 13:14:11 +01:00
cketti
025502ceb5
Don't crash on unknown content transfer encoding
2017-01-12 21:08:09 +01:00
Vincent Breitmoser
c5234d88e0
set content-transfer-encoding for RawDataBody in setBody
2017-01-10 15:11:41 +01:00
cketti
db791579c1
Add support for obsolete header field format
...
Putting whitespace between header field name and colon is valid in the
obsolete syntax.
2017-01-05 07:09:43 +01:00
cketti
b7adc5e574
Merge pull request #1939 from k9mail/GH-1936_add_support_for_delimiter_value_nil
...
Add support for delimiter value NIL in LIST responses
2017-01-04 07:31:00 +01:00
cketti
d3310b5656
Add support for delimiter value NIL in LIST responses
2017-01-03 17:41:08 +01:00
cketti
55c87fcaaf
Properly handle exceptions thrown by ImapResponseCallback
...
Fixes #1919
2017-01-03 00:24:16 +01:00
cketti
9d18ed97fe
Fix TestImapResponseCallback
2017-01-02 21:48:15 +01:00
cketti
de60e0e8c4
Merge pull request #1835 from k9mail/flowed-display
...
Support display of format=flowed (rfc2646)
2017-01-01 02:47:40 +01:00
cketti
40e5f03804
Avoid NPE in Address.hashCode()
...
Fixes #1874
2016-12-28 22:24:43 +01:00
Vincent Breitmoser
a055ed42a8
don't handle format parameter in setBody(), style fixes
2016-12-12 14:24:30 +01:00
Vincent Breitmoser
dc3d1f0e87
support display of format=flowed (rfc2646)
2016-12-12 14:24:30 +01:00
cketti
15ca92414b
Merge pull request #1747 from k9mail/xoauth2Backend
...
Back-end changes for Google XOAUTH2
2016-12-12 03:14:59 +01:00
cketti
f9ed304770
Don't pass OAuth2TokenProvider to RemoteStore and Transport
2016-12-12 02:48:55 +01:00
cketti
74017c926e
Code style fixes
2016-12-12 02:48:55 +01:00
cketti
8def88afcb
Merge pull request #1565 from k9mail/boundary_generator_optimization
...
Optimize BoundaryGenerator
2016-12-12 00:42:37 +01:00
cketti
5fca3c871d
Merge pull request #1847 from k9mail/multipart-attachments
...
Handle attachments with CHILD_PART_CONTAINS_DATA data location
2016-12-11 02:45:00 +01:00
Vincent Breitmoser
0ecbf441c1
handle attachments with CHILD_PART_CONTAINS_DATA data location (message/rfc822)
2016-12-11 02:33:56 +01:00
cketti
68e3c2a431
Avoid crashing with NPE when creating exception message
2016-12-09 04:59:52 +01:00
cketti
87e13ef800
Merge pull request #1836 from k9mail/multipart-digest-content-type
...
Properly handle multipart/digest content type
2016-12-09 00:18:59 +01:00
Vincent Breitmoser
0beff4cdb8
use message/rfc822 as default content type for multipart/digest subparts
2016-12-07 00:23:28 +01:00
cketti
4855d48ba3
Merge pull request #1805 from philipwhiuk/unsupportedEncodingHandling
...
Handle e-mails with unsupported encoding better
2016-12-05 18:05:16 +01:00
Philip Whitehouse
53e8d92066
Handle NIL date - per RFC3501 4.5
2016-11-27 03:09:41 +00:00
Philip Whitehouse
1497b5f781
Simplify based on feedback
2016-11-24 23:11:03 +00:00
Philip Whitehouse
3e6625dd24
Rename exception and update test
2016-11-21 12:46:40 +00:00
Philip Whitehouse
d220b29a2b
Handle e-mails with unsupported encoding
2016-11-21 12:15:03 +00:00
cketti
48581bd53c
Throw instead of returning null when Body.getInputStream() is not supported
...
Inspired by trying to find out what happened in issue #1794
2016-11-14 12:18:08 +01:00
Vincent Breitmoser
cedaecb38e
Merge pull request #1769 from k9mail/attachment-ninjafix
...
use AttachmentTempFileProvider to expose file-backed content uris
2016-11-08 11:21:39 +01:00
cketti
fbecc40d01
Use okio with AttachmentTempFileProvider
2016-11-08 09:07:52 +01:00
Philip Whitehouse
76536ce5c9
WebDAV: Improve logging when we get an unexpected redirect during sync
2016-11-05 17:25:44 +01:00
Philip Whitehouse
79c1f921f9
Clean-up following code review thanks to Valodim
2016-10-27 02:15:53 +01:00
Philip Whitehouse
25cba114a6
Minor changes to front-end and interface to handle no implementation
2016-10-24 12:40:31 +01:00
Philip Whitehouse
7774ebc788
Back-end changes for Google XOAUTH2
2016-10-24 12:27:45 +01:00
Jan Berkel
8b1c768483
Inject config from properties file
2016-10-19 12:35:28 +02:00
Jan Berkel
0342648568
Merge pull request #1734 from k9mail/test_cleanup
...
Clean up ImapFolderTest
2016-10-19 10:53:54 +02:00
cketti
e2f5719826
Override hostname used for EHLO command in tests
2016-10-19 10:20:27 +02:00
cketti
81245150d7
Tweak test names
2016-10-19 09:57:52 +02:00
cketti
457f69a94e
Add missing assertions to SmtpTransportTest
2016-10-19 09:57:52 +02:00
cketti
5ab9de5f55
Make tests more concise to improve readability
2016-10-19 09:57:52 +02:00
cketti
2ecd7f0e4e
Add nicer API to build test messages
2016-10-19 09:57:52 +02:00
cketti
edbda6df26
Move test helper classes to different package
2016-10-19 09:57:52 +02:00
cketti
82bc18673c
Code style fixes
2016-10-19 09:56:16 +02:00
Philip Whitehouse
a2b545fc39
SMTP: Further test coverage for various cases
2016-10-19 09:56:16 +02:00
Philip Whitehouse
d1904900c8
SMTP: Add test for 8-bit encoding behaviour
2016-10-19 09:56:16 +02:00
Philip Whitehouse
0d339ef56c
SMTP: Test sendMessage
2016-10-19 09:56:16 +02:00
Philip Whitehouse
215cbb6d9a
SMTP: Testing SmtpTransport using new MockSmtpServer
2016-10-19 09:56:16 +02:00
cketti
61662c5b4a
Don't use numerals in test names
2016-10-19 09:38:41 +02:00
cketti
89212cd10c
Use okio's Buffer instead of ByteArrayOutputStream
2016-10-19 09:33:06 +02:00
cketti
1a60a91ddf
Stop using "result" as variable name to store result of tested method
2016-10-19 09:31:30 +02:00
cketti
6caada1b48
Fix warnings
2016-10-19 09:31:30 +02:00
cketti
f9853dce08
Code style fixes
2016-10-19 09:19:48 +02:00
Jan Berkel
7956c3aa83
Merge pull request #1654 from philipwhiuk/imapTesting
...
IMAP: Tests for fetchPart and other uncovered areas of code
2016-10-19 08:30:27 +02:00
Philip Whitehouse
2feb367de1
Changes from code review by jberkel
2016-10-19 01:34:05 +01:00
Jan Berkel
6b76a727e2
On my system this test fails with SocketTimeoutException
2016-10-18 13:52:23 +02:00
Philip Whitehouse
10b46e2f49
Reformat to match coding standards
2016-10-13 23:14:40 +01:00
Philip Whitehouse
dfc3212ca5
IMAP: Finish test when index 1 passed to areMoreMessagesAvailable
2016-10-13 23:06:44 +01:00
Philip Whitehouse
0a7de4b645
IMAP: Add proper test for fetchPart()
2016-10-13 23:06:44 +01:00
Philip Whitehouse
9a6009d8d4
IMAP: Test coverage improvements
2016-10-13 23:06:44 +01:00
Philip Whitehouse
8b4fc30f4a
IMAP: Clarify location of unimplemented functionality
2016-10-13 23:06:44 +01:00
cketti
96216e6d44
Fix bug in TextBody.getSize()
2016-08-20 01:20:32 +02:00
cketti
71dca79726
Add test to demonstrate bug in TextBody.getSize()
2016-08-20 01:19:40 +02:00
Vincent Breitmoser
042fc3de6d
remove 8bit encoding tests
2016-08-19 22:21:43 +02:00
Vincent Breitmoser
674cd3bf5a
remove 7 bit reencoding routines
2016-08-19 22:21:42 +02:00
Vincent Breitmoser
1c837930c8
encode textual bodies as quoted printable by default
2016-08-16 12:23:43 +02:00
Vincent Breitmoser
08ef3d5ce5
clean up TextBody, make it slightly more failfast
...
Previously, TextBody supported only 8bit or quoted printable encodings,
defaulting to quoted printable if the encoding was not equal to "8bit".
This behavior is now changed to throw a runtime exception when an
unsupported encoding has been selected. The `setEncoding` method also
throws if an unsupported encoding is selected.
2016-08-16 12:21:09 +02:00
cketti
946114ef2d
Optimize BoundaryGenerator
2016-08-16 02:28:13 +02:00
cketti
b0e5912891
Merge pull request #1414 from k9mail/build_speed_improvements
...
Build speed improvements
2016-08-16 01:38:13 +02:00
cketti
716432c82f
Increase timeouts for ImapConnectionTest
2016-08-16 01:30:25 +02:00
cketti
1cc7c499f9
Merge pull request #1553 from k9mail/message-builder-tests
...
MessageBuilder refactorings for tests
2016-08-16 00:02:49 +02:00
cketti
411ec0ec34
Use 'newInstance' as name for static factory methods
2016-08-15 11:48:36 +02:00
cketti
84cef1d8b1
Get rid of trivial static factory methods
2016-08-15 11:42:47 +02:00
cketti
a7abf62dc1
Add tests for BoundaryGenerator
2016-08-15 11:26:02 +02:00
cketti
c234578271
Don't inject BoundaryGenerator into MimeMultipart
2016-08-15 11:14:38 +02:00
cketti
7719153cc0
Extract code to generate Message-Id header value
...
This moves Message closer to being a dumb data class and avoids having to
pass around a UuidGenerator reference.
2016-08-15 10:22:17 +02:00
cketti
0c61ba2e66
Merge pull request #1564 from ligi/addEspass
...
Add esPass MIME type
2016-08-14 23:21:58 +02:00
ligi
00ff1d4789
Add esPass MIME type
2016-08-14 15:17:00 +02:00
Vincent Breitmoser
4d9283f124
construct MessageBuilder classes in factory methods
2016-08-10 14:49:12 +02:00
Vincent Breitmoser
1e97f1ce16
inject UuidGenerator into MimeMessage via constructor instead of parameter
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
bb8e5a68df
rename UUIDGenerator to UuidGenerator
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
874b981ba6
get message boundaries from injected BoundaryGenerator in MessageBuilder
2016-08-10 14:30:53 +02:00
Vincent Breitmoser
f4b0521bbb
get uuid from injected generator in message builder
2016-08-10 14:30:53 +02:00
cketti
f518365bd7
Don't add additional newline when sending message via SMTP
2016-08-08 16:23:28 +02:00
Vincent Breitmoser
f87a9cad49
don't throw MessagingExceptions for getting headers from parts
2016-07-28 14:53:58 +02:00
Vincent Breitmoser
3f0fb9fd3e
change tests to use more actual Part/Body classes instead of mocks
2016-07-28 14:53:57 +02:00
Vincent Breitmoser
174f99b94c
don't trust X_DOWNLOADED_FULL flag, consider messages with missing on-disk data incomplete
2016-07-24 23:40:12 +02:00
Vincent Breitmoser
600537f5fb
use mimeType and boundary values from BodyDescriptor rather than header values
2016-07-19 17:14:46 +02:00
Vincent Breitmoser
bb9f857d86
add Attachment* tests, and some annotations
2016-07-06 21:48:38 +02:00
Vincent Breitmoser
fcf6e9e9ff
move text/plain up in extension list
...
This list is used for extension lookup, higher values will be preferred.
For text/plain, we want to default to a .txt extension.
2016-07-06 21:47:55 +02:00
cketti
e75d3ca1c4
Merge pull request #1479 from k9mail/imap_fix_alert_response_text
...
Fix extracting alert text from negative IMAP responses
2016-07-05 02:50:25 +02:00
Vincent Breitmoser
4d3bc41c0a
unfold+decode header value in getContentType() and getDisposition()
2016-07-01 18:40:48 +02:00
Vincent Breitmoser
240c5c8ea8
messageview: support mutt's application/pgp mimetype for pgp/inline messages ( fixes #1271 )
2016-06-30 10:49:04 +02:00
Vincent Breitmoser
b73805c598
first steps towards primary-part-centered MessageViewInfo structure
...
This most importantly means moving away from the find*Parts family of
methods in MessageDecryptVerifier. at the moment, the initial detection
of parts to process in MessageCryptoHelper still uses the old methods,
which are strictly more inclusive about what is processed.
2016-06-30 10:49:04 +02:00
cketti
4e7f081396
Fix extracting alert text from negative IMAP responses
2016-06-28 00:36:05 +02:00
cketti
90e3a337d4
Alternate approach to fixing MessageTest
2016-06-25 05:09:35 +02:00
Richard Neish
df877fb470
Fix failing com.fsck.k9.mail.MessageTest
2016-06-24 23:00:39 +01:00
cketti
eca66c1a34
Don't load Gradle plugins for code quality during development
2016-05-28 15:18:11 +02:00
cketti
1eb0ef4a6b
Merge pull request #1390
...
Fix reply to all, and some refactorings for initFromReplyTo
2016-05-21 00:00:37 +02:00
cketti
7e829bbfb7
Fix test instead of adding null check to ListHeaders
2016-05-20 23:39:55 +02:00
Vincent Breitmoser
43899da77c
same signature to get replyTo and replyToAll addresses in ReplyToParser
2016-05-20 11:26:13 +02:00
cketti
2e480e7463
Merge pull request #1355 from philipwhiuk/webDavSubFolders
...
Fetch sub-folders when fetching folder list for WebDAV
2016-05-19 19:34:20 +02:00
cketti
120c72a0fc
Merge pull request #1386 from k9mail/download-messagebody
...
Fetch message on view if body unavailable
2016-05-19 15:18:31 +02:00
Vincent Breitmoser
e3593a14bf
ensure that multipart/* parts always have a non-null boundary field
2016-05-19 14:56:40 +02:00
cketti
af0c8aab75
Merge pull request #1337 from k9mail/webDavPollingFix
...
WebDav polling fix
2016-05-19 14:51:31 +02:00
Vincent Breitmoser
b7e668cc61
allow null-parameters in MessageExtractor.findViewablesAndAttachments
2016-05-19 14:27:58 +02:00
Vincent Breitmoser
e57c82238d
some refactorings for Message*Extractor classes
...
This commit contains no semantic changes. One significant change is the
return type of MessageExtractor.findViewablesAndAttachments, which was
changed from a mixed return type (viewables as return value, attachments
as output parameter) to two output parameters, both for consistency and
performance.
2016-05-19 14:27:55 +02:00
Vincent Breitmoser
8d631fd905
compose: small refactorings for readability in RecipientPresenter
2016-05-17 15:52:16 +02:00
Vincent Breitmoser
7644abb142
messagingcontroller: optimize imports, remove unused parameter
2016-05-16 23:22:03 +02:00
Vincent
94b9da3d16
Merge pull request #1331 from k9mail/compose-mime-combined
...
PGP/INLINE and build in combined mime format
2016-05-13 14:44:40 +02:00
Vincent Breitmoser
b6f540bfd9
compose: apply transfer encoding *after* PGP/INLINE signing
2016-05-09 09:54:06 +02:00
Vincent Breitmoser
6064e814a9
add charset parameter only to text/* content-types
2016-05-09 09:54:06 +02:00
Philip Whitehouse
3c439d285c
Add pkpass MIME type
2016-05-07 21:30:48 +01:00
Philip Whitehouse
58e24e2c9d
Fetch sub-folders when fetching folder list for WebDAV
2016-05-06 01:25:16 +01:00
Philip Whitehouse
dfe3372447
WebDAV: Stop notifying of message retrieval when flags are fetched
2016-05-05 21:45:23 +01:00
Vincent Breitmoser
e92bb14d0b
compose: save inline mode setting as flag for drafts
2016-05-03 21:24:10 +02:00
cketti
e7d7b3f15c
Don't reuse connection after exception in ImapFolderPusher
2016-05-01 04:24:37 +02:00
cketti
9240e25921
Merge pull request #1316 from philipwhiuk/webDavFixes
...
WebDAV fixes
2016-04-29 03:16:57 +02:00
Philip Whitehouse
969a66489c
Improving test coverage of Folder and Store
2016-04-22 20:11:40 +01:00
Vincent Breitmoser
8c4fcaec4b
fts: working fts, first iteration
2016-04-22 13:22:17 +02:00
Vincent Breitmoser
126a75c12f
use BoundedInputStream to limit checked preview length
2016-04-22 13:22:17 +02:00
cketti
3d34d24a70
Merge pull request #1300 from k9mail/prevent_ImapConnection_reuse
...
Prevent ImapConnection reuse
2016-04-21 21:42:56 +02:00
ligi
e7d022de30
Add test for Address quotation and fix javadoc
2016-04-20 04:56:59 +02:00
ligi
6f26ac6caa
Add support-annotations
2016-04-20 04:41:49 +02:00
cketti
aa084b93e5
Rename ImapConnection.isOpen() to isConnected()
2016-04-18 03:55:35 +02:00
cketti
d7cc579391
Don't allow ImapConnection to be opened twice
2016-04-18 03:24:23 +02:00
cketti
f65b95a0cb
Throw if ImapConnection.open() is called after it has been closed
2016-04-18 00:55:01 +02:00
cketti
1cd4d87068
Apply current code style
2016-04-16 20:52:14 +02:00
Philip Whitehouse
af7e0ac4cb
Close underlying streams
2016-04-16 20:46:37 +02:00