Commit graph

8414 commits

Author SHA1 Message Date
cketti
6a408df8fe Properly delete message after sending (destroy) 2018-12-13 19:59:53 +01:00
cketti
6f49b97514 Don't move message that failed to send to Drafts folder 2018-12-13 19:59:52 +01:00
cketti
e5025e1ab8 Use 'outbox_state' table for send error handling 2018-12-13 19:59:52 +01:00
cketti
03f0fa9f0f Add 'outbox_state' table to database 2018-12-13 19:59:52 +01:00
Vincent Breitmoser
72b605fae8
Merge pull request #3817 from wiktor-k/fix-dark-theme
Fix consistent crashes when using dark theme
2018-12-13 19:22:52 +01:00
Wiktor Kwapisiewicz
cad4cac6df
Fix consistent crashes when using dark theme
Commit 212f36170 moved dark theme's parent to
Theme.AppCompat.NoActionBar but the theme file for v21 was not updated.
This caused IllegalStateException to be thrown when constructing
K9Activities when dark theme has been selected.

The fix corrects the parent value.
2018-12-12 21:50:13 +01:00
Vincent Breitmoser
ecfbbca9d9
Merge pull request #3814 from wiktor-k/fix-missing-subject
Fix subject being overwritten with `null`
2018-12-12 12:52:58 +01:00
Vincent Breitmoser
ac8fe9dbe7
Merge pull request #3790 from k9mail/accounts-listener
add AccountsChangeListener to Preferences
2018-12-12 12:42:09 +01:00
Vincent Breitmoser
af09f7b02e
Merge pull request #3799 from k9mail/smtp-pipeline-first-error
Return first, rather than last, response for pipelined SMTP commands
2018-12-12 12:05:29 +01:00
Vincent Breitmoser
099e13f0c4
Merge pull request #3800 from k9mail/manage-folders-item
add "Manage folders" item to drawer footer
2018-12-12 11:43:42 +01:00
Wiktor Kwapisiewicz
314cb93d2b
Fix subject being overwritten with null
Not using crypto-provider passes `null` as `plaintextSubject`.
`saveDraft` already has protection against overwriting subject with `null`.
This change adds the same check to `sendMessage`.

Fixes #3811.
2018-12-11 12:23:11 +01:00
Vincent Breitmoser
037b19d7ce
Merge pull request #3807 from k9mail/message_list_title
Remove custom view in MessageList toolbar
2018-12-10 19:11:49 +01:00
Vincent Breitmoser
214580a2ec reload account onActive 2018-12-10 18:54:27 +01:00
Vincent Breitmoser
012742787e synchronized Preferences with a lock object 2018-12-10 18:43:22 +01:00
Vincent Breitmoser
e7d6f85e66 add AccountsChangeListener to Preferences 2018-12-10 18:13:34 +01:00
Vincent Breitmoser
fda70cbea7 respect first overall negative reply in smtp pipelining 2018-12-10 17:21:10 +01:00
Vincent Breitmoser
4160a1b4ee
Merge pull request #3775 from k9mail/extract-storage-persister
extract persistence logic from Storage into StoragePersister
2018-12-10 13:20:25 +01:00
Vincent Breitmoser
216d51a069 StorageEditor: add test 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
474610139f StoagePersister: add test 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
342048e961 StoragePerister: use statement for delete, drop intermediate map 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
40b4ebbc8e add unit test for Storage 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
9c6952275a Storage may still be written to and read from concurrently 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
75c4b9ff73 revert accidental changes 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
f7faccf5d9 extract persistence logic from Storage into StoragePersister 2018-12-10 13:06:52 +01:00
Vincent Breitmoser
d1c4701256
Merge pull request #3808 from artbristol/remove-exception-todo
Remove TODO
2018-12-10 12:55:12 +01:00
Art O Cathain
5e3141d236 Remove TODO 2018-12-09 14:06:17 +01:00
cketti
2f80530b2d Use FolderNameFormatter to get display names for folders 2018-12-08 23:23:13 +01:00
cketti
958c3cf29c Remove custom actionbar view 2018-12-08 23:23:06 +01:00
cketti
278e7d339c
Merge pull request #3783 from ByteHamster/drawer-above
Switch to Toolbar
2018-12-08 22:58:45 +01:00
cketti
3c16d2caed Fix empty view handling in K9ListActivity 2018-12-08 22:37:55 +01:00
cketti
227972ffde Fix layouts 2018-12-08 22:00:06 +01:00
ByteHamster
212f36170f Switch to Toolbar
This allows to show the sidebar above the ActionBar.
2018-12-08 21:59:22 +01:00
cketti
4a342435e3
Merge pull request #3802 from k9mail/fix_mail_sync
Fix periodic mail sync
2018-12-07 00:37:14 +01:00
cketti
8b676343a4 Make MessagingController.checkMailBlocking() actually terminate 2018-12-06 23:34:51 +01:00
cketti
2f8778be33
Merge pull request #3763 from ojiofong/oji_mail_sync
Change mail sync to work with background execution limits
2018-12-06 19:57:00 +01:00
cketti
fa3458f920 Make mail check blocking when called from MailSyncJob 2018-12-06 19:45:11 +01:00
cketti
c555790ca3
Merge pull request #3798 from k9mail/helo-ip
Always send IP instead of hostname in HELO/EHLO
2018-12-06 04:02:59 +01:00
Vincent Breitmoser
3c663098b3 Use local ip statically for SMTP HELO/EHLO 2018-12-05 22:26:17 +01:00
Vincent Breitmoser
c3c7593458 add "Manage folders" item to drawer footer
part of #3750
2018-12-05 16:47:27 +01:00
Vincent Breitmoser
bad3f20852 add unit test for negative response in smtp pipeline 2018-12-05 15:58:23 +01:00
Vincent Breitmoser
64c6a14e77 Return first, rather than last, response for pipelined SMTP commands 2018-12-05 14:50:57 +01:00
Vincent Breitmoser
4333a3a16f remove "hideHostnameWhenConnecting" from global settings 2018-12-05 14:39:08 +01:00
Vincent Breitmoser
c06e1a9d9b always just send IP instead of hostname in SMTP EHLO message
Clients are very often behind NATs, which makes the hostname in
HELO/EHLO messages virtually useless these days. Attempting to figure
out a hostname we could use also led to issues with some strict Postfix
configurations (see https://github.com/k9mail/k-9/issues/3387). This
commit changes our behavior to simply send the local IP always, getting
rid of this metadata.

Fixes #3387
2018-12-05 14:36:06 +01:00
cketti
48ef5e43b7
Merge pull request #3769 from Khyojung/khyojung
Add padding between labels and input fields in message composition screen

Fixes #3768
2018-12-04 21:59:24 +01:00
cketti
6bb9f844e9 Add padding between labels and input fields in message composition screen 2018-12-04 21:47:14 +01:00
H. Lehmann
03907d8861 Add icons to account settings screen (#3792) 2018-12-04 21:37:31 +01:00
Oji Ofong
49917278de Resolve scheduled job issues 2018-12-04 13:42:22 -05:00
Vincent Breitmoser
8b3d51686a
Merge pull request #3788 from k9mail/empty_trash
Add "empty trash" action to MessageList activity
2018-12-03 20:09:39 +01:00
cketti
5aa157d3c1
Merge pull request #3789 from k9mail/fix-3787
Fix assigning account number when Account is first saved (fixes #3787)
2018-12-03 17:09:21 +01:00
Vincent Breitmoser
62411ace05 Fix assigning account number when Account is first saved (fixes #3787) 2018-12-03 14:12:25 +01:00