toolbox/test/system/102-list.bats

167 lines
4.5 KiB
Text
Raw Normal View History

#!/usr/bin/env bats
#
# Copyright © 2019 2022 Red Hat, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
load 'libs/bats-support/load'
load 'libs/bats-assert/load'
load 'libs/helpers'
setup() {
_setup_environment
cleanup_all
}
teardown() {
cleanup_all
}
@test "list: Run 'list' with zero containers and zero images (the list should be empty)" {
run --keep-empty-lines $TOOLBOX list
assert_success
assert_output ""
}
@test "list: Run 'list -c' with zero containers (the list should be empty)" {
run --keep-empty-lines $TOOLBOX list -c
assert_success
assert_output ""
}
@test "list: Run 'list -i' with zero images (the list should be empty)" {
run --keep-empty-lines $TOOLBOX list -i
assert_success
assert_output ""
}
@test "list: Run 'list' with zero toolbox's containers and images, but other image (the list should be empty)" {
pull_distro_image busybox
run podman images
assert_output --partial "$BUSYBOX_IMAGE"
run --keep-empty-lines $TOOLBOX list
assert_success
assert_output ""
}
@test "list: List an image without a name" {
build_image_without_name >/dev/null
run --keep-empty-lines --separate-stderr $TOOLBOX list
assert_success
assert_line --index 1 --partial "<none>"
assert [ ${#lines[@]} -eq 3 ]
if check_bats_version 1.7.0; then
assert [ ${#stderr_lines[@]} -eq 0 ]
fi
}
@test "list: Image and its copy" {
local default_image
default_image="$(get_default_image)"
pull_default_image_and_copy
local num_of_images
num_of_images="$(list_images)"
assert_equal "$num_of_images" 2
run --keep-empty-lines --separate-stderr "$TOOLBOX" list
assert_success
assert_line --index 1 --partial "$default_image"
assert_line --index 2 --partial "$default_image-copy"
assert [ ${#lines[@]} -eq 4 ]
if check_bats_version 1.7.0; then
assert [ ${#stderr_lines[@]} -eq 0 ]
fi
}
@test "list: Try to list images and containers (no flag) with 3 containers and 2 images (the list should have 3 images and 2 containers)" {
# Pull the two images
pull_default_image
pull_distro_image fedora 34
# Create three containers
create_default_container
create_container non-default-one
create_container non-default-two
# Check images
run --keep-empty-lines --separate-stderr $TOOLBOX list --images
assert_success
Unbreak sorting and clearly identify copied images in 'list' Currently, if an image was copied with: $ skopeo copy \ containers-storage:registry.fedoraproject.org/fedora-toolbox:36 \ containers-storage:localhost/fedora-toolbox:36 ... or: $ podman tag \ registry.fedoraproject.org/fedora-toolbox:36 \ localhost/fedora-toolbox:36 ... then it would show up twice in 'list' with the same name, and in the wrong order. Either as: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... ... or as: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... The correct output should be similar to 'podman images', and be sorted in ascending order of the names: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... The problem is that, in these situations, 'podman images --format json' returns separate identical JSON collections for each copy of the image, and all of those copies have multiple names: [ { "Id": "2110dbbc33d2", ... "Names": [ "localhost/fedora-toolbox:36", "registry.fedoraproject.org/fedora-toolbox:36" ], ... }, { "Id": "e085805ade4a", ... "Names": [ "registry.access.redhat.com/ubi8/toolbox:latest" ], ... }, { "Id": "2110dbbc33d2", ... "Names": [ "localhost/fedora-toolbox:36", "registry.fedoraproject.org/fedora-toolbox:36" ], ... } { "Id": "70cbe2ce60ca", ... "Names": [ "registry.fedoraproject.org/fedora-toolbox:34" ], ... }, ] The image objects need to be flattened to have only one unique name per copy, but with the same ID, and then sorted to ensure the right order. Note that the ordering was already broken since commit 2369da5d31830e5c, which started using 'podman images --sort repository'. Podman can sort by either the image's repository or tag, but not by the unified name, which is what Toolbx needs. Therefore, even without copied images, Toolbx really does need to sort the images itself. Prior to commit 2369da5d31830e5c, the ordering was correct, but copied images would only show up once. Fallout from 2369da5d31830e5cd3e1a13857a686365875ae61 This reverts parts of commit 67e210378e7b43cc0847cd171209861862f225b0. https://github.com/containers/toolbox/issues/1043
2022-12-06 17:15:15 +00:00
assert_line --index 1 --partial "fedora-toolbox:34"
assert_line --index 2 --partial "$(get_system_id)-toolbox:$(get_system_version)"
assert [ ${#lines[@]} -eq 4 ]
if check_bats_version 1.7.0; then
assert [ ${#stderr_lines[@]} -eq 0 ]
fi
# Check containers
run --keep-empty-lines --separate-stderr $TOOLBOX list --containers
assert_success
assert_line --index 1 --partial "$(get_system_id)-toolbox-$(get_system_version)"
assert_line --index 2 --partial "non-default-one"
assert_line --index 3 --partial "non-default-two"
assert [ ${#lines[@]} -eq 5 ]
if check_bats_version 1.7.0; then
assert [ ${#stderr_lines[@]} -eq 0 ]
fi
# Check all together
run --keep-empty-lines --separate-stderr $TOOLBOX list
assert_success
Unbreak sorting and clearly identify copied images in 'list' Currently, if an image was copied with: $ skopeo copy \ containers-storage:registry.fedoraproject.org/fedora-toolbox:36 \ containers-storage:localhost/fedora-toolbox:36 ... or: $ podman tag \ registry.fedoraproject.org/fedora-toolbox:36 \ localhost/fedora-toolbox:36 ... then it would show up twice in 'list' with the same name, and in the wrong order. Either as: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... ... or as: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... The correct output should be similar to 'podman images', and be sorted in ascending order of the names: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... The problem is that, in these situations, 'podman images --format json' returns separate identical JSON collections for each copy of the image, and all of those copies have multiple names: [ { "Id": "2110dbbc33d2", ... "Names": [ "localhost/fedora-toolbox:36", "registry.fedoraproject.org/fedora-toolbox:36" ], ... }, { "Id": "e085805ade4a", ... "Names": [ "registry.access.redhat.com/ubi8/toolbox:latest" ], ... }, { "Id": "2110dbbc33d2", ... "Names": [ "localhost/fedora-toolbox:36", "registry.fedoraproject.org/fedora-toolbox:36" ], ... } { "Id": "70cbe2ce60ca", ... "Names": [ "registry.fedoraproject.org/fedora-toolbox:34" ], ... }, ] The image objects need to be flattened to have only one unique name per copy, but with the same ID, and then sorted to ensure the right order. Note that the ordering was already broken since commit 2369da5d31830e5c, which started using 'podman images --sort repository'. Podman can sort by either the image's repository or tag, but not by the unified name, which is what Toolbx needs. Therefore, even without copied images, Toolbx really does need to sort the images itself. Prior to commit 2369da5d31830e5c, the ordering was correct, but copied images would only show up once. Fallout from 2369da5d31830e5cd3e1a13857a686365875ae61 This reverts parts of commit 67e210378e7b43cc0847cd171209861862f225b0. https://github.com/containers/toolbox/issues/1043
2022-12-06 17:15:15 +00:00
assert_line --index 1 --partial "fedora-toolbox:34"
assert_line --index 2 --partial "$(get_system_id)-toolbox:$(get_system_version)"
assert_line --index 5 --partial "$(get_system_id)-toolbox-$(get_system_version)"
assert_line --index 6 --partial "non-default-one"
assert_line --index 7 --partial "non-default-two"
assert [ ${#lines[@]} -eq 9 ]
if check_bats_version 1.7.0; then
assert [ ${#stderr_lines[@]} -eq 0 ]
fi
}
@test "list: Images with and without names" {
local default_image
default_image="$(get_default_image)"
pull_default_image
pull_distro_image fedora 34
build_image_without_name >/dev/null
run --keep-empty-lines --separate-stderr "$TOOLBOX" list --images
assert_success
assert_line --index 1 --partial "<none>"
Unbreak sorting and clearly identify copied images in 'list' Currently, if an image was copied with: $ skopeo copy \ containers-storage:registry.fedoraproject.org/fedora-toolbox:36 \ containers-storage:localhost/fedora-toolbox:36 ... or: $ podman tag \ registry.fedoraproject.org/fedora-toolbox:36 \ localhost/fedora-toolbox:36 ... then it would show up twice in 'list' with the same name, and in the wrong order. Either as: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... ... or as: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... The correct output should be similar to 'podman images', and be sorted in ascending order of the names: $ toolbox list --images IMAGE ID IMAGE NAME CREATED 2110dbbc33d2 localhost/fedora-toolbox:36 1 day... e085805ade4a registry.access.redhat.com/ubi8/toolbox:latest 1 day... 70cbe2ce60ca registry.fedoraproject.org/fedora-toolbox:34 1 day... 2110dbbc33d2 registry.fedoraproject.org/fedora-toolbox:36 1 day... The problem is that, in these situations, 'podman images --format json' returns separate identical JSON collections for each copy of the image, and all of those copies have multiple names: [ { "Id": "2110dbbc33d2", ... "Names": [ "localhost/fedora-toolbox:36", "registry.fedoraproject.org/fedora-toolbox:36" ], ... }, { "Id": "e085805ade4a", ... "Names": [ "registry.access.redhat.com/ubi8/toolbox:latest" ], ... }, { "Id": "2110dbbc33d2", ... "Names": [ "localhost/fedora-toolbox:36", "registry.fedoraproject.org/fedora-toolbox:36" ], ... } { "Id": "70cbe2ce60ca", ... "Names": [ "registry.fedoraproject.org/fedora-toolbox:34" ], ... }, ] The image objects need to be flattened to have only one unique name per copy, but with the same ID, and then sorted to ensure the right order. Note that the ordering was already broken since commit 2369da5d31830e5c, which started using 'podman images --sort repository'. Podman can sort by either the image's repository or tag, but not by the unified name, which is what Toolbx needs. Therefore, even without copied images, Toolbx really does need to sort the images itself. Prior to commit 2369da5d31830e5c, the ordering was correct, but copied images would only show up once. Fallout from 2369da5d31830e5cd3e1a13857a686365875ae61 This reverts parts of commit 67e210378e7b43cc0847cd171209861862f225b0. https://github.com/containers/toolbox/issues/1043
2022-12-06 17:15:15 +00:00
assert_line --index 2 --partial "fedora-toolbox:34"
assert_line --index 3 --partial "$default_image"
assert [ ${#lines[@]} -eq 5 ]
if check_bats_version 1.7.0; then
assert [ ${#stderr_lines[@]} -eq 0 ]
fi
}