wbrawner/toolbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
toolbox/test/system/102-list.bats

113 lines
2.7 KiB
Text
Raw Normal View History

test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
#!/usr/bin/env bats
load 'libs/bats-support/load'
load 'libs/bats-assert/load'
load 'libs/helpers'
setup() {
cleanup_all
}
teardown() {
cleanup_all
}
@test "list: Run 'list' with zero containers and zero images (the list should be empty)" {
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
assert_output ""
}
@test "list: Run 'list -c' with zero containers (the list should be empty)" {
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list -c
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
assert_output ""
}
@test "list: Run 'list -i' with zero images (the list should be empty)" {
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list -c
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
assert_output ""
}
@test "list: Run 'list' with zero toolbox's containers and images, but other image (the list should be empty)" {
test/system: Decouple image caching from Zuul Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. [0] https://github.com/containers/toolbox/pull/517 https://github.com/containers/toolbox/pull/774
2021-05-25 22:09:53 +00:00
pull_distro_image busybox
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
run podman images
assert_output --partial "$BUSYBOX_IMAGE"
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
assert_output ""
}
@test "list: Try to list images and containers (no flag) with 3 containers and 2 images (the list should have 3 images and 2 containers)" {
# Pull the two images
pull_default_image
test/system: Decouple image caching from Zuul Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. [0] https://github.com/containers/toolbox/pull/517 https://github.com/containers/toolbox/pull/774
2021-05-25 22:09:53 +00:00
pull_distro_image fedora 32
# Create three containers
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
create_default_container
create_container non-default-one
create_container non-default-two
# Check images
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list --images
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
test/system: Decouple image caching from Zuul Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. [0] https://github.com/containers/toolbox/pull/517 https://github.com/containers/toolbox/pull/774
2021-05-25 22:09:53 +00:00
assert_output --partial "$(get_system_id)-toolbox:$(get_system_version)"
test/system: Bump secondary fedora image from 29 to 32 The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. Seems like newer version of ShellCheck checks the validity of variable names (SC2153). This caused a false positive, so I silenced it. [0] https://github.com/containers/toolbox/pull/615 https://github.com/containers/toolbox/pull/780
2021-05-26 22:13:18 +00:00
assert_output --partial "fedora-toolbox:32"
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
# Check containers
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list --containers
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
test/system: Decouple image caching from Zuul Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. [0] https://github.com/containers/toolbox/pull/517 https://github.com/containers/toolbox/pull/774
2021-05-25 22:09:53 +00:00
assert_output --partial "$(get_system_id)-toolbox-$(get_system_version)"
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_output --partial "non-default-one"
assert_output --partial "non-default-two"
# Check all together
test/system: Use env var for invoking Toolbox The system test refactor[0] replaced the 'run_toolbox' helper function with 'run toolbox', which is a normal invocation of Toolbox. This makes it impossible to override Toolbox used during the tests using env var. [0] https://github.com/containers/toolbox/pull/693
2021-05-26 20:12:18 +00:00
run $TOOLBOX list
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_success
test/system: Decouple image caching from Zuul Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. [0] https://github.com/containers/toolbox/pull/517 https://github.com/containers/toolbox/pull/774
2021-05-25 22:09:53 +00:00
assert_output --partial "$(get_system_id)-toolbox:$(get_system_version)"
test/system: Bump secondary fedora image from 29 to 32 The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. Seems like newer version of ShellCheck checks the validity of variable names (SC2153). This caused a false positive, so I silenced it. [0] https://github.com/containers/toolbox/pull/615 https://github.com/containers/toolbox/pull/780
2021-05-26 22:13:18 +00:00
assert_output --partial "fedora-toolbox:32"
test/system: Decouple image caching from Zuul Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. [0] https://github.com/containers/toolbox/pull/517 https://github.com/containers/toolbox/pull/774
2021-05-25 22:09:53 +00:00
assert_output --partial "$(get_system_id)-toolbox-$(get_system_version)"
test/system: Refactor tests using bats-support and bats-assert The bats-support[0] and bats-assert[1] libraries extend the capabilities of bats[2]. Mainly, bats-assert is very useful for clean checking of values/outputs/return codes. Apart from updating the cases to use the libraries, the test cases have been restructured in a way that they don't depend on each other anymore. This required major changes in the helpers.bats file. Overall, the tests are cleaner to read and easier to extend due to the test cases being independent. Some slight changes were made to the test cases themselves. Should not alter their final behaviour. There will be a follow up commit that will take care of downloading of the tested images locally and caching them using Skopeo to speedup the tests and try to resolve network problems when pulling the images that we experienced in the past. [0] https://github.com/bats-core/bats-support [1] https://github.com/bats-core/bats-assert [2] https://github.com/bats-core/bats-core
2020-07-27 13:35:17 +00:00
assert_output --partial "non-default-one"
assert_output --partial "non-default-two"
}
list: Recognize UBI8 as Toolbox image & split tracked labels UBI[0] does not have the recommend Toolbox labels used to track whether an image/container is truly a toolbox image/container. Thankfully, they have a number of labels to choose from that we can use to identify the image. The "com.redhat.component=ubi8-container" seems to be ideal. The approach of using the UBI8 label introduces one problem though. If we were to use only one set of labels for both images and containers, containers created with Podman and not Toolbox from UBI8 would also be marked as toolbox containers. This is not desired and therefore there are now two sets of labels. Ones for images where the new label has been added and other for containers that stays the same.
2021-05-26 13:25:04 +00:00
@test "list: Run 'list -i' with UBI image (8.4; public) present" {
pull_distro_image rhel 8.4
run toolbox list --images
assert_success
assert_output --partial "registry.access.redhat.com/ubi8/ubi:8.4"
}
@test "list: Run 'list' with UBI image (8.4; public), toolbox container and non-toolbox container" {
local num_of_containers
pull_distro_image rhel 8.4
create_distro_container rhel 8.4 rhel-toolbox
podman create --name podman-container ubi8/ubi:8.4 /bin/sh
num_of_containers=$(list_containers)
assert [ $num_of_containers -eq 2 ]
run toolbox list
assert_success
assert_line --index 1 --partial "registry.access.redhat.com/ubi8/ubi:8.4"
assert_line --index 3 --partial "rhel-toolbox"
refute_output --partial "podman-container"
}
Reference in a new issue Copy permalink