From 74bf1af9837dfec1dd40c5687e1aea1798469f11 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Fri, 22 Sep 2023 19:35:22 +0200 Subject: [PATCH] test/system: Remove stray 'podman ...' error in setup_suite() failures If setup_suite() fails for some reason, then an unrelated message from 'podman system reset' would show up: not ok 1 setup_suite # (from function `setup_suite' in test file test/system/setup_suite.bash, line 43) # `_pull_and_cache_distro_image foo || false' failed # Requested distro (foo) does not have a matching image # A "/home/rishi/.cache/toolbox/system-test-storage/storage.conf" config file exists. # Remove this file if you did not modify the configuration. This extra error message from 'podman system reset' serves no purpose because it's not related to the cause of the setup_suite() failure. It's just noise and it's better to silence it. https://github.com/containers/toolbox/pull/1375 --- test/system/libs/helpers.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/system/libs/helpers.bash b/test/system/libs/helpers.bash index 896c0fa..66c1030 100644 --- a/test/system/libs/helpers.bash +++ b/test/system/libs/helpers.bash @@ -56,7 +56,7 @@ function _setup_containers_storage() { function _clean_temporary_storage() { - "$PODMAN" system reset --force + "$PODMAN" system reset --force >/dev/null rm --force --recursive "${ROOTLESS_PODMAN_STORE_DIR}" rm --force --recursive "${ROOTLESS_PODMAN_RUNROOT_DIR}"