From cb4e5dd52dbf2b65377b3bd7eb16100e294e7214 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Fri, 13 Oct 2023 23:59:05 +0200 Subject: [PATCH] playbooks: Show the go-md2man(1) version Ansible's built-in 'package' module doesn't show any details when installing the RPMs. All that can be seen is: TASK [Install RPM packages] fedora-rawhide | changed Therefore, there's no way to know what version of the packages got installed. In this case, not knowing the go-md2man(1) version being used by the CI makes it difficult to know why the tests are failing on Fedora Rawhide and Fedora 39 with: not ok 3 help: Command 'help' in 177ms # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 479, # in test file test/system/002-help.bats, line 48) # `assert_line --index 0 --partial "toolbox(1)"' failed # /usr/bin/man # # -- line does not contain substring -- # index : 0 # substring : toolbox(1) # line : troff::33: warning: cannot select font 'C' # -- # It could be either because the CI is still using an older version of go-md2man(1) [1,2], or that there's some other problem. [1] Fedora golang-github-cpuguy83-md2man commit 117806d50e401c19 https://src.fedoraproject.org/rpms/golang-github-cpuguy83-md2man/c/117806d50e401c19 https://src.fedoraproject.org/rpms/golang-github-cpuguy83-md2man/pull-request/3 [2] go-md2man commit d85280db9b54b574 https://github.com/cpuguy83/go-md2man/commit/d85280db9b54b574 https://github.com/cpuguy83/go-md2man/issues/99 https://github.com/containers/toolbox/pull/1386 --- playbooks/dependencies-centos-9-stream.yaml | 2 +- playbooks/dependencies-fedora-restricted.yaml | 2 +- playbooks/dependencies-fedora.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/playbooks/dependencies-centos-9-stream.yaml b/playbooks/dependencies-centos-9-stream.yaml index 157ae4f..ffbc6d9 100644 --- a/playbooks/dependencies-centos-9-stream.yaml +++ b/playbooks/dependencies-centos-9-stream.yaml @@ -54,7 +54,7 @@ chdir: '{{ zuul.project.src_dir }}' - name: Check versions of crucial packages - command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* golang shadow-utils-subid-devel podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper skopeo + command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* golang golang-github-cpuguy83-md2man shadow-utils-subid-devel podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper skopeo - name: Show podman versions command: podman version diff --git a/playbooks/dependencies-fedora-restricted.yaml b/playbooks/dependencies-fedora-restricted.yaml index f0e3649..2567e0c 100644 --- a/playbooks/dependencies-fedora-restricted.yaml +++ b/playbooks/dependencies-fedora-restricted.yaml @@ -78,4 +78,4 @@ chdir: '{{ zuul.project.src_dir }}' - name: Check versions of crucial packages - command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* shadow-utils-subid-devel golang flatpak-session-helper + command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* shadow-utils-subid-devel golang golang-github-cpuguy83-md2man flatpak-session-helper diff --git a/playbooks/dependencies-fedora.yaml b/playbooks/dependencies-fedora.yaml index eec0ef5..194f4e6 100644 --- a/playbooks/dependencies-fedora.yaml +++ b/playbooks/dependencies-fedora.yaml @@ -54,7 +54,7 @@ chdir: '{{ zuul.project.src_dir }}' - name: Check versions of crucial packages - command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* shadow-utils-subid-devel golang podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper skopeo + command: rpm -qa ShellCheck codespell *kernel* gcc *glibc* shadow-utils-subid-devel golang golang-github-cpuguy83-md2man podman conmon containernetworking-plugins containers-common container-selinux crun fuse-overlayfs flatpak-session-helper skopeo - name: Show podman versions command: podman version