Commit graph

71 commits

Author SHA1 Message Date
Debarshi Ray
a878a1fe40 Dockerfile: Add a maintainer label
... as mandated by the Fedora Container Guidelines:
https://fedoraproject.org/wiki/Container:Guidelines#LABELS
2018-09-18 16:06:55 +02:00
Debarshi Ray
c9e1d585f0 Remove extra whitespaces
Fallout from d7219ba512
2018-09-14 20:03:54 +02:00
Debarshi Ray
4581537baf Localize the working container name to 'create'
The working container and its name is a temporary and internal detail
of the 'create' command. It's not something that someone would want to
manually tweak.

Since 'local' is not mandated by POSIX, use a subshell for the
function instead.

This is a step towards making the commands more parametrized so that
one can use different toolbox containers.
2018-09-14 20:03:54 +02:00
Debarshi Ray
29b8471f6c Unhide the error output when unable to create a working container
Fallout from d7219ba512
2018-09-14 17:14:38 +02:00
Debarshi Ray
5cc2678a36 Dockerfile: Specify a CMD
... as mandated by the Fedora Container Guidelines:
https://fedoraproject.org/wiki/Container:Guidelines#CMD_.2F_ENTRYPOINT

The same entrypoint is also specified in 'create' because since
podman-0.9.1 'podman create ...' doesn't work without a command. See
commit fd697274a3.
2018-09-14 16:38:59 +02:00
Debarshi Ray
419bb1edeb README.md: Be consistent with the hyphenation 2018-09-14 13:11:53 +02:00
Debarshi Ray
edfb736517 Dockerfile: COPY the README.md into the fedora-toolbox image
... as mandated by the Fedora Container Guidelines:
https://fedoraproject.org/wiki/Container:Guidelines#Help_File
2018-09-14 11:49:24 +02:00
Debarshi Ray
b85fd7fccc README.md: Link to the GitHub page
The Fedora Container Guidelines [1] mandate that a README.md must be
COPYed into the image, and that it should have a link to the project
page.

[1] https://fedoraproject.org/wiki/Container:Guidelines#Help_File
2018-09-14 11:47:11 +02:00
Debarshi Ray
89bd833f44 README.md: Add description 2018-09-13 14:26:58 +02:00
Debarshi Ray
fd697274a3 Use a lighter PID 1 than $SHELL
When used as PID 1, /bin/sh takes 3248 kB compared to the 4136 kB
taken by /bin/bash. It's not a lot, but is memory that can be saved
for free.

As a nice side-effect, this unbreaks 'create' with podman-0.9.1 because
'podman create ...' doesn't work without a command.

https://github.com/containers/libpod/issues/1452
2018-09-13 11:49:26 +02:00
Debarshi Ray
d7219ba512 Allow unhiding the error output when desired
This adds a --verbose flag which will prevent the error stream of the
child commands from being redirected to /dev/null. The intermediate
file descriptor is arbitrarily hard coded as 42 because shell
variables and redirection don't appear to play well together.
2018-09-12 20:44:24 +02:00
Debarshi Ray
678bdbaf4e Make room for specifying global options and commands
A subsequent commit will add a global --verbose option that's can be
used with all commands. This will make it possible to do so.
2018-09-12 20:44:20 +02:00
Debarshi Ray
7cd0b3ce97 Be more explicit when the number of arguments is wrong
This is more in line with how unrecognized commands and options are
reported.
2018-09-12 20:44:16 +02:00
Debarshi Ray
fb3b0f76cb Add missing 'enter' command to --help
Fallout from 990e9eb5b7
2018-09-12 20:44:14 +02:00
Debarshi Ray
e02ea68921 README.md: Update
Fallout from 6c3031c9d0
2018-09-12 16:29:15 +02:00
Debarshi Ray
6c3031c9d0 Prefix the toolbox PS1 with an emoji for differentiation
Flatbox already uses 📦, so got to try something different. 🔹 could be
a good option. It's small, subtle and blue.
2018-09-12 15:19:55 +02:00
Debarshi Ray
f100cdaf77 Use $XDG_RUNTIME_DIR instead of /run/user/$UID 2018-09-11 19:25:28 +02:00
Debarshi Ray
34bfd0317d extra-packages: Add more things present in the Workstation image 2018-09-11 19:09:10 +02:00
Debarshi Ray
9e9a373d97 extra-packages: Add dnf-plugins-core
It's installed by default on Fedora Workstation.
2018-09-04 16:35:54 +02:00
Michael Scherer
0dedc0140d Avoid repeated prompts to unlock SSH keys
... by giving access to the SSH agent.

https://github.com/debarshiray/fedora-toolbox/pull/1
2018-09-03 16:39:51 +02:00
Debarshi Ray
990e9eb5b7 Initial revision 2018-08-31 18:38:01 +02:00