Commit graph

38 commits

Author SHA1 Message Date
Harry Míchal
dd947016b3 pkg/utils: Add function to check if an image is referenced by its ID
https://github.com/containers/toolbox/pull/318
2020-05-13 12:59:04 +02:00
Harry Míchal
d589b3a252 pkg/utils: Add function to show an error for invalid release arguments
https://github.com/containers/toolbox/pull/318
2020-05-13 12:59:04 +02:00
Harry Míchal
43082145a9 pkg/utils: Add function to parse the user-specified release string
https://github.com/containers/toolbox/pull/318
2020-05-13 12:59:04 +02:00
Debarshi Ray
9e2825524a pkg/utils: Add functions for reading various os-release fields
https://github.com/containers/toolbox/pull/318
2020-05-13 12:59:04 +02:00
Harry Míchal
2edc30836b pkg/utils: Add functions to get the mount metadata of a directory
https://github.com/containers/toolbox/pull/318
2020-05-13 12:59:04 +02:00
Harry Míchal
98b7753104 pkg/utils: Add function to check the validity of a container's name
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Debarshi Ray
08fbf92473 pkg/utils: Wrap call to o.fd.Flatpak.SessionHelper.RequestSession
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
772b66bf3e cmd/initContainer: Implement the init-container command
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
31f1b741c0 pkg/utils: Add function to get the name of the sudoers group
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
188c92c76e cmd/rm: Implement the rm command in Go
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
805450283b cmd/rmi: Implement the rmi command
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
08e8a80d4c pkg/podman: Add functions to check if a container/image is a Toolbox
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
c75404c056 pkg/podman: Wrap 'podman inspect --format json'
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
c30d5549b6 cmd/list: Implement the list command
Go's text/tabwriter package isn't aware of the ANSI Select Graphic
Rendition (or SGR) escape sequences to change the terminal's
foreground colour [1,2]. Using the sequences disrupt the alignment of
the columns in the tabbed output.

Therefore, unlike the existing POSIX shell implementation, running
containers aren't marked in green in the Go version.

[1] https://en.wikipedia.org/wiki/ANSI_escape_code
[2] https://github.com/golang/go/issues/12073

https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
f4d129ab4d pkg/podman: Wrap 'podman images' & 'podman ps'
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
74c2d7f02b pkg/utils: Add function to sort sets of containers or images in JSON
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
928bf53943 pkg/utils: Add function to join sets of containers or images in JSON
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
6170f494aa pkg/utils: Add function to shorten the hash of a container of image
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
c2ba67569b cmd/root: Implement migration of containers and images
https://github.com/containers/toolbox/pull/318
2020-05-13 12:42:26 +02:00
Harry Míchal
d1a9fe20aa pkg/podman: Wrap 'podman system migrate'
https://github.com/containers/toolbox/pull/318
2020-05-13 12:33:34 +02:00
Harry Míchal
46c21a5c14 podman: Add function to check if Podman is newer than a given version
This is in the same style as GLib's GLIB_CHECK_VERSION [1].

Note that the github.com/HarryMichal/go-version package is a fork of
github.com/mcuadros/go-version. The latter is now marked as read-only
and archived by its owner.

The fork was necessary to fix the documentation of the CompareSimple
function. The function is supposed to conform to the strcmp
convention. ie., return 0 if both versions are equal, 1 if the left
side is bigger, and -1 if the right side is bigger. However, the
documentation had it the other way round.

[1] https://developer.gnome.org/glib/stable/glib-Version-Information.html#GLIB-CHECK-VERSION:CAPS

https://github.com/containers/toolbox/pull/318
2020-05-13 12:16:48 +02:00
Harry Míchal
b3fca25764 pkg/podman: Wrap 'podman version --format json'
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Harry Míchal
3f0a135937 cmd/root: Initialize TOOLBOX_PATH; validate /etc/subgid & /etc/subuid
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Debarshi Ray
e8866f2db1 cmd/help, cmd/root: Parametrize the basename of the executable
... instead of hard coding it as 'toolbox'.

https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Harry Míchal
e8d7f25e83 cmd/root: Initialize globals on start-up
These values are generally useful, and reading any of them is a
potentially fallible operation. Since the absence of any of these
values is indicative of a broken environment, it's more convenient to
read them early on during start-up and abort, instead of trying to
handle the error later on.

https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Debarshi Ray
f5bf741f86 pkg/utils: Add function to get the cgroups version
Based on the IsCgroup2UnifiedMode function:
https://github.com/containers/libpod/tree/master/pkg/cgroups

As suggested by Matthew Heon.

https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Harry Míchal
aaf81a56ea Sketch out the command line interface in Go
All the existing commands and their flags are present; but barring
'help', '--help' and logging, they don't do anything.

The skeleton was bootstrapped with Cobra Generator.

https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Debarshi Ray
561fe8b12d Lay the foundations for logging Podman in Go
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Debarshi Ray
c9ae8ad3b6 pkg/utils: Add function to tunnel a Toolbox invocation to the host
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:41 +02:00
Harry Míchal
ebad3af632 pkg/utils: Add function to get the options to propagate the environment
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:40 +02:00
Debarshi Ray
03ca79a7b0 pkg/utils: Add function to check if running inside a toolbox container
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:40 +02:00
Harry Míchal
8f03a902f2 pkg/utils: Add function to check if running inside a container
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:40 +02:00
Harry Míchal
bd5b8065ae pkg/utils: Add function to conveniently check if a path exists
https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:40 +02:00
Debarshi Ray
7ab4ca868c Add a utility function for showing manuals in Go
A subsequent commit will use this to implement the help command.

Just like the existing POSIX shell implementation, the standard error
needs to be redirected to standard output. For details see commit
5e63e9ec9b.

https://github.com/containers/toolbox/pull/318
2020-05-13 09:40:00 +02:00
Debarshi Ray
19081b5d4a Add convenience wrappers to shell out to any binary in Go
https://github.com/containers/toolbox/pull/318
2020-05-13 09:39:35 +02:00
Harry Míchal
53f4d0c2f0 Add versioning infrastructure in Go
https://github.com/containers/toolbox/pull/318
2020-05-13 09:38:58 +02:00
Debarshi Ray
1b6d7d6410 build: Hook up the Go code with Meson
Meson doesn't support Go [1], so this is implemented by a custom target
that invokes 'go build' to generate the binary.

Unfortunately, when using Go modules, 'go build' insists on being
invoked in the same source directory where the go.mod file lives,
while Meson insists on using a build directory separate from the
corresponding source directory. This is addressed by using a build
script that goes into the source directory and then invokes 'go build'.

Currently, the Go code is only built when a Go implementation is found,
and even then, it's not installed. Non-technical end-users are supposed
to continue using the POSIX shell implementation until the Go version
is blessed as stable.

[1] https://github.com/mesonbuild/meson/issues/123

https://github.com/containers/toolbox/pull/318
2020-05-13 09:38:52 +02:00
Harry Míchal
d857471aa2 Add a skeleton for the Go rewrite
To build the Go, enter the src sub-directory and use 'go build':
  $ cd src
  $ go build

https://github.com/containers/toolbox/pull/318
2020-05-12 16:58:03 +02:00