wbrawner/twigs
1
0
Fork 0
Code Issues Pull requests 2 Projects Releases Packages 1 Wiki Activity Actions

Revert "Return full transaction object for individual transactions"

Browse source 
This reverts commit 17ad169fe1.
This commit is contained in:
Billy Brawner 2019-10-12 17:51:42 -07:00
parent 17ad169fe1
commit 5d7470a006
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/main/kotlin/com/wbrawner/budgetserver/transaction/TransactionController.kt
View file

@ -90,11 +90,11 @@ class TransactionController @Autowired constructor(
@GetMapping("/{id}", produces = [MediaType.APPLICATION_JSON_VALUE])
@ApiOperation(value = "getTransaction", nickname = "getTransaction", tags = ["Transactions"])
fun getTransaction(@PathVariable id: Long): ResponseEntity<Transaction> {
fun getTransaction(@PathVariable id: Long): ResponseEntity<TransactionResponse> {
val transaction = transactionRepository.findById(id).orElse(null) ?: return ResponseEntity.notFound().build()
budgetRepository.findByUsersContainsAndTransactionsContains(getCurrentUser()!!, transaction).orElse(null)
?: return ResponseEntity.notFound().build()
return ResponseEntity.ok(transaction)
return ResponseEntity.ok(TransactionResponse(transaction))
}
@Transactional
@ -107,7 +107,7 @@ class TransactionController @Autowired constructor(
val category: Category? = request.categoryId?.let {
categoryRepository.findByBudgetAndId(budget, request.categoryId).orElse(null)
}
return ResponseEntity.ok(transactionRepository.save(Transaction(
return ResponseEntity.ok(TransactionResponse(transactionRepository.save(Transaction(
title = request.title,
description = request.description,
date = Instant.parse(request.date),
@ -116,12 +116,12 @@ class TransactionController @Autowired constructor(
expense = request.expense,
budget = budget,
createdBy = getCurrentUser()!!
)))
))))
}
@PutMapping("/{id}", consumes = [MediaType.APPLICATION_JSON_VALUE], produces = [MediaType.APPLICATION_JSON_VALUE])
@ApiOperation(value = "updateTransaction", nickname = "updateTransaction", tags = ["Transactions"])
fun updateTransaction(@PathVariable id: Long, @RequestBody request: UpdateTransactionRequest): ResponseEntity<Transaction> {
fun updateTransaction(@PathVariable id: Long, @RequestBody request: UpdateTransactionRequest): ResponseEntity<TransactionResponse> {
var transaction = transactionRepository.findById(id).orElse(null) ?: return ResponseEntity.notFound().build()
var budget = budgetRepository.findByUsersContainsAndTransactionsContains(getCurrentUser()!!, transaction)
.orElse(null) ?: return ResponseEntity.notFound().build()
@ -141,7 +141,7 @@ class TransactionController @Autowired constructor(
transaction = transaction.copy(category = category)
}
}
return ResponseEntity.ok(transactionRepository.save(transaction))
return ResponseEntity.ok(TransactionResponse(transactionRepository.save(transaction)))
}
@DeleteMapping("/{id}", produces = [MediaType.TEXT_PLAIN_VALUE])