Commit graph

359 commits

Author SHA1 Message Date
Yigit Boyar
1ef805fa73 Stream only (#19)
* try delegaitng get calls to steam

* WIP handle null

This CL changes pipeline persister to handle null reader response to fetch.
This is WIP, need another fix before it can be used

* move StoreTest and StoreWithParserTest to coroutines testing lib

The test coroutine scope checks for any remaining jobs at the end of a test
which helped us find two bugs (#17, #18) both of which were discovered when
i tried to move this tests to the TestCoroutineScope after the streamOnly
change.
This change completes the move to avoid further regressions. Eventually,
we should move all tests

* remove unused get method from PipelineStore
2019-08-03 18:43:54 -04:00
Yigit Boyar
c82421104e
Fix key tracker (#18)
* Fix KeyTracker subscription order

This PR fixes a race condition where if the SimplePersisterAsFlowable's write
is called inside a reader, reader wouldn't be notified again

* Fix StreamOneKeyTest

This test was passing by mistake :/. Right now, when we create the backport
Store from a Pipeline, the  method skips memory cache but uses
disk cache. This test was not initializing the disk cache w/ empty value,
which meant the initial read would get first value as if it is cached and
then would also get the new value.'
The test didn't fail before because KeyTracker had a concurrency but where
it missed 1 invalidation call
2019-08-03 01:37:46 -07:00
Yigit Boyar
550eb18f48
Fix side collect (#17)
This PR fixes a bug in side-collect where it was not cancelling the side
collection when main flow stops.
It still does not handle the case where side collect fails but that can only be fixed when we have error handling.

Needed to move the method to a non-private place to be able to write tests :/
2019-08-02 05:27:03 -07:00
Yigit Boyar
645cbc1ef5
StoreRequest (#15)
StoreRequest to encapsulate the get/stream into an object that can be passed down/modified/scaled.

The suspend cache APIs became a bit weird due to supporting both implementations. We can clean it up once we have only 1 implementation.
2019-07-25 21:04:06 -07:00
Fabio Collini
b7c4dbdebf Removed extra generic (#14) 2019-07-18 09:47:30 -07:00
fabioCollini
e63c6bbef8 Revert "Removed extra generic"
This reverts commit 1d912ea8
2019-07-17 08:43:24 +02:00
fabioCollini
1d912ea898 Removed extra generic 2019-07-17 08:41:41 +02:00
Yigit Boyar
1ba634e7c3 [DO NOT MERGE] Pipeline Implementation (#13)
pipeline API
2019-07-15 21:01:09 -04:00
Yigit Boyar
dc9b1bd51c
Suspend cache (#8)
This PR adds a cache implementation that has all APIs as suspend functions.
It uses guava's cache under the hood and handles query deduplication in a custom
Entry type that we keep in the cache
2019-07-02 07:25:36 -07:00
Fabio Collini
823dbcc3e2
Fix inflight definition and create new builder (#2)
* AGP 3.5.0-beta05

* Inflight as constructor argument

* New builder class

* Rename addPersister to persister

* Rename addParser to parser

* Rename addCache to cache
2019-07-01 08:36:40 +02:00
Yigit Boyar
8cf3ec1dcc
Merge pull request #7 from friendlyrobotnyc/mike/optimizeCacheLoader
make cache  use function in builder rather than  in each call
2019-06-30 20:50:11 -07:00
DigitalBuddha
b560d6d503 make cache use function in builder rather than in each call 2019-06-30 18:01:18 -04:00
Fabio Collini
58cdc5420d REFRESH_ON_STALE managed using a new scope (#6) 2019-06-30 13:14:22 -04:00
DigitalBuddha
7a0398ddf4 Merge remote-tracking branch 'origin/master' 2019-06-30 12:38:52 -04:00
DigitalBuddha
b72122a5e5 fix tests 2019-06-30 12:38:46 -04:00
Brian Plummer
5664208277
Merge pull request #3 from yigit/move-to-androidx
Move dependencies to AndroidX
2019-06-30 11:42:43 -04:00
Brian Plummer
5b3b1b03f2
Merge branch 'master' into move-to-androidx 2019-06-30 11:42:03 -04:00
Brian Plummer
c55bc6708e
Merge pull request #4 from friendlyrobotnyc/tech/circleCISetup
test of circle ci
2019-06-30 11:24:45 -04:00
Brian Plummer
6ebeea26f3 point readme to core repo 2019-06-30 11:20:01 -04:00
Yigit Boyar
25ef7dc72d Move dependencies to AndroidX 2019-06-30 06:18:07 -07:00
Fabio Collini
91217c8fa8 RealInternalStore refactoring (#1)
* AGP 3.5.0-beta04

* Stream implementation defined in the interface

* New class StoreWrapper

* Delete StoreBuilder

* Rename plus methods

* Move stalePolicy to Persister

* Simplify code

* Move inflight request management to a new class

* Move cache management to a new class

* Move wrappers to new package

* Delete StoreWrapper class

* New test

* Restored old versions

* Restored old versions

* Restored old versions

* Restored old versions

* Restored old versions

* Restored old versions

* Add runCatching to ignore exceptions on persisters

* Backward compatible RealStoreBuilder implementation

* Fix tests
2019-06-29 19:49:47 -04:00
Brian Plummer
2f9dc95aa0 Merge remote-tracking branch 'r1remote/feature/coroutines' 2019-06-06 21:03:09 -04:00
Brian Plummer
727a17dd73 remove gitignore 2019-06-06 20:59:22 -04:00
Brian Plummer
2ac2dd1c9c remove license 2019-06-06 20:57:30 -04:00
Brian Plummer
83a07e3b87
Initial commit 2019-06-06 20:36:36 -04:00
Brian Plummer
df98e78043
Merge pull request #8 from friendlyrobotnyc/feature/clear
Remove deprecated and unused methods
2019-05-29 19:32:59 -04:00
fabioCollini
ae2576922c Fix tests 2019-05-29 09:14:21 +02:00
fabioCollini
53f823548c Removed extra RealInternalStore constructor 2019-05-29 08:46:35 +02:00
fabioCollini
1861992d69 Removed class delegates in RealInternalStore 2019-05-29 08:43:28 +02:00
fabioCollini
805b19c533 Removed getRefreshing method 2019-05-29 08:40:20 +02:00
fabioCollini
7958f3a0e0 Removed deprecated clear methods 2019-05-29 08:37:26 +02:00
Mike Nakhimovich
d2f35e48ad
Update PersistingStoreActivity.kt 2019-05-28 22:00:09 -04:00
Brian Plummer
8479076edd
Merge pull request #7 from friendlyrobotnyc/feature/reifiedParsers
Feature/reified parsers
2019-05-28 09:15:09 -04:00
Brian Plummer
e23b13583b comment out testMultiBarcode 2019-05-28 09:11:35 -04:00
Brian Plummer
60245460d7
Merge pull request #6 from friendlyrobotnyc/feature/fresh-only-on-network
Never returns cached data on fresh
2019-05-28 08:30:55 -04:00
Brian Plummer
3d1ebd751a reify gson, use jvm 1.8 for kotlin compile in sample 2019-05-28 08:17:23 -04:00
fabioCollini
fddea54d32 Never returns cached data on fetch 2019-05-28 09:54:15 +02:00
Brian Plummer
e4b8a682a0 reified moshi 2019-05-27 18:09:32 -04:00
Brian Plummer
98458352fe
Merge pull request #5 from friendlyrobotnyc/bug/testMultiBarcode
change name to testMultiBarcode and use delay
2019-05-27 16:02:54 -04:00
Brian Plummer
7981500102
Merge pull request #3 from friendlyrobotnyc/feature/remove-getWithResult
Remove getWithResult and freshWithResult
2019-05-27 15:58:29 -04:00
Brian Plummer
15a624ad52 remove delay, remove wildcard 2019-05-27 15:57:51 -04:00
Brian Plummer
51063b9eea change name to testMultiBarcode and use delay 2019-05-27 15:51:15 -04:00
Fabio Collini
7480d5a9c4 Convert filesystem classes to Kotlin (#4) 2019-05-27 15:41:04 -04:00
fabioCollini
e65f18a4f4 Remove getWithResult and freshWithResult 2019-05-27 20:47:58 +02:00
Fabio Collini
a7edcf2aca Flow<Pair<V, T>> as stream result (#2) 2019-05-27 12:26:55 -04:00
Brian Plummer
98cd388e7f
Merge pull request #1 from friendlyrobotnyc/feature/flow
stream methods using Flows instead of Channels
2019-05-27 11:04:45 -04:00
fabioCollini
4e3411ebf7 Restore test 2019-05-27 16:57:04 +02:00
fabioCollini
b50c41a5f3 Merge branch 'feature/coroutines' into feature/flow
# Conflicts:
#	store/src/main/java/com/nytimes/android/external/store3/base/impl/RealInternalStore.kt
2019-05-27 16:55:48 +02:00
fabioCollini
ca62ca14a1 Restore code format 2019-05-27 16:55:09 +02:00
DigitalBuddha
a227ae2169 fixing readme 2019-05-27 10:32:20 -04:00