Commit graph

36598 commits

Author SHA1 Message Date
Jordan Borean
00bf656c89 win_uri: use variable for httpbin host (#46734)
(cherry picked from commit f34f75be45)
2018-10-16 16:51:33 -07:00
Jordan Borean
cadc146ffe ps-lint: ignore rules that are not relevant to Ansible (#46376)
(cherry picked from commit ba638f40cf)
2018-10-16 16:50:25 -07:00
Matt Clay
abef1d5dd3 [stable-2.5] Update requirements for urllib3 for python 2.6.
(cherry picked from commit d048785640)

Co-authored-by: Matt Clay <matt@mystile.com>
2018-10-16 15:40:16 -07:00
Jordan Borean
31ed283e33 ansible-test: swap 2.5 to use AWS and not Azure 2018-10-15 15:44:06 -07:00
Risto Oikarinen
9dda676118 Make filters doc easier to read. Backport of #46569. (#47000) 2018-10-15 16:52:34 -05:00
Matt Clay
ca13e678ae Backport test infra fixes and updates to stable-2.5. (#46992)
* Fix unit test parametrize order on Python 3.5.

(cherry picked from commit 53b230ca74)

* Fix ansible-test unit test execution. (#45772)

* Fix ansible-test units requirements install.
* Run unit tests as unprivileged user under Docker.

(cherry picked from commit 379a7f4f5a)

* Run unit tests in parallel. (#45812)

(cherry picked from commit abe8e4c9e8)

* Minor fixes for unit test delegation.

(cherry picked from commit be199cfe90)

* add support for opening shell on remote Windows host (#43919)

* add support for opening shell on remote Windows host

* added arg completion and fix sanity check

* remove uneeded arg

(cherry picked from commit 6ca4ea0c1f)

* Block network access for unit tests in docker.

(cherry picked from commit 99cac99cbc)

* Make ansible-test available in the bin directory. (#45876)

(cherry picked from commit f3d1f9544b)

* Support comments in ansible-test flat files.

(cherry picked from commit 5a3000af19)

* Fix incorrect use of subprocess.CalledProcessError (#45890)

(cherry picked from commit 24dd87bd0a)

* Improve ansible-test match error handling.

(cherry picked from commit 2056c981ae)

* Improve error handling for docs-build test.

(cherry picked from commit 2148999048)

* Bug fixes and cleanup for ansible-test. (#45991)

* Remove unused imports.
* Clean up ConfigParser usage in ansible-test.
* Fix bare except statements in ansible-test.
* Miscellaneous cleanup from PyCharm inspections.
* Enable pylint no-self-use for ansible-test.
* Remove obsolete pylint ignores for Python 3.7.
* Fix shellcheck issuers under newer shellcheck.
* Use newer path for ansible-test.
* Fix issues in code-smell tests.

(cherry picked from commit ac492476e5)

* Fix integration test library search path.

This prevents tests from loading modules outside the source tree,
which could result in testing the wrong module if a system-wide
install is present, or custom modules exist.

(cherry picked from commit d603cd41fe)

* Update default container to version 1.2.0.

(cherry picked from commit d478a4c3f6)
(cherry picked from commit 21c4eb8db5)

* Fix ansible-test docker python version handling.

This removes the old name based version detection behavior and
uses versions defined in the docker completion file instead, as
the new containers do not follow the old naming scheme.

(cherry picked from commit 54937ba784)

* Reduce noise in docs-build test failures.

(cherry picked from commit 4085d01617)

* Fix ansible-test encoding issues for exceptions.

(cherry picked from commit 0d7a156319)

* Fix ansible-test multi-group smoke test handling. (#46363)

* Fix ansible-test smoke tests across groups.
* Fix ansible-test list arg defaults.
* Fix ansible-test require and exclude delegation.
* Fix detection of Windows specific changes.
* Add minimal Windows testing for Python 3.7.

(cherry picked from commit e53390b3b1)

* Use default-test-container version 1.3.0.

(cherry picked from commit 6d9be66418)

* Add file exists check in integration-aliases test.

(cherry picked from commit 33a8be9109)

* Improve ansible-test environment checking between tests. (#46459)

* Add unified diff output to environment validation.

This makes it easier to see where the environment changed.

* Compare Python interpreters by version to pip shebangs.

This helps expose cases where pip executables use a different
Python interpreter than is expected.

* Query `pip.__version__` instead of using `pip --version`.

This is a much faster way to query the pip version. It also more
closely matches how we invoke pip within ansible-test.

* Remove redundant environment scan between tests.

This reuses the environment scan from the end of the previous test
as the basis for comparison during the next test.

(cherry picked from commit 0dc7f38787)

* Add symlinks sanity test. (#46467)

* Add symlinks sanity test.
* Replace legacy test symlinks with actual content.
* Remove dir symlink from template_jinja2_latest.
* Update import test to use generated library dir.
* Fix copy test symlink setup.

(cherry picked from commit e2b6047514)

* Fix parametrize warning in unit tests.

(cherry picked from commit 1a28898a00)

* Update MANIFEST.in (#46502)

* Update MANIFEST.in:

- Remove unnecessary prune.
- Include files needed by tests.
- Exclude botmeta sanity test.

These changes permit sanity tests to pass on sdist output.
(cherry picked from commit cbb49f66ec)

* Fix unit tests which modify the source tree. (#45763)

* Fix CNOS unit test log usage.
* Use temp dir for Galaxy unit tests.
* Write to temp files in interfaces_file unit test.
* Fix log placement in netapp_e_ldap unit test.

(cherry picked from commit 0686450cae)

* Fix ansible-test custom docker image traceback.

(cherry picked from commit 712ad9ed64)

* ansible-test: Create public key creating Windows targets (#43760)

* ansible-test: Create public key creating Windows targets

* Changed to always set SSH Key for Windows hosts

(cherry picked from commit adc0efe10c)

* Fix and re-enable sts_assume_role integration tests (#46026)

* Fix the STS assume role error message assertion when the role to assume does not exist.

(cherry picked from commit 18dc928e28)

* Fix ACI unit test on Python 3.7.0.

The previous logic was only needed for pre-release versions of 3.7.

(cherry picked from commit c0bf9815c9)

* Remove placeboify from unit tests that are not calling AWS (i.e. creating a recording) (#45754)

(cherry picked from commit 2167ce6cb6)

* Update sanity test ignore entries.
2018-10-13 10:44:11 -07:00
Jordan Borean
f9c4da4cdf ansible-test: set ulimit to enforce consistent test environment (#46652)
* ansible-test: set ulimit to enforce consistent test environment

* fixed santiy issue

(cherry picked from commit 7b774117ab)
2018-10-09 18:56:02 -07:00
Matt Clay
034e5b6341 Use default Shippable container. (#46703)
(cherry picked from commit 40c9301b27)
2018-10-09 11:47:39 -07:00
Sloane Hertel
9a497b0557 Add 'auto' to documented default enabled inventory plugins (#46621) (#46639)
* Correct default inventory plugins enabled in docs and example/ansible.cfg

* Fix headers

(cherry picked from commit 43d12c11be)
2018-10-08 15:22:32 -05:00
Sandra McCann
b074980d12 updated to 2.7 and fixed merge conflict (#46417) 2018-10-02 16:22:44 -05:00
Matt Davis
37ca38bf67 New release v2.5.10 2018-09-27 16:30:06 -07:00
Alicia Cozine
954bf74158
doc: index_var: fix version added (#37982) (#46224)
e9b0a4ccb4 is present since v2.5.0b1

(cherry picked from commit 2a604f6fe6)
2018-09-27 13:58:53 -05:00
Jordan Borean
ade5934d33 skip installing linux-image-extra in CI as it shouldn't be needed (#46101) (#46131)
(cherry picked from commit 40379b76b1)
2018-09-25 13:25:33 -07:00
Matt Martz
e0eec68fe2 [stable-2.5] Fix issues with PLUGIN_FILTERS_CFG config handling (#45994) (#46092)
* Ensure that the value of PLUGIN_FILTERS_CFG is treated as type=path, and that we use the standard section of 'defaults' instead of 'default'

* deprecate the default section

* Don't add version_added for the corrected section
(cherry picked from commit 172137c)

Co-authored-by: Matt Martz <matt@sivel.net>
2018-09-25 13:25:06 -07:00
Jordan Borean
412b6a8ca7 append AWS region to test instance file (#45877) (#45884)
(cherry picked from commit 582a4dfa13)
2018-09-25 13:24:30 -07:00
Jonathan
ad1c62d6dd Added default value for when CloudFrontOriginAccessIdentityList is (#44984)
missing.

(cherry picked from commit 93cd050250)
2018-09-25 13:18:11 -07:00
Daniel Speichert
7aad590d3d [stable-2.5] Migrate from MySQLdb to PyMySQL (#40123) (#45982)
* Migrate from MySQLdb to PyMySQL

* Deduplicate driver loading and failure message

* Explain requirements

* Apply requirements docs change to proxysql too

* Add changelog.
(cherry picked from commit d34cf93f1a)

Co-authored-by: Daniel Speichert <DSpeichert@users.noreply.github.com>
2018-09-25 10:10:28 -07:00
Jordan Borean
c484a6efdd add skip/docker alias to skip tests when running on Docker (#45955) (#45959)
* add skip/docker alias to skip tests when running on Docker

* changed warning message wording

(cherry picked from commit 27c10fa502)
2018-09-25 09:14:31 -07:00
Jordan Borean
65fa6c17a7 go back to FreeBSD 11.1 for tests due to 11.2 stability issues (#45872) (#45873)
(cherry picked from commit a7d372c3ba)
2018-09-25 09:12:51 -07:00
Matt Martz
4e2d6df970 [stable-2.5] Support transfering empty files to target host. Fixes #36725 (#45751) (#45790)
(cherry picked from commit b6fcbfe)

Co-authored-by: Matt Martz <matt@sivel.net>
2018-09-25 09:11:51 -07:00
Nilashish Chakraborty
c60c27b7da Backport 2.5: Return correct version on installed VyOS (#39115) (#45715)
* Return correct version on installed VyOS (#39115)

* Return correct version on installed VyOS

Previously existing regexp will shows only "VyOS" without numeric output of router version.
For example: from  "Version:      VyOS 1.1.6" only VyOS will be written in ansible_net_version variable
For more informative output numeric value should be returned as well

* Fixed unittests

(cherry picked from commit 235b11f681)

* Added changelog
2018-09-25 09:10:52 -07:00
Matt Martz
6eb21c7852 [stable-2.5] Support empty files with piped transfer_method. Fixes #45426 (#45618) (#45626)
(cherry picked from commit e68f895)

Co-authored-by: Matt Martz <matt@sivel.net>
2018-09-25 09:10:00 -07:00
Matt Martz
0ba6cbfd02 [stable-2.5] Fix logic to not re-download existing files when force=no (#45495) (#45509) (#45567)
* [stable-2.5] [stable-2.7] Fix logic to not re-download existing files when force=no (#45495) (#45509)

* [stable-2.7] Fix logic to not re-download existing files when force=no (#45495)

* Fix logic to not re-download existing files when force=no. Fixes #45491

* Reduce logic complexity.
(cherry picked from commit 5785de582f)

Co-authored-by: Matt Martz <matt@sivel.net>

* Backport of get_url fix cannot use result

result was only added in 2.8+.
(cherry picked from commit 99171a9c6f)

Co-authored-by: Matt Martz <matt@sivel.net>

* Update get_url.py
2018-09-25 09:09:18 -07:00
Jordan Borean
1c8aeb0410 reordered windows test groups for better efficiency (#45445) (#45449)
(cherry picked from commit 25ae4f2b73)
2018-09-25 09:07:00 -07:00
Matt Martz
d1ef02c714 [stable-2.5] Don't pass file_name to DataLoader.load in script inventory plugin (#45428) (#45441)
* Don't pass file_name to DataLoader.load in script inventory plugin. Fixes #34164

* Add changelog fragment
(cherry picked from commit 263b9fa)

Co-authored-by: Matt Martz <matt@sivel.net>
2018-09-25 09:06:32 -07:00
Matt Martz
9046c3e63c [stable-2.5] Ensure loop with delegate_to can short circuit the same as without delegate_to. Fixes #45189 (#45231). (#45354)
(cherry picked from commit 2ac647def8)
2018-09-25 09:00:24 -07:00
Trishna Guha
52e4d2b36c [2.5] Fix python2.6 nothing to repeat nxos terminal plugin bug (#45283)
* fix python26 nxos terminal plugin bug (#45271)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit c98494d5bf)

* nxos terminal plugin changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Update nxos_terminal_plugin_2.5.yaml
2018-09-25 08:59:20 -07:00
Pilou
72889706d3 [stable-2.5] HashiVault: fix AttributeError when auth_method != 'token' (#36513) (#45243)
* Fixed `'HashiVault' object has no attribute 'verify'"}` (#36513)


(cherry picked from commit 0ceb717cae)

* Add changelog entry

* Update hashi_vault_fix_object_has_no_attribute_verify
2018-09-25 08:57:48 -07:00
Alicia Cozine
f87f239925
Restore license agreement (#45809) (#46019)
* adds page for CLA in community docs with link from community index

(partial cherry-pick from commit f430f60541)
2018-09-21 19:24:44 -05:00
Julien Girardin
c25d2f2562 Backport a change on doc for lvol module (#45914)
* Documentation change for resizefs (#43224)
Changed documentation to match the default value of resizefs set in the code.
Added a note on the resizefs use on the example utilizing it.
2018-09-21 15:53:31 -05:00
Matt Clay
062113731a Update RHEL and FreeBSD versions used for tests:
- RHEL 7.4 -> 7.5
- FreeBSD 11.1 -> 11.2

(cherry picked from commit c50d6f1944)
2018-09-12 10:19:07 -07:00
Matt Davis
7fc2fbb55c New release v2.5.9 2018-09-10 04:34:45 -07:00
Matt Clay
729736f30c Remove obsolete default container.
(cherry picked from commit 4173a30941)
2018-09-05 19:21:48 -07:00
Matt Clay
e7d75d4bff Switch default test container to quay.io.
(cherry picked from commit 3f8edb440a)
2018-09-05 19:21:48 -07:00
Matt Clay
8e048c0ab7 Fixes for ansible-test sanity import test. (#45249)
* Fix import test on Python 3.7.
* Fix path processing in import sanity test.

(cherry picked from commit 6fb333faff)
2018-09-05 19:21:48 -07:00
Matt Clay
0c3faa2e1c Fix ansible-test virtualenv use in import test.
(cherry picked from commit 998badbda5)
2018-09-05 19:21:48 -07:00
Matt Clay
9ac580f564 Update test constraints. (#44975)
- Limit virtualenv version on Python 2.6.
- Limit pyopenssl version on Python 2.6.
- Pin pyfmg version to keep unit tests passing.

(cherry picked from commit b3a3e8ba7b)
2018-09-05 19:21:48 -07:00
Matt Clay
c8eeafdc15 Flush output from timing script.
(cherry picked from commit 771768966f)
2018-09-05 19:21:48 -07:00
Matt Clay
fb153e4da7 Add seccomp support to ansible-test.
(cherry picked from commit c1173a2aec)
2018-09-05 19:21:48 -07:00
Alicia Cozine
339d064584
Correct to development_process (#39069) (#45264)
(cherry picked from commit c4e298b808)
2018-09-05 20:52:50 -05:00
Matt Clay
38b9fee32f Get packages for dnf and yum tests from S3.
(cherry picked from commit 22d5f5d97f)
2018-09-05 15:35:01 -07:00
Nilashish Chakraborty
7113e50a42 Fix ios_user issue CP in 2.5 (#45180)
* Fix ios_user issues (#44904)

* Fix ios_user issues

* Modify regex and fix unittests

(cherry picked from commit 0f268e70a1)

* Added changelog
2018-09-05 11:08:43 -07:00
Matt Martz
5ea238912f [stable-2.5] Don't allow import_tasks to transition to dynamic when file is missing. See #44822 (#44836) (#44854)
* [stable-2.5] Don't allow import_tasks to transition to dynamic when file is missing. See #44822 (#44836)
(cherry picked from commit cd2f66f)

Co-authored-by: Matt Martz <matt@sivel.net>

* Look in task_ds, as we don't have action var in 2.5
2018-09-05 11:08:09 -07:00
Toshio Kuratomi
d89bd2d3c1 [stable-2.5] Fix another corner case of too many warnings for world readable current working directory (#44610)
There should be no warning if there is no ansible.cfg file i nthe
current working directory.
(cherry picked from commit f46c943)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2018-09-05 11:07:31 -07:00
Sam Doran
2a2e4721a4 Pass path to GalaxyRole object (#43051) (#44583)
This will list all roles in all paths in roles_path rather than just the first path in roles_path.

(cherry picked from commit 05fff27415)
2018-09-05 11:06:39 -07:00
Guilherme Steinmuller
12d0684ee2 Fix enable_snat parameter (#44418) (#44451)
* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b7139782cf)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b7139782cf)

* Fix enable_snat parameter (#44418)

Fixes the issue #44285
(cherry picked from commit b7139782cf)
2018-09-05 11:06:06 -07:00
Tom Matthews
8854f77d67 Strip trailing comments from /etc/default/passwd (#43931) (#44367)
* strip additional comments from /etc/default/passwd

Strip trailling comments from /etc/default/passwd like
MINWEEKS=1 #MINWEEKS=2
MAXWEEKS=12  # MAXWEEKS=8
Which otherwise cause failures with "failed to read /etc/default/passwd: too many values to unpack"

* fix carriage return typo in commit

* yet another typo in commit

* Fix indent problem

* add changelog fragment for PR 43931

(cherry picked from commit 5c1e620504)
2018-09-05 11:05:26 -07:00
Sam Doran
3f80b6ccb1 Remove python-keyczar dependency (#38534) (#44321)
(cherry picked from commit 02bc4c570f)
2018-09-05 11:04:38 -07:00
Nilashish Chakraborty
847a7f9ca5 Fix ios_vlan and ios_l2_interface issues CP in 2.5 (#44253)
* Fixes ios_l2_interface and ios_vlan not working on certain interface types issue (#43819)

* Fixes #43654 and #43582

* Remove q statement

* Fix shippable errors

* Fix more shippable errors

* Fix unittest

(cherry picked from commit b14f256d41)

* Added changelog entries

* Fixed Shippable yamllint error
2018-09-05 11:04:07 -07:00
Trishna Guha
3e6cc1abd5 nxos bugfix Pick 2.5 (#44249)
* nxos_interface port-channel idempotence fix for mode (#44248)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 6af6e806ed)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add md5sum check in nxos_file_copy module (#43423)

* Add md5sum check in nxos_file_copy module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit fee4c24ad4)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* check_mode in nxos_static_route module (#44252)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 7e39c5bf07)

* changelog nxos_static_route

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos_linkagg mode fix (#44294)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 6090802551)

* changelog nxos_linkagg

* fix Python 2.6 regex bug terminal plugin nxos, iosxr (#45135)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ab3cd10dfe)

* terminal plugin changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-05 11:03:19 -07:00