wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
33537 commits 42 branches 295 tags 186 MiB
Commit graph

33537 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dag Wieers
0d5aa161e8 Improve convert_bool error message 
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
 2018-02-15 14:19:42 -08:00
Adam Miller
291c1eb57d make v2_playbook_on_notify method signatures consistent 
This was causing an exception in the TaskQueueManager when a third
party handler plugin was processed that inherited or explicitly
called the callback method from super because the method signature
was incorrect in callback/__init__ and it processed the arguments as
incorrect data types as a side effect.

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit dd9b2c0774)
 2018-02-15 16:06:29 -05:00
Adrian Likins
7e32010bdb Fix ansible-console always asking for vault passwords 
ansible-console was calling setup_vault_secrets
twice. Once directly and once via _play_prereqs()

The direct invocation was not setting auto_prompt=False.

However, the direct invocation isn't need at all so
this removes it so only _play_reqs() is used.
That fixes the unrequested vault password
prompting.

Fixes #33027

(cherry picked from commit 810fa7046b)
 2018-02-15 16:06:28 -05:00
tedder
7d6e3f3bba fix spelling. Seriously, that's it. 
(cherry picked from commit e8fc269cd3)
 2018-02-15 16:06:17 -05:00
Martin Krizek
acea14b392 add_host: check if name or hostname arg is provided 
(cherry picked from commit 39d9496282)
 2018-02-15 16:00:38 -05:00
Brian Coca
dfa3ecaf84 fixes to virtual facts 
fixes #36038

(cherry picked from commit 97b6e99479)
 2018-02-15 15:57:00 -05:00
Michael Nugent
0c4f6c3f68 False matches the docs and intentions of the previous developer (#35762) 
(cherry picked from commit d212ca11b3)
 2018-02-15 15:45:37 -05:00
Toshio Kuratomi
5c937b21f3 Add oom_killer fix for docker_container to the changelog 2018-02-15 09:07:29 -08:00
PikachuEXE
14e7432467 Backport fix in PR #30712 into 2.4 
https://github.com/ansible/ansible/pull/30712
 2018-02-15 09:06:15 -08:00
Jordan Borean
71b1a1e982
updated changelog for win_uri fix 2018-02-15 07:22:35 +11:00
Jordan Borean
f37cba14ac
win_uri: fix creates/remotes - manual cherry-picking for pull 36016 for stable-2.4 2018-02-15 07:21:49 +11:00
Matt Martz
cc7dfdeb52 Add changelog entry for reparenting fix (#36075) 2018-02-13 09:35:33 -06:00
Matt Martz
103e569f5e Prevent reparenting a block with itself (#36075) 
* Prevent reparenting a block with itself

* Move __eq__ to Block, to avoid some unexpected problems

(cherry picked from commit 76ff3e9efc)
 2018-02-13 09:33:57 -06:00
Trishna Guha
9fcff68ae1
Fix nxos_igmp_interface for diff nxos versions (#35959) (#36020) 
* Fix nxos_igmp_interface for diff nxos versions (#35959)

(cherry picked from commit 7a711cf942)

* update CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-12 10:42:07 +05:30
Matt Martz
c6a5a27531 Add changelog entry for memory ballooning fix 2018-02-09 11:40:24 -06:00
Matt Martz
a889576d39 Address memory ballooning caused by task caching changes (#35921) 
* Exclude parent when copying included task to avoid memory issues. Fixes #35796

* Simplify implicit block squashing to pre-group, instead of post re-parenting

(cherry picked from commit 7d1eb88ecf)
 2018-02-09 11:37:59 -06:00
Trishna Guha
7c4e343864
networking fix cherry-pick (#35936) 
* Add minor conditional checks to nxos_bgp sanity test (#35476)

* Add minor conditional checks to nxos_bgp sanity test

* Make ansibot happy

(cherry picked from commit 5a198e1e6a)

* fixing the removed_in_version to 2.6. (#35853)

(cherry picked from commit 73650cf854)

* fix eos_config second-level indent idempotece (#35588)

* fix eos_config second-level indent idempotece

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address ganeshrn's comment - update doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b30f3b9f4d)

* update CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-09 11:37:02 +05:30
Toshio Kuratomi
458968ed00 Add dest in copy return fix to changelog 2018-02-08 16:23:21 -08:00
Tomasz Kontusz
0ac4722b29 Fix for #31477: return 'dest' from copy when file wasn't changed 
(cherry picked from commit 89ad40b129)
 2018-02-08 16:22:39 -08:00
Trishna Guha
3c4d6a25ed
fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules (#35590) 
* fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-08 18:51:14 +05:30
Abhijeet Kasurde
9a64ee4d87
device operations are recursive if serialized (#35727) 
(cherry picked from commit 0bb3c4379c)
 2018-02-07 10:32:57 +05:30
Matt Clay
61fe2efa48 Temp install of setuptools for import coverage. (#35752) 
(cherry picked from commit f46f6c8dec)
 2018-02-06 14:04:43 -08:00
Sam Doran
ed5a73251b Fix lineinfile to insert line when pattern exists elsewhere in the file. (#33393) 
* Insert lines before or after when the regexp exists elsewhere in the file

* Correct filter syntax in lineinfile integration test

* Use multi-line YAML syntax on lineinfile tests

Unify indentation

* Add lineinfile tests for same line matched to different regexps

* Remove debug statement from test

(cherry picked from commit f8f2b6d61d)
 2018-02-05 17:34:40 -05:00
Toshio Kuratomi
2ae94fc0cd Add winrm ipaddress fix to changelog 2018-02-05 10:53:30 -08:00
Luca Berruti
8d968e5001 Fix: global name 'HAS_IPADDRESS' is not defined. 
(cherry picked from commit f0ea2b60e1)
 2018-02-05 06:41:46 -08:00
Matt Clay
feea6425f3 Fix pip integration test. 
(cherry picked from commit ea70b49b11)
 2018-01-31 23:27:31 -08:00
Matt Clay
4fd0cd853e Remove EOL openSUSE Leap 42.2 from CI. 
(cherry picked from commit abbc1ed4e6)
 2018-01-31 21:51:29 -08:00
Toshio Kuratomi
475cc33546 Revert "Add test for fix using loop_control with delegate_to (#33809)" 
This reverts commit adf8927c74.

This test uses features not found in ansible-2.4
 2018-01-31 19:54:11 -08:00
Martin Krizek
adf8927c74 Add test for fix using loop_control with delegate_to (#33809) 
(cherry picked from commit 5c7f203c33)
 2018-01-31 17:37:33 -08:00
Scott Butler
b2c3dd3507 Fixes broken link. 2018-01-31 17:31:52 -08:00
Trishna Guha
21255ae76d Fix networking bugs cherry-picked from devel (#35533) 
* fix *os_config module backward diff (#35332)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit cff4a2d26e)

* bug-35431 fixed removing encryption from user on subsequent runs of the task (#35433)

(cherry picked from commit 2293252e52)

* Fix nxos terminal plugin to support certain commands

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-31 17:31:52 -08:00
Matt Martz
11081cbeda Catch exception comparing role versions, and provide a user friendly error message. Fixes #32301 (#34427) 
(cherry picked from commit 42a0d71413)
 2018-01-31 17:31:52 -08:00
Matt Martz
32ddcf96df Recursively remove args with omit as as their value, to match suboptions in argument_spec (#35299) 
* Recursively remove args with omit as as their value, to match suboptions in argument_spec

* Add test for the new remove_omit function

(cherry picked from commit 7404dc6767)
 2018-01-31 17:31:52 -08:00
Dag Wieers
0ac3c990ed Backport of docsite changes to module list/options 2018-01-31 17:31:52 -08:00
Abhijeet Kasurde
c4d3a3d596 VMware: Fix SSL Context checking for Python <2.7.9 (#33683) 
Fixes: #33602

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 73abde399c)
 2018-01-31 17:31:52 -08:00
Matt Martz
2ded3e1fb1 failed, skipped, and unreachable all seem to be needed for various callbacks. Fixes #34716 (#34724) 
(cherry picked from commit d8329e530c)
 2018-01-31 17:31:51 -08:00
Jordan Borean
80baeb6a3b updated changelog for azure_rm_virtualmachine fix 2018-01-31 17:31:51 -08:00
Yuwei Zhou
09a244fc13 subnet should in the virtual network resource group (#35038) 
(cherry picked from commit bec4dcd66c)
 2018-01-31 17:31:51 -08:00
Jordan Borean
38089acae6 Updated changelog for azure_rm_subnet issue 2018-01-31 17:31:51 -08:00
Yuwei Zhou
6b26ca183d delete subnet should be idempotent (#35037) 
(cherry picked from commit 7c201fc9bc)
 2018-01-31 17:31:51 -08:00
Matt Martz
2924ad1bbf Don't skip an inventory source just because it has a comma (#35002) 
* Don't skip an inventory source just because it has a comma, make sure it's also doesn't exist as a path. Fixes #34931

* Add integration test for inventory path with commas

(cherry picked from commit 1ac04ba52e)
 2018-01-31 17:31:51 -08:00
Jordan Borean
71f6573bf5 updating changelog with win_dns_client dynamic fix 2018-01-31 17:31:51 -08:00
Ben
5bb1faee42 Fixes issue #34956 (#35149) 
(cherry picked from commit 9fdaa86c9f)
 2018-01-31 17:31:51 -08:00
Trishna Guha
128ee6f48f fix conflict nxos tests (#35078) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-31 17:31:51 -08:00
saichint
d16b5c23c9 fix vxlan idempotent issue (#34750) 
(cherry picked from commit c04cd8642d)
 2018-01-31 17:31:51 -08:00
Toshio Kuratomi
fe6f28f570 Add nxapi nxos_banner test to the changelog 2018-01-31 17:31:51 -08:00
Trishna Guha
31519edee6 Enable nxapi nxos_banner test (#35033) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8a6d699198)
 2018-01-31 17:31:51 -08:00
Toshio Kuratomi
e2986cba75 Add nxos_bgp fixes to changelog 2018-01-31 17:31:51 -08:00
saichint
49df1fbafd Fixes for nxos_bgp (#34590) 
* fix bgp issues

* add new tests cases

* review comments

(cherry picked from commit 6f8d3ad70d)
 2018-01-31 17:31:51 -08:00
Toshio Kuratomi
4449142896 Add nxos_vxlan_vtep_vni fixes to changelog 2018-01-31 17:31:51 -08:00