Commit graph

33557 commits

Author SHA1 Message Date
Matt Clay
29e7d5ecd9 Fix unclosed anchor in changelog. 2018-02-26 10:08:10 -08:00
Matt Martz
668a17cfba
Backport #36602 for stable-2.4 (#36607)
* Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules (#36602)

(cherry picked from commit a7062b7587)

* Modify test to work on 2.4 due to lacking templar kwarg
2018-02-22 17:52:47 -06:00
Deepak Agrawal
3b0686ffe8
vyos_config IndexError in sanitize_config (#36375) (#36566)
* Bug in del(list) logic. Say you have a list of 4 elements a[0-3]
and you have to remove index 1 and 3, if you remove index 1 first
then list is cut short a[0-2] and does not have index 3

Fix: Remove indexes in reverse sorted order e.g. 3 and 1 in above
example so that order of indexes remain preserved even after deleting

fix is to remove indexes in reverse sorted order

* Add test cases for failed case

(cherry picked from commit 0bbea9a579)
2018-02-22 20:20:49 +05:30
Toshio Kuratomi
52c85f6c66 New release v2.4.4-0.1.beta1 2018-02-21 20:29:49 -08:00
Toshio Kuratomi
fe7e44a5d7 Add python3 ansible_*_interpreter fix to the changelog 2018-02-21 18:09:22 -08:00
Matt Martz
a8582663b1 Fix types when evaluating interpreter (#36541)
* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d33ac)
2018-02-21 18:09:16 -08:00
Sam Doran
23289bd2f2 Check for regexp match when using insertbefore or insertafter (#36474)
Add tests to cover this scenario
Fixes #36156

(cherry picked from commit 723daf3e3a)

# Conflicts:
#	lib/ansible/modules/files/lineinfile.py
2018-02-21 17:06:27 -05:00
Sam Doran
0231cd9c93 Add note to use script module rather than inline here documents (#32863)
* Add example on how to use a here document with shell module

* Remove here doc example and add note to use script module instead

(cherry picked from commit 5e7ee9df0a)
2018-02-21 15:09:18 -05:00
Matt Martz
4e4cd7ee67
cherry-pick #36470 for 2.4 (#36526)
* Re-use logic from StrategyBase._load_included_file in StrategyModule.run for free and linear (#36470)

This improves include_role performance and recursion limits

(cherry picked from commit 10fefc7156)

* Add changelog for 36470
2018-02-21 11:30:21 -06:00
Abhijeet Kasurde
101578b63f
VMware: set extra configs for virtual machine (#36521)
This fixes implementation of extra config for virtual machine.

Fixes: #32004

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 80fb836ce5)
2018-02-21 21:44:44 +05:30
Jordan Borean
a3e02a2417
fetch: changed docs around behaviour for default fail_on_missing 2018-02-21 18:14:27 +10:00
Sam Doran
8b6184472b Update CHANGELOG 2018-02-20 20:01:22 -05:00
Sam Doran
6598c8e361
Always show prompt, even if seconds or minutes are specified (#36258)
Fixes #36057
2018-02-20 19:57:11 -05:00
Jordan Borean
55f903eafd
winrm: Fix kerberos auth encoding for Python 3 (#36465) 2018-02-21 08:43:02 +10:00
Toshio Kuratomi
f3a395b783 Add deb packaging fix for ubuntu12.04 to changelog 2018-02-19 13:41:04 -08:00
Grant Slater
858a1f802f Use pycrypto backend, rather than python-cryptography, on Ubuntu Precise
(cherry picked from commit e3192fb3a4)
2018-02-19 13:40:27 -08:00
David Newswanger
a98700917f added support for --testcase flag in ansible-test (#36134)
* added support for --testcase flag in ansible-test

* fixed command format

* added tab completion

* fixed sanity issues

* added documenation for --testcase

* don't autocomplete when multiple modules are selected

(cherry picked from commit 3f5caf659e)
2018-02-19 09:01:38 -08:00
Toshio Kuratomi
4a08e07da0 Add changelog entries for some more 2.4.4 fixes 2018-02-15 14:28:09 -08:00
Adam Miller
1ab84b1cfd fix new EC2 C5 instance virtualization_type identification (#35063)
* fix new EC2 C5 instance virtualization_type identification

Fixes #35051

Signed-off-by: Adam Miller <admiller@redhat.com>

(cherry picked from commit f95adcce8e)
2018-02-15 14:23:37 -08:00
John R Barker
37334ca3ee Clarify when and how to enable ANSIBLE_DEBUG (#35220)
(cherry picked from commit 181085821b)
2018-02-15 14:21:50 -08:00
Dag Wieers
0d5aa161e8 Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
2018-02-15 14:19:42 -08:00
Adam Miller
291c1eb57d make v2_playbook_on_notify method signatures consistent
This was causing an exception in the TaskQueueManager when a third
party handler plugin was processed that inherited or explicitly
called the callback method from super because the method signature
was incorrect in callback/__init__ and it processed the arguments as
incorrect data types as a side effect.

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit dd9b2c0774)
2018-02-15 16:06:29 -05:00
Adrian Likins
7e32010bdb Fix ansible-console always asking for vault passwords
ansible-console was calling setup_vault_secrets
twice. Once directly and once via _play_prereqs()

The direct invocation was not setting auto_prompt=False.

However, the direct invocation isn't need at all so
this removes it so only _play_reqs() is used.
That fixes the unrequested vault password
prompting.

Fixes #33027

(cherry picked from commit 810fa7046b)
2018-02-15 16:06:28 -05:00
tedder
7d6e3f3bba fix spelling. Seriously, that's it.
(cherry picked from commit e8fc269cd3)
2018-02-15 16:06:17 -05:00
Martin Krizek
acea14b392 add_host: check if name or hostname arg is provided
(cherry picked from commit 39d9496282)
2018-02-15 16:00:38 -05:00
Brian Coca
dfa3ecaf84 fixes to virtual facts
fixes #36038

(cherry picked from commit 97b6e99479)
2018-02-15 15:57:00 -05:00
Michael Nugent
0c4f6c3f68 False matches the docs and intentions of the previous developer (#35762)
(cherry picked from commit d212ca11b3)
2018-02-15 15:45:37 -05:00
Toshio Kuratomi
5c937b21f3 Add oom_killer fix for docker_container to the changelog 2018-02-15 09:07:29 -08:00
PikachuEXE
14e7432467 Backport fix in PR #30712 into 2.4
https://github.com/ansible/ansible/pull/30712
2018-02-15 09:06:15 -08:00
Jordan Borean
71b1a1e982
updated changelog for win_uri fix 2018-02-15 07:22:35 +11:00
Jordan Borean
f37cba14ac
win_uri: fix creates/remotes - manual cherry-picking for pull 36016 for stable-2.4 2018-02-15 07:21:49 +11:00
Matt Martz
cc7dfdeb52 Add changelog entry for reparenting fix (#36075) 2018-02-13 09:35:33 -06:00
Matt Martz
103e569f5e Prevent reparenting a block with itself (#36075)
* Prevent reparenting a block with itself

* Move __eq__ to Block, to avoid some unexpected problems

(cherry picked from commit 76ff3e9efc)
2018-02-13 09:33:57 -06:00
Trishna Guha
9fcff68ae1
Fix nxos_igmp_interface for diff nxos versions (#35959) (#36020)
* Fix nxos_igmp_interface for diff nxos versions (#35959)

(cherry picked from commit 7a711cf942)

* update CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-12 10:42:07 +05:30
Matt Martz
c6a5a27531 Add changelog entry for memory ballooning fix 2018-02-09 11:40:24 -06:00
Matt Martz
a889576d39 Address memory ballooning caused by task caching changes (#35921)
* Exclude parent when copying included task to avoid memory issues. Fixes #35796

* Simplify implicit block squashing to pre-group, instead of post re-parenting

(cherry picked from commit 7d1eb88ecf)
2018-02-09 11:37:59 -06:00
Trishna Guha
7c4e343864
networking fix cherry-pick (#35936)
* Add minor conditional checks to nxos_bgp sanity test (#35476)

* Add minor conditional checks to nxos_bgp sanity test

* Make ansibot happy

(cherry picked from commit 5a198e1e6a)

* fixing the removed_in_version to 2.6. (#35853)

(cherry picked from commit 73650cf854)

* fix eos_config second-level indent idempotece (#35588)

* fix eos_config second-level indent idempotece

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address ganeshrn's comment - update doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b30f3b9f4d)

* update CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-09 11:37:02 +05:30
Toshio Kuratomi
458968ed00 Add dest in copy return fix to changelog 2018-02-08 16:23:21 -08:00
Tomasz Kontusz
0ac4722b29 Fix for #31477: return 'dest' from copy when file wasn't changed
(cherry picked from commit 89ad40b129)
2018-02-08 16:22:39 -08:00
Trishna Guha
3c4d6a25ed
fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules (#35590)
* fix connection gets overridden by network_cli for transport nxapi,eapi net_* modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-08 18:51:14 +05:30
Abhijeet Kasurde
9a64ee4d87
device operations are recursive if serialized (#35727)
(cherry picked from commit 0bb3c4379c)
2018-02-07 10:32:57 +05:30
Matt Clay
61fe2efa48 Temp install of setuptools for import coverage. (#35752)
(cherry picked from commit f46f6c8dec)
2018-02-06 14:04:43 -08:00
Sam Doran
ed5a73251b Fix lineinfile to insert line when pattern exists elsewhere in the file. (#33393)
* Insert lines before or after when the regexp exists elsewhere in the file

* Correct filter syntax in lineinfile integration test

* Use multi-line YAML syntax on lineinfile tests

Unify indentation

* Add lineinfile tests for same line matched to different regexps

* Remove debug statement from test

(cherry picked from commit f8f2b6d61d)
2018-02-05 17:34:40 -05:00
Toshio Kuratomi
2ae94fc0cd Add winrm ipaddress fix to changelog 2018-02-05 10:53:30 -08:00
Luca Berruti
8d968e5001 Fix: global name 'HAS_IPADDRESS' is not defined.
(cherry picked from commit f0ea2b60e1)
2018-02-05 06:41:46 -08:00
Matt Clay
feea6425f3 Fix pip integration test.
(cherry picked from commit ea70b49b11)
2018-01-31 23:27:31 -08:00
Matt Clay
4fd0cd853e Remove EOL openSUSE Leap 42.2 from CI.
(cherry picked from commit abbc1ed4e6)
2018-01-31 21:51:29 -08:00
Toshio Kuratomi
475cc33546 Revert "Add test for fix using loop_control with delegate_to (#33809)"
This reverts commit adf8927c74.

This test uses features not found in ansible-2.4
2018-01-31 19:54:11 -08:00
Martin Krizek
adf8927c74 Add test for fix using loop_control with delegate_to (#33809)
(cherry picked from commit 5c7f203c33)
2018-01-31 17:37:33 -08:00
Scott Butler
b2c3dd3507 Fixes broken link. 2018-01-31 17:31:52 -08:00