Commit graph

48091 commits

Author SHA1 Message Date
Benjamin Leber
52c4c1b00d docker_login: Use with statement for accessing files (#64382) (#64392)
* docker_login: Use with statement for accessing files (#64382)

* Update changelogs/fragments/64382-docker_login-fix-invalid-json.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-06 09:40:30 +01:00
Andrey Klychkov
9a8d73456c mariadb_replication: fix CI tests (#64481) 2019-11-06 07:48:42 +01:00
David Gwynne
8c0ab43f05 Use more route information to improve default_ipvX facts on BSDs (#64172)
* Use "default" route info to help pick the default address.

Before this change, the address information used for the "default_ipv4"
and "default_ipv6" information is whatever is first on the interface
identified by the looking up the "default" route. On OpenBSD at
least, the first IPv6 address tends to be a link-local address,
which is not useful if you want to try and put a globally routable
v6 address in a template somewhere.

OpenBSD and NetBSD list the local address used for the default
route, so we can then use that to filter the addresses on the
interface and use the right one when it is available. This should
also help in situations where the interface has a lot of aliases,
or if you're doing IP multipath.

Thanks to John-Mark Gurney and Jared McNeill for providing me output
from the route command on FreeBSD and NetBSD respectively.

* Use "route get default" to get default route information.

Using some other arbitrary address makes these facts produce
unexpected results in some situations.
2019-11-05 19:36:04 -05:00
Matt Clay
adcf9458f1
Fix ansible-test collections sanity import test. (#64467)
* Fix ansible-test collections sanity import test.

Resolves https://github.com/ansible/ansible/issues/64466

* Fix get_source implementation also.

* Fix is_package function.
2019-11-05 16:06:57 -08:00
Ashley Hardin
78be0dcbc8 Update faq.rst (#63026) 2019-11-05 16:55:01 -05:00
Michael Shen
70d2750e0a Improve formatting of include_vars doc page (#63482) 2019-11-05 16:48:55 -05:00
Denis
b2939c71b7 Fix modules code quote documentations (#63594) 2019-11-05 16:44:21 -05:00
Caleb Collins-Parks
f178c49c02 Add warning about skipped vars (#63599) 2019-11-05 16:25:15 -05:00
aaronk1
0e4716d326 Clarify Python 2.x support in python_3_support.rst (#64077)
+label: docsite_pr
2019-11-05 16:08:07 -05:00
Major Hayden
fbbf21f771 Add note about spot instances for ec2_instance (#64069)
Signed-off-by: Major Hayden <major@redhat.com>
2019-11-05 16:06:27 -05:00
stevenamelinckx
e704406564 Update firewalld.py (#64153)
+label: docsite_pr
2019-11-05 15:43:23 -05:00
sblondon
2d92ad5736 Admin rights are required (documentation) (#64260) 2019-11-05 15:30:51 -05:00
Jill R
798d622a08 ec2_* Sanity corrections (#64409)
* ec2_* Sanity corrections

Cleanup some typos that were missed in #64230

* Update lib/ansible/modules/cloud/amazon/ec2_launch_template.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-05 20:58:11 +01:00
林博仁(Buo-ren Lin)
8e4ac212c8 Improve control node concept explanation (#64356)
Signed-off-by: 林博仁(Buo-ren, Lin) <Buo.Ren.Lin@gmail.com>

+label: docsite_pr
2019-11-05 14:57:16 -05:00
Pedro Gomes
de2b29a60f Unlimited CPU credits apply to any T instance (#64372)
+label: docsite_pr
2019-11-05 14:55:05 -05:00
Matthew Davis
4ee9f40e62 Add aws_acm module (#60552)
* convert aws_acm_facts to AnsibleAWSModule

* factor aws_acm_facts into module_utils

* add more filtering options for aws_acm_info

* add aws_acm module and tests

* uncomment aws_acm test

* fix linting for aws_acm

* fix __future__ linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix aws_acm_info arg type

* remove test for old module name aws_acm_facts

* simplify AWS ACM client creation

* fix indent typo in aws_acm test

* catch BotoCoreError in aws_acm

* fix indent typo in aws_acm test

* tighten AWS ACM test policy resource

* move aws acm int test to venv

* remove errant file

* fix AWS ACM int test perms

* undo copyright addition to wrong file

* fix invalid log message in aws_acm

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* rephrase aws_acm_info doc from facts to information

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* rename aws_facts var to aws_info

* remove case insensitivity for aws_acm pem compare

* add no_log for aws_acm credential setting

* add per-test prefix to aws_acm test resource names

* make aws_acm use crypto module_util

* clarify copyright for aws_acm

* make aws_acm int test clearer

* add explicit crypto dependency to aws_acm

* change requests for aws_acm pr

* fix wrong copyright owner aws_acm test

* fix wrong copyright owner aws_acm test

* rewrite aws_acm cert chain compare with regex, no dependency

* fix linting for aws_acm unit test

* fix linting for aws_acm unit test

* fix linting and duplicate ignore

* fix failed cert chain split in aws_acm, add more tests

* remove errant file

* more linting fixes for aws_acm

* fix sanity ignore

* rewrite cert compare in aws_acm to use base64 decode

* improve regex for pem cert chain split in aws_acm

* undo changes to crypto module util for aws_acm

* increment ansible version for new aws_acm module

* convert aws_acm return(x) to return x

* increment version added for aws_acm_info new features

* fix linting

* fix bugs with AWS ACM

* fix bad rebase

* disable AWS ACM integration test, due to AWS account limit issue

* remove aws acm integration test from shippable group
2019-11-05 11:57:08 -07:00
Mads Jensen
ecc8e51044 Remove empty overridden unittest.setUp and unittest.tearDown methods. 2019-11-05 09:12:11 -08:00
James Mighion
377c763334 Removing jmighion as maintainer of aruba and aireos modules. (#61469) 2019-11-05 11:20:03 -05:00
Felix Fontein
f4ff45dcd4 ansible-test: bumping ACME test container version (#64424)
* Bumping ACME test container version.

* Add changelog.
2019-11-05 10:51:22 -05:00
karthikeyan-dhandapani
37c7f2414a Adding team_aruba as maintainer for aruba modules (#64423) 2019-11-05 10:50:27 -05:00
Gonéri Le Bouder
519e4f4223 debian: install lib in dist-packages (#64412)
On Ubuntu Precise and Trusty, the build was failing because the Ansible
libs were installed in /usr/lib/python2.7/site-packages.

According to the Debian Policy (2.5), they should actually be install in
/usr/lib/python2.7/dist-packages This is also CDBS default behaviour since
0.4.131.

See: https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html

Closes: #64160
2019-11-05 10:45:05 -05:00
Jordan Borean
7acae62fa8 Fix up role version pagination for Galaxy install (#64373)
* Fix up role version pagination for Galaxy install

* Fix sanity issue
2019-11-05 10:34:50 -05:00
Med
a1ab093ddb synchronize - remove unused block (#64344) 2019-11-05 10:34:18 -05:00
Martin Nečas
d9f5be8d0d Ovirt host network dict correct (#64437)
* ovirt_host_network: correct comparing of two dicts

* update mode_number for 4th option
2019-11-05 08:22:17 -05:00
GomathiselviS
484943cbd1
Add unit testcases to eos_vlans (#63404)
* Added unit testcases to eos_vlans

* Corrected lint errors

* Corrected lint errors

* Corrected lint errors

* Addressed review comments and changed the testcase after bug fix

* Corrected lint errors

* removed the unwanted comments
2019-11-05 07:55:05 -05:00
GomathiselviS
4c8d0b1b8d
eos_l2interfaces: Add unit testcases to eos_l2interfaces (#64127)
* Add unit testcases to eos_l2interfaces

* Fixed lint errors

* Corrected lint errors
2019-11-05 07:51:13 -05:00
GomathiselviS
143b5a3674
Added Unit tests to eos_logging (#63248)
* Added Unit tests to eos_logging

* Added Unit testcases for eos_logging

* Added Unit testcases for eos_logging

* Added Unit testcases for eos_logging

* Add UT

* Corrected lint errors

* Corrected lint errors

* Addressed review comments

* Corrected lint errors
2019-11-05 07:50:00 -05:00
chkp-orso
3a0c6454a9 Enable logging to any domain in the check point machine (#63976)
* enable using any domain in the check point machine

* Update checkpoint.py

* trying to checge `test_chrckpoint` according to `test_ftd` in order to pass the tests

* Update test_checkpoint.py
2019-11-05 17:44:34 +05:30
Bill Dodd
48e132b9c3 Add GetHealthReport commands (#57494)
* add GetHealthReport commands

* add NetworkInterfaces and SimpleStorage

* convert report uri property keys from plural to singular

* one more plural to sungular uri conversion

* change module name to redfish_info in EXAMPLES docstring
2019-11-05 11:46:58 +00:00
Tomáš Karásek
8f853fef11 Added module for attaching volumes in the Packet host (#27843)
* Added module for attaching volumes in the Packet host

* Fix __future__ import sanity

* removed changed from RETURN doc

* Fix sanity tests, add check mode & few other minor changes
2019-11-05 11:36:59 +00:00
Tomáš Karásek
edf776189d Added module for handling volumes in the Packet Host (#27842)
* Added module for handling volumes in the Packet Host

* fixed CI bot issues

* Fix sanity tests, add check mode & few other minor changes
2019-11-05 11:36:23 +00:00
Tomáš Karásek
a3772e1ac3 New module: Add module for Packet API IP address assignment (cloud/packet/packet_ip_address) (#23133)
* Added module for IP address assignment in the Packet Host

* fixed CI bot issues

* rework of IP address handling to subnets

* fix pep8 in modules/cloud/packet/packet_ip_subnet

* Fix verison added

* Fix sanity tests, rebase, refactor & other improvements
2019-11-05 11:35:25 +00:00
Andrey Klychkov
04c999f0f8 postgresql_idx: add stat mode support (#64138)
* postgresql_idx: add stat mode support

* postgresql_idx: add stat mode support, add changelog

* postgresql_idx: add stat mode support, fix CI
2019-11-05 10:26:51 +00:00
Hiroki Kobayashi
e7cd5af1a6 Update intro_inventory.rst (#64345)
##### SUMMARY
A minor typo in `user_guide/intro_inventory.rst` is fixed.
Changed from "know" to "known"
2019-11-05 12:42:28 +05:30
Mark Chappell
9b0d487ce1 Add module_defaults group for ovirt (#64377)
* Add module_defaults group for ovirt

* Update docs to list ovirt module_defaults group
2019-11-05 12:30:41 +05:30
Kenyon Ralph
53f07bc283 intro_patterns.rst: fix typo (#64422)
Changed "your" to "you" in intro_patterns.rst
2019-11-05 11:56:41 +05:30
Christian Adams
b1f02be9eb clarify vault warning and fix typo (#64419) 2019-11-04 17:47:03 -06:00
Sandra McCann
797397558e Add note about large tarball sizes for collections (#64411)
* add note on collection tarball size
2019-11-04 14:26:59 -06:00
Felix Fontein
0bf9146b29 Document 'elements' for module option and return value documentation. (#64075) 2019-11-04 15:21:07 -05:00
The Magician
0515633189 Bug fixes for GCP modules (#64083) 2019-11-04 14:52:57 -05:00
The Magician
def62163c2 New Module: gcp_compute_reservation_info (#64134) 2019-11-04 14:52:36 -05:00
The Magician
1a726d436e New Module: gcp_compute_target_instance (#64135) 2019-11-04 14:52:28 -05:00
The Magician
14cf1c1197 New Module: gcp_logging_metric (#64339) 2019-11-04 14:51:52 -05:00
The Magician
9517d4c755 New Module: gcp_logging_metric_info (#64340) 2019-11-04 14:51:44 -05:00
The Magician
4569949bcd Bug fixes for GCP modules (#64407) 2019-11-04 14:50:42 -05:00
Mark Chappell
819ba2259d Sanity test fixups for AWS ec2 modules (#64230)
* ec2_ boilerplate

* Deprecate unused options.

* ec2_vol: Perform explicit type checking on volume_size and iops when parsing the args

Boto would through a type exception if the string couldn't be converted to an int.

* ec2_lc_find: remove duplicate definition of region

It's defined in ec2_argument_spec and ec2 doc fragment

* ec2_lc_info: Move responsibility for type checking/conversion of sort_start and sort_end into arg parser

* General sanity test related doc fixups

* Remove EC2 related sanity/ignore.txt entries

* Add changelog fragment
2019-11-04 18:39:31 +00:00
Mark Chappell
8528fbc790 Amazon related Sanity test fixups (remaining batch 2) (#64358)
* Remove sanity/ignore.txt entries

* replace use of "_" as a variable name

* Cleanup boilerplate

* Remove default values from mandatory parameters

* Sanity test documentation updates

* Remove unused imports from iam_role
2019-11-04 16:56:14 +00:00
Sandra McCann
9686808326 restore TOC links to old porting guides (#64395)
* restore TOC links to old porting guides

* remove stray orphans
2019-11-04 10:55:31 -06:00
Sloane Hertel
c1f1b2029c
Support vars plugins in collections (#61078)
* Move var plugins handling to a separate file

* Allow var plugins to require whitelisting

* Add global configuration ('demand', 'start') for users to control when they execute

* Add 'stage' configuration ('all', 'task', 'inventory') for users to control on a per-plugin basis when they execute

* Update ansible-inventory and InventoryManager to the global and stage configuration

* Update host_group_vars to use stage configuration and whitelisting

* Add documentation for using new options and to the developer's guide

* Add integration tests to exercise whitelisting and the new configuration options, using vars plugins in collections, and maintain backward compatibility

* Changelog

Co-Authored-By: Brian Coca <brian.coca+git@gmail.com>
Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-11-04 11:41:14 -05:00
Mads Jensen
39bf09517a wait_for - remove an obsolete fallback for Python 2.6 (#63988) 2019-11-04 11:39:19 -05:00