Commit graph

35917 commits

Author SHA1 Message Date
Michael Nugent
5ca8b7829a False matches the docs and intentions of the previous developer (#35762)
(cherry picked from commit d212ca11b3)
2018-02-15 15:41:22 -05:00
John R Barker
784932875f
Reduces the unit test time of select bigip modules (#36256) (#36260)
The modules in this patch include waits that need to happen to ensure
something is correctly configured on a BIG-IP. These waits were
raised as an issue in a recent ansible-testing meeting.

This patch eliminates the waits by mocking time.sleep
(cherry picked from commit 77fa41795e)
2018-02-15 20:28:45 +00:00
Nathaniel Case
3d81f94349
Update ios_ping.py to allow for count > 70. (#36142) (#36250)
* Update ios_ping.py to allow for count > 70.

Find 'Success...' output rather than relying on list index.  Index -1 won't pass unit test.

(cherry picked from commit fed20b825f)
2018-02-15 14:54:30 -05:00
Toshio Kuratomi
a7a03bbf4a Normalize usage of temp and tmp on tmp (#36221)
* Normalize usage of temp and tmp on tmp
* Rename system_tmps system_tmpdirs
* Add ANSIBLE_REMOTE_TMP spelling of environment variables

(cherry picked from commit 06f73ad578)
2018-02-15 09:01:33 -08:00
Monty Taylor
4848652c7a Add a module_utils OpenStack Cloud constructor (#20974)
Start using this to construct shade OpenStack Cloud objects in a
consistent manner. This will let us centralize things like dealing with
password arguments and whatnot. It also allows us to introduce the
ability to pass a fully formed config dict directly to the module.

Migrate all OpenStack modules to use openstack_cloud_from_module.

Have it return the shade library since it's responsible for
importing shade and shade is needed for the exceptions.

Only pull specific OpenStack arguments for the constructor

Rather than passing **module.params to the shade constructor, pull out
only the values that make sense. This should prevent the issues with
module parameters stepping on shade parameters.

Replace module.params.pop with module.params.get

We don't need to pop these anymore since the shade constructor is now
using opt-in values.

Using real urls is ungood. Use example.com domains. Also, get rid of the
antiquated port numbers.

(cherry picked from commit 0f893027c4)
2018-02-15 17:59:05 +01:00
Pilou
bca8b80069 vars.clean: remove unused method inject_facts (#34838)
* vars.clean: remove unused method inject_facts

Removing this unused method seems better than fixing the typo.

* Fix typo in comments

(cherry picked from commit b3ce136256)
2018-02-15 08:56:38 -08:00
Nathaniel Case
c1dcbb42c7
Alter ASA regexes to be byte-strings (#36176) (#36239)
(cherry picked from commit f67ff4a78e)
2018-02-15 10:57:11 -05:00
Ganesh Nalawade
38717551f8
Updating URL to Nuage Python VSPK documentation (#36213) (#36232)
Fixes ansible/ansible#35766
(cherry picked from commit cffa3caa60)
2018-02-15 18:36:03 +05:30
Trishna Guha
a6be3df24c
Fix nxos_linkagg tests (#36175) (#36222)
(cherry picked from commit 787114462e)
2018-02-15 11:07:18 +05:30
Toshio Kuratomi
d4aa089639 Fix line too long
(cherry picked from commit 717c7d26b7)
2018-02-14 19:04:56 -08:00
Toshio Kuratomi
2e91c2b640 Final fix for #35666 Previous PR (#36143) was merged prematurely.
(cherry picked from commit a612137098)
2018-02-14 18:47:57 -08:00
Toshio Kuratomi
71a34d005c * Fix for setting remote_tmp as a subdirectory of a system temp dir (#36143)
Fixes #35666

* Check that system_temps is all absolute paths

(cherry picked from commit 15fe59ef0c)
2018-02-14 20:34:52 -05:00
Brian Coca
74b120329c never tags docs and test (#35964)
* fufilling the promise

* moved changes

* Copy edit

(cherry picked from commit 0cf70a8970)
2018-02-14 20:34:11 -05:00
David Newswanger
078467d18d added support for --testcase flag in ansible-test (#36134)
* added support for --testcase flag in ansible-test

* fixed command format

* added tab completion

* fixed sanity issues

* added documenation for --testcase

* don't autocomplete when multiple modules are selected

(cherry picked from commit 3f5caf659e)
2018-02-14 15:41:43 -08:00
Chris Houseknecht
b6c9630094 Upgrade to openshift client 0.4.0 (#35127) (#36195) 2018-02-14 14:53:01 -08:00
Brian Coca
41c6415941 fixes to virtual facts
fixes #36038

(cherry picked from commit 97b6e99479)
2018-02-14 15:54:07 -05:00
Brian Coca
5f46773151 deal with no config for view
fixes #35965

(cherry picked from commit 3680d65d1d)
2018-02-14 15:53:07 -05:00
Brian Coca
15cbe1472d fix loop_control templating (#36124)
* fix loop_control templating

- properly template ALL properites for loop_control
- loop_control inherits from base, it should not, but needs validate/attribute functionality

fixes #24719

(cherry picked from commit 8de4f7cd9f)
2018-02-14 15:52:02 -05:00
Brian Coca
03c7751394 Inv export (#36188)
* add export option

* added 'export mode' to ansible-inventory

this optimizes the output for exporting inventory vs representing the 'ansible view'

fixes #30877

* added group priority when needed

(cherry picked from commit b403653bd2)
2018-02-14 15:47:18 -05:00
Jordan Borean
7dd4625dde
win_uri: fix creates/removes option (#36016)
(cherry picked from commit f8d1c97279)
2018-02-15 07:17:59 +11:00
Jordan Borean
25e02d17d2
win_domain_controller: optionally add -ReadOnlyReplica if true (#36017)
(cherry picked from commit 09d939fb00)
2018-02-15 07:17:48 +11:00
Jordan Borean
375bc11139
win_updates: fix regression when using string cat names (#36015)
(cherry picked from commit 8fb66c18de)
2018-02-15 07:16:42 +11:00
Chris Houseknecht
ac44b2062d Revert "Upgrade to openshift client 0.4.0 (#35127)" 2018-02-14 13:15:39 -05:00
Chris Houseknecht
4d79ab64d1 Upgrade to openshift client 0.4.0 (#35127) 2018-02-14 13:13:05 -05:00
John R Barker
67d14c963a
Add unit tests for edgeos_command (#35861) (#36184)
(cherry picked from commit 97573d8b0c)
2018-02-14 15:42:27 +00:00
John R Barker
8833823195
Ensure docs are valid before checking deprecation (#36160) (#36182)
(cherry picked from commit 3e22efa0ba)
2018-02-14 15:39:36 +00:00
John R Barker
52e47ce8fe
File Module docs, adding mode permission example with sticky bit (#36151) (#36164)
* File Module docs, adding mode permission example with sticky bit
(cherry picked from commit ef9dac548f)
2018-02-14 15:00:28 +00:00
Abhijeet Kasurde
b7f1163ab9 VMware: Additional check for RootSnapshot (#36001) (#36166)
This fix adds an additional check if there is no snapshot available
in VM. `rootSnapshotList` is None, if no snapshot is taken.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 52f79fa5a4)
2018-02-14 12:38:14 +00:00
Ganesh Nalawade
df751cd834
adding support for loopback interface (#36141) (#36154)
* adding support for loopback interface

currently the loopback interface lo is not supported with vyos_l3_interface, this commit fixes that.  Right now there is a limit of loopback interfaces to just lo, if you want more interfaces you need to use a dummy interface https://wiki.vyos.net/wiki/Dummy_interfaces

* fixing spacing as per pep8 test

fixing issues for sanity test

* ugh, missed on spacing issue

* getting rid of continuation lines, the CI system does not like it

(cherry picked from commit a52a7d2065)
2018-02-14 13:16:43 +05:30
scottb
5c94b5daf2 Fixes broken nested tables in module docs (#36144)
(cherry picked from commit dc902a5022)
2018-02-13 15:25:19 -08:00
David Newswanger
3e8b0487bb
[WIP] Add ios smoke tests (#35972) (#36133)
* added basic ios_smoke files

* added smoke tests for network.common.config

* added tests for network.common.utils

* added remainder of test cases

(cherry picked from commit 01bd9759e3)
2018-02-13 14:06:09 -05:00
Toshio Kuratomi
3b7ca2ac10 Add docs reorg to changelog 2018-02-13 11:02:05 -08:00
scottb
d03202e4d6 Followup to docs refactor pull request #36067 - fixes gitignore and c… (#36120)
* Followup to docs refactor pull request #36067 - fixes gitignore and cleanup in makefile; removes some generated files; moves a straggler to the appropriate subdirectory.

* Fixed some stragglers

* Removed redundant module entries

* Delete generated RST files.

(cherry picked from commit c10080bfba)
2018-02-13 11:00:43 -08:00
scottb
8998ec17b8 Core Docs Refactor and Redesign (#36067)
* Docs refactor as outlined in https://github.com/ansible/proposals/issues/79. Moves content into 'guides'; refactors TOC; fixes CSS; design tweaks to layout and CSS; fixes generated plugin, CLI and module docs to fix links accodingly; more.

* Adding extra blank line for shippable

(cherry picked from commit 373b1dcf59)
2018-02-13 11:00:31 -08:00
Nathaniel Case
75528e56bf
Acquire displayed messages from forked process (#36064) (#36119)
Also restore verbosity value from loaded `play_context`

(cherry picked from commit 527fc492b9)
2018-02-13 12:49:13 -05:00
Matt Martz
14dcf10882 Prevent reparenting a block with itself (#36075)
* Prevent reparenting a block with itself

* Move __eq__ to Block, to avoid some unexpected problems

(cherry picked from commit 76ff3e9efc)
2018-02-13 09:32:40 -06:00
Nathaniel Case
707fd61a78
Fix VyOS check mode (#35977) (#36114)
* Revert "commented out check tests (#35788)"

This reverts commit 3df2561405.

* `discard_changes()` now uses `exit discard`

instead of just `discard`. Also a slight tweak to avoid a second `exit` after
`exit discard`

(cherry picked from commit 6cdf91fd35)
2018-02-13 10:31:04 -05:00
John R Barker
c76caf3c29
Consistant headings (#36112) (#36113)
(cherry picked from commit 480a9c10c9)
2018-02-13 14:48:59 +00:00
John R Barker
82685806b2
provide detailed description of module (#36107) (#36111)
Fix vague description of module.

Resolves:
Related:
Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
(cherry picked from commit 6cfd198b13)
2018-02-13 14:14:26 +00:00
John R Barker
533f4157d1
Fix YAML issue (#36103) (#36105)
(cherry picked from commit e4c04aa0f3)
2018-02-13 12:48:48 +00:00
Trishna Guha
be92a5f876
fix nxos_interface_ospf issues (#35988) (#36090)
* fix nxos_interface_ospf issues

* review comment

(cherry picked from commit eab1b62cd2)
2018-02-13 10:11:12 +05:30
Matt Davis
96b682b157 cherry-pick disable of unstable azure tests 2018-02-12 10:31:10 -08:00
John R Barker
c232d6cb85
Fix more docs vs argspec (#36048) (#36052)
(cherry picked from commit 17c0d3eae0)
2018-02-12 18:05:39 +00:00
John R Barker
72ad157b07
Change wording of Going Further section (#35949) (#36032)
* Change wording of Going Further section

The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.

Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.

(cherry picked from commit d5ae63c0ea)
2018-02-12 10:54:06 +00:00
Ganesh Nalawade
1b9dde7c29
Fix vrf parsing in eos_vrf and eos_eapi module (#35791) (#36023)
* Fix vrf parsing in eos_vrf and eos_eapi module

Fixes #30250

Fix logic to parse vrf when interface value in `show vrf`
command output spans on multiple lines

* Add idempotent test case

(cherry picked from commit 6a223d5576)
2018-02-12 12:59:45 +05:30
Trishna Guha
d2e5706467
Fix nxos_igmp_interface for diff nxos versions (#35959) (#36019)
(cherry picked from commit 7a711cf942)
2018-02-12 10:41:58 +05:30
Matt Davis
50e79c5a14 initial cutover to API profiles (#35538)
* hardcoded API profiles in azure_rm_common
* changed azure_rm_securitygroup module to use api_profiles, dynamic models, kwargs on all SDK methods
* changed azure_rm_containerinstance module to use api_profiles, dynamic models, kwargs on all SDK methods
* fixed polling performance issue in azure_rm_securitygroup (default poll interval was 30s)
(cherry picked from commit 26f551d1c3)
2018-02-09 14:27:30 -08:00
Ryan Brown
a1d53b4e98 Tower callback fixes (#35927) (#35981)
* Fix tower_callback script return code

* Add ec2_key parameter to integration tests
2018-02-09 14:55:28 -05:00
John R Barker
67590e4e35
Test against a single transport (#35903) (#35970)
Network integration tests can use tags to run only a specific transport
(cherry picked from commit c3523cdd60)
2018-02-09 16:17:34 +00:00
John R Barker
8e7b25025d
Accept interfaces without address family or method (#34200) (#35963)
(cherry picked from commit 79b0739ba2)
2018-02-09 15:42:36 +00:00