Commit graph

40488 commits

Author SHA1 Message Date
Felix Fontein
7705c9044d Update openssl_privatekey.py (#55438) (#56066)
Docs: Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
(cherry picked from commit 2925f6960e)
2019-05-06 09:57:17 -05:00
Matt Clay
a44b62a2dd [stable-2.7] Install rabbitmq from s3 in tests..
(cherry picked from commit e105f5b436)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-30 12:47:05 -05:00
Sam Doran
5ab7ec153f Properly reset timezone in user test when it was originally n/a (#55389)
(cherry picked from commit b4e83642c8)
2019-04-24 18:11:00 -06:00
Sam Doran
b394d309f1 [stable-2.7] User - Fix shadow file parsing on AIX (#55230)
Implement a new method for shadow file parsing so it can be subclassed..
(cherry picked from commit f27eccabbd)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-04-24 18:11:00 -06:00
Rene Moser
17961e6335 tests: vultr: fix tests due to vultr API changes (#55621)
(partly cherry picked from commit e0ea5bb)
2019-04-24 18:09:56 -06:00
René Moser
8a8c9ed089 vultr_server: fix idempotency for private network and IPv6 options (#55619)
* vultr_server: fix idempotency for private network and IPv6 options

* add changelog

(partly cherry picked from commit 1705ef5f26)
2019-04-24 18:09:56 -06:00
Hannes Ljungberg
6f3b0e7177 [2.7] docker_swarm_service: Pass correct types on secrets/configs gid,uid,mode (#55617)
* Pass correct types on secrets/configs gid,uid,mode

* Add changelog fragment

* Fix idempotency
2019-04-23 22:05:17 -06:00
Nathaniel Case
f31374914f [stable-2.7] Move missing library abort to use rather than import (#55648)
* [stable-2.7] Move missing library abort to use rather than import for netconf (#55384).
(cherry picked from commit b442706b54)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>

* Add changelog

* missing_required_lib not in 2.7
2019-04-23 20:31:25 -06:00
Robert Osowiecki
9aa9c11a1a vsphere_guest: corrected fix #19716 misbehaviour (#55285)
* creating machines without vm_extra_config is possible
* power state operation on absent machines will fail

(cherry picked from commit 93758a5141)
2019-04-23 20:28:18 -06:00
Jordan Borean
d9c065d217 win_service - simply env test (#55498)
(cherry picked from commit 62badd76a5)
2019-04-23 20:27:37 -06:00
Felix Fontein
ed1640e9dc [2.7] docker_container: fix support for docker-py 1.7.0 (#55496)
* In theory, some 2.7 modules support docker-py 1.7.0.

* Add changelog.
2019-04-23 20:27:16 -06:00
Jordan Borean
e51edbfa1e win_region - fix format issues when using psrp (#55487)
(cherry picked from commit f247c21d23)
2019-04-23 20:26:29 -06:00
Sandra McCann
22194345d0 Update Ansible docsite CSS to fix multi-page printing issue (#51472) (#55666)
* Update css to fix multi-page printing issue
* Add margin edit

(cherry picked from commit 51ac4d3441)
2019-04-23 14:03:46 -05:00
Jordan Borean
e093b8a07e SCP filename validation docs (#55399)
* SCP filename validation docs

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: jborean93 <jborean93@gmail.com>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: jborean93 <jborean93@gmail.com>

* Update docs/docsite/rst/reference_appendices/faq.rst

Co-Authored-By: jborean93 <jborean93@gmail.com>

* edits to scp FAQ entry

* zeut alors I have missed one

* incorporate jborean feedback

* adds link to bug report

(cherry picked from commit 8542f16fa9)
2019-04-23 12:35:44 -06:00
Martin Krizek
44b3f967bf ansible-test yamllint: fix UnicodeDecodeError (#55364)
* ansible-test yamllint: fix UnicodeDecodeError

* Conditional fix

(cherry picked from commit f8bebc61c8)
2019-04-22 10:04:28 -07:00
Jordan Borean
ab725bb86e psrp - Fix raw and script tests for connection plugin (#55357)
* psrp - Fix raw and script tests for connection plugin

* Fix error propagation with raw in psrp

* uncomment test

(cherry picked from commit fdf9df89f5)
2019-04-17 06:56:49 -07:00
Christopher Snyder
ad953171eb redhat_subscription: Fix usage of ConfigParser (#54815)
(cherry picked from commit 09f68fc659)
2019-04-16 16:56:18 -07:00
Jordan Borean
8d259f6e64 psrp - fix test_command rc for win_reboot (#55354)
(cherry picked from commit 49655a452d)
2019-04-16 16:55:54 -07:00
Jordan Borean
08c2fb8626 psrp - Fix fetch for large files (#55351)
* psrp - Fix fetch for large files

* Fix typo

(cherry picked from commit 52946c49a4)
2019-04-16 16:35:18 -07:00
Jordan Borean
01eb82cb40 win_feature - get tests working on psrp (#55353)
(cherry picked from commit 15c331cb48)
2019-04-16 16:21:01 -07:00
Jordan Borean
b0f6ca287b win_whoami - Fix tests to work over psrp (#55352)
(cherry picked from commit 33c2a9cea7)
2019-04-16 16:20:47 -07:00
Dag Wieers
653e9da228 ACI: Ensure we use native strings for signature (#55161)
* ACI: Ensure we use native strings for signature

* Add changelog fragment
2019-04-16 15:35:36 -07:00
Trishna Guha
ca49ae7ba5 nxos_interface DI delay only when operation state check is requested (#55355)
* nxos_interface:DI: delay only when operation state check is requested (#54862)

* nxos_interface:DI: should only use delay when operation state check is requested

There is a 10 second delay that is added for every interface that is changed.
This delay should only occur when a task sets one of the `want` vars.

* /return/continue/

(cherry picked from commit 0fe6bf911a)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-04-16 15:02:07 -07:00
Kevin Breit
1435b6771a meraki_vlan - Remove unnecessary API calls when net_id is specified (#54939)
* Remove unnecessary API calls when net_id is specified

* Remove temp_get_nets commented out code

(cherry picked from commit fb3cc7f687)
2019-04-16 15:01:19 -07:00
Mario Lenz
3604fe8517 backport #55193 to 2.7 2019-04-16 15:00:22 -07:00
Felix Fontein
f27481a6e8 docker_container: improve log_options idempotency by converting to string (#54955)
* Warn when log_options values are not strings.

* Add changelog.

* Improve message.

* Improve formatting and formulation of other messages.

* Add test for warning.

* Trying double escaping.

(cherry picked from commit d64b17731d)
2019-04-16 14:59:19 -07:00
Matt Clay
1a499c6a6a [stable-2.7] Fix ansible-test unicode error with redact option.
(cherry picked from commit 2ef4ba3b4d)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-15 17:12:00 -07:00
Brian Coca
bcf0770a04 remove become_plugins ref from backported fix 2019-04-15 14:01:28 -07:00
Jordan Borean
fb96c007b5 win_domain - fix for checking for domain on new host (#55195)
(cherry picked from commit 6039ff9a24)
2019-04-12 12:28:27 -07:00
Brian Coca
5d58a7cadb Correct plugin loader context for persistent (#54860)
* Correct plugin loader context for persistent

(cherry picked from commit 6579dfda17)
2019-04-12 12:28:03 -07:00
Tobias Rüetschi
a79c57b1e1 Backport/2.7/55083 (#55141)
* The Univention modules have a issue with an unassigned variable.

The variable diff is only assigned if state is 'present', else the
variable is unused. But the module will return the diff variable as a
return value. If the state isn't 'present' the module will fail with an
python UnboundLocalError exception.

(cherry picked from commit 26fa97922abb9bc197af5745e83c235c2d652116)

* Add a changelog fragment for PR 55083.

(cherry picked from commit b4ae654890a606bf5321c6b1a612d77de9ef47dd)
2019-04-12 12:20:36 -07:00
Jordan Borean
6814d1cb57 Increase async timeout for psrp connection test (#55068)
(cherry picked from commit 58e076b64c)
2019-04-12 12:18:38 -07:00
Sandra McCann
c44c38cdc2 Clarify platform EOS and NXOS table settings (#55096) (#55174)
(cherry picked from commit 7a1e2ef746)
2019-04-11 18:29:56 -05:00
Matt Clay
b65aaa8f9a [stable-2.7] Compat fix for ansible-core-ci on Python 3.7.
(cherry picked from commit 5b133f3455)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-10 10:47:42 -07:00
Felix Fontein
c58f0a7b8d doc: preseve block-quote structure (#53293) (#55072)
Without the `::`, the indentation of the example block is lost.

(cherry picked from commit 0b579a0837)
2019-04-10 11:52:31 -05:00
Kevin Breit
c5666e5185 meraki_admin - Added recently added return fields for query (#51876) (#55048)
* Added recently added return fields for query
* Defined type of string for older fields too
* Fix incorrect type for org_id

(cherry picked from commit 9f7584e311)
2019-04-10 11:51:55 -05:00
Paul Puschmann
4b28413446 Backport/2.7/50183 (#55035)
* gcp: documentation update (#50183)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit ae404d1476)

* Add changelog-document for gcp_inventory improvement
2019-04-10 11:50:06 -05:00
Matt Clay
f030191782 [stable-2.7] Fix apache shutdown in subversion test.
(cherry picked from commit 58f4947ffe)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-08 11:19:33 -07:00
Robert Osowiecki
910d21e15c Allow all of yum version compare operators (#54603)
* Allow all of yum version compare operators

* * yum: name="foo >= VERSION" integration test
* changelog fragment

(cherry picked from commit 1532e31ec0)
2019-04-08 10:28:24 -07:00
Adam Miller
d262f35789 fix dnf module removal in dnf upstream 4.2.2+ (#54923)
* fix dnf module removal in dnf upstream 4.2.2+

Signed-off-by: Adam Miller <admiller@redhat.com>

* Remove extra blank line in changelog fragment.
2019-04-08 10:19:02 -07:00
Felix Fontein
712e79eb5e ufw: fix default, direction is not necessary for it (#54799)
* Correct behavior so that direction isn't required for default.
* Add more tests.
* 'disabled' values cannot be changed.
* Include 'not specified' in messages.

(cherry picked from commit 7d27348356)
2019-04-08 10:18:14 -07:00
Matt Clay
99815d5b54
Limit supervisor in tests to < 4.0.0. (#54937)
Tests fail when using version 4.0.0.

(cherry picked from commit 4b3662605d)
2019-04-05 18:32:45 -07:00
Kevin Breit
737cd948d6 Meraki performance fixes for net and org lookups (#51395)
* Performance fixes for net and org lookups
- Both methods had duplicate lookups
- This should significantly improve performance
- Currently untested

* Add ChangeLog file

* Change from bugfix to bugfixes and change indent

(cherry picked from commit c254b93796)
2019-04-04 12:06:38 -07:00
Daniel Hagan
e852164d48 correct openssl rsa to genrsa in acme doc fragment (#54744)
* correct openssl rsa to genrsa in acme doc fragment

* acme_certificate.py - updated route53 example to include wait: yes

(cherry picked from commit c11af3dbef)
2019-04-04 12:04:38 -07:00
Felix Fontein
eeb6ec1097 acme_certficate: allow to write files to CWD (#54754)
* Allow to write files to CWD.

* Add changelog.

(cherry picked from commit e422f18898)
2019-04-04 12:03:55 -07:00
Martin Krizek
a8a318e588 Fix copy module to reset filesystem acls (#51868)
The controller's fixup_perms2 uses filesystem acls to make the temporary
file for copy readable by an unprivileged become user. On Python3, the
acls are then copied to the destination filename so we have to remove
them from there.

We can't remove them prior to the copy because we may not have
permission to read the file if the acls are not present. We can't
remove them in atomic_move() because the move function shouldn't know
anything about controller features. We may want to generalize this into
a helper function, though.

Fixes #44412

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
(cherry picked from commit d15812fabf)
2019-04-04 12:03:03 -07:00
Trishna Guha
7871e63783 Add type of group in nxos_linkagg module doc (#54769)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 6155701e36)
2019-04-04 11:59:35 -07:00
Trishna Guha
b79d1002f8 changelog
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-04-04 11:59:35 -07:00
Chris Van Heuveln
5d9bac9cfb nxos_igmp_snooping: group-timeout fails when igmp snooping disabled (#53079)
* nxos_igmp_snooping: group-timeout fails when igmp snooping disabled

group-timeout config will be rejected by the device if `ip igmp snooping` is disabled.

  * raise a failure for this condition

  * reorder the command list so that group-timeout is always last

* SA fixes

* SA fixes

* only call gt_dependency if gt

(cherry picked from commit 8c33ba3ecd)
2019-04-04 11:59:35 -07:00
Chris Van Heuveln
903e6cd2d6 httpapi/nxos_facts: raise ConnectionError is missing code (#53406)
* `nxos_facts` crashes with certain nxos images; e.g. `7.0(3)I7(3)` as a result of this call:
  ```
        data = self.run('show lldp neighbors', output='json')
  ```
  ...which returns `ERROR: No neighbour information` when the device has no neighbors.

* This response causes httpapi's `handle_reponse()` to raise a ConnectionError, which is caught by `utils/jsonrpc.py` which is expecting `code` in the exception data:

  ```
             except ConnectionError as exc:
                 display.vvv(traceback.format_exc())
                 error = self.error(code=exc.code, message=to_text(exc))
  ```

* Found by: `nxos_facts/tests/common/not_hardware.yaml:7`

(cherry picked from commit 874fd70d10)
2019-04-04 11:59:35 -07:00