Commit graph

46495 commits

Author SHA1 Message Date
Klaus Frank
811153afb1 Add exception handling to win_domain_controller (#58234)
* Add exception handling to win_domain_controller

* Add changelog

* Fix PSUseDeclaredVarsMoreThanAssignments

* Remove dns domain cannot be resolved error message

As requested by PR review in https://github.com/ansible/ansible/pull/58234#discussion_r300509880
2019-08-18 16:14:51 -04:00
Klaus Frank
cc5957001c win_domain reboot required exception incorrectly reported (#60496)
* Set reboot required dependent on exception message.

* Use exception id instead of it's message
2019-08-19 06:05:33 +10:00
Felix Fontein
0d88ec241f
openssl_certificate: fix idempotency (#60745)
* Fix openssl_certificate idempotency.

* Add changelog.

* Add integration test.
2019-08-18 20:48:34 +02:00
Felix Fontein
16056f4978
openssl_certificate: check for existence before loading CSR / private keys / ... (#60740)
* Check file existence before loading files.

* Remove superfluous import.

* Add changelog.
2019-08-18 11:41:50 +02:00
Hannes Ljungberg
13364fc530 docker_swarm_service: Allow passing dicts in networks (#58961)
* Add support for passing networks as dicts

* Add function to compare a list of different objects

* Handle comparing falsy values to missing values

* Pass docker versions to Service

* Move can_update_networks to Service class

* Pass Networks in TaskTemplate when supported

* Remove weird __str__

* Add networks integration tests

* Add unit tests

* Add example

* Add changelog fragment

* Make sure that network options are clean

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Set networks elements as raw in arg spec

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix wrong variable naming

* Check for network options that are not valid

* Only check for None options

* Validate that aliases is a list
2019-08-18 08:55:54 +02:00
Felix Fontein
aaaa4f1809
This line apparently got lost. (#60739) 2019-08-18 06:00:21 +02:00
Felix Fontein
26b9c81a8e
crypto modules: fix sanity errors (#60046)
* Remove sanity warnings.

* Linting.

* More linting.

* Forgot one place.

* no_bytes -> num_bytes
2019-08-18 05:37:57 +02:00
Felix Fontein
ceff0029cb
openssl_certificate: deprecate assertonly provider (#60623)
* Add deprecation marks.

* Add conversion example.

* Split long line.

* Add changelog and porting guide entry.

* Fix unrelated porting guide entry.

* Fix format.

* Fix doc mistakes found in review.

* Fix filter name.

* Compare CSR and cert subject via subject_ordered.
2019-08-18 05:09:49 +02:00
Chris Trufan
86366530e8 Entrust Datacard - Support for "entrust" provider in openssl_certificate module (#59272)
* Addition of entrust provider to openssl_certificate module

* Fix native return values of error messages and JSON response.

* Documentation and syntax fixes per ansibot.

* Refactored structure of for loop due to ansible test failures in python 2.6

* Remove OCSP functionality for inclusion in possible seperate future pull request.

* Remove reissue support.

* Indicate the entrust parameters are specific to entrust.

* Comment fixes to make it clear module_utils request is used.

* Fixes to not_after documentation

* Response to pull request comments and cleanup of error handling for bad connections to properly use the 'six' HttpError for compatibility with both Python 2/3 underlying url libraries.

* pep8/pycodestyle fixes.

* Added code fragment and response to comments.

* Update license to simplified BSD

* Fixed botmeta typo

* Include license text in api.yml

* Remove unsupported certificate types, and always submit an explicit organization to match organization in CSR

* Fix documentation misquote, add expired to a comment, and fix path check timing.

* Update changelogs/fragments/59272-support-for-entrust-provider-in-openssl_certificate_module.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-17 21:32:02 +02:00
Sumit Jaiswal
ab07c206aa
Resource module for ios_l2_interfaces (#60344)
* ios_l2_interface checkin

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-17 23:02:36 +05:30
Paul Belanger
c11d144302 Remove unused imports / variables for junos (#60705)
* Remove unused imports / variables for junos

This is to help with the migration to collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* Remove duplicate execute_module() function for junos lacp_interfaces

This seems to have passed lint checks, but something we caught in
collection migration.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-17 22:38:53 +05:30
Felix Fontein
6a786d0d93
openssl_publickey: add cryptography backend (#60387)
* Add cryptography backend.

* Add changelog.

* Make sure requirements are satisfied.

* Use more compatible elliptic curve.

* Decrease required version numbers.

* PyOpenSSL >= 16.0.0 is really needed.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>
2019-08-17 18:52:14 +02:00
Paul Belanger
13996aaff6
Fix missing variable with nxos_install_os tests (#60351)
Today we are getting an Ansible templating exception because this
variable isn't defined. But we also don't want testing to run, as we
don't have ability to run this test in DCI.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-17 10:04:50 -04:00
Felix Fontein
601a4b8f47
get_certificate: add cryptography backend (#60599)
* Add cryptography backend for get_certificate.

* Add changelog.

* Use short names (if possible).

* Adjust version (to behave as pyOpenSSL).

* Work around bugs (needed for cryptography 1.2.3).

* Don't run cryptography backend tests for CentOS 6.

* Bump cryptography requirement to 1.6 or newer.

Otherwise, signature_algorithm_oid isn't there, either.

* Simplify requirement text.

* CentOS 6 has cryptography 1.9, so we still need to block.

* Add auto-detect test.

* Improve YAML.
2019-08-17 16:02:14 +02:00
Felix Fontein
38435e1bd0
openssl_certificate: various assertonly bugfixes (#60658)
* Fix get_relative_time_option for byte string input. Also fix it for None input.

* Using correct property for invalid_at check.

* Fix invalid_at comparison.

* Converting relative timestamps before comparison for valid_at and invalid_at.

* Fixing key usage display for cryptography backend.

* Fix key usage comparison. OBJ_txt2nid always returns 0 for key usage identifiers.

* Add changelog.

* Fix pyOpenSSL key usage comparison.
2019-08-17 15:58:25 +02:00
Felix Fontein
cf69b73c04
openssl_certificate/csr_info: add ordered issuer/subject return value (#60708)
* Add ordered issuer/subject return value.

* Add changelog.
2019-08-17 15:49:54 +02:00
Lukas Kämmerling
100b56439e hcloud_server: Allow users to enable/disable the rescue mode (#60070) 2019-08-17 11:29:58 +02:00
Fabrizio Dall'ara
85f7a7e848 Adding Port Security Timeout option in Interface Policy Port Security (#57108)
* Adding support for port security timeout attribute for ACI Interface Policy Port Security

- Feature Pull Request

Network Module ACI

lib:  _aci_intf_policy_port_security.py

* Fixing missing quotes

* Fixing errors raised by ansible-test sanity test

pylint error E321 missing whitespace after comma

Added version 2.9 as version_added

* Fixing the missing version_added under new port_security_timeout option
2019-08-16 22:17:51 -04:00
Derrick Johnson
175f80c788 aci_epg_to_domain - Add switching_mode support (#58429)
* aci_epg_to_domain - Add switching_mode support

##### SUMMARY
When deploying an AVE with VXLAN, the switching mode cannot be native and must be AVE.

##### ISSUE TYPE
- Feature Pull Request

+label: docsite_pr

* Update aci_epg_to_domain.py

* Update aci_epg_to_domain.py
2019-08-17 03:15:32 +02:00
sig9org
82a00afffb Add aci_extepg.py and aci_extsubnet.py (#58079)
* Add aci_extepg.py and aci_extsubnet.py

* Check pep8 style.

* Remove aci_extsubnet.py.

* Rename to aci_l3out_extepg

* Change file name. (aci_extepg.py -> aci_l3out_extepg.py)
2019-08-17 03:15:18 +02:00
Derrick Johnson
bb7da4239b Fix INTERSITE BUM TRAFFIC ALLOW (#58608)
##### SUMMARY
The payload was using the incorrect keyword to push the True or False statement to the device and was getting dropped. This would also result in erroring out if layer2_unknown_unicase was set to Flood instread of Proxy.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-08-16 21:10:08 -04:00
Nirav Katarmal
b34002bb55 Added preferred group attribute to epg (#59779) 2019-08-17 03:04:52 +02:00
The Magician
11862782ff Bug fixes for GCP modules (#60666) 2019-08-16 17:41:54 -04:00
Matt Clay
ebe55e83c3 Fix ansible-test bin creation.
Use symlink instead of link.
2019-08-16 14:00:43 -07:00
Jon Pugh
6a5cbcf8b8 Link to the GitHub Web UI for the example file. (#60611)
Change link in the Ansible Config docs to the example `ansible.cfg` file, from the raw download to the web user interface.
2019-08-16 15:09:43 -05:00
Matt Davis
68f1e42d95 Minimize collection loader ansible imports
* pass in optional config instead of importing, so other things (eg ansible-test, units) don't have to take a config dependency
2019-08-16 12:36:43 -07:00
Matt Martz
def3d1f815
validate-modules: support collections (#60247)
* Start of work to support collections

* remove version_added from base schema

* If a collection, pass that to validate-modules

* clean ups

* Allow version_added in a collection, just make it optional

* Don't traceback on missing doc_fragment

* Don't validate metadata in a collection
2019-08-16 14:28:34 -05:00
Paul Belanger
7f280434de
Remove unused import from eos facts (#60694)
Code clean up to help with collections migration

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-16 15:25:10 -04:00
The Magician
da57c3b334 Bug fixes for GCP modules (#60664) 2019-08-16 15:24:24 -04:00
The Magician
7cee7a6d90 Bug fixes for GCP modules (#60665) 2019-08-16 15:24:15 -04:00
The Magician
8d33e9ae4d Bug fixes for GCP modules (#60667) 2019-08-16 15:23:48 -04:00
The Magician
818d1b2e45 New Module: gcp_cloudfunctions_cloud_function (#60668) 2019-08-16 15:23:39 -04:00
Jiri Tyr
134379b273 Updating documentation for the setup module (#60696) 2019-08-16 13:42:54 -05:00
The Magician
e7a8e48053 New Module: gcp_cloudfunctions_cloud_function_info (#60669) 2019-08-16 14:32:35 -04:00
Dusan Matejka
df9b4faa9f Documented disadvantages of using default zabbix password for all zab… (#60639)
* Update lib/ansible/plugins/doc_fragments/zabbix.py
2019-08-16 10:58:06 -05:00
Mauricio Accetturi Carvalho
477b34c440 Add network and vpc to args (#60657)
* Add network and vpc to args

network and vpc are needed when create a loadbalancer in a vpc in a recent adquired public ip

* version_added in new args
2019-08-16 11:51:20 -04:00
Miguel Angel Muñoz González
7e22c7482e Fortinet's new module for fortios_switch_controller_system (#60691) 2019-08-16 20:40:37 +05:30
Miguel Angel Muñoz González
b4f210945e Fortinet's new module for fortios_system_ha (#60689)
* Fortinet's new module for fortios_system_ha

* Retriggering Ansible checks due to strange failure
2019-08-16 20:40:27 +05:30
Miguel Angel Muñoz González
ca28ae3be5 FortiOS modules for 2.9 - 2 (#60598)
* FortiOS modules for 2.9 - 2

* Fix long lines and ignore.txt
2019-08-16 20:34:37 +05:30
Jeff Geerling
9c61ef10d1 Fix typo and uses more common role syntax in usage examples (#60165)
* Fix typo and use import_role in examples
2019-08-16 09:34:45 -05:00
Jiri Tyr
da18e3b76c Updating intro_inventory.rst (#60676) 2019-08-16 09:23:58 -05:00
Sumit Jaiswal
585bfead75
fix ios_interfaces (#60687) 2019-08-16 19:25:28 +05:30
Mitsuru Nakakawaji
064cd63f3d fix: docker_swarm_service does not publish both tcp and udp ports (#60616)
* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value
2019-08-16 15:23:45 +02:00
Felix Fontein
48541910bf
docker_container: add mount endpoint collision detection (#60384)
* Add mount endpoint collision detection.

* Add changelog.

* Fix error.
2019-08-16 15:23:03 +02:00
Alex Stephen
523e40e993 nonetype error (#60603) 2019-08-16 06:04:32 -04:00
Dane DeValcourt
c5c270d9f7 Typo fix in nxos_file_copy.py (#60659)
Corrected typo in example documentation "local_filr_directory" to "local_file_directory"
2019-08-16 10:40:30 +05:30
zingyb
06d1705752 Fix mispelling in postgresql_query docs (#60648)
Changed `arbitraty` to `arbitrary` in postgresql_query docs
2019-08-16 10:38:47 +05:30
Gonéri Le Bouder
c60676a118 VMware: add a changelog entry for PR #60476 (#60490)
Add a changelog entry for https://github.com/ansible/ansible/pull/60476.
2019-08-16 09:10:42 +05:30
Patrick Marques
39d249155a Deprecates Digital Ocean sshkey_facts in favor of new module sshkey_info (#60546)
* Renames Digital Ocean sshkey_facts modules to sshkey_info

* Change digital_ocean_sshkey_facts status to deprected

* Update digital_ocean_sshkey _facts _info doc

* Allow digital_ocean_sshkey_info in Check Mode

* Update lib/ansible/modules/cloud/digital_ocean/_digital_ocean_sshkey_facts.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix _info added version
2019-08-15 23:45:05 +02:00
Simon Dodsley
491a47c7c5 Pure modules: rename _facts with ansible_facts result to _info (#60641) 2019-08-15 22:42:35 +02:00