Commit graph

7844 commits

Author SHA1 Message Date
Craig Tracey
8c6b3baf6f Make default ANSIBLE_REMOTE_PORT None
The ansible remote port should be None, not 22. Having a default value
of 22 means that '-o Port 22' will be appended to the ssh connection
all of the time. This is incorrect as when one would like to use
something like an ssh configuration file (-F) that sets the port to
something other than 22.

Part of this change requires that we check that, in get_config, the
value is not None before trying to cast it into an integer or float.
2014-01-23 12:49:07 -05:00
James Cammarata
9101c2af98 Fix traceback in template error detection code
Fixes #5081
2013-11-29 08:47:54 -06:00
Michael DeHaan
44ca015d87 Merge pull request #5088 from EspadaV8/5057_assemble_fix
Correct the invocation of ‘_assemble_from_fragments’
2013-11-27 18:38:21 -08:00
Michael DeHaan
c3245e45c2 Update the .gitignore based on the docsite restructuring. 2013-11-27 21:35:43 -05:00
Michael DeHaan
40429ee64e Code to limit display of version_added attributions in modules for modules that are too old to call out this information.
This does not generically apply to new arguments added to existing modules, just the version_added attribute on the top level modules.
2013-11-27 21:34:00 -05:00
Michael DeHaan
36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Michael DeHaan
51e6f411f2 Docs: Fix the module formatter code that is intended to remove the 'historical' variable from showing up in version_added information (RST) 2013-11-27 21:14:38 -05:00
Andrew Smith
7d007cac16 Correct the invocation of ‘_assemble_from_fragments’ 2013-11-28 09:44:14 +10:00
Michael DeHaan
52b2cfedfc Add release history for 1.4.1 into 1.5 branch. 2013-11-27 18:41:07 -05:00
jctanner
920bc6e75b Merge pull request #5086 from j2sol/fix-accelerate_inventory
Avoid a traceback when using accelerate
2013-11-27 14:46:12 -08:00
Michael DeHaan
55cc5f25c5 Merge pull request #5085 from tgerla/awsfixes
fix heading name syntax in AWS guide
2013-11-27 14:35:49 -08:00
James Tanner
b6879ca2bd Fixes #5030 compare connection user and sudo user and disable sudo if identical 2013-11-27 17:01:53 -05:00
Jesse Keating
5522d489e3 Avoid a traceback when using accelerate
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
2013-11-27 13:58:11 -08:00
Tim Gerla
af42f0b771 fix heading name syntax in AWS guide 2013-11-27 12:36:49 -08:00
James Tanner
12ed39ef7b Fixes #5056 Append new hosts to the groups cache 2013-11-27 13:04:31 -05:00
James Cammarata
1f80aa768a Fix bug in error detection code, where a zero-length string was causing a traceback
Fixes #5064
2013-11-27 11:57:15 -06:00
James Cammarata
30948ae0dc Fix accelerate module parameter for IPv6 activation 2013-11-27 09:32:07 -06:00
jctanner
696ce0effe Merge pull request #5067 from justinludwig/fix-aws-credential-params
Fix AWS credential params for ec2_ami, ec2_elb, ec2_tag, ec2_vpc, route53, and s3 modules
2013-11-27 07:14:19 -08:00
Michael DeHaan
4deac3c3f4 Merge pull request #5068 from jimrybarski/devel
fixed documentation typo about region purpose
2013-11-27 04:50:05 -08:00
Jim Rybarski
483bb58f2d fixed documentation typo about region purpose 2013-11-27 00:35:33 -06:00
Justin Ludwig
26374d89a0 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
2013-11-26 19:29:06 -08:00
James Tanner
7be13faae8 Fix comment yaml escaping in authorized_key module 2013-11-26 08:54:19 -05:00
Michael DeHaan
82c9f5bfe4 Merge pull request #5060 from bcoca/assemble_fix
fixed typo for assemble function
2013-11-26 05:30:22 -08:00
Brian Coca
65885feeeb fixed typo for assemble function 2013-11-26 08:30:28 -05:00
James Tanner
4ba51eef6f Save comment hashes in sshkeys 2013-11-25 23:46:48 -05:00
James Tanner
16b22d0d64 Cleanup debug statements 2013-11-25 22:16:04 -05:00
James Tanner
b938554311 Fixes #5032 escape and safely split key options in authorized_keys module 2013-11-25 22:13:42 -05:00
James Tanner
d187066339 Fixes #5010 Add user to all defined supplementary groups 2013-11-25 14:56:46 -05:00
Michael DeHaan
d308aa584a Merge pull request #5050 from greenbrian/devel
Update unarchive
2013-11-25 10:39:52 -08:00
greenbrian
d80eb4a7fd Update unarchive
Modified argument order provided to unzip command as the -o was being interpreted as a file.
2013-11-25 10:44:39 -06:00
Michael DeHaan
41e83d9df1 Merge pull request #5045 from junegunn/wait_for-python2.4
Remove Python 2.4-incompatible 'with' statement
2013-11-25 08:28:14 -08:00
James Tanner
b8146e3bc7 Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin 2013-11-25 10:57:10 -05:00
James Tanner
903c4cae7b Fixes #5031 Template the delay value and cast to float for loops 2013-11-25 10:13:55 -05:00
James Tanner
5c1fbcc9d2 Addresses #5036 fix typo in git module 2013-11-25 09:55:05 -05:00
James Tanner
d950a3d1b5 Fixes 5036 add missing parameter to git module function call 2013-11-25 09:51:07 -05:00
Junegunn Choi
9c798b119c Remove Python 2.4-incompatible 'with' statement 2013-11-25 17:01:24 +09:00
Michael DeHaan
828b9f872f Merge pull request #5033 from tgerla/vagrantguide
Add a basic guide describing Vagrant and Ansible
2013-11-24 08:15:58 -08:00
Tim Gerla
fb3d5d6589 elaborate on a couple of sections 2013-11-23 14:59:35 -08:00
Michael DeHaan
0d4c690111 Merge pull request #5034 from zanardo/fix-typo
fix typo in deprecation warning
2013-11-23 13:24:45 -08:00
Antonio Zanardo
8dbd91b5ad fix typo in deprecation warning 2013-11-23 19:15:51 -02:00
Tim Gerla
461afa2b25 remove Vagrant from the list of pending topics 2013-11-23 11:13:56 -08:00
Tim Gerla
1cd71b7899 fix up word wrapping 2013-11-23 11:10:43 -08:00
Tim Gerla
7adf33ed41 add a topical guide for Vagrant integration 2013-11-23 11:07:51 -08:00
James Tanner
32986c4d64 Fixes #5021 safely split hostkeys with quotes 2013-11-22 16:36:31 -05:00
Michael DeHaan
e54a574bb2 Merge pull request #5020 from damycra/django_manage_migrate_changed_filter
Reports changed status from django_manage migrate
2013-11-22 13:22:07 -08:00
Steven Davidson
f5d9679abc Reports changed status from django_manage migrate 2013-11-22 19:35:19 +00:00
jctanner
815b32685b Merge pull request #4985 from zakkie/devel
fix typo in document
2013-11-22 09:25:44 -08:00
James Tanner
bca2634d54 Fix missing eval for string search in ssh controlpersist 2013-11-22 12:22:53 -05:00
James Tanner
a16fe923ed Addresses #5011 check for proper string in smartos ssh error output 2013-11-22 12:13:24 -05:00