Commit graph

47707 commits

Author SHA1 Message Date
Sam Doran
9d014778ad
cronvar - use correct binary name (#63279)
Fixes regression introduced by #62554
Add integration tests for cronvar
2019-10-09 18:33:25 -04:00
Jill R
ce402f003f
Fix STS assume role error message when role does not exist (#63249)
AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
2019-10-09 14:08:29 -07:00
Adrian Likins
ed203c5902 Fix galaxy url use everywhere when url is set in config. (#63286)
In addition to trying the configured url (for ex, a migrated
'https://galaxy.ansible.com/') there is an attempt at that
URL with '/api' postpended.

If the extended URL works, update GalaxyAPI.api_server to
use the extended URL. Previously it only used it for finding
the API root info ('available_versions', etc)
2019-10-09 16:24:46 -04:00
Felix Fontein
5349b3ae4c
docker_* modules: docs improvements (#63165)
* Improve docker_container docs.

* Fix usage of C(...) and I(...).

* Fix abuses of I(...).

* tls_verify has been made an alias of validate_certs some time ago.

* Fix YAML problems.

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Fix order.

* Split long description.

* Improve formatting.

* Rewrite state docs.

* Make proper sentences.
2019-10-09 22:21:28 +02:00
Saleh Batati
1d5206f53e Pass a JSON file to the Lambda's payload (#63261)
* Add an example of passing a JSON file to the Lambda's payload
Events passed to Lambda are commonly in JSON format, the change provides an example of using JSON file as an alternative to the inline YAML payload in the other examples.
2019-10-09 15:10:32 -05:00
Jian Fang
5ed163ce3f Spot instance code error (#63246)
##### SUMMARY
Adds 'instance_initiated_shutdown_behavior: terminate' to spot instance example for greater efficiency.
2019-10-09 14:57:13 -05:00
Kev Pearce
81a614684a Typo on line 161 (#63133)
fix module name for azure_rm_manageddisk in one example
2019-10-09 14:38:32 -05:00
thaim
021d095625 Fix broken link (#63185) 2019-10-09 14:36:43 -05:00
m3gat0nn4ge
ce1c8c24f7 Update win_disk_facts.py example (#63266)
Fix incorrect index for second disk (should be `disks[1]` not `disks[0]`)
2019-10-09 14:21:37 -05:00
Felix Fontein
aa04e61c89 docker_* modules: add docker module defaults group (#63164)
* Add docker module defaults group.
* Add footnote about docker_stack not being included (instead of remarks column)
2019-10-09 14:12:02 -05:00
memotype
b46299ff86 Update stat.py (#63289)
Reword awkward documentation language.
2019-10-09 14:07:56 -05:00
Michael C
19587b35da docs: add Centos and Ubuntu to examples for playbook conditionals (#63085)
* docs: add Centos and Ubuntu to examples for playbook conditionals

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-10-09 14:05:21 -05:00
Martin Nečas
0fcb6574dd Ovirt: add ovirt_vnic_profile_info (#62396) 2019-10-10 00:20:12 +05:30
Alexander Kapshuna
3ad602bfa6 Add aliases to path parameter of stat module (#61270) 2019-10-09 11:24:59 -04:00
James Powis
d4ad541eee dest lives in 4 different places depending on exeuction type (#62444) 2019-10-09 19:50:08 +05:30
Nathaniel Case
d336a14da6 Fix junos unicode errors. (#63046) 2019-10-09 19:26:27 +05:30
Andrey Klychkov
71bcce5db5 mysql_replication: add channel parameter (#63271)
* mysql_replication: add channel parameter

* mysql_replication: add channel parameter, add changelog
2019-10-09 14:27:01 +01:00
Martin Krizek
f72d4d2339
Do not use fully qualified module_utils imports (#63101) 2019-10-09 11:30:43 +02:00
Andrey Klychkov
9f9afcb203 mysql_replication: add connection_name param for MariaDB multi source replication support (#63229)
* mysql_replication: add connection_name param for MariaDB multi source support

* mysql_replication: add connection_name param for MariaDB multi source support, add changelog
2019-10-09 10:05:55 +02:00
Matt Davis
fd229dcbb5
add ANSIBLE_PLAYBOOK_DIR envvar support (#63220)
* add ANSIBLE_PLAYBOOK_DIR envvar support

* allows `ANSIBLE_PLAYBOOK_DIR` envvar as a fallback on CLI types that support `--playbook-dir`. This should have been implemented with #59464, but was missed due to an oversight.
* added basic integration test

* make first-class PLAYBOOK_DIR config entry

* update changelog
2019-10-08 17:34:15 -07:00
Adrian Likins
bad72693e4 Stop appending '/api' to galaxy server url (#63238)
* Stop appending '/api' to configured galaxy server url

Since not all galaxy REST api server URLs live
at '/api', stop always appending it to the
'url' value loaded from config.

* Add note about manually migrated galaxy configs and /api

* Add '/api/' to galaxy url and guessing if galaxy API

* Fix most unit tests (update to expect /api/)

* Fix test_initialise_unknown unit test

Since we retry now with an added /api/, mock it as well.

* Update fallback default avail_ver to new format
2019-10-08 15:09:19 -07:00
Mark Chappell
dbc9444572 ec2_vpc_nacl and ec2_vpc_nacl_info migrate to AnsibleAWSModule and add tests (#63163)
* Move EC2 networking objects into network-policy.json

* ec2_vpc_nacl: Add integration tests

* ec2_vpc_nacl: Migrate tests to use module_defaults

* ec2_vpc_nacl: (integration tests) Add missing AWS permissions

* ec2_vpc_nacl: (integration tests) Update tests for ipv6 support

* ec2_vpc_nacl: Migrate to AnsibleAWSModule

* Fix sanity tests for ec2_vpc_nacl and ec2_vpc_nacl_info

* ec2_vpc_nacl_info: Migrate to AnsibleAWSModule

* ec2_vpc_nacl_info: (integration tests) Rename from ec2_vpc_nacl_facts to ec2_vpc_nacl_info and add a test using a filter (by tag)

* Pick availability zones dynamically

Rather than assuming that AZa and AZb always exist (they don't), query to find out which AZs we have available first

* Test that the NACLs we get back are actually the *saml* NACL rather than duplicates/delete remove

* Cleanup IPv6 tests a little.

Note: IPv6 support for ec2_vpc_nacl not complete yet.

This provides the initial framework, and should ensure things don't start exploding when support is added.

* Removing subnets by name from a NACL *is* now supported

* Fix ec2_vpc_nacl return documentation
2019-10-08 13:27:24 -07:00
Matt Clay
811127d64d Add RHEL 8.1b to the Shippable test matrix. 2019-10-08 13:06:28 -07:00
Toshio Kuratomi
5997d33381 Updated with slipped dates for the 2.9.0 release (#63243) 2019-10-08 14:13:45 -04:00
Alicia Cozine
941a9b68fc Docs: User guide overhaul, part 1 (#63056) 2019-10-08 13:46:38 -04:00
Sebastian Gumprich
da1a945088 fix typo in collection/plugins/readme (#63162) 2019-10-08 11:12:34 -04:00
Ondra Machacek
35c3d831fb ovirt_vm: Add new suboptions to graphical_console (#63230)
Fixes: https://github.com/ansible/ansible/issues/63225

This PR add following new suboptions to graphical_console param:

  - keyboard_layout
  - monitors
  - disconnect_action
2019-10-08 11:12:14 -04:00
Pedro Magalhães
67d9cc45bd maven_artifact.py - add support for version ranges by using spec (#54309) (#61813) 2019-10-08 15:24:50 +01:00
Martin Nečas
65fd331cb5 Ovirt add template timeout error (#63199)
* Ovirt add template timeout error

* correct example syntax
2019-10-08 10:03:44 -04:00
Andrey Klychkov
3b18337cac lineinfile - fix bug with insertbefore/insertafter and firstmatch (#63194) 2019-10-08 10:01:36 -04:00
Robert de Bock
b7a9d99cef Add spaces around {{ indicators. (#63125)
##### SUMMARY
The example looked a little less readable by not having spaces after `{{` and before `}}`. This commit should make the examples match [ansible-lint rule 206](https://github.com/ansible/ansible-lint/blob/master/lib/ansiblelint/rules/VariableHasSpacesRule.py)

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-10-08 13:41:54 +01:00
Andrey Klychkov
5fcaefc012 mysql_replication: small fix of master_delay parameter (#63221) 2019-10-08 13:06:54 +05:30
Matt Clay
022335669c
Work around ssh-keygen issue in ansible-test. (#63211)
Newer versions of ssh-keygen create PEM keys that are not recognized by Paramiko.

Now ansible-test compensates for this by updating they keys it generates so Paramiko will recognize them.
2019-10-07 14:36:05 -07:00
Pavan Bidkar
314f9fbd5c Support latest version while upgrading VM hardware. (#62188)
Support for the `latest` version during an VM hardware upgrade.
2019-10-07 16:41:57 -04:00
Matt Clay
4c79f1ec4d Fix ansible-test integration temp dir location.
Previously the temporary directory used to run integration tests resided under the user's home directory. This prevented ansible-playbook from detecting the default collection when running tests.

Now the temporary directory is created within the collection to facilitate default collection detection.
2019-10-07 13:12:59 -07:00
Matt Clay
32979430d0 Add missing var for format string in ansible-test. 2019-10-07 13:10:42 -07:00
Abhijeet Kasurde
deda9d4cc5 VMware: Add module defaults for VMware modules (#63197)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-07 14:24:58 -04:00
Matt Clay
86ae3cfa12 Install zip for unarchive test when using dnf. 2019-10-07 10:41:46 -07:00
The Magician
4959ab5004 Bug fixes for GCP modules (#63153) 2019-10-07 13:22:41 -04:00
The Magician
1522603078 New Module: gcp_compute_region_backend_service (#63154) 2019-10-07 13:22:26 -04:00
The Magician
94433dc65e New Module: gcp_compute_region_backend_service_info (#63155) 2019-10-07 13:22:19 -04:00
Nik Reiman
785ba62867 vmware: Only add configured network interfaces to facts (#28552)
This change effectively filters out any network interfaces which were
not explicitly configured for the guest. This fixes some unexpected behaviour where a machine with multiple IP addresses (for example, when Docker is installed, an internal IPv4 interface is added to
communicate with the container) would show one of the internal
addresses in the 'ipv4' field, but then no other information about the
corresponding hardware interface.
2019-10-07 21:41:50 +05:30
Andrey Klychkov
e48202838c mysql_replication: add master_delay parameter (#63130) 2019-10-07 15:23:56 +02:00
Andrey Klychkov
30c2d21f17 mysql: add elements for list params to the modules' documentation (#63187) 2019-10-07 07:58:15 -04:00
Andrey Klychkov
8a37a2440e postgresql: add elements for list params to the module's documentation (#63186) 2019-10-07 04:44:57 -04:00
Joshua Miller
0554b50eed Misc typo in nxos_config documentation (#62629)
* Changed 'exit' to 'exist'
* Removed unnecessary word 'first'
2019-10-07 11:23:31 +05:30
sky-joker
7b7d266a39 VMware: add properties option to vmware_host_facts module (#62916)
* add properties option to vmware_host_facts
2019-10-07 10:27:57 +05:30
Martin Schweyen
e977e0af74 VMware: Update maintenance notes on vmware_cfg_backup (#62853)
Maintenance mode seems only to be required for load or restet, not for save_configuration.
2019-10-07 10:19:37 +05:30
Ryan MacLean
b5cc0872e7 Typo fix in mssql_db (#63184)
Changed from 'then' to 'than'
2019-10-06 21:13:23 -04:00
Felix Fontein
a99af710fb
mariadb_replication / mysql_replication integration tests: conflicts on centos7 (#63171)
* Change group of mariadb_replication to avoid mysql_replication conflicts.

* Add remarks.
2019-10-06 10:21:15 +02:00