Commit graph

35948 commits

Author SHA1 Message Date
Nathaniel Case
a3f96ec4af
ios_static_route idempotence fix (#35912) (#37012)
* Remove default admin_distance and fix the idempotence thereof

Fixes #33290

* Fix tests and use yaml anchors to shorten tests

* Add test for undefined admin_distance

* Read config from `show run` if `show ip static route` fails

* Restore flags to ios.get_config &  use get_config where appropriate

(cherry picked from commit 7016b3b9ca)
2018-03-05 10:48:18 -05:00
John R Barker
9ac8aa3552
Ability to link to other pages from plugin docs (#37009) (#37014)
Support relative links
(cherry picked from commit 985f09270d)
2018-03-05 15:20:49 +00:00
Nathaniel Case
639f7b569a
Move _start_connection() to module_utils/connection and fix Popen() call (#36249) (#37005)
* Fix Popen() call to use ansible python

* Remove PATH searching, reuse location of ansible instead

(cherry picked from commit 0feea66988)
2018-03-05 09:54:30 -05:00
John R Barker
801b5dcd04
[WIP] Backport/2.5/multiple docs (#36907)
Backport/2.5/multiple docs
2018-03-05 14:40:14 +00:00
John R Barker
36566e62a7
Fix_regex (#36569) (#37002)
(cherry picked from commit 4021194532)
2018-03-05 12:10:08 +00:00
Ganesh Nalawade
3f8377c2d9
Enable eapi integration test for eos modules (#36934) (#36935)
(cherry picked from commit 83c3561ee5)
2018-03-02 13:02:52 +05:30
Trishna Guha
2cd49b4ab0
eos_static_route fix (#36903) (#36933)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ef7f3fcab6)
2018-03-02 09:02:36 +05:30
Ganesh Nalawade
3e123d8298
map network_os to ncclient device_params (#36819) (#36913)
* map network_os to ncclient device_params

Fixes #36786

* update device map

* Add default netconf fallback plugin

(cherry picked from commit b12e90311f)
2018-03-01 23:03:31 +05:30
John R Barker
617659a33c
Network Platform docs (#36814) (#36899)
* introduces platform docs

(cherry picked from commit 4f63123320)
2018-03-01 11:47:42 +00:00
Ganesh Nalawade
a275a39299
Fix eos_vrf integration test failures (#36893) (#36896)
(cherry picked from commit 5c2a1a6124)
2018-03-01 14:30:29 +05:30
Ganesh Nalawade
dce80b1364
Fix junos_command py3 related issues (#36782) (#36895)
Fixes #36204

*  tostring() input string shoulb be in byte string format
*  to_ele() input is required in unicode format
(cherry picked from commit 41d75783b5)
2018-03-01 14:29:54 +05:30
Trishna Guha
f3653747bb
Fix nxos_interface multiple issues (#36827) (#36891)
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2fbfce06e7)
2018-03-01 11:19:02 +05:30
Chris Houseknecht
5c65fa3e00 Convert key to snake. Fixes #36845. (#36887) 2018-02-28 22:04:54 -06:00
John R Barker
f5684acee5
Updated the documentation of modules to match argspec including the type setting for bool parameters (#36821) (#36860)
(cherry picked from commit 60e39b9718)
2018-02-28 16:07:45 +00:00
John R Barker
bfbea05d26
Fix broken links (#36864) (#36866)
(cherry picked from commit 41c066eff9)
2018-02-28 15:56:45 +00:00
John R Barker
8040168c4f
aws_ssm_parameter_store module - value parameter should be no_log since it's often a secret (#36843) (#36859)
(cherry picked from commit 3f19ef680a)
2018-02-28 14:43:27 +00:00
Ondra Machacek
3257fe28f3 Fixes for oVirt modules (#36846)
* ovirt_vms: Fix boot devices idempotence

* ovirt_host_networks: Fix removing the label

* ovirt_vms: Fix NoneType in placement policy check

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1549082

* int("255.255.255.0" does not work, fixes issue #33867 (#36271)
2018-02-28 13:33:23 +00:00
John R Barker
f14e0e7ee3
clarify the slicing example (#36842) (#36847)
As stated by fellow contributors, update the slicing example

Resolves:
Related: #36625
Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
(cherry picked from commit 8362ddd107)
2018-02-28 13:31:33 +00:00
John R Barker
d4252c89e9
nso_config break cycles in dependency sorting (#36828) (#36838)
False assumption that values can not have cyclic dependencies. Fix by
removing dependency on self and look for cycles, if found remove
dependency to get a partial sort done.
(cherry picked from commit 042c111563)
2018-02-28 11:33:18 +00:00
Trishna Guha
fb630c926a
nxos_facts fix and integration tests (#36796) (#36820)
* fix nxos_facts ipv6 error

* time_range not supported for N35

(cherry picked from commit db43fe6a76)
2018-02-28 10:54:35 +05:30
John R Barker
409193a7dc
Explain what the Ansible Quickstart video does (#36453) (#36793)
* Explain what the Ansible Quickstart video does

Rewrote what video does. The video is really not teaching you how to do the work. It explains why you'd want to use Ansible and shows you what it takes (some sample code) . Video also introduces you to other products in the Ansible ecosystem.

(cherry picked from commit de7692b1c9)
2018-02-27 18:48:13 +00:00
John R Barker
19ea7bcdd8
nso_config work around ordering issues (#36774) (#36785)
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
(cherry picked from commit e75989ec88)
2018-02-27 15:41:34 +00:00
John R Barker
99f4e016bb
Added extra choice floppy for bootdev option in ipmi_boot module (#36174) (#36784)
(cherry picked from commit 52627f3fa0)
2018-02-27 15:21:41 +00:00
Julien Vey
9e9f910cb6 ec2_group:documentation explicit a behaviour for sg rules (#36627) 2018-02-27 16:07:18 +10:00
Matt Clay
78cc85fa27 Fix rst link syntax.
(cherry picked from commit 3937082892)
2018-02-26 11:18:38 -08:00
David Newswanger
e1eae55e55
skip fmg_script unit test if the pyFMG script is not present (#36732) (#36749)
* skip fmg_script unit test if the pyFMG script is not present

* appease the sanity test gods

(cherry picked from commit 6bd715a17d)
2018-02-26 12:41:14 -05:00
Peter Sprygada
b86f07324e fix cliconf get_config method to match base signature (#36682)
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class.  Without this patch, the
get_config method calls will fail in some cirumstances.

(cherry picked from commit fb6a8c0133)
2018-02-26 10:57:25 -05:00
René Moser
eb12520854
cs_sshkeypair: fix ssh key rename (#36726) (#36730)
* tests: cs_sshkeypair: add reproducer for failed key rename

* cs_sshkeypair: fix rename ssh key

(cherry picked from commit cdb2969703)
2018-02-26 15:45:39 +01:00
John R Barker
5052db2698
NSO ValueBuilder improvements. 4.5 leaf-list compatability. (#36583) (#36735)
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
(cherry picked from commit 2789cc5c09)
2018-02-26 13:50:11 +00:00
John R Barker
d67d19bc1f
Backport/2.5/36722 (#36733)
* Fix sanity checks in OpenStack docs fragment (#36722)

Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
(cherry picked from commit 8b52006d5c)
2018-02-26 13:48:38 +00:00
Peter Sprygada
0aa62a54cd allows ib_spec attrs to be filtered in update (#36673)
* allows ib_spec attrs to be filtered in update

This change will allow the ib_spec entries to be be filtered on a change
object by setting the update keyword to false.  The default value for
update is true.  When the update keyword is set to false, the keyed
entry will be removed from the update object before it is sent to the
api endpoint.

fixes #36563

* fix up pep8 issues

(cherry picked from commit 93b795baf0)
2018-02-26 08:17:55 -05:00
John R Barker
6bf30f65b9
Fix typos (#36671) (#36724)
Fix minor typos
(cherry picked from commit 487ff1fe9b)
2018-02-26 11:27:24 +00:00
Trishna Guha
b1bdc5dae2
nxos_vlan, nxos_linkagg fix (#36711)
* fix nxos_vlan aggregate (#36710)

* fix nxos_vlan aggregate

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 44332bda78)

* nxos_linkagg fix (#36706)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d6912cf40e)
2018-02-26 13:01:20 +05:30
Ganesh Nalawade
d60eac9bc4
Decouple config and state check in vlan and vrf network modules (#36386) (#36704)
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules

Fixes #35567
Fixes #34754

`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.

Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.

* Fix CI failures

* Fix review comment

* Fixed integration test failure

(cherry picked from commit 5a6b893240)
2018-02-26 10:16:39 +05:30
Matt Clay
a48254275f Temporarily disable subversion test on osx.
(cherry picked from commit f283edcb19)
2018-02-24 17:26:39 -08:00
Ed Costello
b717765d59 Fix documentation of validate_certificates option in aws doc_fragment.
Unignore sanity test failures for AWS modules caused by this common
fragment.

(cherry picked from commit 2a0c7c4331)
2018-02-23 21:42:36 -08:00
John R Barker
e1174f8864
fix yamllint issue (#36636) 2018-02-23 13:30:48 +00:00
Matt Davis
e77c1b9e42 New release v2.5.0rc1 2018-02-22 17:40:29 -08:00
Matt Davis
98882b725f 2.5.0rc1 CHANGELOG prep 2018-02-22 17:34:03 -08:00
Matt Davis
97a7c3f39c rename versioned CHANGELOGs with dash 2018-02-22 17:32:58 -08:00
Matt Davis
2ddcdb8720 Revert "Add force option to systemd module (#35925)"
(mistaken cherry pick)

This reverts commit 9935cda4a3.
2018-02-22 17:10:05 -08:00
Dag Wieers
917e5ae5d8 Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
2018-02-22 16:36:29 -08:00
Matt Davis
ed9781bbfb
Do not cache the loop item label so that it will update with each item (#36609)
Add integration test for #36430 (#36432)

(cherry picked from commit d1f76939e5)
(cherry picked from commit 9fced4f0a9)
2018-02-22 16:08:00 -08:00
Dag Wieers
b1e125b718 Backport missing integration tests (#36610)
Somehow this file was missing from the previous backport.
2018-02-22 15:18:06 -08:00
John R Barker
3d1c8bc2e1 Network Getting started docs (#36337) (#36597)
* first draft of getting started guide
(cherry picked from commit 51a010a696)
2018-02-22 15:15:11 -08:00
Jordan Borean
f8d8d84f05 Win feature error cp (#36559)
* win_feature: better error handling to make it easier to debug issues (#36491)

* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed

(cherry picked from commit ef4f8851dc)

* Added changelog for win_feature error handling fix
2018-02-22 15:05:13 -08:00
Matt Martz
9bd7147bb8 Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules (#36602) (#36606)
(cherry picked from commit a7062b7587)
2018-02-22 14:56:03 -08:00
Chris Houseknecht
7e378e791c
Bump OpenShift client req to 0.4.3. Fixes openshift_scale. (#36580) 2018-02-22 16:14:26 -05:00
Abhijeet Kasurde
980b6a00e2 Fixup VMware module docs issues (#36409) (#36523)
Fix various argspec vs documentation issue

(cherry picked from commit 5d0ed38e3a)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-22 08:44:09 -08:00
Ryan Brown
c4e94af4e9 [cloud] catch NoCredentialsError in boto3_conn (#36545) 2018-02-21 23:18:41 -05:00